159103 2016-06-24 15:42:14 -0700 TransactionOperations can get destroyed on the wrong thread 2016-07-05 15:26:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154968 1 beidson beidson achristensen alecflett cdumez commit-queue jsbell ossy oldest_to_newest 1205227 0 beidson 2016-06-24 15:42:14 -0700 TransactionOperations can get destroyed on the wrong thread This can happen for worker transaction operations. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000105cda037 WTFCrash + 39 1 com.apple.WebCore 0x000000010ba8dde8 WebCore::IDBClient::TransactionOperation::~TransactionOperation() + 104 2 com.apple.WebCore 0x000000010baa8ea5 WebCore::IDBClient::TransactionOperationImpl<WebCore::IDBKeyData const&, unsigned long const&>::~TransactionOperationImpl() + 21 3 com.apple.WebCore 0x000000010baa55c5 WebCore::IDBClient::TransactionOperationImpl<WebCore::IDBKeyData const&, unsigned long const&>::~TransactionOperationImpl() + 21 4 com.apple.WebCore 0x000000010baa55e9 WebCore::IDBClient::TransactionOperationImpl<WebCore::IDBKeyData const&, unsigned long const&>::~TransactionOperationImpl() + 25 5 com.apple.WebCore 0x000000010ba02cd3 WTF::ThreadSafeRefCounted<WebCore::IDBClient::TransactionOperation>::deref() + 83 6 com.apple.WebCore 0x000000010ba02c7a void WTF::derefIfNotNull<WebCore::IDBClient::TransactionOperation>(WebCore::IDBClient::TransactionOperation*) + 58 7 com.apple.WebCore 0x000000010ba02c33 WTF::RefPtr<WebCore::IDBClient::TransactionOperation>::~RefPtr() + 83 8 com.apple.WebCore 0x000000010b9fcd85 WTF::RefPtr<WebCore::IDBClient::TransactionOperation>::~RefPtr() + 21 9 com.apple.WebCore 0x000000010b9f9f5f WebCore::IDBClient::IDBConnectionProxy::completeOperation(WebCore::IDBResultData const&) + 223 10 com.apple.WebCore 0x000000010ba262f2 WebCore::IDBClient::IDBConnectionToServer::didIterateCursor(WebCore::IDBResultData const&) + 98 11 com.apple.WebCore 0x000000010bb4b7a0 WebCore::InProcessIDBServer::didIterateCursor(WebCore::IDBResultData const&)::$_16::operator()() const + 64 12 com.apple.WebCore 0x000000010bb4b67c WTF::Function<void ()>::CallableWrapper<WebCore::InProcessIDBServer::didIterateCursor(WebCore::IDBResultData const&)::$_16>::call() + 28 13 com.apple.JavaScriptCore 0x0000000105d098f3 WTF::Function<void ()>::operator()() const + 99 14 com.apple.JavaScriptCore 0x0000000105d24fab WTF::RunLoop::performWork() + 219 15 com.apple.JavaScriptCore 0x0000000105d25754 WTF::RunLoop::performWork(void*) + 36 16 com.apple.CoreFoundation 0x00007fff8c2d7881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 17 com.apple.CoreFoundation 0x00007fff8c2b6fbc __CFRunLoopDoSources0 + 556 18 com.apple.CoreFoundation 0x00007fff8c2b64df __CFRunLoopRun + 927 19 com.apple.CoreFoundation 0x00007fff8c2b5ed8 CFRunLoopRunSpecific + 296 20 DumpRenderTree 0x00000001047de21c runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 6252 (DumpRenderTree.mm:2065) 21 DumpRenderTree 0x00000001047dc8fd runTestingServerLoop() + 333 (DumpRenderTree.mm:1193) 22 DumpRenderTree 0x00000001047dbe82 dumpRenderTree(int, char const**) + 450 (DumpRenderTree.mm:1307) 23 DumpRenderTree 0x00000001047deb5d DumpRenderTreeMain(int, char const**) + 125 (DumpRenderTree.mm:1442) 24 DumpRenderTree 0x0000000104837f72 main + 34 (DumpRenderTreeMain.mm:34) 25 libdyld.dylib 0x00007fff885bd5ad start + 1 1205228 1 beidson 2016-06-24 15:43:53 -0700 This is a race, pure and simple. The operation completion has to happen on the background thread so quickly that it's done before the main thread that scheduled the background thread task even finishes doing so. It's going to be difficult to write a dedicated test for. But it will clear up random bot exposure in random workers tests. 1207720 2 282735 beidson 2016-07-04 15:08:46 -0700 Created attachment 282735 Patch 1207721 3 commit-queue 2016-07-04 15:11:13 -0700 Attachment 282735 did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h:66: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1207740 4 beidson 2016-07-04 21:43:27 -0700 The Windows build breakage is not from this patch. 1207874 5 282735 commit-queue 2016-07-05 11:05:03 -0700 Comment on attachment 282735 Patch Clearing flags on attachment: 282735 Committed r202821: <http://trac.webkit.org/changeset/202821> 1207875 6 commit-queue 2016-07-05 11:05:07 -0700 All reviewed patches have been landed. Closing bug. 1207931 7 ossy 2016-07-05 13:15:05 -0700 (In reply to comment #5) > Comment on attachment 282735 [details] > Patch > > Clearing flags on attachment: 282735 > > Committed r202821: <http://trac.webkit.org/changeset/202821> (In reply to comment #4) > The Windows build breakage is not from this patch. It's not true, it broke the Apple Windows and WinCairo build too, see build.webkit.org for details. 1207932 8 beidson 2016-07-05 13:19:56 -0700 (In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 282735 [details] > > Patch > > > > Clearing flags on attachment: 282735 > > > > Committed r202821: <http://trac.webkit.org/changeset/202821> > > (In reply to comment #4) > > The Windows build breakage is not from this patch. > > It's not true, it broke the Apple Windows and WinCairo build too, > see build.webkit.org for details. Yup, sure did. I saw other errors when I looked at the EWS, but they were apparently just warnings. 1207960 9 achristensen 2016-07-05 15:26:18 -0700 Build should be fixed in r202836 282735 2016-07-04 15:08:46 -0700 2016-07-05 11:05:03 -0700 Patch bug-159103-20160704150852.patch text/plain 4096 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZiZTAyYmUyNTQyNjY2 N2RhNjNjMDc5MDJmNThjMmRjYzA1ZTZmYi4uNDQ1MDBkMTk3ZTNjYjIxNmE4Mjg4ODRlMTM1NWUy YTAxMDE4MzE4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA3LTA0ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBUcmFuc2FjdGlvbk9wZXJh dGlvbnMgY2FuIGdldCBkZXN0cm95ZWQgb24gdGhlIHdyb25nIHRocmVhZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTEwMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoVmVyeSBy YWN5LCBub3QgZmVhc2libGUgdG8gd3JpdGUgYSBkZWRpY2F0ZWQgdGVzdCBmb3IsIGNhdWdodCBv biBib3RzIG9jY2FzaW9uYWxseSBhcy1pcykuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRk Yi9JREJBY3RpdmVET01PYmplY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkFjdGl2ZURPTU9i amVjdDo6Y2FsbEZ1bmN0aW9uT25PcmlnaW5UaHJlYWQpOgorICAgICAgICAKKyAgICAgICAgKiBN b2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCQ29ubmVjdGlvblByb3h5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OklEQkNsaWVudDo6SURCQ29ubmVjdGlvblByb3h5Ojpjb21wbGV0ZU9wZXJhdGlv bik6IFBhc3MgdGhlIGxhc3QgcmVmIHRvIHRoZSBvcGVyYXRpb24gdG8gaXRzCisgICAgICAgICAg b3JpZ2luIHRocmVhZCB0byBiZSBkZWxldGVkIHRoZXJlLgorICAgICAgICAKKyAgICAgICAgKiBN b2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvVHJhbnNhY3Rpb25PcGVyYXRpb24uaDoKKyAgICAgICAg KFdlYkNvcmU6OklEQkNsaWVudDo6VHJhbnNhY3Rpb25PcGVyYXRpb246OnBlcmZvcm1Db21wbGV0 ZU9uT3JpZ2luVGhyZWFkKToKKworMjAxNi0wNy0wNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBh cHBsZS5jb20+CisKICAgICAgICAgV2ViUHJvY2Vzc2VzIGRvbid0IGhhbmRsZSBEYXRhYmFzZVBy b2Nlc3MgZ29pbmcgYXdheSB1bmNsZWFubHkuLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MzcxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL0lEQkFjdGl2ZURPTU9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCQWN0aXZlRE9NT2JqZWN0LmgKaW5kZXggODQyZGNlNDE4ODlj ZDI3MzU4M2I5NzQyZmIzYzg4OGI1NWNmNWFhZS4uMmQwYzllYjdhYjdkOGM2ZmFmMTU0N2ZlOGU4 YjE4ZWJlNDEwMjNjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvSURCQWN0aXZlRE9NT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl eGVkZGIvSURCQWN0aXZlRE9NT2JqZWN0LmgKQEAgLTYzLDYgKzYzLDIyIEBAIHB1YmxpYzoKICAg ICAgICAgY29udGV4dC0+cG9zdENyb3NzVGhyZWFkVGFzayhvYmplY3QsIG1ldGhvZCwgYXJndW1l bnRzLi4uKTsKICAgICB9CiAKKyAgICB2b2lkIGNhbGxGdW5jdGlvbk9uT3JpZ2luVGhyZWFkKEZ1 bmN0aW9uPHZvaWQgKCk+JiYgZnVuY3Rpb24pCisgICAgeworICAgICAgICBpZiAob3JpZ2luVGhy ZWFkSUQoKSA9PSBjdXJyZW50VGhyZWFkKCkpIHsKKyAgICAgICAgICAgIGZ1bmN0aW9uKCk7Cisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBMb2NrZXI8TG9jaz4gbG9j ayhtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHRMb2NrKTsKKworICAgICAgICBTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0ID0gc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpOworICAgICAgICBp ZiAoIWNvbnRleHQpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgY29udGV4dC0+cG9z dFRhc2soV1RGTW92ZShmdW5jdGlvbikpOworICAgIH0KKwogcHJvdGVjdGVkOgogICAgIElEQkFj dGl2ZURPTU9iamVjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgICAgICA6 IEFjdGl2ZURPTU9iamVjdChjb250ZXh0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQkNvbm5lY3Rpb25Qcm94eS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCQ29ubmVjdGlvblByb3h5LmNwcAppbmRl eCA4MzYzNjE5MGU1MDZiYjNmYTU5YmJjNWZhMmYxMDRiNjBiYzE4MWY3Li5iM2M3NGRjZWYxY2Ey MDczNDgyZGEzODcwOTY2MjIyZTgyOTllNjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCQ29ubmVjdGlvblByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCQ29ubmVjdGlvblByb3h5LmNw cApAQCAtMjIzLDcgKzIyMyw3IEBAIHZvaWQgSURCQ29ubmVjdGlvblByb3h5Ojpjb21wbGV0ZU9w ZXJhdGlvbihjb25zdCBJREJSZXN1bHREYXRhJiByZXN1bHREYXRhKQogICAgIGlmICghb3BlcmF0 aW9uKQogICAgICAgICByZXR1cm47CiAKLSAgICBvcGVyYXRpb24tPnBlcmZvcm1Db21wbGV0ZU9u T3JpZ2luVGhyZWFkKHJlc3VsdERhdGEpOworICAgIG9wZXJhdGlvbi0+cGVyZm9ybUNvbXBsZXRl T25PcmlnaW5UaHJlYWQocmVzdWx0RGF0YSwgV1RGTW92ZShvcGVyYXRpb24pKTsKIH0KIAogdm9p ZCBJREJDb25uZWN0aW9uUHJveHk6OmFib3J0T3BlbkFuZFVwZ3JhZGVOZWVkZWQodWludDY0X3Qg ZGF0YWJhc2VDb25uZWN0aW9uSWRlbnRpZmllciwgY29uc3QgSURCUmVzb3VyY2VJZGVudGlmaWVy JiB0cmFuc2FjdGlvbklkZW50aWZpZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9jbGllbnQvVHJhbnNhY3Rpb25PcGVyYXRpb24uaCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oCmluZGV4 IGM3YTE5ZGMzMTBlYThhZTNlYjcwODUwMDBkMTQ5NGQwMjk2ZTBjOTcuLmJmMDdiYmNhODVlZDNl MjZiMmI4ZDk1OTNmMDA5Y2JhYzVkMzg2ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9UcmFuc2FjdGlvbk9wZXJhdGlvbi5o CkBAIC02MiwxNCArNjIsMTcgQEAgcHVibGljOgogICAgICAgICBtX3BlcmZvcm1GdW5jdGlvbiA9 IHsgfTsKICAgICB9CiAKLSAgICB2b2lkIHBlcmZvcm1Db21wbGV0ZU9uT3JpZ2luVGhyZWFkKGNv bnN0IElEQlJlc3VsdERhdGEmIGRhdGEpCisgICAgdm9pZCBwZXJmb3JtQ29tcGxldGVPbk9yaWdp blRocmVhZChjb25zdCBJREJSZXN1bHREYXRhJiBkYXRhLCBSZWZQdHI8VHJhbnNhY3Rpb25PcGVy YXRpb24+JiYgbGFzdFJlZikKICAgICB7CiAgICAgICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7 CiAKICAgICAgICAgaWYgKG1fb3JpZ2luVGhyZWFkSUQgPT0gY3VycmVudFRocmVhZCgpKQogICAg ICAgICAgICAgY29tcGxldGVkKGRhdGEpOwotICAgICAgICBlbHNlCisgICAgICAgIGVsc2Ugewog ICAgICAgICAgICAgbV90cmFuc2FjdGlvbi0+cGVyZm9ybUNhbGxiYWNrT25PcmlnaW5UaHJlYWQo KnRoaXMsICZUcmFuc2FjdGlvbk9wZXJhdGlvbjo6Y29tcGxldGVkLCBkYXRhKTsKKyAgICAgICAg ICAgIG1fdHJhbnNhY3Rpb24tPmNhbGxGdW5jdGlvbk9uT3JpZ2luVGhyZWFkKFtsYXN0UmVmID0g V1RGTW92ZShsYXN0UmVmKV0oKSB7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfQogICAgIH0K IAogICAgIHZvaWQgY29tcGxldGVkKGNvbnN0IElEQlJlc3VsdERhdGEmIGRhdGEpCg==