159083 2016-06-23 23:47:34 -0700 THUMB2 support not correctly detected on Fedora with GCC 6.1. 2016-07-13 03:27:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159707 P2 Normal --- 159408 1 tpopela webkit-unassigned benjamin cdumez clopez cmarcelo commit-queue ossy oldest_to_newest 1205040 0 tpopela 2016-06-23 23:47:34 -0700 After http://trac.webkit.org/changeset/202214 the build fails with: In file included from /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:34:0, from /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/MacroAssembler.h:40, from /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/LinkBuffer.h:39, from /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/LinkBuffer.cpp:27: /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h: In instantiation of ‘void JSC::AbstractMacroAssembler<AssemblerType, MacroAssemblerType>::emitNops(size_t) [with AssemblerType = JSC::ARMAssembler; MacroAssemblerType = JSC::MacroAssemblerARM; size_t = unsigned int]’: /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/LinkBuffer.cpp:232:50: required from here /home/fedora/tpopela/rpmbuild/BUILD/webkitgtk-2.13.2/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:1049:32: error: ‘fillNops’ is not a member of ‘JSC::ARMAssembler’ AssemblerType::fillNops(static_cast<char*>(buffer.data()) + startCodeSize, memoryToFillWithNopsInBytes, isCopyingToExecutableMemory); There is an implementation of fillNops missing in the ARMAssembler.h 1205508 1 clopez 2016-06-27 03:16:28 -0700 The GTK+ ARM bot (ARMv7) seems happy. https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release?numbuilds=50 And it seems there is also an implementation of fillNops in ARMv7Assembler.h Is this an issue that happens only with ARMv6 ? In that case, does this still happens if the JIT is disabled (-DENABLE_JIT=OFF) ? 1206007 2 tpopela 2016-06-28 05:20:44 -0700 Ok, the problem here is the detection of THUMB2 support. Our code is based on __thumb2__ or __thumb__ defines. This does work on Debian: $ gcc -dM -E - < /dev/null | grep -i thumb #define __thumb2__ 1 #define __THUMB_INTERWORK__ 1 #define __thumb__ 1 #define __ARM_ARCH_ISA_THUMB 2 #define __THUMBEL__ 1 but does not on Fedora 24 with GCC 6.1. : $ gcc -dM -E - < /dev/null | grep -i thumb #define __THUMB_INTERWORK__ 1 #define __ARM_ARCH_ISA_THUMB 2 as the previously mentions defines are not presented there. 1206009 3 282244 tpopela 2016-06-28 05:27:04 -0700 Created attachment 282244 Correct the THUMB2 detection on Fedora with gcc 6.1. 1206016 4 282244 commit-queue 2016-06-28 06:25:38 -0700 Comment on attachment 282244 Correct the THUMB2 detection on Fedora with gcc 6.1. Clearing flags on attachment: 282244 Committed r202560: <http://trac.webkit.org/changeset/202560> 1206017 5 commit-queue 2016-06-28 06:25:42 -0700 All reviewed patches have been landed. Closing bug. 1207620 6 ossy 2016-07-04 01:48:14 -0700 (In reply to comment #2) > Ok, the problem here is the detection of THUMB2 support. Our code is based > on __thumb2__ or __thumb__ defines. This does work on Debian: > > $ gcc -dM -E - < /dev/null | grep -i thumb > #define __thumb2__ 1 > #define __THUMB_INTERWORK__ 1 > #define __thumb__ 1 > #define __ARM_ARCH_ISA_THUMB 2 > #define __THUMBEL__ 1 > > but does not on Fedora 24 with GCC 6.1. : > > $ gcc -dM -E - < /dev/null | grep -i thumb > #define __THUMB_INTERWORK__ 1 > #define __ARM_ARCH_ISA_THUMB 2 > > as the previously mentions defines are not presented there. (In reply to comment #4) > Comment on attachment 282244 [details] > Correct the THUMB2 detection on Fedora with gcc 6.1. > > Clearing flags on attachment: 282244 > > Committed r202560: <http://trac.webkit.org/changeset/202560> This change is incorrect, because it enables thumb2 instruction set on ARMv7 by default and doesn't work with toolchain uses -marm option: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Traditional%20Release/builds/1514 You are right, r202214 broke the build with ARM instruction set - ARM traditional in WebKit terminology - because of missing fillNops implementation in ARMAssembler.h. ARMv7Assembler.h is responsible for ARMv7 with Thumb2 instruction set. note: ARMv6 doesn't build with enabled JIT long long time ago, at least 2.5 years ago, see bug125581 and bug141288 for details. The thumb2 detection in Platform.h was correct, but it seem your toolchain was changed for some reason. The old one was built to use -mthumb, but the new one was built to use -marm as default instruction set. You can check your toolchain default settings with this command: gcc -Q --help=target | grep -i "\(marm\|mthumb\)" result if you have thumb2 toolchain: -marm [disabled] -mthumb [enabled] -mthumb-interwork [enabled] result if you have ARM toolchain: -marm [enabled] -mthumb [disabled] -mthumb-interwork [enabled] I'm going to fix the ARM traditional build soon in a separated bug. 1209054 7 tpopela 2016-07-08 04:19:45 -0700 (In reply to comment #6) > You can check your toolchain default settings with this command: > gcc -Q --help=target | grep -i "\(marm\|mthumb\)" > > result if you have thumb2 toolchain: > -marm [disabled] > -mthumb [enabled] > -mthumb-interwork [enabled] > > result if you have ARM toolchain: > -marm [enabled] > -mthumb [disabled] > -mthumb-interwork [enabled] > > I'm going to fix the ARM traditional build soon in a separated bug. Sorry Ossy about the breakage and thank you for working on the fix! It is as you said the thumb2 toolchain is indeed disabled and the ARM one enabled. 282244 2016-06-28 05:27:04 -0700 2016-06-28 06:25:38 -0700 Correct the THUMB2 detection on Fedora with gcc 6.1. bug-159083-20160628142647.patch text/plain 1475 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDAxMDExZTAxNWI1MTNmMzM5MjZmMTM2 OWQ1YjE1NDVjODRmNmYzMTEuLjAzMGZlNDA4NTFlYzYwNDhkNzgxYjQ2MGRiYjMzNTNlMmVlZGFk MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMDYtMjggIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBUSFVNQjIgc3VwcG9ydCBub3QgY29ycmVjdGx5IGRl dGVjdGVkIG9uIEZlZG9yYSB3aXRoIEdDQyA2LjEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBPbiBGZWRvcmEgMjQgd2l0aCBHQ0MgNi4xLiB0aGUgX190 aHVtYjJfXyBhbmQgX190aHVtYl9fIGFyZSBub3QKKyAgICAgICAgZGVmaW5lZCBzbyB0aGUgZGV0 ZWN0aW9uIG9mIFRIVU1CMiBzdXBwb3J0IHdpbGwgZmFpbC4gTG9vayBhbHNvCisgICAgICAgIHdo ZXRoZXIgdGhlIF9fQVJNX0FSQ0hfSVNBX1RIVU1CIGlzIGRlZmluZWQgdG8gZml4IHRoZSBUSFVN QjIKKyAgICAgICAgZGV0ZWN0aW9uLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIw MTYtMDYtMjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgbm93IHVudXNlZCBXVEY6OmZpbmROZXh0TGluZVN0YXJ0CmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRl eCBiOWE2YTVmNjRiZGU2MjM5MDAyY2E2ODBmOWY3ZjJkNjE2NDI3MDZhLi43MjdjNzMyMmZmMTdm ZTg4ZjZmMzhhNzZjYmQyZDEzOGJmYjA2MzgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTMwMiw2ICszMDIs NyBAQAogLyogT25seSBvbmUgb2YgdGhlc2Ugd2lsbCBiZSBkZWZpbmVkLiAqLwogI2lmICFkZWZp bmVkKFdURl9DUFVfQVJNX1RSQURJVElPTkFMKSAmJiAhZGVmaW5lZChXVEZfQ1BVX0FSTV9USFVN QjIpCiAjICBpZiBkZWZpbmVkKHRodW1iMikgfHwgZGVmaW5lZChfX3RodW1iMl9fKSBcCisgICAg fHwgKGRlZmluZWQoX19BUk1fQVJDSF9JU0FfVEhVTUIpICYmIF9fQVJNX0FSQ0hfSVNBX1RIVU1C ID09IDIpIFwKICAgICB8fCAoKGRlZmluZWQoX190aHVtYikgfHwgZGVmaW5lZChfX3RodW1iX18p KSAmJiBXVEZfVEhVTUJfQVJDSF9WRVJTSU9OID09IDQpCiAjICAgIGRlZmluZSBXVEZfQ1BVX0FS TV9UUkFESVRJT05BTCAwCiAjICAgIGRlZmluZSBXVEZfQ1BVX0FSTV9USFVNQjIgMQo=