159078 2016-06-23 17:56:14 -0700 Media elements should not lose playback controls when muted by a user gesture 2016-06-24 16:01:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue webkit-bug-importer oldest_to_newest 1204982 0 jer.noble 2016-06-23 17:56:14 -0700 Media elements should not lose playback controls when muted by a user gesture 1204985 1 jer.noble 2016-06-23 17:59:19 -0700 <rdar://problem/26925904> 1204986 2 281949 jer.noble 2016-06-23 18:00:22 -0700 Created attachment 281949 Patch 1205045 3 281949 jonlee 2016-06-24 00:56:37 -0700 Comment on attachment 281949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281949&action=review > Source/WebCore/html/MediaElementSession.cpp:239 > + } Is it ok to return true even if any of the conditions below in the "if (m_element.isVideo())" block would otherwise return false? Should both these checks happen after that block? 1205115 4 281949 jer.noble 2016-06-24 09:58:18 -0700 Comment on attachment 281949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281949&action=review >> Source/WebCore/html/MediaElementSession.cpp:239 >> + } > > Is it ok to return true even if any of the conditions below in the "if (m_element.isVideo())" block would otherwise return false? Should both these checks happen after that block? We don't want to do the size check if we already have had a user gesture, which is why this was moved before. The only case that changes here is that videos which are not in the DOM but are playing due to a user gesture will now show up in the DFR. So in that sense, it's the same as a playing <audio> element, and I think that's fine. 1205219 5 282018 jer.noble 2016-06-24 15:12:57 -0700 Created attachment 282018 Patch 1205237 6 282018 commit-queue 2016-06-24 16:01:24 -0700 Comment on attachment 282018 Patch Clearing flags on attachment: 282018 Committed r202459: <http://trac.webkit.org/changeset/202459> 1205238 7 commit-queue 2016-06-24 16:01:27 -0700 All reviewed patches have been landed. Closing bug. 281949 2016-06-23 18:00:22 -0700 2016-06-24 15:12:54 -0700 Patch bug-159078-20160623180009.patch text/plain 3092 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU0MTkyMGQ1ZGIxMzhh NzZmNDIxNmExN2NjNmFhMjJmN2NjNzBkMi4uMjkxN2ZiYTNmZWM5YjU2NjJjYzc4M2E0NzJiZDEw MjY0YTNkYzI4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTA2LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIGVsZW1lbnRzIHNo b3VsZCBub3QgbG9zZSBwbGF5YmFjayBjb250cm9scyB3aGVuIG11dGVkIGJ5IGEgdXNlciBnZXN0 dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkw NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2OTI1OTA0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYXJyYW5nZSBjYW5Db250cm9sQ29udHJv bHNNYW5hZ2VyKCkgc28gdGhhdCB0aGUgbXV0ZWQgY2hlY2sgb25seSBvY2N1cnMgaWYKKyAgICAg ICAgYSB1c2VyIGdlc3R1cmUgaXMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBodG1sL01lZGlhRWxl bWVudFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6 Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlcik6CisKKzIwMTYtMDYtMjMgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAgUGxheWJhY2sgY29udHJvbHMgcmVmZXIgdG8g d3JvbmcgZWxlbWVudCB3aGVuIHBsYXlpbmcgbXVsdGlwbGUgaXRlbXMgaW4gYSBwYWdlLgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDc2CiAgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNjk1MzUzMj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlh RWxlbWVudFNlc3Npb24uY3BwCmluZGV4IDgwZGEyMWFkMWY1MWE1ZTg0ZGJjMGFiMTUyNTMxNGM3 YmM5MmYxYjcuLmNlYTg1MTcyNTk0MjI3ZmIyYjQyNTk2NGEzNzk2YjZkNTY2ODMxMzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcApAQCAtMjE4LDExICsy MTgsNiBAQCBib29sIE1lZGlhRWxlbWVudFNlc3Npb246OmNhbkNvbnRyb2xDb250cm9sc01hbmFn ZXIoKSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgaWYgKG1fZWxl bWVudC5tdXRlZCgpKSB7Ci0gICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246 OmNhbkNvbnRyb2xDb250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgRkFMU0U6IE11dGVkIik7Ci0g ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KICAgICBpZiAobV9lbGVtZW50LmVuZGVkKCkp IHsKICAgICAgICAgTE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENv bnRyb2xzTWFuYWdlciAtIHJldHVybmluZyBGQUxTRTogRW5kZWQiKTsKICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMjM4LDYgKzIzMywxNiBAQCBib29sIE1lZGlhRWxlbWVudFNlc3Npb246OmNh bkNvbnRyb2xDb250cm9sc01hbmFnZXIoKSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgfQogCisgICAgaWYgKCFoYXNCZWhhdmlvclJlc3RyaWN0aW9uKFJlcXVpcmVVc2VyR2VzdHVy ZVRvQ29udHJvbENvbnRyb2xzTWFuYWdlcikgfHwgU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2lu Z1VzZXJHZXN0dXJlRm9yTWVkaWEoKSkgeworICAgICAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1l bnRTZXNzaW9uOjpjYW5Db250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIFRSVUU6IE5v IHVzZXIgZ2VzdHVyZSByZXF1aXJlZCIpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisK KyAgICBpZiAobV9lbGVtZW50Lm11dGVkKCkpIHsKKyAgICAgICAgTE9HKE1lZGlhLCAiTWVkaWFF bGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlciAtIHJldHVybmluZyBGQUxT RTogTXV0ZWQiKTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIGlmIChtX2Vs ZW1lbnQuaXNWaWRlbygpKSB7CiAgICAgICAgIGlmICghbV9lbGVtZW50LnJlbmRlcmVyKCkpIHsK ICAgICAgICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246OmNhbkNvbnRyb2xD b250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgRkFMU0U6IE5vIHJlbmRlcmVyIik7CkBAIC0yNTUs MTMgKzI2MCw4IEBAIGJvb2wgTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xz TWFuYWdlcigpIGNvbnN0CiAgICAgICAgIH0KICAgICB9CiAKLSAgICBpZiAobV9yZXN0cmljdGlv bnMgJiBSZXF1aXJlVXNlckdlc3R1cmVUb0NvbnRyb2xDb250cm9sc01hbmFnZXIgJiYgIVNjcmlw dENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZUZvck1lZGlhKCkpIHsKLSAgICAgICAg TE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdl ciAtIHJldHVybmluZyBGQUxTRTogTm8gdXNlciBnZXN0dXJlIik7Ci0gICAgICAgIHJldHVybiBm YWxzZTsKLSAgICB9Ci0KLSAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNzaW9uOjpjYW5D b250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIFRSVUU6IEFsbCBjcml0ZXJpYSBtZXQi KTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNzaW9u OjpjYW5Db250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIEZBTFNFOiBObyB1c2VyIGdl c3R1cmUiKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKICNpZiBFTkFCTEUoV0lSRUxFU1NfUExB WUJBQ0tfVEFSR0VUKQo= 282018 2016-06-24 15:12:57 -0700 2016-06-24 16:01:24 -0700 Patch bug-159078-20160624151245.patch text/plain 3092 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdkZGIwM2I1NTliZjAw NDY3OTJjNTZjNTcxZmY1ZGNkMzE0Mjc2ZS4uZGI3M2U4YzU1OTUwNDIxNTRlZWI2MWM3NmNhMzIw NjI3YjgzNWVkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTA2LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIE1lZGlhIGVsZW1lbnRzIHNo b3VsZCBub3QgbG9zZSBwbGF5YmFjayBjb250cm9scyB3aGVuIG11dGVkIGJ5IGEgdXNlciBnZXN0 dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkw NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2OTI1OTA0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYXJyYW5nZSBjYW5Db250cm9sQ29udHJv bHNNYW5hZ2VyKCkgc28gdGhhdCB0aGUgbXV0ZWQgY2hlY2sgb25seSBvY2N1cnMgaWYKKyAgICAg ICAgYSB1c2VyIGdlc3R1cmUgaXMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBodG1sL01lZGlhRWxl bWVudFNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbGVtZW50U2Vzc2lvbjo6 Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlcik6CisKKzIwMTYtMDYtMjMgIEplciBOb2JsZSAgPGpl ci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAgUGxheWJhY2sgY29udHJvbHMgcmVmZXIgdG8g d3JvbmcgZWxlbWVudCB3aGVuIHBsYXlpbmcgbXVsdGlwbGUgaXRlbXMgaW4gYSBwYWdlLgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDc2CiAgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNjk1MzUzMj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlh RWxlbWVudFNlc3Npb24uY3BwCmluZGV4IDgwZGEyMWFkMWY1MWE1ZTg0ZGJjMGFiMTUyNTMxNGM3 YmM5MmYxYjcuLmNlYTg1MTcyNTk0MjI3ZmIyYjQyNTk2NGEzNzk2YjZkNTY2ODMxMzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmNwcApAQCAtMjE4LDExICsy MTgsNiBAQCBib29sIE1lZGlhRWxlbWVudFNlc3Npb246OmNhbkNvbnRyb2xDb250cm9sc01hbmFn ZXIoKSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgaWYgKG1fZWxl bWVudC5tdXRlZCgpKSB7Ci0gICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246 OmNhbkNvbnRyb2xDb250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgRkFMU0U6IE11dGVkIik7Ci0g ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KICAgICBpZiAobV9lbGVtZW50LmVuZGVkKCkp IHsKICAgICAgICAgTE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENv bnRyb2xzTWFuYWdlciAtIHJldHVybmluZyBGQUxTRTogRW5kZWQiKTsKICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMjM4LDYgKzIzMywxNiBAQCBib29sIE1lZGlhRWxlbWVudFNlc3Npb246OmNh bkNvbnRyb2xDb250cm9sc01hbmFnZXIoKSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgfQogCisgICAgaWYgKCFoYXNCZWhhdmlvclJlc3RyaWN0aW9uKFJlcXVpcmVVc2VyR2VzdHVy ZVRvQ29udHJvbENvbnRyb2xzTWFuYWdlcikgfHwgU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2lu Z1VzZXJHZXN0dXJlRm9yTWVkaWEoKSkgeworICAgICAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1l bnRTZXNzaW9uOjpjYW5Db250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIFRSVUU6IE5v IHVzZXIgZ2VzdHVyZSByZXF1aXJlZCIpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisK KyAgICBpZiAobV9lbGVtZW50Lm11dGVkKCkpIHsKKyAgICAgICAgTE9HKE1lZGlhLCAiTWVkaWFF bGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdlciAtIHJldHVybmluZyBGQUxT RTogTXV0ZWQiKTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIGlmIChtX2Vs ZW1lbnQuaXNWaWRlbygpKSB7CiAgICAgICAgIGlmICghbV9lbGVtZW50LnJlbmRlcmVyKCkpIHsK ICAgICAgICAgICAgIExPRyhNZWRpYSwgIk1lZGlhRWxlbWVudFNlc3Npb246OmNhbkNvbnRyb2xD b250cm9sc01hbmFnZXIgLSByZXR1cm5pbmcgRkFMU0U6IE5vIHJlbmRlcmVyIik7CkBAIC0yNTUs MTMgKzI2MCw4IEBAIGJvb2wgTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xz TWFuYWdlcigpIGNvbnN0CiAgICAgICAgIH0KICAgICB9CiAKLSAgICBpZiAobV9yZXN0cmljdGlv bnMgJiBSZXF1aXJlVXNlckdlc3R1cmVUb0NvbnRyb2xDb250cm9sc01hbmFnZXIgJiYgIVNjcmlw dENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZUZvck1lZGlhKCkpIHsKLSAgICAgICAg TE9HKE1lZGlhLCAiTWVkaWFFbGVtZW50U2Vzc2lvbjo6Y2FuQ29udHJvbENvbnRyb2xzTWFuYWdl ciAtIHJldHVybmluZyBGQUxTRTogTm8gdXNlciBnZXN0dXJlIik7Ci0gICAgICAgIHJldHVybiBm YWxzZTsKLSAgICB9Ci0KLSAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNzaW9uOjpjYW5D b250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIFRSVUU6IEFsbCBjcml0ZXJpYSBtZXQi KTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICBMT0coTWVkaWEsICJNZWRpYUVsZW1lbnRTZXNzaW9u OjpjYW5Db250cm9sQ29udHJvbHNNYW5hZ2VyIC0gcmV0dXJuaW5nIEZBTFNFOiBObyB1c2VyIGdl c3R1cmUiKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKICNpZiBFTkFCTEUoV0lSRUxFU1NfUExB WUJBQ0tfVEFSR0VUKQo=