159072 2016-06-23 14:56:02 -0700 Make window.open layout tests for about: URLs work on iOS 2016-06-24 10:34:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=158855 P2 Normal --- 1 wilander wilander ap commit-queue ryanhaddad wilander oldest_to_newest 1204937 0 wilander 2016-06-23 14:56:02 -0700 Two window.open layout tests had to be skipped for iOS since they used click events. 1204941 1 281934 wilander 2016-06-23 15:00:52 -0700 Created attachment 281934 Patch 1205135 2 281934 commit-queue 2016-06-24 10:34:56 -0700 Comment on attachment 281934 Patch Clearing flags on attachment: 281934 Committed r202428: <http://trac.webkit.org/changeset/202428> 1205136 3 commit-queue 2016-06-24 10:34:59 -0700 All reviewed patches have been landed. Closing bug. 281934 2016-06-23 15:00:52 -0700 2016-06-24 10:34:56 -0700 Patch bug-159072-20160623150041.patch text/plain 7375 wilander SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMjM5OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA2LTIzICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugd2luZG93Lm9wZW4gbGF5b3V0IHRl c3RzIGZvciBhYm91dDogVVJMcyB3b3JrIG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHR3byB3aW5kb3cub3BlbiBsYXlvdXQgdGVzdHMg Zm9yIGlPUy4gVGhleSBwcmV2aW91c2x5IHVzZWQgY2xpY2sgZXZlbnRzLgorICAgICAgICBOb3cg dGhleSBpbnN0ZWFkIHR1cm4gb2ZmIHRoZSBwb3B1cCBibG9ja2VyIGFuZCBqdXN0IGNhbGwgd2lu ZG93Lm9wZW4oKSBvbgorICAgICAgICB0aGUgbG9hZCBldmVudC4KKworICAgICAgICAqIGh0dHAv dGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LWJsYW5rLWFuZC1hY2Nlc3MtZG9jdW1lbnQtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LWJs YW5rLWFuZC1hY2Nlc3MtZG9jdW1lbnQuaHRtbDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2RvbS93 aW5kb3ctb3Blbi1hYm91dC13ZWJraXQtb3JnLWFuZC1hY2Nlc3MtZG9jdW1lbnQtZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LXdlYmtpdC1v cmctYW5kLWFjY2Vzcy1kb2N1bWVudC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy1zaW11 bGF0b3IvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgICAgIFJlbW92ZWQgdGhlIHNraXBwaW5n IG9mIHRoZXNlIHR3byB0ZXN0IGNhc2VzLgorCiAyMDE2LTA2LTIzICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIExhbmQgdGVzdCBleHBlY3RhdGlvbnMgZm9y IHJkYXI6Ly9wcm9ibGVtLzI2OTUyNjI3LgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9k b20vd2luZG93LW9wZW4tYWJvdXQtYmxhbmstYW5kLWFjY2Vzcy1kb2N1bWVudC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9kb20vd2luZG93LW9wZW4t YWJvdXQtYmxhbmstYW5kLWFjY2Vzcy1kb2N1bWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIw MjM5NykKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LWJs YW5rLWFuZC1hY2Nlc3MtZG9jdW1lbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0x LDQgKzEsMyBAQAogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE6IEluamVjdGVkIHNjcmlwdCBydW5u aW5nLgotCiBQQVNTIG5ld1dpbmRvdy5kb2N1bWVudCBpcyBkZWZpbmVkLgogCkluZGV4OiBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1hYm91dC1ibGFuay1hbmQtYWNjZXNz LWRvY3VtZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9kb20v d2luZG93LW9wZW4tYWJvdXQtYmxhbmstYW5kLWFjY2Vzcy1kb2N1bWVudC5odG1sCShyZXZpc2lv biAyMDIzOTcpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1hYm91 dC1ibGFuay1hbmQtYWNjZXNzLWRvY3VtZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEwLDQw ICsxMCwyOSBAQAogICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICAgICAgICAg IHRlc3RSdW5uZXIuc2V0Q2FuT3BlbldpbmRvd3MoKTsKICAgICAgICAgICAgIHRlc3RSdW5uZXIu d2FpdFVudGlsRG9uZSgpOworICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRQb3B1cEJsb2NraW5n RW5hYmxlZChmYWxzZSk7CiAgICAgICAgIH0KIAotICAgICAgICBmdW5jdGlvbiBjaGVja05ld1dp bmRvd0RvY3VtZW50SXNVbmRlZmluZWQgKCkgeworICAgICAgICBmdW5jdGlvbiBjaGVja05ld1dp bmRvd0RvY3VtZW50SXNEZWZpbmVkICgpIHsKICAgICAgICAgICAgIHNob3VsZEJlRGVmaW5lZCgi bmV3V2luZG93LmRvY3VtZW50Iik7CiAgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp CiAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CiAgICAgICAgIH0KIAot ICAgICAgICBmdW5jdGlvbiBjbGlja0hhbmRsZXIoKSB7CisgICAgICAgIGZ1bmN0aW9uIHJ1bigp IHsKICAgICAgICAgICAgIG5ld1dpbmRvdyA9IHdpbmRvdy5vcGVuKCJhYm91dDpibGFuayIpOwog ICAgICAgICAgICAgdHJ5IHsKICAgICAgICAgICAgICAgICBuZXdXaW5kb3cuZG9jdW1lbnQud3Jp dGUoIjxzY3JpIiArICJwdD5jb25zb2xlLmxvZygnSW5qZWN0ZWQgc2NyaXB0IHJ1bm5pbmcuJyk8 L3NjIiArICJyaXB0PiIpOwotICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoY2hlY2tOZXdXaW5k b3dEb2N1bWVudElzVW5kZWZpbmVkLCA1MDApOworICAgICAgICAgICAgICAgIHNldFRpbWVvdXQo Y2hlY2tOZXdXaW5kb3dEb2N1bWVudElzRGVmaW5lZCwgNTAwKTsKICAgICAgICAgICAgIH0gY2F0 Y2ggKGUpIHsKICAgICAgICAgICAgICAgICB0ZXN0RmFpbGVkKCJXYXMgbm90IGFibGUgdG8gd3Jp dGUgdG8gdGhlIG5ldyB3aW5kb3cncyBkb2N1bWVudC4iKTsKICAgICAgICAgICAgICAgICBpZiAo d2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0KLSAgICAgICAgZnVuY3Rpb24gY2xp Y2tCdXR0b24oKSB7Ci0gICAgICAgICAgICB2YXIgYnV0dG9uID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInRlc3QiKTsKLSAgICAgICAgICAgIHZhciBidXR0b25YID0gYnV0dG9uLm9mZnNldExl ZnQgKyBidXR0b24ub2Zmc2V0V2lkdGggLyAyOwotICAgICAgICAgICAgdmFyIGJ1dHRvblkgPSBi dXR0b24ub2Zmc2V0VG9wICsgYnV0dG9uLm9mZnNldEhlaWdodCAvIDI7Ci0gICAgICAgICAgICBp ZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91 c2VNb3ZlVG8oYnV0dG9uWCwgYnV0dG9uWSk7Ci0gICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7Ci0gICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwotICAg ICAgICAgICAgfQotICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8L2hlYWQ+Ci08Ym9keSBvbmxv YWQ9ImNsaWNrQnV0dG9uKCkiPgotPGJ1dHRvbiBpZD0idGVzdCIgb25jbGljaz0iY2xpY2tIYW5k bGVyKCkiPjwvYnV0dG9uPgorPGJvZHkgb25sb2FkPSJydW4oKSI+CiA8ZGl2IGlkPSJjb25zb2xl Ij48L2Rpdj4KIDwvYm9keT4KLTwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCis8 L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1hYm91 dC13ZWJraXQtb3JnLWFuZC1hY2Nlc3MtZG9jdW1lbnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LXdlYmtpdC1v cmctYW5kLWFjY2Vzcy1kb2N1bWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIwMjM5NykKKysr IExheW91dFRlc3RzL2h0dHAvdGVzdHMvZG9tL3dpbmRvdy1vcGVuLWFib3V0LXdlYmtpdC1vcmct YW5kLWFjY2Vzcy1kb2N1bWVudC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNyAr MSw2IEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNDU6IEJsb2NrZWQgYSBmcmFtZSB3aXRoIG9y aWdpbiAiaHR0cDovLzEyNy4wLjAuMTo4MDAwIiBmcm9tIGFjY2Vzc2luZyBhIGZyYW1lIHdpdGgg b3JpZ2luICJudWxsIi4gIFRoZSBmcmFtZSByZXF1ZXN0aW5nIGFjY2VzcyBoYXMgYSBwcm90b2Nv bCBvZiAiaHR0cCIsIHRoZSBmcmFtZSBiZWluZyBhY2Nlc3NlZCBoYXMgYSBwcm90b2NvbCBvZiAi YWJvdXQiLiBQcm90b2NvbHMgbXVzdCBtYXRjaC4KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAzNDog QmxvY2tlZCBhIGZyYW1lIHdpdGggb3JpZ2luICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiIGZyb20g YWNjZXNzaW5nIGEgZnJhbWUgd2l0aCBvcmlnaW4gIm51bGwiLiAgVGhlIGZyYW1lIHJlcXVlc3Rp bmcgYWNjZXNzIGhhcyBhIHByb3RvY29sIG9mICJodHRwIiwgdGhlIGZyYW1lIGJlaW5nIGFjY2Vz c2VkIGhhcyBhIHByb3RvY29sIG9mICJhYm91dCIuIFByb3RvY29scyBtdXN0IG1hdGNoLgogCiBD T05TT0xFIE1FU1NBR0U6IGxpbmUgMzQ3OiBCbG9ja2VkIGEgZnJhbWUgd2l0aCBvcmlnaW4gImh0 dHA6Ly8xMjcuMC4wLjE6ODAwMCIgZnJvbSBhY2Nlc3NpbmcgYSBmcmFtZSB3aXRoIG9yaWdpbiAi bnVsbCIuICBUaGUgZnJhbWUgcmVxdWVzdGluZyBhY2Nlc3MgaGFzIGEgcHJvdG9jb2wgb2YgImh0 dHAiLCB0aGUgZnJhbWUgYmVpbmcgYWNjZXNzZWQgaGFzIGEgcHJvdG9jb2wgb2YgImFib3V0Ii4g UHJvdG9jb2xzIG11c3QgbWF0Y2guCiAKLQogUEFTUyBuZXdXaW5kb3cuZG9jdW1lbnQgaXMgdW5k ZWZpbmVkLgogCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1h Ym91dC13ZWJraXQtb3JnLWFuZC1hY2Nlc3MtZG9jdW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1hYm91dC13ZWJraXQtb3JnLWFu ZC1hY2Nlc3MtZG9jdW1lbnQuaHRtbAkocmV2aXNpb24gMjAyMzk3KQorKysgTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9kb20vd2luZG93LW9wZW4tYWJvdXQtd2Via2l0LW9yZy1hbmQtYWNjZXNzLWRv Y3VtZW50Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTksNiArOSw3IEBACiAgICAgICAgIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRDYW5PcGVuV2lu ZG93cygpOwogICAgICAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAg ICAgICB0ZXN0UnVubmVyLnNldFBvcHVwQmxvY2tpbmdFbmFibGVkKGZhbHNlKTsKICAgICAgICAg fQogCiAgICAgICAgIGZ1bmN0aW9uIGNoZWNrTmV3V2luZG93RG9jdW1lbnRJc1VuZGVmaW5lZCAo KSB7CkBAIC0xNyw3ICsxOCw3IEBACiAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlE b25lKCk7CiAgICAgICAgIH0KIAotICAgICAgICBmdW5jdGlvbiBjbGlja0hhbmRsZXIoKSB7Cisg ICAgICAgIGZ1bmN0aW9uIHJ1bigpIHsKICAgICAgICAgICAgIG5ld1dpbmRvdyA9IHdpbmRvdy5v cGVuKCJhYm91dDovL3dlYmtpdC5vcmciKTsKICAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAg ICAgICAgbmV3V2luZG93LmRvY3VtZW50LndyaXRlKCI8c2NyaSIgKyAicHQ+Y29uc29sZS5sb2co J0luamVjdGVkIHNjcmlwdCBydW5uaW5nLicpPC9zYyIgKyAicmlwdD4iKTsKQEAgLTI4LDIxICsy OSw5IEBACiAgICAgICAgICAgICAgICAgc2V0VGltZW91dChjaGVja05ld1dpbmRvd0RvY3VtZW50 SXNVbmRlZmluZWQsIDUwMCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLQotICAgICAgICBm dW5jdGlvbiBjbGlja0J1dHRvbigpIHsKLSAgICAgICAgICAgIHZhciBidXR0b24gPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgidGVzdCIpOwotICAgICAgICAgICAgdmFyIGJ1dHRvblggPSBidXR0 b24ub2Zmc2V0TGVmdCArIGJ1dHRvbi5vZmZzZXRXaWR0aCAvIDI7Ci0gICAgICAgICAgICB2YXIg YnV0dG9uWSA9IGJ1dHRvbi5vZmZzZXRUb3AgKyBidXR0b24ub2Zmc2V0SGVpZ2h0IC8gMjsKLSAg ICAgICAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKLSAgICAgICAgICAgICAgICBldmVu dFNlbmRlci5tb3VzZU1vdmVUbyhidXR0b25YLCBidXR0b25ZKTsKLSAgICAgICAgICAgICAgICBl dmVudFNlbmRlci5tb3VzZURvd24oKTsKLSAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3Vz ZVVwKCk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KICAgICA8L3NjcmlwdD4KIDwvaGVhZD4K LTxib2R5IG9ubG9hZD0iY2xpY2tCdXR0b24oKSI+Ci08YnV0dG9uIGlkPSJ0ZXN0IiBvbmNsaWNr PSJjbGlja0hhbmRsZXIoKSI+PC9idXR0b24+Cis8Ym9keSBvbmxvYWQ9InJ1bigpIj4KIDxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgogPC9ib2R5PgotPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5k IG9mIGZpbGUKKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0 b3IvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9p b3Mtc2ltdWxhdG9yL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDIwMjM5NykKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3IvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBj b3B5KQpAQCAtMjU0LDggKzI1NCw2IEBAIGZhc3Qvc2Nyb2xsaW5nL3Njcm9sbC1hbmltYXRvci1v dmVybGF5LXMKIGZhc3Qvc2Nyb2xsaW5nL3Njcm9sbC1hbmltYXRvci1zZWxlY3QtbGlzdC1ldmVu dHMuaHRtbCBbIFNraXAgXQogZmFzdC9ldmVudHMvcHJldmVudC1kZWZhdWx0LXByZXZlbnRzLWlu dGVyYWN0aW9uLXdpdGgtc2Nyb2xsYmFycy5odG1sIFsgU2tpcCBdCiBmYXN0L3RleHQvdGV4dC1k aXNhcHBlYXItb24tZGVzZWxlY3QuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotaHR0cC90ZXN0 cy9kb20vd2luZG93LW9wZW4tYWJvdXQtYmxhbmstYW5kLWFjY2Vzcy1kb2N1bWVudC5odG1sIFsg U2tpcCBdCi1odHRwL3Rlc3RzL2RvbS93aW5kb3ctb3Blbi1hYm91dC13ZWJraXQtb3JnLWFuZC1h Y2Nlc3MtZG9jdW1lbnQuaHRtbCBbIFNraXAgXQogCiB3ZWJraXQub3JnL2IvMTQ4Njk1IGZhc3Qv c2hhZG93LWRvbSBbIFBhc3MgXQogCg==