159070 2016-06-23 14:17:01 -0700 REGRESSION(r201171): CRASH at WebKit::WebInspectorProxy::open() + 31 when running inspector layout tests 2016-06-24 17:37:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1204928 0 bburg 2016-06-23 14:17:01 -0700 Looks like something weird is going on. 1204929 1 bburg 2016-06-23 14:17:13 -0700 <rdar://problem/26768628> 1204930 2 281931 bburg 2016-06-23 14:24:36 -0700 Created attachment 281931 Proposed Fix 1205278 3 281931 joepeck 2016-06-24 17:03:17 -0700 Comment on attachment 281931 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review r=me > Source/WebKit2/ChangeLog:12 > + However, it doesn't make sense that we would hit the null dereference here: Should we add an ASSERT? 1205282 4 281931 bburg 2016-06-24 17:15:45 -0700 Comment on attachment 281931 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281931&action=review >> Source/WebKit2/ChangeLog:12 >> + However, it doesn't make sense that we would hit the null dereference here: > > Should we add an ASSERT? I added a more valuable assert in https://bugs.webkit.org/show_bug.cgi?id=159073. Since this code is only ever called via IPC (one frame below bringToFront()) an assertion here is not going to tell us anything useful, as the backtrace will just be full of IPC junk. 1205290 5 281931 commit-queue 2016-06-24 17:37:02 -0700 Comment on attachment 281931 Proposed Fix Clearing flags on attachment: 281931 Committed r202464: <http://trac.webkit.org/changeset/202464> 1205291 6 commit-queue 2016-06-24 17:37:05 -0700 All reviewed patches have been landed. Closing bug. 281931 2016-06-23 14:24:36 -0700 2016-06-24 17:37:02 -0700 Proposed Fix bug-159070-20160623142426.patch text/plain 2538 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmI2MTJlZWQzOTE1Y2Y1 MzBmODBjMjUzYWNjMzkyYTU0ZmFkZTQyZC4uN2Q0OTNiYTBhOTk4NDFmNDQ0ODU5MGYwNTNlOGMy MDdlNGQ4YTA1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE2LTA2LTIzICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwMTE3MSk6 IENSQVNIIGF0IFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6Om9wZW4oKSArIDMxIHdoZW4gcnVu bmluZyBpbnNwZWN0b3IgbGF5b3V0IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NzY4 NjI4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IGhhdmUgYmVlbiBzZWVpbmcgYSBmZXcgY3Jhc2hlcyB1bmRlcm5lYXRoIFdlYkluc3BlY3RvclBy b3h5OjpicmluZ1RvRnJvbnQoKSBvbiB0aGUgYm90cy4KKyAgICAgICAgUHJldmlvdXNseSwgdGhp cyBjb2RlIGRpZG4ndCB1c2UgbV9pbnNwZWN0b3JQYWdlIHNvIHRoZXJlIHdhcyBub3RoaW5nIHRv IG51bGwtZGVyZWZlcmVuY2UuCisKKyAgICAgICAgSG93ZXZlciwgaXQgZG9lc24ndCBtYWtlIHNl bnNlIHRoYXQgd2Ugd291bGQgaGl0IHRoZSBudWxsIGRlcmVmZXJlbmNlIGhlcmU6CisKKyAgICAg ICAgIC0gVGhlIG9ubHkgY2FsbGVyIG9mIGJyaW5nVG9Gcm9udCgpIG9uIHRoZSBXZWJQcm9jZXNz IHNpZGUgaXMgSW5zcGVjdG9yQ29udHJvbGxlcjo6c2hvdygpLgorICAgICAgICAgICBJdCBvbmx5 IHRyaWVzIHRvIGJyaW5nIHRvIGZyb250IGlmIHRoZXJlIGlzIGFscmVhZHkgYSBsb2NhbCBmcm9u dGVuZCBjb25uZWN0aW9uLCB3aGljaAorICAgICAgICAgICBzaG91bGRuJ3QgYmUgdGhlIGNhc2Ug aWYgbV9pbnNwZWN0b3JQYWdlIGlzIG51bGwuCisKKyAgICAgICAgIC0gSXQncyBndWFyZGVkIGJ5 IG1fdW5kZXJUZXN0LCB3aGljaCBzaG91bGQgaGF2ZSBiZWVuIHNldCB0byB0cnVlIGluIGNyZWF0 ZUluc3BlY3RvclBhZ2UoKS4KKworICAgICAgICBUaGVzZSBjbHVlcyBsZWFkIG1lIHRvIGJlbGll dmUgdGhhdCB3ZSBtYXkgYmUgaW1wcm9wZXJseSB0ZWFyaW5nIGRvd24gdGhlIGluc3BlY3RvciBi ZXR3ZWVuIHRlc3RzLgorICAgICAgICBGb3IgZXhhbXBsZSwgaXQgc2VlbXMgcG9zc2libGUgdGhh dCBhIGxvY2FsIGZyb250ZW5kIGNvbm5lY3Rpb24gaXMgbm90IGJlaW5nIHRvcm4gZG93biwgc28K KyAgICAgICAgSW5zcGVjdG9yQ29udHJvbGxlciBuZXZlciBhc2tzIHRvIGNyZWF0ZSBhIGluc3Bl Y3RvciBwYWdlIHdoZW4gdGhlIG5leHQgdGVzdCBjYWxscyBzaG93V2ViSW5zcGVjdG9yLgorCisg ICAgICAgIFNpbmNlIHRoaXMgY3Jhc2ggaXMgbm90IGVhc3kgdG8gcmVwcm9kdWNlLCB3ZSBkb24n dCBoYXZlIG11Y2ggdG8gZ28gb24uIEZvciBub3csIHRoaXMgcGF0Y2gKKyAgICAgICAgYWRkcyBh biBlYXJseSByZXR1cm4gaW4gdGhlIGNhc2Ugd2hlcmUgbV9pbnNwZWN0b3JQYWdlIGlzIG51bGwg d2hlbiBjYWxsaW5nIG9wZW4oKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpvcGVuKToKKwog MjAxNi0wNi0yMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBT UEkgdG8gYWxsb3cgY3JlYXRpbmcgYSBXS0NlcnRpZmljYXRlSW5mb1JlZiBmcm9tIGEgU2VjVHJ1 c3RSZWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3Bw CmluZGV4IDJiMjExMDNkNzFiZmMwMTVmOTIxY2E0NmNmMWNhYjhlYThkZDg2ODUuLjMwMjJhNTRi MmQ3NmI4NmUyODhhNGJmM2E5ZGE2MjZjMDIwM2U4OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcApAQCAtNTgwLDYgKzU4MCw5IEBAIHZvaWQg V2ViSW5zcGVjdG9yUHJveHk6Om9wZW4oKQogICAgIGlmIChtX3VuZGVyVGVzdCkKICAgICAgICAg cmV0dXJuOwogCisgICAgaWYgKCFtX2luc3BlY3RvclBhZ2UpCisgICAgICAgIHJldHVybjsKKwog ICAgIG1faXNWaXNpYmxlID0gdHJ1ZTsKICAgICBtX2luc3BlY3RvclBhZ2UtPnByb2Nlc3MoKS5z ZW5kKE1lc3NhZ2VzOjpXZWJJbnNwZWN0b3JVSTo6U2V0SXNWaXNpYmxlKG1faXNWaXNpYmxlKSwg bV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQoKSk7CiAK