159069 2016-06-23 13:15:04 -0700 Remove unused and static return value from InspectorStyle::populateAllProperties 2016-06-24 13:14:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue timothy oldest_to_newest 1204918 0 joepeck 2016-06-23 13:15:04 -0700 Summary: Remove unused and static return value from InspectorStyle::populateAllProperties It is always true and is never checked. 1204919 1 281929 joepeck 2016-06-23 13:15:49 -0700 Created attachment 281929 [PATCH] Proposed Fix 1205189 2 281929 commit-queue 2016-06-24 13:14:45 -0700 Comment on attachment 281929 [PATCH] Proposed Fix Clearing flags on attachment: 281929 Committed r202440: <http://trac.webkit.org/changeset/202440> 1205190 3 commit-queue 2016-06-24 13:14:48 -0700 All reviewed patches have been landed. Closing bug. 281929 2016-06-23 13:15:49 -0700 2016-06-24 13:14:45 -0700 [PATCH] Proposed Fix cleanup-2.patch text/plain 2664 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZWRhNmM5Li40ODNhYTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTYtMDYtMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBSZW1vdmUgdW51c2VkIGFuZCBzdGF0aWMgcmV0dXJuIHZhbHVlIGZyb20gSW5zcGVj dG9yU3R5bGU6OnBvcHVsYXRlQWxsUHJvcGVydGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZTo6cG9wdWxhdGVBbGxQcm9wZXJ0 aWVzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5oOgorCisyMDE2 LTA2LTIzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogTWVtb3J5IFRpbWVsaW5lIHNvbWV0aW1lcyBzaG93cyBpbXBvc3NpYmxl IHZhbHVlIGZvciBibWFsbG9jIHNpemUgKHVuZGVyZmxvd2VkKQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MTEwCiAgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yNjQ5ODU4ND4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JTdHlsZVNoZWV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JT dHlsZVNoZWV0LmNwcAppbmRleCA3ZGU5OGFhLi4wZDA1OTc4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCkBAIC0zNTcsNyArMzU3LDcg QEAgc3RhdGljIFN0cmluZyBsb3dlcmNhc2VQcm9wZXJ0eU5hbWUoY29uc3QgU3RyaW5nJiBuYW1l KQogICAgIHJldHVybiBuYW1lLmNvbnZlcnRUb0FTQ0lJTG93ZXJjYXNlKCk7CiB9CiAKLWJvb2wg SW5zcGVjdG9yU3R5bGU6OnBvcHVsYXRlQWxsUHJvcGVydGllcyhWZWN0b3I8SW5zcGVjdG9yU3R5 bGVQcm9wZXJ0eT4qIHJlc3VsdCkgY29uc3QKK3ZvaWQgSW5zcGVjdG9yU3R5bGU6OnBvcHVsYXRl QWxsUHJvcGVydGllcyhWZWN0b3I8SW5zcGVjdG9yU3R5bGVQcm9wZXJ0eT4qIHJlc3VsdCkgY29u c3QKIHsKICAgICBIYXNoU2V0PFN0cmluZz4gc291cmNlUHJvcGVydHlOYW1lczsKIApAQCAtMzgw LDggKzM4MCw2IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGU6OnBvcHVsYXRlQWxsUHJvcGVydGllcyhW ZWN0b3I8SW5zcGVjdG9yU3R5bGVQcm9wZXJ0eT4qIHJlc3VsCiAgICAgICAgIGlmIChzb3VyY2VQ cm9wZXJ0eU5hbWVzLmFkZChsb3dlcmNhc2VQcm9wZXJ0eU5hbWUobmFtZSkpKQogICAgICAgICAg ICAgcmVzdWx0LT5hcHBlbmQoSW5zcGVjdG9yU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eVNvdXJj ZURhdGEobmFtZSwgbV9zdHlsZS0+Z2V0UHJvcGVydHlWYWx1ZShuYW1lKSwgIW1fc3R5bGUtPmdl dFByb3BlcnR5UHJpb3JpdHkobmFtZSkuaXNFbXB0eSgpLCB0cnVlLCBTb3VyY2VSYW5nZSgpKSwg ZmFsc2UsIGZhbHNlKSk7CiAgICAgfQotCi0gICAgcmV0dXJuIHRydWU7CiB9CiAKIFJlZjxJbnNw ZWN0b3I6OlByb3RvY29sOjpDU1M6OkNTU1N0eWxlPiBJbnNwZWN0b3JTdHlsZTo6c3R5bGVXaXRo UHJvcGVydGllcygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yU3R5bGVTaGVldC5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv clN0eWxlU2hlZXQuaAppbmRleCA1ZTM2MDg3Li5kNWEyY2VkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmgKQEAgLTE0MCw3ICsxNDAsNyBAQCBw dWJsaWM6CiBwcml2YXRlOgogICAgIEluc3BlY3RvclN0eWxlKGNvbnN0IEluc3BlY3RvckNTU0lk JiBzdHlsZUlkLCBSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4mJiwgSW5zcGVjdG9yU3R5bGVT aGVldCogcGFyZW50U3R5bGVTaGVldCk7CiAKLSAgICBib29sIHBvcHVsYXRlQWxsUHJvcGVydGll cyhWZWN0b3I8SW5zcGVjdG9yU3R5bGVQcm9wZXJ0eT4qIHJlc3VsdCkgY29uc3Q7CisgICAgdm9p ZCBwb3B1bGF0ZUFsbFByb3BlcnRpZXMoVmVjdG9yPEluc3BlY3RvclN0eWxlUHJvcGVydHk+KiBy ZXN1bHQpIGNvbnN0OwogICAgIFJlZjxJbnNwZWN0b3I6OlByb3RvY29sOjpDU1M6OkNTU1N0eWxl PiBzdHlsZVdpdGhQcm9wZXJ0aWVzKCkgY29uc3Q7CiAgICAgUmVmUHRyPENTU1J1bGVTb3VyY2VE YXRhPiBleHRyYWN0U291cmNlRGF0YSgpIGNvbnN0OwogICAgIFN0cmluZyBzaG9ydGhhbmRWYWx1 ZShjb25zdCBTdHJpbmcmIHNob3J0aGFuZFByb3BlcnR5KSBjb25zdDsK