159068 2016-06-23 12:22:49 -0700 [iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion 2016-06-23 12:59:14 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified iOS 9.3 RESOLVED FIXED InRadar P1 Normal --- 1 cdumez cdumez andersca barraclough dbates kling rniwa sam thorton webkit-bug-importer oldest_to_newest 1204904 0 cdumez 2016-06-23 12:22:49 -0700 A WebPageProxy in closed state should not be allowed to hold a process assertion. It currently happens that WebPageProxy::close() gets called but that the WebPageProxy is kept alive by Safari (e.g. In case of top-hit preloading). In such cases, we fail to release the foreground process assertion that the WebPageProxy holds. We should clear the foreground process assertion that the WebPageProxy holds as soon as WebPageProxy::close() is called. 1204905 1 cdumez 2016-06-23 12:23:22 -0700 rdar://problem/17665473 1204908 2 281928 cdumez 2016-06-23 12:26:53 -0700 Created attachment 281928 Patch 1204909 3 281928 thorton 2016-06-23 12:52:51 -0700 Comment on attachment 281928 Patch It doesn't make sense for Safari to keep the view alive if it has been closed; you can't come back from being closed, as far as I remember. Are you sure that is intentional? 1204910 4 cdumez 2016-06-23 12:56:16 -0700 (In reply to comment #3) > Comment on attachment 281928 [details] > Patch > > It doesn't make sense for Safari to keep the view alive if it has been > closed; you can't come back from being closed, as far as I remember. Are you > sure that is intentional? It may not be intentional, I'll investigate separately. I definitely see close() getting called but not the destructor. Do you mind if we still land as is though? It cannot hurt to release the assertion as soon as close() is called I believe. 1204911 5 281928 cdumez 2016-06-23 12:59:09 -0700 Comment on attachment 281928 Patch Clearing flags on attachment: 281928 Committed r202393: <http://trac.webkit.org/changeset/202393> 1204912 6 cdumez 2016-06-23 12:59:14 -0700 All reviewed patches have been landed. Closing bug. 281928 2016-06-23 12:26:53 -0700 2016-06-23 12:59:09 -0700 Patch bug-159068-20160623122643.patch text/plain 1972 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjNiYTIwNzQyOWMxMjgw NzJjZGZkZjI5ZWUxYjg3ODBmNjlmNTAzMS4uNzQyMWJjMjRhNjcyMzUzOWRhN2VkMzA0YTg5MDc4 ZGFjZjE0YTViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA2LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQSBXZWJQYWdlUHJv eHkgaW4gY2xvc2VkIHN0YXRlIHNob3VsZCBub3QgYmUgYWxsb3dlZCB0byBob2xkIGEgcHJvY2Vz cyBhc3NlcnRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1OTA2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc2NjU0NzM+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBXZWJQYWdlUHJveHkgaW4g Y2xvc2VkIHN0YXRlIHNob3VsZCBub3QgYmUgYWxsb3dlZCB0byBob2xkIGEgcHJvY2VzcyBhc3Nl cnRpb24uIEl0CisgICAgICAgIGN1cnJlbnRseSBoYXBwZW5zIHRoYXQgV2ViUGFnZVByb3h5Ojpj bG9zZSgpIGdldHMgY2FsbGVkIGJ1dCB0aGF0IHRoZSBXZWJQYWdlUHJveHkgaXMKKyAgICAgICAg a2VwdCBhbGl2ZSBieSBTYWZhcmkgKGUuZy4gSW4gY2FzZSBvZiB0b3AtaGl0IHByZWxvYWRpbmcp LiBJbiBzdWNoIGNhc2VzLCB3ZSBmYWlsIHRvCisgICAgICAgIHJlbGVhc2UgdGhlIGZvcmVncm91 bmQgcHJvY2VzcyBhc3NlcnRpb24gdGhhdCB0aGUgV2ViUGFnZVByb3h5IGhvbGRzLgorCisgICAg ICAgIFdlIHNob3VsZCBjbGVhciB0aGUgZm9yZWdyb3VuZCBwcm9jZXNzIGFzc2VydGlvbiB0aGF0 IHRoZSBXZWJQYWdlUHJveHkgaG9sZHMgYXMgc29vbgorICAgICAgICBhcyBXZWJQYWdlUHJveHk6 OmNsb3NlKCkgaXMgY2FsbGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2xvc2UpOgorCiAyMDE2LTA2LTIz ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjAxMTk0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAppbmRleCAxN2RjOTFlZjg2MTY3ZTc0YThjNzBmMzg2NGFjMzE4OTFkYzc3 MWRkLi5iN2VlMmZhNzNkNmI5YmU2N2RhNGZiYjI1NGMxNTQxZDY2NmU0ODIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtODY4LDYgKzg2OCwxMSBAQCB2 b2lkIFdlYlBhZ2VQcm94eTo6Y2xvc2UoKQogICAgIG1fcHJvY2Vzcy0+cmVtb3ZlV2ViUGFnZSht X3BhZ2VJRCk7CiAgICAgbV9wcm9jZXNzLT5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6 OldlYlBhZ2VQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJRCk7CiAgICAgbV9w cm9jZXNzLT5wcm9jZXNzUG9vbCgpLnN1cHBsZW1lbnQ8V2ViTm90aWZpY2F0aW9uTWFuYWdlclBy b3h5PigpLT5jbGVhck5vdGlmaWNhdGlvbnModGhpcyk7CisKKyNpZiBQTEFURk9STShJT1MpCisg ICAgLy8gTWFrZSBzdXJlIHdlIGRvbid0IGhvbGQgYSBwcm9jZXNzIGFzc2VydGlvbiBhZnRlciBn ZXR0aW5nIGNsb3NlZC4KKyAgICBtX2FjdGl2aXR5VG9rZW4gPSBudWxscHRyOworI2VuZGlmCiB9 CiAKIGJvb2wgV2ViUGFnZVByb3h5Ojp0cnlDbG9zZSgpCg==