159062 2016-06-23 11:01:47 -0700 Handle (0, 0) ranges from Lookup 2016-06-23 12:18:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159063 InRadar P2 Normal --- 1 ap ap thorton oldest_to_newest 1204859 0 ap 2016-06-23 11:01:47 -0700 When Lookup can't provide a range, it sometimes returns (NSNotFound, 0), and other times, (0, 0). In the latter case, we somehow build a single character string. rdar://problem/26960385 1204862 1 281916 ap 2016-06-23 11:08:28 -0700 Created attachment 281916 proposed patch 1204864 2 281917 ap 2016-06-23 11:09:28 -0700 Created attachment 281917 proposed patch Forgot to update a FIXME. 1204865 3 281917 thorton 2016-06-23 11:11:06 -0700 Comment on attachment 281917 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281917&action=review > Source/WebCore/editing/mac/DictionaryLookup.mm:144 > + // FIXME (159063): We shouldn't need to check for zero lenght here. lenght! 1204902 4 ap 2016-06-23 12:18:15 -0700 Committed http://trac.webkit.org/r202390 281916 2016-06-23 11:08:28 -0700 2016-06-23 11:09:28 -0700 proposed patch LookupZero.txt text/plain 2884 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjM4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTIzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEhhbmRsZSAoMCwgMCkgcmFu Z2VzIGZyb20gTG9va3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTkwNjIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjY5NjAzODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvbWFjL0Rp Y3Rpb25hcnlMb29rdXAubW06IChXZWJDb3JlOjpEaWN0aW9uYXJ5TG9va3VwOjpyYW5nZUF0SGl0 VGVzdFJlc3VsdCk6CisgICAgICAgIFBhcGVyIG92ZXIgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTkwNjM+LCB3aGljaCBzZWVtcyB0b28gaW52b2x2ZWQKKyAgICAg ICAgdG8gZml4IG5vdy4KKwogMjAxNi0wNi0yMyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFw cGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgd2luZG93Lm9wZW4oKSBmb3IgZXhpc3RpbmcgdmVy c2lvbnMgb2YgU2VjcmV0IFNvY2lldHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFj L0RpY3Rpb25hcnlMb29rdXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYWMvRGljdGlvbmFyeUxvb2t1cC5tbQkocmV2aXNpb24gMjAyMjg0KQorKysgU291cmNlL1dl YkNvcmUvZWRpdGluZy9tYWMvRGljdGlvbmFyeUxvb2t1cC5tbQkod29ya2luZyBjb3B5KQpAQCAt MTQxLDcgKzE0MSw4IEBAIFJlZlB0cjxSYW5nZT4gRGljdGlvbmFyeUxvb2t1cDo6cmFuZ2VBdEgK ICAgICAgICAgZXh0cmFjdGVkUmFuZ2UgPSBbbHVMb29rdXBEZWZpbml0aW9uTW9kdWxlIHRva2Vu UmFuZ2VGb3JTdHJpbmc6ZnVsbFBsYWluVGV4dFN0cmluZyByYW5nZTpyYW5nZVRvUGFzcyBvcHRp b25zOm9wdGlvbnNdOwogCiAgICAgLy8gVGhpcyBmdW5jdGlvbiBzb21ldGltZXMgcmV0dXJucyB7 TlNOb3RGb3VuZCwgMH0gaWYgaXQgd2FzIHVuYWJsZSB0byBkZXRlcm1pbmUgYSBnb29kIHN0cmlu Zy4KLSAgICBpZiAoZXh0cmFjdGVkUmFuZ2UubG9jYXRpb24gPT0gTlNOb3RGb3VuZCkKKyAgICAv LyBJdCBjYW4gYWxzbyByZXR1cm4gezAsIDB9LCBpbiB3aGljaCBjYXNlIFRleHRJdGVyYXRvcjo6 c3VicmFuZ2Ugd291bGQgcmV0dXJuIGEgc2luZ2xlIGNoYXJhY3RlciBzdHJpbmcgKHNlZSA8cmRh cjovL3Byb2JsZW0vMjY5NjAzODU+KS4KKyAgICBpZiAoZXh0cmFjdGVkUmFuZ2UubG9jYXRpb24g PT0gTlNOb3RGb3VuZCB8fCBleHRyYWN0ZWRSYW5nZS5sZW5ndGggPT0gMCkKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAKICAgICByZXR1cm4gVGV4dEl0ZXJhdG9yOjpzdWJyYW5nZShmdWxsQ2hh cmFjdGVyUmFuZ2UuZ2V0KCksIGV4dHJhY3RlZFJhbmdlLmxvY2F0aW9uLCBleHRyYWN0ZWRSYW5n ZS5sZW5ndGgpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyMzYwKQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDYtMjMgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgSGFuZGxlICgwLCAwKSBy YW5nZXMgZnJvbSBMb29rdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1OTA2MgorICAgICAgICByZGFyOi8vcHJvYmxlbS8yNjk2MDM4NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFj L1Rlc3RFeHBlY3RhdGlvbnM6IFVubWFyayB0aGUgdGVzdCB0aGF0IHdhcyBicm9rZW4gZHVlIHRv IHRoaXMuCisKIDIwMTYtMDYtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgVGVzdCBleHBlY3RhdGlvbnMgZ2FyZGVuaW5nIGZvciByZGFyOi8vcHJvYmxl bS8yNjk2MDM4NQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMJKHJldmlzaW9uIDIwMjM2MCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhw ZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xNDM5LDYgKzE0MzksMyBAQCB3ZWJraXQub3Jn L2IvMTU4ODg5IG1lZGlhL3ZpZGVvLWNvbnRyb2xzCiAKICMgcmRhcjovL3Byb2JsZW0vMjY5NTAw NjUKIFsgU2llcnJhKyBdIGVkaXRpbmcvbWFjL2lucHV0L3VuY29uZmlybWVkLXRleHQtbmF2aWdh dGlvbi13aXRoLXBhZ2UtY2FjaGUuaHRtbCBbIFNraXAgXQotCi0jIHJkYXI6Ly9wcm9ibGVtLzI2 OTYwMzg1Ci1bIFNpZXJyYSsgXSBlZGl0aW5nL21hYy9kaWN0aW9uYXJ5LWxvb2t1cC9kaWN0aW9u YXJ5LWxvb2t1cC1pbnB1dC5odG1sIFsgRmFpbHVyZSBdCg== 281917 2016-06-23 11:09:28 -0700 2016-06-23 11:11:06 -0700 proposed patch LookupZero.txt text/plain 2813 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjM4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTIzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEhhbmRsZSAoMCwgMCkgcmFu Z2VzIGZyb20gTG9va3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTkwNjIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjY5NjAzODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvbWFjL0Rp Y3Rpb25hcnlMb29rdXAubW06IChXZWJDb3JlOjpEaWN0aW9uYXJ5TG9va3VwOjpyYW5nZUF0SGl0 VGVzdFJlc3VsdCk6CisgICAgICAgIFBhcGVyIG92ZXIgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTkwNjM+LCB3aGljaCBzZWVtcyB0b28gaW52b2x2ZWQKKyAgICAg ICAgdG8gZml4IG5vdy4KKwogMjAxNi0wNi0yMyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFw cGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgd2luZG93Lm9wZW4oKSBmb3IgZXhpc3RpbmcgdmVy c2lvbnMgb2YgU2VjcmV0IFNvY2lldHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFj L0RpY3Rpb25hcnlMb29rdXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9tYWMvRGljdGlvbmFyeUxvb2t1cC5tbQkocmV2aXNpb24gMjAyMjg0KQorKysgU291cmNlL1dl YkNvcmUvZWRpdGluZy9tYWMvRGljdGlvbmFyeUxvb2t1cC5tbQkod29ya2luZyBjb3B5KQpAQCAt MTQxLDcgKzE0MSw4IEBAIFJlZlB0cjxSYW5nZT4gRGljdGlvbmFyeUxvb2t1cDo6cmFuZ2VBdEgK ICAgICAgICAgZXh0cmFjdGVkUmFuZ2UgPSBbbHVMb29rdXBEZWZpbml0aW9uTW9kdWxlIHRva2Vu UmFuZ2VGb3JTdHJpbmc6ZnVsbFBsYWluVGV4dFN0cmluZyByYW5nZTpyYW5nZVRvUGFzcyBvcHRp b25zOm9wdGlvbnNdOwogCiAgICAgLy8gVGhpcyBmdW5jdGlvbiBzb21ldGltZXMgcmV0dXJucyB7 TlNOb3RGb3VuZCwgMH0gaWYgaXQgd2FzIHVuYWJsZSB0byBkZXRlcm1pbmUgYSBnb29kIHN0cmlu Zy4KLSAgICBpZiAoZXh0cmFjdGVkUmFuZ2UubG9jYXRpb24gPT0gTlNOb3RGb3VuZCkKKyAgICAv LyBGSVhNRSAoMTU5MDYzKTogV2Ugc2hvdWxkbid0IG5lZWQgdG8gY2hlY2sgZm9yIHplcm8gbGVu Z2h0IGhlcmUuCisgICAgaWYgKGV4dHJhY3RlZFJhbmdlLmxvY2F0aW9uID09IE5TTm90Rm91bmQg fHwgZXh0cmFjdGVkUmFuZ2UubGVuZ3RoID09IDApCiAgICAgICAgIHJldHVybiBudWxscHRyOwog CiAgICAgcmV0dXJuIFRleHRJdGVyYXRvcjo6c3VicmFuZ2UoZnVsbENoYXJhY3RlclJhbmdlLmdl dCgpLCBleHRyYWN0ZWRSYW5nZS5sb2NhdGlvbiwgZXh0cmFjdGVkUmFuZ2UubGVuZ3RoKTsKSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDIwMjM2MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA2LTIzICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEhhbmRsZSAoMCwgMCkgcmFuZ2VzIGZyb20gTG9v a3VwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkw NjIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjY5NjAzODUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRp b25zOiBVbm1hcmsgdGhlIHRlc3QgdGhhdCB3YXMgYnJva2VuIGR1ZSB0byB0aGlzLgorCiAyMDE2 LTA2LTIyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFRl c3QgZXhwZWN0YXRpb25zIGdhcmRlbmluZyBmb3IgcmRhcjovL3Byb2JsZW0vMjY5NjAzODUKSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAy MDIzNjApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkod29y a2luZyBjb3B5KQpAQCAtMTQzOSw2ICsxNDM5LDMgQEAgd2Via2l0Lm9yZy9iLzE1ODg4OSBtZWRp YS92aWRlby1jb250cm9scwogCiAjIHJkYXI6Ly9wcm9ibGVtLzI2OTUwMDY1CiBbIFNpZXJyYSsg XSBlZGl0aW5nL21hYy9pbnB1dC91bmNvbmZpcm1lZC10ZXh0LW5hdmlnYXRpb24td2l0aC1wYWdl LWNhY2hlLmh0bWwgWyBTa2lwIF0KLQotIyByZGFyOi8vcHJvYmxlbS8yNjk2MDM4NQotWyBTaWVy cmErIF0gZWRpdGluZy9tYWMvZGljdGlvbmFyeS1sb29rdXAvZGljdGlvbmFyeS1sb29rdXAtaW5w dXQuaHRtbCBbIEZhaWx1cmUgXQo=