159054 2016-06-23 00:34:04 -0700 WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification 2016-06-23 08:11:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned commit-queue eric.carlson oldest_to_newest 1204787 0 adam.bergkvist 2016-06-23 00:34:04 -0700 The 'update ICE connection/gathering state' steps should abort if the RTCPeerConnection is closed or if the new state is the same as the current state as specified in [1]. [1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state 1204789 1 281901 adam.bergkvist 2016-06-23 00:49:10 -0700 Created attachment 281901 Proposed patch 1204807 2 281901 eric.carlson 2016-06-23 06:17:31 -0700 Comment on attachment 281901 Proposed patch Is it possible to test this? 1204811 3 adam.bergkvist 2016-06-23 06:40:37 -0700 (In reply to comment #2) > Comment on attachment 281901 [details] > Proposed patch > > Is it possible to test this? Not currently. I thought I could produce double icegatheringstatechange events by setting the same offer twice with setLocalDescription(), but the state is only updated if the current state is 'new' (in accordance with the spec). We can probably hit one of the checks added by this change when we have the ICE-related callbacks from the WebRTC backend implemented. 1204818 4 281901 adam.bergkvist 2016-06-23 07:50:36 -0700 Comment on attachment 281901 Proposed patch Thanks Eric 1204822 5 281901 commit-queue 2016-06-23 08:10:59 -0700 Comment on attachment 281901 Proposed patch Clearing flags on attachment: 281901 Committed r202378: <http://trac.webkit.org/changeset/202378> 1204823 6 commit-queue 2016-06-23 08:11:03 -0700 All reviewed patches have been landed. Closing bug. 281901 2016-06-23 00:49:10 -0700 2016-06-23 08:10:59 -0700 Proposed patch align-update-ice-states_0.patch text/plain 2451 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYjg5MGRlLi4yZjg3NWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTYtMDYtMjMgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFdlYlJUQzogQWxpZ24gJ3VwZGF0ZSBJQ0UgY29ubmVjdGlvbi9nYXRo ZXJpbmcgc3RhdGUnIHN0ZXBzIHdpdGggdGhlIFdlYlJUQyAxLjAgc3BlY2lmaWNhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDU0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNoZWNrcyBm b3Igc2FtZSBzdGF0ZSBhbmQgY2xvc2VkIFJUQ1BlZXJDb25uZWN0aW9uIGluIHRoZSAndXBkYXRl IElDRSBjb25uZWN0aW9uIHN0YXRlJworICAgICAgICBhbmQgJ3VwZGF0ZSBJQ0UgZ2F0aGVyaW5n IHN0YXRlJyByb3V0aW5lcyBhcyBkZXNjcmliZWQgaW4gWzFdLgorCisgICAgICAgIFsxXSBodHRw czovL3czYy5naXRodWIuaW8vd2VicnRjLXBjL2FyY2hpdmVzLzIwMTYwNTEzL3dlYnJ0Yy5odG1s I3VwZGF0ZS1pY2UtZ2F0aGVyaW5nLXN0YXRlCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGN1cnJl bnQgYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25u ZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9uOjp1cGRhdGVJ Y2VHYXRoZXJpbmdTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6 dXBkYXRlSWNlQ29ubmVjdGlvblN0YXRlKToKKwogMjAxNi0wNi0yMiAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjAxNjI5KTog V2VpcmQgYnV0dG9uIGdsaXRjaGluZyBvbiBnaXRodWIuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCmluZGV4 IDcyNGI5YzIuLmRiMWFhMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCkBAIC00NTcsOCArNDU3LDEwIEBA IHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OnNldFNpZ25hbGluZ1N0YXRlKFNpZ25hbGluZ1N0YXRl IG5ld1N0YXRlKQogdm9pZCBSVENQZWVyQ29ubmVjdGlvbjo6dXBkYXRlSWNlR2F0aGVyaW5nU3Rh dGUoSWNlR2F0aGVyaW5nU3RhdGUgbmV3U3RhdGUpCiB7CiAgICAgc2NyaXB0RXhlY3V0aW9uQ29u dGV4dCgpLT5wb3N0VGFzayhbPV0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYpIHsKLSAgICAgICAg bV9pY2VHYXRoZXJpbmdTdGF0ZSA9IG5ld1N0YXRlOworICAgICAgICBpZiAobV9zaWduYWxpbmdT dGF0ZSA9PSBTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkIHx8IG1faWNlR2F0aGVyaW5nU3RhdGUgPT0g bmV3U3RhdGUpCisgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgbV9pY2VHYXRoZXJpbmdT dGF0ZSA9IG5ld1N0YXRlOwogICAgICAgICBkaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZl bnROYW1lcygpLmljZWdhdGhlcmluZ3N0YXRlY2hhbmdlRXZlbnQsIGZhbHNlLCBmYWxzZSkpOwog ICAgIH0pOwogfQpAQCAtNDY2LDggKzQ2OCwxMCBAQCB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjp1 cGRhdGVJY2VHYXRoZXJpbmdTdGF0ZShJY2VHYXRoZXJpbmdTdGF0ZSBuZXdTdGF0ZSkKIHZvaWQg UlRDUGVlckNvbm5lY3Rpb246OnVwZGF0ZUljZUNvbm5lY3Rpb25TdGF0ZShJY2VDb25uZWN0aW9u U3RhdGUgbmV3U3RhdGUpCiB7CiAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFz ayhbPV0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYpIHsKLSAgICAgICAgbV9pY2VDb25uZWN0aW9u U3RhdGUgPSBuZXdTdGF0ZTsKKyAgICAgICAgaWYgKG1fc2lnbmFsaW5nU3RhdGUgPT0gU2lnbmFs aW5nU3RhdGU6OkNsb3NlZCB8fCBtX2ljZUNvbm5lY3Rpb25TdGF0ZSA9PSBuZXdTdGF0ZSkKKyAg ICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBtX2ljZUNvbm5lY3Rpb25TdGF0ZSA9IG5ld1N0 YXRlOwogICAgICAgICBkaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmlj ZWNvbm5lY3Rpb25zdGF0ZWNoYW5nZUV2ZW50LCBmYWxzZSwgZmFsc2UpKTsKICAgICB9KTsKIH0K