159053 2016-06-22 21:46:44 -0700 CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value 2016-06-23 11:50:53 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck benjamin commit-queue hyatt joepeck koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1204766 0 281896 joepeck 2016-06-22 21:46:44 -0700 Created attachment 281896 [TEST] Reduction Test Page Summary: CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value. JavaScript access to the ComputedStyleDeclaration should always have the most accurate data. That should include accessing the length. Right now the length is out of date until a style recalculation or forced layout (such as accessing an item / propertyValue in the computed style). Test: <body> <script> var computedStyle = window.getComputedStyle(document.body); var defaultLength = computedStyle.length; document.documentElement.style.setProperty('--default-color', '#c80'); var newLength = computedStyle.length; document.body.offsetTop; var finalLength = computedStyle.length; console.log("default", defaultLength); console.log("new - with computed property", newLength); console.log("final - after forced layout", finalLength); </script> Results: Expect "new" and "final" to be equal, and both be 1 greater than "default". Safari: (bad) default – 331 new - with computed property – 331 final - after forced layout – 332 Firefox: (expected) default 263 new - with computed property 264 final - after forced layout 264 Chrome: Doesn't appear to include computed properties in Computed Style at all. 1204767 1 joepeck 2016-06-22 21:47:03 -0700 <rdar://problem/26638119> 1204769 2 281897 joepeck 2016-06-22 22:03:45 -0700 Created attachment 281897 [PATCH] Proposed Fix 1204770 3 281897 joepeck 2016-06-22 22:04:44 -0700 Comment on attachment 281897 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281897&action=review > LayoutTests/fast/css/variables/custom-property-computed-style-length-update-expected.html:2 > +<head> Err, I should clean up the test... 1204771 4 281898 joepeck 2016-06-22 22:05:28 -0700 Created attachment 281898 [PATCH] Proposed Fix 1204774 5 281898 simon.fraser 2016-06-22 22:53:12 -0700 Comment on attachment 281898 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281898&action=review > LayoutTests/fast/css/variables/custom-property-computed-style-length-update.html:12 > +document.write(success ? "PASS" : "FAIL"); This should be a dumpAsText(). There's no point using a ref test (two snapshots and hashing) for this. 1204867 6 281918 joepeck 2016-06-23 11:14:57 -0700 Created attachment 281918 [PATCH] For Landing 1204884 7 281918 commit-queue 2016-06-23 11:43:56 -0700 Comment on attachment 281918 [PATCH] For Landing Clearing flags on attachment: 281918 Committed r202382: <http://trac.webkit.org/changeset/202382> 281896 2016-06-22 21:46:44 -0700 2016-06-22 21:46:44 -0700 [TEST] Reduction Test Page computed-style-reduction.html text/html 455 joepeck PGJvZHk+CjxzY3JpcHQ+CnZhciBjb21wdXRlZFN0eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5 bGUoZG9jdW1lbnQuYm9keSk7CnZhciBkZWZhdWx0TGVuZ3RoID0gY29tcHV0ZWRTdHlsZS5sZW5n dGg7CmRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5zdHlsZS5zZXRQcm9wZXJ0eSgnLS1kZWZhdWx0 LWNvbG9yJywgJyNjODAnKTsKdmFyIG5ld0xlbmd0aCA9IGNvbXB1dGVkU3R5bGUubGVuZ3RoOwpk b2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKdmFyIGZpbmFsTGVuZ3RoID0gY29tcHV0ZWRTdHlsZS5s ZW5ndGg7Cgpjb25zb2xlLmxvZygiZGVmYXVsdCIsIGRlZmF1bHRMZW5ndGgpOwpjb25zb2xlLmxv ZygibmV3IC0gd2l0aCBjb21wdXRlZCBwcm9wZXJ0eSIsIG5ld0xlbmd0aCk7CmNvbnNvbGUubG9n KCJmaW5hbCAtIGFmdGVyIGZvcmNlZCBsYXlvdXQiLCBmaW5hbExlbmd0aCk7Cjwvc2NyaXB0Pgo= 281897 2016-06-22 22:03:45 -0700 2016-06-22 22:05:28 -0700 [PATCH] Proposed Fix recalculate-style-length.patch text/plain 3503 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNjY0OTFhLi4wNTRkM2RmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDYt MjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBDU1ND b21wdXRlZFN0eWxlRGVjbGFyYXRpb246Omxlbmd0aCBzaG91bGQgcmVjYWxjdWxhdGUgc3R5bGVz IGlmIG5lZWRlZCB0byBwcm92aWRlIHRoZSBjb3JyZWN0IHZhbHVlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNTMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI2NjM4MTE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1z dHlsZS1sZW5ndGgtdXBkYXRlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Y3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0 ZS5odG1sOiBBZGRlZC4KKwogMjAxNi0wNi0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIwMjI1Myk6IEJyb2tlIGluc3BlY3Rv ci91bml0LXRlc3RzL2hlYXAtc25hcHNob3QtY29sbGVjdGlvbi1ldmVudC5odG1sCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5LWNvbXB1 dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0 ZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjFlYjg4 YzgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3Vz dG9tLXByb3BlcnR5LWNvbXB1dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUtZXhwZWN0ZWQuaHRtbApA QCAtMCwwICsxLDYgQEAKKzxodG1sPgorPGhlYWQ+Cis8Ym9keT4KK1BBU1MKKzwvYm9keT4KKzwv aHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3ZhcmlhYmxlcy9jdXN0b20t cHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0ZS5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1zdHlsZS1sZW5ndGgt dXBkYXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTM4OGExMwot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3ZhcmlhYmxlcy9jdXN0b20t cHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0ZS5odG1sCkBAIC0wLDAgKzEsMTYg QEAKKzxodG1sPgorPGhlYWQ+Cis8Ym9keT4KKzxzY3JpcHQ+Cit2YXIgY29tcHV0ZWRTdHlsZSA9 IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpOwordmFyIGluaXRpYWxMZW5n dGggPSBjb21wdXRlZFN0eWxlLmxlbmd0aDsKK2RvY3VtZW50LmRvY3VtZW50RWxlbWVudC5zdHls ZS5zZXRQcm9wZXJ0eSgnLS1jb21wdXRlZCcsICcjYWJjJyk7Cit2YXIgYWZ0ZXJBZGRpbmdDb21w dXRlZFByb3BlcnR5TGVuZ3RoID0gY29tcHV0ZWRTdHlsZS5sZW5ndGg7Citkb2N1bWVudC5ib2R5 Lm9mZnNldFRvcDsKK3ZhciBhZnRlckZvcmNlZExheW91dExlbmd0aCA9IGNvbXB1dGVkU3R5bGUu bGVuZ3RoOworCit2YXIgc3VjY2VzcyA9IGFmdGVyQWRkaW5nQ29tcHV0ZWRQcm9wZXJ0eUxlbmd0 aCA+IGluaXRpYWxMZW5ndGggJiYgYWZ0ZXJBZGRpbmdDb21wdXRlZFByb3BlcnR5TGVuZ3RoID09 PSBhZnRlckZvcmNlZExheW91dExlbmd0aDsKK2RvY3VtZW50LndyaXRlKHN1Y2Nlc3MgPyAiUEFT UyIgOiAiRkFJTCIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2Q0NTViZC4uNTJmYjA2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA2LTIy ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgQ1NTQ29t cHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpsZW5ndGggc2hvdWxkIHJlY2FsY3VsYXRlIHN0eWxlcyBp ZiBuZWVkZWQgdG8gcHJvdmlkZSB0aGUgY29ycmVjdCB2YWx1ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDUzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yNjYzODExOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUZXN0OiBmYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5LWNvbXB1dGVk LXN0eWxlLWxlbmd0aC11cGRhdGUuaHRtbAorCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVj bGFyYXRpb246Omxlbmd0aCk6CisgICAgICAgIFJlY2FsY3VsYXRlIHN0eWxlIGlmIG5lZWRlZCBz byB0aGF0IGxlbmd0aCBpcyBhY2N1cmF0ZS4KKwogMjAxNi0wNi0yMSAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGZpcnN0IGhl YXAgc25hcHNob3QgdGFrZW4gd2hlbiBhIHBhZ2UgaXMgcmVsb2FkZWQgaGFwcGVucyBiZWZvcmUg dGhlIHJlbG9hZCBuYXZpZ2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT Q29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21w dXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4IDg4NzUwZGUuLjAzNmNiNDYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCkBA IC0zOTQ4LDYgKzM5NDgsOCBAQCB1bnNpZ25lZCBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246 Omxlbmd0aCgpIGNvbnN0CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm4gMDsKIAorICAg IHVwZGF0ZVN0eWxlSWZOZWVkZWRGb3JOb2RlKCpub2RlKTsKKwogICAgIGF1dG8qIHN0eWxlID0g bm9kZS0+Y29tcHV0ZWRTdHlsZShtX3BzZXVkb0VsZW1lbnRTcGVjaWZpZXIpOwogICAgIGlmICgh c3R5bGUpCiAgICAgICAgIHJldHVybiAwOwo= 281898 2016-06-22 22:05:28 -0700 2016-06-22 22:53:12 -0700 [PATCH] Proposed Fix cleaner-1.patch text/plain 3487 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNjY0OTFhLi4wNTRkM2RmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDYt MjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBDU1ND b21wdXRlZFN0eWxlRGVjbGFyYXRpb246Omxlbmd0aCBzaG91bGQgcmVjYWxjdWxhdGUgc3R5bGVz IGlmIG5lZWRlZCB0byBwcm92aWRlIHRoZSBjb3JyZWN0IHZhbHVlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNTMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI2NjM4MTE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1z dHlsZS1sZW5ndGgtdXBkYXRlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Y3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0 ZS5odG1sOiBBZGRlZC4KKwogMjAxNi0wNi0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIwMjI1Myk6IEJyb2tlIGluc3BlY3Rv ci91bml0LXRlc3RzL2hlYXAtc25hcHNob3QtY29sbGVjdGlvbi1ldmVudC5odG1sCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5LWNvbXB1 dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0 ZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmZkMGI5 N2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3Vz dG9tLXByb3BlcnR5LWNvbXB1dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUtZXhwZWN0ZWQuaHRtbApA QCAtMCwwICsxLDUgQEAKKzxodG1sPgorPGJvZHk+CitQQVNTCis8L2JvZHk+Cis8L2h0bWw+CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5 LWNvbXB1dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz L3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0ZS5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQ3MzI2YjcKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5 LWNvbXB1dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUuaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRt bD4KKzxib2R5PgorPHNjcmlwdD4KK3ZhciBjb21wdXRlZFN0eWxlID0gd2luZG93LmdldENvbXB1 dGVkU3R5bGUoZG9jdW1lbnQuYm9keSk7Cit2YXIgaW5pdGlhbExlbmd0aCA9IGNvbXB1dGVkU3R5 bGUubGVuZ3RoOworZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCct LWNvbXB1dGVkJywgJyNhYmMnKTsKK3ZhciBhZnRlckFkZGluZ0NvbXB1dGVkUHJvcGVydHlMZW5n dGggPSBjb21wdXRlZFN0eWxlLmxlbmd0aDsKK2RvY3VtZW50LmJvZHkub2Zmc2V0VG9wOwordmFy IGFmdGVyRm9yY2VkTGF5b3V0TGVuZ3RoID0gY29tcHV0ZWRTdHlsZS5sZW5ndGg7CisKK3ZhciBz dWNjZXNzID0gYWZ0ZXJBZGRpbmdDb21wdXRlZFByb3BlcnR5TGVuZ3RoID4gaW5pdGlhbExlbmd0 aCAmJiBhZnRlckFkZGluZ0NvbXB1dGVkUHJvcGVydHlMZW5ndGggPT09IGFmdGVyRm9yY2VkTGF5 b3V0TGVuZ3RoOworZG9jdW1lbnQud3JpdGUoc3VjY2VzcyA/ICJQQVNTIiA6ICJGQUlMIik7Cis8 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZDQ1NWJkLi41MmZiMDZj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMDYtMjIgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBDU1NDb21wdXRlZFN0eWxlRGVjbGFy YXRpb246Omxlbmd0aCBzaG91bGQgcmVjYWxjdWxhdGUgc3R5bGVzIGlmIG5lZWRlZCB0byBwcm92 aWRlIHRoZSBjb3JyZWN0IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTkwNTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NjM4MTE5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZh c3QvY3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVw ZGF0ZS5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6bGVuZ3Ro KToKKyAgICAgICAgUmVjYWxjdWxhdGUgc3R5bGUgaWYgbmVlZGVkIHNvIHRoYXQgbGVuZ3RoIGlz IGFjY3VyYXRlLgorCiAyMDE2LTA2LTIxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZmlyc3QgaGVhcCBzbmFwc2hvdCB0YWtl biB3aGVuIGEgcGFnZSBpcyByZWxvYWRlZCBoYXBwZW5zIGJlZm9yZSB0aGUgcmVsb2FkIG5hdmln YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVj bGFyYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJh dGlvbi5jcHAKaW5kZXggODg3NTBkZS4uMDM2Y2I0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTM5NDgsNiArMzk0OCw4 IEBAIHVuc2lnbmVkIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6bGVuZ3RoKCkgY29uc3QK ICAgICBpZiAoIW5vZGUpCiAgICAgICAgIHJldHVybiAwOwogCisgICAgdXBkYXRlU3R5bGVJZk5l ZWRlZEZvck5vZGUoKm5vZGUpOworCiAgICAgYXV0byogc3R5bGUgPSBub2RlLT5jb21wdXRlZFN0 eWxlKG1fcHNldWRvRWxlbWVudFNwZWNpZmllcik7CiAgICAgaWYgKCFzdHlsZSkKICAgICAgICAg cmV0dXJuIDA7Cg== 281918 2016-06-23 11:14:57 -0700 2016-06-23 11:43:56 -0700 [PATCH] For Landing for-landing-1.patch text/plain 3891 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNjY0OTFhLi5iZjMwMGZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDYt MjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBDU1ND b21wdXRlZFN0eWxlRGVjbGFyYXRpb246Omxlbmd0aCBzaG91bGQgcmVjYWxjdWxhdGUgc3R5bGVz IGlmIG5lZWRlZCB0byBwcm92aWRlIHRoZSBjb3JyZWN0IHZhbHVlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNTMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI2NjM4MTE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKwor ICAgICAgICAqIGZhc3QvY3NzL3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5 bGUtbGVuZ3RoLXVwZGF0ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3Nz L3ZhcmlhYmxlcy9jdXN0b20tcHJvcGVydHktY29tcHV0ZWQtc3R5bGUtbGVuZ3RoLXVwZGF0ZS5o dG1sOiBBZGRlZC4KKwogMjAxNi0wNi0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIwMjI1Myk6IEJyb2tlIGluc3BlY3Rvci91 bml0LXRlc3RzL2hlYXAtc25hcHNob3QtY29sbGVjdGlvbi1ldmVudC5odG1sCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5LWNvbXB1dGVk LXN0eWxlLWxlbmd0aC11cGRhdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv dmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1zdHlsZS1sZW5ndGgtdXBkYXRlLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lZjkwZTFlCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1w cm9wZXJ0eS1jb21wdXRlZC1zdHlsZS1sZW5ndGgtdXBkYXRlLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDggQEAKK0NoZWNrIHRoYXQgQ1NTU3R5bGVEZWNsYXJhdGlvbi5sZW5ndGggaXMgYWNjdXJh dGUgYWZ0ZXIgY3VzdG9tIHByb3BlcnR5IG1vZGlmaWNhdGlvbnMuCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIGFmdGVyQWRkaW5nQ29tcHV0ZWRQcm9wZXJ0eUxlbmd0aCA+ IGluaXRpYWxMZW5ndGggaXMgdHJ1ZQorUEFTUyBhZnRlckFkZGluZ0NvbXB1dGVkUHJvcGVydHlM ZW5ndGggPT09IGFmdGVyRm9yY2VkTGF5b3V0TGVuZ3RoIGlzIHRydWUKKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1z dHlsZS1sZW5ndGgtdXBkYXRlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMv Y3VzdG9tLXByb3BlcnR5LWNvbXB1dGVkLXN0eWxlLWxlbmd0aC11cGRhdGUuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5mNzAwNzY5Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL2N1c3RvbS1wcm9wZXJ0eS1jb21wdXRlZC1z dHlsZS1sZW5ndGgtdXBkYXRlLmh0bWwKQEAgLTAsMCArMSwxOSBAQAorPGh0bWw+Cis8Ym9keT4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJDaGVjayB0aGF0IENTU1N0eWxlRGVjbGFyYXRpb24u bGVuZ3RoIGlzIGFjY3VyYXRlIGFmdGVyIGN1c3RvbSBwcm9wZXJ0eSBtb2RpZmljYXRpb25zLiIp OworCit2YXIgY29tcHV0ZWRTdHlsZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50 LmJvZHkpOwordmFyIGluaXRpYWxMZW5ndGggPSBjb21wdXRlZFN0eWxlLmxlbmd0aDsKK2RvY3Vt ZW50LmRvY3VtZW50RWxlbWVudC5zdHlsZS5zZXRQcm9wZXJ0eSgnLS1jb21wdXRlZCcsICcjYWJj Jyk7Cit2YXIgYWZ0ZXJBZGRpbmdDb21wdXRlZFByb3BlcnR5TGVuZ3RoID0gY29tcHV0ZWRTdHls ZS5sZW5ndGg7Citkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKK3ZhciBhZnRlckZvcmNlZExheW91 dExlbmd0aCA9IGNvbXB1dGVkU3R5bGUubGVuZ3RoOworCitzaG91bGRCZVRydWUoImFmdGVyQWRk aW5nQ29tcHV0ZWRQcm9wZXJ0eUxlbmd0aCA+IGluaXRpYWxMZW5ndGgiKTsKK3Nob3VsZEJlVHJ1 ZSgiYWZ0ZXJBZGRpbmdDb21wdXRlZFByb3BlcnR5TGVuZ3RoID09PSBhZnRlckZvcmNlZExheW91 dExlbmd0aCIpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZDQ1NWJkLi5hOGQ4OWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDYtMjMg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBDU1NDb21w dXRlZFN0eWxlRGVjbGFyYXRpb246Omxlbmd0aCBzaG91bGQgcmVjYWxjdWxhdGUgc3R5bGVzIGlm IG5lZWRlZCB0byBwcm92aWRlIHRoZSBjb3JyZWN0IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNTMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI2NjM4MTE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAg ICAgICBUZXN0OiBmYXN0L2Nzcy92YXJpYWJsZXMvY3VzdG9tLXByb3BlcnR5LWNvbXB1dGVkLXN0 eWxlLWxlbmd0aC11cGRhdGUuaHRtbAorCisgICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVE ZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFy YXRpb246Omxlbmd0aCk6CisKIDIwMTYtMDYtMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXJzdCBoZWFwIHNuYXBzaG90 IHRha2VuIHdoZW4gYSBwYWdlIGlzIHJlbG9hZGVkIGhhcHBlbnMgYmVmb3JlIHRoZSByZWxvYWQg bmF2aWdhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURl Y2xhcmF0aW9uLmNwcAppbmRleCA4ODc1MGRlLi4wMzZjYjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcApAQCAtMzk0OCw2ICsz OTQ4LDggQEAgdW5zaWduZWQgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpsZW5ndGgoKSBj b25zdAogICAgIGlmICghbm9kZSkKICAgICAgICAgcmV0dXJuIDA7CiAKKyAgICB1cGRhdGVTdHls ZUlmTmVlZGVkRm9yTm9kZSgqbm9kZSk7CisKICAgICBhdXRvKiBzdHlsZSA9IG5vZGUtPmNvbXB1 dGVkU3R5bGUobV9wc2V1ZG9FbGVtZW50U3BlY2lmaWVyKTsKICAgICBpZiAoIXN0eWxlKQogICAg ICAgICByZXR1cm4gMDsK