159042 2016-06-22 15:23:01 -0700 'webkit-patch land' puts an inferred Reviewed By line between the bugzilla and radar links 2016-06-23 11:38:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=159014 P2 Normal --- 1 bburg webkit-unassigned bburg ddkilzer joepeck lforschler oldest_to_newest 1204691 0 bburg 2016-06-22 15:23:01 -0700 See what happened here? https://trac.webkit.org/r202353 In my local changes, there was no Reviewed By line. Then, webkit-patch found Joe on the previously reviewed patch, and inserted the Reviewed By line between bugzilla and radar links. It should be after the radar link. 1204878 1 ddkilzer 2016-06-23 11:32:39 -0700 Note for future self: This may (or may not) be related to the fact that both patches had the same first 4 or 5 lines before landing: +2016-06-22 Brian Burg <bburg@apple.com> + + Web Inspector: don't start auto capturing if the Inspector window is not visible + https://bugs.webkit.org/show_bug.cgi?id=159014 + <rdar://problem/26931269> I know prepare-ChangeLog has issues "fixing up" patches where the added lines in ChangeLog files are offset from Line 1 because the title and bug are identical, so this may be a similar issue. This will also be fixed by switching to git, using commit-log-editor for commit messages, and then getting rid of ChangeLog files. :) Brian, what was the exact "webkit-patch land" command you used when committing, and what state was your local repository in? Had you just committed r202352? Did you svn-update/git-svn-rebase your repo between commits? The exact sequence of steps to land the two patches would be useful here to try to reproduce. 1204881 2 bburg 2016-06-23 11:38:44 -0700 (In reply to comment #1) > Note for future self: This may (or may not) be related to the fact that > both patches had the same first 4 or 5 lines before landing: > > +2016-06-22 Brian Burg <bburg@apple.com> > + > + Web Inspector: don't start auto capturing if the Inspector window > is not visible > + https://bugs.webkit.org/show_bug.cgi?id=159014 > + <rdar://problem/26931269> > > I know prepare-ChangeLog has issues "fixing up" patches where the added > lines in ChangeLog files are offset from Line 1 because the title and bug > are identical, so this may be a similar issue. > > This will also be fixed by switching to git, using commit-log-editor for > commit messages, and then getting rid of ChangeLog files. :) > > Brian, what was the exact "webkit-patch land" command you used when > committing, and what state was your local repository in? Had you just > committed r202352? Did you svn-update/git-svn-rebase your repo between > commits? I used `webkit-patch land` for the original patch. I don't remember if it was with -g head or no arguments, but I usually make a local commit and `git svn rebase` it myself. For the follow-up patch, I didn't make a local commit, nor did I update/rebase. > The exact sequence of steps to land the two patches would be useful here to > try to reproduce.