159033 2016-06-22 12:26:26 -0700 Only call sqlite3_initialize() when a SQLite database is actually being opened 2016-06-23 09:03:35 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue dbates kling koivisto oldest_to_newest 1204622 0 cdumez 2016-06-22 12:26:26 -0700 Only call sqlite3_initialize() when a SQLite database is actually being opened instead of doing it unconditionally. Sqlite3_initialize() is currently called in the SQLiteDatabase constructor which gets called on WebContent process initialization because a DatabaseTracker is constructed on initialization and DatabaseTracker has a SQLiteDatabase data member. 1204625 1 281860 cdumez 2016-06-22 12:35:21 -0700 Created attachment 281860 Patch 1204768 2 achristensen 2016-06-22 22:01:18 -0700 Brady will have to review this. I have two questions: Is it ok to assume that open is always going to be the first call on a SQLiteDatabase? I think the answer is yes. Should we even have databases in the WebProcess? 1204825 3 281860 commit-queue 2016-06-23 09:03:31 -0700 Comment on attachment 281860 Patch Clearing flags on attachment: 281860 Committed r202379: <http://trac.webkit.org/changeset/202379> 1204826 4 commit-queue 2016-06-23 09:03:35 -0700 All reviewed patches have been landed. Closing bug. 281860 2016-06-22 12:35:21 -0700 2016-06-23 09:03:31 -0700 Patch bug-159033-20160622123513.patch text/plain 3599 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA1YjhlNGMwNTlmZWE3 YTg1MGVmMmZiZTlmYzE3MzBlYThmMzZjYS4uZTEyZWYxMDQ1NTE0MDJjYzQ3MTA2M2Y3ZWE2ZTIw OTk3YmQ2ZTU2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA2LTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgT25seSBjYWxsIHNxbGl0ZTNf aW5pdGlhbGl6ZSgpIHdoZW4gYSBTUUxpdGUgZGF0YWJhc2UgaXMgYWN0dWFsbHkgYmVpbmcgb3Bl bmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkw MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5 IGNhbGwgc3FsaXRlM19pbml0aWFsaXplKCkgd2hlbiBhIFNRTGl0ZSBkYXRhYmFzZSBpcyBhY3R1 YWxseSBiZWluZyBvcGVuZWQKKyAgICAgICAgaW5zdGVhZCBvZiBkb2luZyBpdCB1bmNvbmRpdGlv bmFsbHkuIHNxbGl0ZTNfaW5pdGlhbGl6ZSgpIHdhcyBwcmV2aW91c2x5IGNhbGxlZAorICAgICAg ICBpbiB0aGUgU1FMaXRlRGF0YWJhc2UgY29uc3RydWN0b3Igd2hpY2ggZ2V0cyBjYWxsZWQgb24g V2ViQ29udGVudCBwcm9jZXNzCisgICAgICAgIGluaXRpYWxpemF0aW9uIGJlY2F1c2UgYSBEYXRh YmFzZVRyYWNrZXIgaXMgY29uc3RydWN0ZWQgb24gaW5pdGlhbGl6YXRpb24gYW5kCisgICAgICAg IERhdGFiYXNlVHJhY2tlciBoYXMgYSBTUUxpdGVEYXRhYmFzZSBkYXRhIG1lbWJlci4KKworICAg ICAgICAqIHBsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojppbml0aWFsaXplU1FMaXRlSWZOZWNlc3NhcnkpOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRl RGF0YWJhc2U6Om9wZW4pOgorICAgICAgICAoV2ViQ29yZTo6U1FMaXRlRGF0YWJhc2U6OlNRTGl0 ZURhdGFiYXNlKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJh c2UuaDoKKwogMjAxNi0wNi0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIEV4Y2VwdGlvbiBpcyBub3QgdGhyb3duIHdoZW4gc2hpcHBpbmcgbWV0aG9k IGlzIGFuIGludmFsaWQgYW1vdW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NR TGl0ZURhdGFiYXNlLmNwcAppbmRleCAxYWM0YTFjYjlmNWFlZTFmZGE4MmVjMTJmN2IwMmMzNjg2 YTA3NGEwLi4zNzk0M2UyNTI2MmI3NGNlY2E3YWMwNzQyOGE0ZjliZjBmNDJlZDQ0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAKQEAgLTQ5LDE1 ICs0OSw3IEBAIHN0YXRpYyB2b2lkIHVuYXV0aG9yaXplZFNRTEZ1bmN0aW9uKHNxbGl0ZTNfY29u dGV4dCAqY29udGV4dCwgaW50LCBzcWxpdGUzX3ZhbHVlCiAgICAgc3FsaXRlM19yZXN1bHRfZXJy b3IoY29udGV4dCwgZXJyb3JNZXNzYWdlLnV0ZjgoKS5kYXRhKCksIC0xKTsKIH0KIAotU1FMaXRl RGF0YWJhc2U6OlNRTGl0ZURhdGFiYXNlKCkKLSAgICA6IG1fZGIoMCkKLSAgICAsIG1fcGFnZVNp emUoLTEpCi0gICAgLCBtX3RyYW5zYWN0aW9uSW5Qcm9ncmVzcyhmYWxzZSkKLSAgICAsIG1fc2hh cmFibGUoZmFsc2UpCi0gICAgLCBtX29wZW5pbmdUaHJlYWQoMCkKLSAgICAsIG1fb3BlbkVycm9y KFNRTElURV9FUlJPUikKLSAgICAsIG1fb3BlbkVycm9yTWVzc2FnZSgpCi0gICAgLCBtX2xhc3RD aGFuZ2VzQ291bnQoMCkKK3N0YXRpYyB2b2lkIGluaXRpYWxpemVTUUxpdGVJZk5lY2Vzc2FyeSgp CiB7CiAgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIGZsYWc7CiAgICAgc3RkOjpjYWxsX29uY2Uo ZmxhZywgW10gewpAQCAtNzcsNiArNjksOCBAQCBTUUxpdGVEYXRhYmFzZTo6U1FMaXRlRGF0YWJh c2UoKQogICAgIH0pOwogfQogCitTUUxpdGVEYXRhYmFzZTo6U1FMaXRlRGF0YWJhc2UoKSA9IGRl ZmF1bHQ7CisKIFNRTGl0ZURhdGFiYXNlOjp+U1FMaXRlRGF0YWJhc2UoKQogewogICAgIGNsb3Nl KCk7CkBAIC04NCw2ICs3OCw4IEBAIFNRTGl0ZURhdGFiYXNlOjp+U1FMaXRlRGF0YWJhc2UoKQog CiBib29sIFNRTGl0ZURhdGFiYXNlOjpvcGVuKGNvbnN0IFN0cmluZyYgZmlsZW5hbWUsIGJvb2wg Zm9yV2ViU1FMRGF0YWJhc2UpCiB7CisgICAgaW5pdGlhbGl6ZVNRTGl0ZUlmTmVjZXNzYXJ5KCk7 CisKICAgICBjbG9zZSgpOwogCiAgICAgbV9vcGVuRXJyb3IgPSBTUUxpdGVGaWxlU3lzdGVtOjpv cGVuRGF0YWJhc2UoZmlsZW5hbWUsICZtX2RiLCBmb3JXZWJTUUxEYXRhYmFzZSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5oCmluZGV4IGJhN2RjMzRkODk4 NjBmMmUwMjQxYzc2YzVjZWU0YWIxZjNkN2QwYzMuLmJmMzM2MWE4MDBkMDk3NGU1MjUyYWVjOTA4 OGZiNTU0NDVkOGJhODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9T UUxpdGVEYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVE YXRhYmFzZS5oCkBAIC0xNDUsMjQgKzE0NSwyNCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBvdmVy cmlkZVVuYXV0aG9yaXplZEZ1bmN0aW9ucygpOwogCi0gICAgc3FsaXRlMyogbV9kYjsKLSAgICBp bnQgbV9wYWdlU2l6ZTsKKyAgICBzcWxpdGUzKiBtX2RiIHsgbnVsbHB0ciB9OworICAgIGludCBt X3BhZ2VTaXplIHsgLTEgfTsKICAgICAKLSAgICBib29sIG1fdHJhbnNhY3Rpb25JblByb2dyZXNz OwotICAgIGJvb2wgbV9zaGFyYWJsZTsKKyAgICBib29sIG1fdHJhbnNhY3Rpb25JblByb2dyZXNz IHsgZmFsc2UgfTsKKyAgICBib29sIG1fc2hhcmFibGUgeyBmYWxzZSB9OwogICAgIAogICAgIExv Y2sgbV9hdXRob3JpemVyTG9jazsKICAgICBSZWZQdHI8RGF0YWJhc2VBdXRob3JpemVyPiBtX2F1 dGhvcml6ZXI7CiAKICAgICBMb2NrIG1fbG9ja2luZ011dGV4OwotICAgIFRocmVhZElkZW50aWZp ZXIgbV9vcGVuaW5nVGhyZWFkOworICAgIFRocmVhZElkZW50aWZpZXIgbV9vcGVuaW5nVGhyZWFk IHsgMCB9OwogCiAgICAgTG9jayBtX2RhdGFiYXNlQ2xvc2luZ011dGV4OwogCi0gICAgaW50IG1f b3BlbkVycm9yOworICAgIGludCBtX29wZW5FcnJvciB7IFNRTElURV9FUlJPUiB9OwogICAgIENT dHJpbmcgbV9vcGVuRXJyb3JNZXNzYWdlOwogCi0gICAgaW50IG1fbGFzdENoYW5nZXNDb3VudDsK KyAgICBpbnQgbV9sYXN0Q2hhbmdlc0NvdW50IHsgMCB9OwogfTsKIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQo=