159031 2016-06-22 12:10:03 -0700 REGRESSION (r201629): Weird button glitching on github.com 2016-06-22 13:45:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser sabouhallawa simon.fraser oldest_to_newest 1204610 0 simon.fraser 2016-06-22 12:10:03 -0700 REGRESSION (r201629): Weird button glitching on github.com 1204612 1 281855 simon.fraser 2016-06-22 12:11:38 -0700 Created attachment 281855 Patch 1204613 2 simon.fraser 2016-06-22 12:11:56 -0700 rdar://problem/26880332 1204617 3 281855 sabouhallawa 2016-06-22 12:20:33 -0700 Comment on attachment 281855 Patch Looks good to me. Unofficial r=me. 1204650 4 simon.fraser 2016-06-22 13:45:39 -0700 https://trac.webkit.org/r202348 281855 2016-06-22 12:11:38 -0700 2016-06-22 13:11:35 -0700 Patch bug-159031-20160622121129.patch text/plain 6957 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODczMGQ1YThlMzEyYTFm NjIzZmY5ZWVlYzYwM2Y3NGFhMjFmODMyNS4uOTk5NzAxN2JhMjY2MDRiODhhMTQyNmVkZGQzNmRj OWY2MmZmZDZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE2LTA2LTIyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04g KHIyMDE2MjkpOiBXZWlyZCBidXR0b24gZ2xpdGNoaW5nIG9uIGdpdGh1Yi5jb20KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTAzMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyMDE2MjkgY2hhbmdlZCB0 aGUgbG9naWMgc2xpZ2h0bHkgd2hlbiBjcmVhdGluZyBhbiBpbWFnZSBidWZmZXIgZm9yIGEgc2Nh bGVkIGNvbnRleHQ7CisgICAgICAgIGl0IHNldCB0aGUgYnVmZmVyIGNvbnRleHQncyBzY2FsZSB0 byB0aGUgc2NhbGUgaW4gdGhlIHNvdXJjZSBjb250ZXh0LCBidXQgdGhpcyBmYWlsZWQKKyAgICAg ICAgdG8gdGFrZSBpbnRvIGFjY291bnQgdGhlIHJvdW5kaW5nIHVwIG9mIHRoZSBidWZmZXIgc2l6 ZSwgd2hpY2ggdGhlIG9sZCBjb2RlIGRpZC4KKworICAgICAgICBGaXggYnkgcmV2ZXJ0aW5nIHRv IHRoZSBvbGQgYmVoYXZpb3IuCisKKyAgICAgICAgU2luY2UgYnVmZmVyIHNpemVzIGNhbiBvbmx5 IGJlIGludGVncmFsLCBjaGFuZ2VkIGNvbXBhdGlibGVCdWZmZXJTaXplKCkgdG8gcmV0dXJuCisg ICAgICAgIGFuIEludFNpemUuCisKKyAgICAgICAgVGVzdDogZmFzdC9iYWNrZ3JvdW5kcy9zY2Fs ZWQtZ3JhZGllbnQtYmFja2dyb3VuZC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9JbWFnZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Y3JlYXRl Q29tcGF0aWJsZUJ1ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Y29tcGF0 aWJsZUJ1ZmZlclNpemUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVy Lmg6CisKKzIwMTYtMDYtMjIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CisKICAgICAgICAgQ3Jhc2ggdW5kZXIgR3JhcGhpY3NMYXllckNBOjpyZWN1cnNpdmVDb21taXRD aGFuZ2VzKCkgd2l0aCBkZWVwIGxheWVyIHRyZWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwMjMKICAgICAgICAgcmRhcjovL3Byb2JsZW0vMjUz Nzc4NDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdl QnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVy LmNwcAppbmRleCBjMzhkNDgxMTJjNTVlNmNlZWEzNDE5NGJkNTYzZThjNzFmZmU2ZmNlLi41Mjcx YTgxOWMyYzhkNDA1Yjc2MGVlZDVjZDU1YTZkY2NlYzQ3ZTgwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwCkBAIC0xNjksMTQgKzE2OSwx NCBAQCBzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IEltYWdlQnVmZmVyOjpjcmVhdGVDb21w YXRpYmxlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZQogICAgIGlmIChzaXplLmlzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAKLSAgICBGbG9hdFNpemUgc2NhbGVkU2l6ZSA9IEltYWdl QnVmZmVyOjpjb21wYXRpYmxlQnVmZmVyU2l6ZShzaXplLCBjb250ZXh0KTsKKyAgICBJbnRTaXpl IHNjYWxlZFNpemUgPSBJbWFnZUJ1ZmZlcjo6Y29tcGF0aWJsZUJ1ZmZlclNpemUoc2l6ZSwgY29u dGV4dCk7CiAKLSAgICBhdXRvIGJ1ZmZlciA9IEltYWdlQnVmZmVyOjpjcmVhdGVDb21wYXRpYmxl QnVmZmVyKGV4cGFuZGVkSW50U2l6ZShzY2FsZWRTaXplKSwgMSwgQ29sb3JTcGFjZVNSR0IsIGNv bnRleHQsIGhhc0FscGhhKTsKKyAgICBhdXRvIGJ1ZmZlciA9IEltYWdlQnVmZmVyOjpjcmVhdGVD b21wYXRpYmxlQnVmZmVyKHNjYWxlZFNpemUsIDEsIENvbG9yU3BhY2VTUkdCLCBjb250ZXh0LCBo YXNBbHBoYSk7CiAgICAgaWYgKCFidWZmZXIpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCiAg ICAgLy8gU2V0IHVwIGEgY29ycmVzcG9uZGluZyBzY2FsZSBmYWN0b3Igb24gdGhlIGdyYXBoaWNz IGNvbnRleHQuCi0gICAgYnVmZmVyLT5jb250ZXh0KCkuc2NhbGUoY29udGV4dC5zY2FsZUZhY3Rv cigpKTsKKyAgICBidWZmZXItPmNvbnRleHQoKS5zY2FsZShGbG9hdFNpemUoc2NhbGVkU2l6ZS53 aWR0aCgpIC8gc2l6ZS53aWR0aCgpLCBzY2FsZWRTaXplLmhlaWdodCgpIC8gc2l6ZS5oZWlnaHQo KSkpOwogICAgIHJldHVybiBidWZmZXI7CiB9CiAKQEAgLTE4NSwxMSArMTg1LDExIEBAIHN0ZDo6 dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4gSW1hZ2VCdWZmZXI6OmNyZWF0ZUNvbXBhdGlibGVCdWZm ZXIoY29uc3QgRmxvYXRTaXplCiAgICAgcmV0dXJuIGNyZWF0ZShzaXplLCBjb250ZXh0LnJlbmRl cmluZ01vZGUoKSwgcmVzb2x1dGlvblNjYWxlLCBjb2xvclNwYWNlKTsKIH0KIAotRmxvYXRTaXpl IEltYWdlQnVmZmVyOjpjb21wYXRpYmxlQnVmZmVyU2l6ZShjb25zdCBGbG9hdFNpemUmIHNpemUs IGNvbnN0IEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCkKK0ludFNpemUgSW1hZ2VCdWZmZXI6OmNv bXBhdGlibGVCdWZmZXJTaXplKGNvbnN0IEZsb2F0U2l6ZSYgc2l6ZSwgY29uc3QgR3JhcGhpY3ND b250ZXh0JiBjb250ZXh0KQogewogICAgIC8vIEVubGFyZ2UgdGhlIGJ1ZmZlciBzaXplIGlmIHRo ZSBjb250ZXh0J3MgdHJhbnNmb3JtIGlzIHNjYWxpbmcgaXQgc28gd2UgbmVlZCBhIGhpZ2hlcgog ICAgIC8vIHJlc29sdXRpb24gdGhhbiBvbmUgcGl4ZWwgcGVyIHVuaXQuCi0gICAgcmV0dXJuIHNp emUgKiBjb250ZXh0LnNjYWxlRmFjdG9yKCk7CisgICAgcmV0dXJuIGV4cGFuZGVkSW50U2l6ZShz aXplICogY29udGV4dC5zY2FsZUZhY3RvcigpKTsKIH0KIAogYm9vbCBJbWFnZUJ1ZmZlcjo6aXND b21wYXRpYmxlV2l0aENvbnRleHQoY29uc3QgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0KSBjb25z dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZm ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgKaW5k ZXggNmRmNzk5NDkyZTIxMGUyZDBkMTdjMDRjMzk1ZTVhNzgwZGM1MjZkNy4uNjM5YzI4ZjZiYWY1 NjZhZTI5ZDUyNGM0OGUwMDNjZjAyOWJkOTlmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCkBAIC04Myw3ICs4Myw3IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBjcmVhdGVDb21wYXRpYmxlQnVm ZmVyKGNvbnN0IEZsb2F0U2l6ZSYsIGNvbnN0IEdyYXBoaWNzQ29udGV4dCYsIGJvb2wgaGFzQWxw aGEgPSB0cnVlKTsKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBjcmVh dGVDb21wYXRpYmxlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZSYsIGZsb2F0IHJlc29sdXRpb25TY2Fs ZSwgQ29sb3JTcGFjZSwgY29uc3QgR3JhcGhpY3NDb250ZXh0JiwgYm9vbCBoYXNBbHBoYSk7CiAK LSAgICBzdGF0aWMgRmxvYXRTaXplIGNvbXBhdGlibGVCdWZmZXJTaXplKGNvbnN0IEZsb2F0U2l6 ZSYsIGNvbnN0IEdyYXBoaWNzQ29udGV4dCYpOworICAgIHN0YXRpYyBJbnRTaXplIGNvbXBhdGli bGVCdWZmZXJTaXplKGNvbnN0IEZsb2F0U2l6ZSYsIGNvbnN0IEdyYXBoaWNzQ29udGV4dCYpOwog ICAgIGJvb2wgaXNDb21wYXRpYmxlV2l0aENvbnRleHQoY29uc3QgR3JhcGhpY3NDb250ZXh0Jikg Y29uc3Q7CiAKICAgICBXRUJDT1JFX0VYUE9SVCB+SW1hZ2VCdWZmZXIoKTsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYTgy MTNmNmIyMTEyZmNkNmQwZDlkY2IwMmQzNTdmNWRkODM2ZGVhLi40Zjk3NzU3ZDliZjE3NWRmYTg4 MWIzMTI2ZmRjNmE0ZGNhNDFjZTA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDYtMjIg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVT U0lPTiAocjIwMTYyOSk6IFdlaXJkIGJ1dHRvbiBnbGl0Y2hpbmcgb24gZ2l0aHViLmNvbQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDMxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2JhY2tn cm91bmRzL3NjYWxlZC1ncmFkaWVudC1iYWNrZ3JvdW5kLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvYmFja2dyb3VuZHMvc2NhbGVkLWdyYWRpZW50LWJhY2tncm91bmQuaHRt bDogQWRkZWQuCisKIDIwMTYtMDYtMjIgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIHdpbmRvdy5zaG93TW9kYWxEaWFsb2cgZG9lc24ndCB3b3JrIGluIER1 bXBSZW5kZXJUcmVlIG9uIFdpbmRvd3MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYmFj a2dyb3VuZHMvc2NhbGVkLWdyYWRpZW50LWJhY2tncm91bmQtZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvc2NhbGVkLWdyYWRpZW50LWJhY2tncm91bmQtZXhwZWN0 ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi4xZGMwNTM4ZGE1NjhkYmY1NjkyODZmZTE5M2YxNGRiNDM2N2Nk ODM1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9iYWNrZ3JvdW5kcy9zY2Fs ZWQtZ3JhZGllbnQtYmFja2dyb3VuZC1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMzUgQEAKKzwh RE9DVFlQRSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAuYm94IHsK KyAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICB0b3A6IDUwcHg7CisgICAgICAg IGxlZnQ6IDUwcHg7CisgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgIHdpZHRoOiAxMDBw eDsKKyAgICAgICAgbWFyZ2luOiAxMDBweDsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3Jl ZW47CisgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOworICAgIH0KKworICAgIC5jbGlw cGVyIHsKKyAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICB0b3A6IDc4cHg7Cisg ICAgICAgIGxlZnQ6IDc4cHg7CisgICAgICAgIGhlaWdodDogMjA1cHg7CisgICAgICAgIHdpZHRo OiAyMDVweDsKKyAgICAgICAgYm9yZGVyOiAyMHB4IHNvbGlkIGdyYXk7CisgICAgfQorICAgIDwv c3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKworPHA+R3JlZW4gYmFja2dyb3VuZCBzaG91bGQgbm90 IGFwcGVhciBzdHJpcGV5PC9wPgorPGRpdiBjbGFzcz0iYm94IiBzdHlsZT0idHJhbnNmb3JtOiBz Y2FsZSgyLjE5KSI+PC9kaXY+CisKKzxkaXYgY2xhc3M9ImNsaXBwZXIiPjwvZGl2PgorCis8L2Jv ZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2JhY2tncm91bmRzL3Nj YWxlZC1ncmFkaWVudC1iYWNrZ3JvdW5kLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2JhY2tncm91 bmRzL3NjYWxlZC1ncmFkaWVudC1iYWNrZ3JvdW5kLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzMwMDI3MmQz NGFiMTk3YjdlZmU5YmI4NTM0ZWJmZWM5NjhjNzQ3MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvc2NhbGVkLWdyYWRpZW50LWJhY2tncm91bmQuaHRtbApA QCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEUgaHRtbD4KKworPGh0bWw+Cis8aGVhZD4KKyAgICA8 c3R5bGU+CisgICAgLmJveCB7CisgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAg dG9wOiA1MHB4OworICAgICAgICBsZWZ0OiA1MHB4OworICAgICAgICBoZWlnaHQ6IDEwMHB4Owor ICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgIG1hcmdpbjogMTAwcHg7CisgICAgICAgIGJh Y2tncm91bmQtaW1hZ2U6IGxpbmVhci1ncmFkaWVudChncmVlbiwgZ3JlZW4pOworICAgICAgICBi b3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICB9CisgICAgCisgICAgLmNsaXBwZXIgeworICAg ICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIHRvcDogNzhweDsKKyAgICAgICAgbGVm dDogNzhweDsKKyAgICAgICAgaGVpZ2h0OiAyMDVweDsKKyAgICAgICAgd2lkdGg6IDIwNXB4Owor ICAgICAgICBib3JkZXI6IDIwcHggc29saWQgZ3JheTsKKyAgICB9CisgICAgPC9zdHlsZT4KKzwv aGVhZD4KKzxib2R5PgorCis8cD5HcmVlbiBiYWNrZ3JvdW5kIHNob3VsZCBub3QgYXBwZWFyIHN0 cmlwZXk8L3A+Cis8ZGl2IGNsYXNzPSJib3giIHN0eWxlPSJ0cmFuc2Zvcm06IHNjYWxlKDIuMTkp Ij48L2Rpdj4KKworPGRpdiBjbGFzcz0iY2xpcHBlciI+PC9kaXY+CisKKzwvYm9keT4KKzwvaHRt bD4K