159021 2016-06-22 03:40:30 -0700 [Win] Use Windows api function to find top level parent. 2016-06-23 11:23:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=53675 P2 Normal --- 1 pvollan pvollan bfulgham ddkilzer lforschler oldest_to_newest 1204488 0 pvollan 2016-06-22 03:40:30 -0700 We can delete the findTopLevelParent function, and instead use the Windows api function GetAncestor. 1204493 1 281835 pvollan 2016-06-22 04:02:56 -0700 Created attachment 281835 Patch 1204508 2 281835 bfulgham 2016-06-22 08:41:24 -0700 Comment on attachment 281835 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281835&action=review A very enthusiastic r+! :-) > Tools/ChangeLog:8 > + Delete findTopLevelParent function, and use Win32 function GetAncestor instead. Oh, very good! 1204591 3 pvollan 2016-06-22 11:18:45 -0700 (In reply to comment #2) > Comment on attachment 281835 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281835&action=review > > A very enthusiastic r+! :-) > > > Tools/ChangeLog:8 > > + Delete findTopLevelParent function, and use Win32 function GetAncestor instead. > > Oh, very good! Thanks for the review! 1204782 4 pvollan 2016-06-22 23:45:37 -0700 Committed r202369: <https://trac.webkit.org/changeset/202369> 281835 2016-06-22 04:02:56 -0700 2016-06-22 08:41:24 -0700 Patch bug-159021-20160622040326.patch text/plain 2960 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjMyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE2LTA2LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBVc2UgV2luZG93cyBhcGkgZnVuY3Rpb24gdG8gZmluZCB0b3Ag bGV2ZWwgcGFyZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU5MDIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGVsZXRlIGZpbmRUb3BMZXZlbFBhcmVudCBmdW5jdGlvbiwgYW5kIHVzZSBXaW4zMiBm dW5jdGlvbiBHZXRBbmNlc3RvciBpbnN0ZWFkLgorIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3dpbi9VSURlbGVnYXRlLmNwcDoKKyAgICAgICAgKFVJRGVsZWdhdGU6OnJ1bk1vZGFsKToKKyAg ICAgICAgKGZpbmRUb3BMZXZlbFBhcmVudCk6IERlbGV0ZWQuCisgICAgICAgICogTWluaUJyb3dz ZXIvd2luL1ByaW50V2ViVUlEZWxlZ2F0ZS5jcHA6CisgICAgICAgIChQcmludFdlYlVJRGVsZWdh dGU6OnJ1bk1vZGFsKToKKyAgICAgICAgKGZpbmRUb3BMZXZlbFBhcmVudCk6IERlbGV0ZWQuCisK IDIwMTYtMDYtMjIgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtXaW5dIEltcGxlbWVudCBtb2RhbCBkaWFsb2cgc3VwcG9ydCBpbiBNaW5pQnJvd3Nlci4K SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9VSURlbGVnYXRlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vVUlEZWxlZ2F0ZS5jcHAJKHJldmlzaW9uIDIw MjMyNikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9VSURlbGVnYXRlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzgwLDI1ICszODAsMTIgQEAgSFJFU1VMVCBVSURlbGVnYXRlOjpjcmVhdGVN b2RhbERpYWxvZyhfSQogICAgIHJldHVybiBTX09LOwogfQogCi1zdGF0aWMgSFdORCBmaW5kVG9w TGV2ZWxQYXJlbnQoSFdORCB3aW5kb3cpCi17Ci0gICAgaWYgKCF3aW5kb3cpCi0gICAgICAgIHJl dHVybiBudWxscHRyOwotCi0gICAgSFdORCBjdXJyZW50ID0gd2luZG93OwotICAgIGZvciAoSFdO RCBwYXJlbnQgPSBHZXRQYXJlbnQoY3VycmVudCk7IGN1cnJlbnQ7IGN1cnJlbnQgPSBwYXJlbnQs IHBhcmVudCA9IEdldFBhcmVudChwYXJlbnQpKSB7Ci0gICAgICAgIGlmICghcGFyZW50KQotICAg ICAgICAgICAgcmV0dXJuIGN1cnJlbnQ7Ci0gICAgfQotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwotICAgIHJldHVybiBudWxscHRyOwotfQotCiBIUkVTVUxUIFVJRGVsZWdhdGU6OnJ1bk1vZGFs KF9Jbl9vcHRfIElXZWJWaWV3KiB3ZWJWaWV3KQogewogICAgIENPTVB0cjxJV2ViVmlldz4gcHJv dGVjdG9yKHdlYlZpZXcpOwogCi0gICAgYXV0byB0b3BMZXZlbFBhcmVudCA9IGZpbmRUb3BMZXZl bFBhcmVudCg6OkdldFdpbmRvdyhtX21vZGFsRGlhbG9nUGFyZW50LCBHV19PV05FUikpOworICAg IGF1dG8gbW9kYWxEaWFsb2dPd25lciA9IDo6R2V0V2luZG93KG1fbW9kYWxEaWFsb2dQYXJlbnQs IEdXX09XTkVSKTsKKyAgICBhdXRvIHRvcExldmVsUGFyZW50ID0gOjpHZXRBbmNlc3Rvcihtb2Rh bERpYWxvZ093bmVyLCBHQV9ST09UKTsKIAogICAgIDo6RW5hYmxlV2luZG93KHRvcExldmVsUGFy ZW50LCBGQUxTRSk7CiAKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL3dpbi9QcmludFdlYlVJRGVs ZWdhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL3dpbi9QcmludFdlYlVJ RGVsZWdhdGUuY3BwCShyZXZpc2lvbiAyMDIzMjcpCisrKyBUb29scy9NaW5pQnJvd3Nlci93aW4v UHJpbnRXZWJVSURlbGVnYXRlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk3LDI1ICsyOTcsMTIg QEAgSFJFU1VMVCBQcmludFdlYlVJRGVsZWdhdGU6OmNhblJ1bk1vZGFsKAogICAgIHJldHVybiBT X09LOwogfQogCi1zdGF0aWMgSFdORCBmaW5kVG9wTGV2ZWxQYXJlbnQoSFdORCB3aW5kb3cpCi17 Ci0gICAgaWYgKCF3aW5kb3cpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgSFdORCBj dXJyZW50ID0gd2luZG93OwotICAgIGZvciAoSFdORCBwYXJlbnQgPSBHZXRQYXJlbnQoY3VycmVu dCk7IGN1cnJlbnQ7IGN1cnJlbnQgPSBwYXJlbnQsIHBhcmVudCA9IEdldFBhcmVudChwYXJlbnQp KSB7Ci0gICAgICAgIGlmICghcGFyZW50KQotICAgICAgICAgICAgcmV0dXJuIGN1cnJlbnQ7Ci0g ICAgfQotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVybiBudWxscHRyOwotfQot CiBIUkVTVUxUIFByaW50V2ViVUlEZWxlZ2F0ZTo6cnVuTW9kYWwoX0luX29wdF8gSVdlYlZpZXcq IHdlYlZpZXcpCiB7CiAgICAgQ09NUHRyPElXZWJWaWV3PiBwcm90ZWN0b3Iod2ViVmlldyk7CiAK LSAgICBhdXRvIHRvcExldmVsUGFyZW50ID0gZmluZFRvcExldmVsUGFyZW50KDo6R2V0V2luZG93 KG1fbW9kYWxEaWFsb2dQYXJlbnQsIEdXX09XTkVSKSk7CisgICAgYXV0byBtb2RhbERpYWxvZ093 bmVyID0gOjpHZXRXaW5kb3cobV9tb2RhbERpYWxvZ1BhcmVudCwgR1dfT1dORVIpOworICAgIGF1 dG8gdG9wTGV2ZWxQYXJlbnQgPSA6OkdldEFuY2VzdG9yKG1vZGFsRGlhbG9nT3duZXIsIEdBX1JP T1QpOwogCiAgICAgOjpFbmFibGVXaW5kb3codG9wTGV2ZWxQYXJlbnQsIEZBTFNFKTsKIAo=