159020 2016-06-22 02:36:14 -0700 JSDOMIterator forEach should support second optional parameter 2016-06-22 10:50:32 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=131443 P2 Normal --- 1 youennf youennf bfulgham cdumez jiewen_tan oldest_to_newest 1204478 0 youennf 2016-06-22 02:36:14 -0700 The second optional parameter should be the thisValue when calling the callback. 1204480 1 281830 youennf 2016-06-22 02:42:04 -0700 Created attachment 281830 Patch 1204512 2 cdumez 2016-06-22 08:50:38 -0700 I am working on confirming that this fixes yahoo.jp. 1204513 3 youennf 2016-06-22 08:52:37 -0700 Thanks! 1204520 4 cdumez 2016-06-22 09:33:33 -0700 Hmm, yahoo.co.jp is still broken with this patch but the JS error is different: [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') (anonymous function) (mtop-page-top.js:662:1513) f (mtop-page-top.js:14:886) 1204521 5 youennf 2016-06-22 09:38:22 -0700 (In reply to comment #4) > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > different: > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > (anonymous function) (mtop-page-top.js:662:1513) > f (mtop-page-top.js:14:886) Do you have a link to mtop-page-top.js? 1204522 6 cdumez 2016-06-22 09:41:40 -0700 (In reply to comment #5) > (In reply to comment #4) > > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > > different: > > > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > > (anonymous function) (mtop-page-top.js:662:1513) > > f (mtop-page-top.js:14:886) > > Do you have a link to mtop-page-top.js? Full URL: http://i.yimg.jp/images/mtop/4.5.38/js/standalone/mtop-page-top.js Note that commenting out the "iterable<Node>;" in NodeList.idl does not seem to help either :/ 1204524 7 cdumez 2016-06-22 09:49:48 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > > > different: > > > > > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > > > (anonymous function) (mtop-page-top.js:662:1513) > > > f (mtop-page-top.js:14:886) > > > > Do you have a link to mtop-page-top.js? > > Full URL: > http://i.yimg.jp/images/mtop/4.5.38/js/standalone/mtop-page-top.js > > Note that commenting out the "iterable<Node>;" in NodeList.idl does not seem > to help either :/ Commenting out "iterable<FontFace>;" on FontFaceSet does not unbreak yahoo.co.jp either :( So I believe I have commented out all the iterables and the site is still broken. It is possible that: 1. There are several bugs and the iterable one hid another one that landed later on. 2. The patch for iterable support changed the behavior of code not strictly related to iterable 1204525 8 youennf 2016-06-22 09:50:46 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > > > different: > > > > > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > > > (anonymous function) (mtop-page-top.js:662:1513) > > > f (mtop-page-top.js:14:886) > > > > Do you have a link to mtop-page-top.js? > > Full URL: > http://i.yimg.jp/images/mtop/4.5.38/js/standalone/mtop-page-top.js > > Note that commenting out the "iterable<Node>;" in NodeList.idl does not seem > to help either :/ Is the page working if only forEach property is removed from JSNodeListPrototypeTableValues in JSNodeList.cpp? 1204527 9 cdumez 2016-06-22 09:54:41 -0700 (In reply to comment #8) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > > > > different: > > > > > > > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > > > > (anonymous function) (mtop-page-top.js:662:1513) > > > > f (mtop-page-top.js:14:886) > > > > > > Do you have a link to mtop-page-top.js? > > > > Full URL: > > http://i.yimg.jp/images/mtop/4.5.38/js/standalone/mtop-page-top.js > > > > Note that commenting out the "iterable<Node>;" in NodeList.idl does not seem > > to help either :/ > > Is the page working if only forEach property is removed from > JSNodeListPrototypeTableValues in JSNodeList.cpp? Not sure I understand the question, I commented out the whole "iterable<Node>;" in NodeList so there is no forEach property in JSNodeList.cpp already. 1204529 10 youennf 2016-06-22 09:56:52 -0700 > Not sure I understand the question, I commented out the whole > "iterable<Node>;" in NodeList so there is no forEach property in > JSNodeList.cpp already. iterable<Node> also triggers methods like keys, values which may or may not be used in the code. 1204534 11 cdumez 2016-06-22 09:59:33 -0700 (In reply to comment #10) > > Not sure I understand the question, I commented out the whole > > "iterable<Node>;" in NodeList so there is no forEach property in > > JSNodeList.cpp already. > > iterable<Node> also triggers methods like keys, values which may or may not > be used in the code. Hmm, ok but the site was working before <http://trac.webkit.org/changeset/200619> where you added iterable<> on NodeList. 1204542 12 youennf 2016-06-22 10:03:06 -0700 (In reply to comment #11) > (In reply to comment #10) > > > Not sure I understand the question, I commented out the whole > > > "iterable<Node>;" in NodeList so there is no forEach property in > > > JSNodeList.cpp already. > > > > iterable<Node> also triggers methods like keys, values which may or may not > > be used in the code. > > Hmm, ok but the site was working before > <http://trac.webkit.org/changeset/200619> where you added iterable<> on > NodeList. Can you describe what means "the site is working" vs "the site is not working"? That might help me trying to investigate further the issue on my local machine. 1204544 13 cdumez 2016-06-22 10:06:53 -0700 (In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > > Not sure I understand the question, I commented out the whole > > > > "iterable<Node>;" in NodeList so there is no forEach property in > > > > JSNodeList.cpp already. > > > > > > iterable<Node> also triggers methods like keys, values which may or may not > > > be used in the code. > > > > Hmm, ok but the site was working before > > <http://trac.webkit.org/changeset/200619> where you added iterable<> on > > NodeList. > > Can you describe what means "the site is working" vs "the site is not > working"? > That might help me trying to investigate further the issue on my local > machine. This was explained on the other bug. The site content at the bottom of the page no longer loads, we just see a spinner. You may be able to reproduce in a simulator. 1204548 14 cdumez 2016-06-22 10:08:33 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > (In reply to comment #4) > > > > > Hmm, yahoo.co.jp is still broken with this patch but the JS error is > > > > > different: > > > > > > > > > > [Error] TypeError: undefined is not an object (evaluating 'o.removeClass') > > > > > (anonymous function) (mtop-page-top.js:662:1513) > > > > > f (mtop-page-top.js:14:886) > > > > > > > > Do you have a link to mtop-page-top.js? > > > > > > Full URL: > > > http://i.yimg.jp/images/mtop/4.5.38/js/standalone/mtop-page-top.js > > > > > > Note that commenting out the "iterable<Node>;" in NodeList.idl does not seem > > > to help either :/ > > > > Is the page working if only forEach property is removed from > > JSNodeListPrototypeTableValues in JSNodeList.cpp? > > Not sure I understand the question, I commented out the whole > "iterable<Node>;" in NodeList so there is no forEach property in > JSNodeList.cpp already. I tried dropping just the forEach property and it did not help. 1204556 15 youennf 2016-06-22 10:18:32 -0700 (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > (In reply to comment #10) > > > > > Not sure I understand the question, I commented out the whole > > > > > "iterable<Node>;" in NodeList so there is no forEach property in > > > > > JSNodeList.cpp already. > > > > > > > > iterable<Node> also triggers methods like keys, values which may or may not > > > > be used in the code. > > > > > > Hmm, ok but the site was working before > > > <http://trac.webkit.org/changeset/200619> where you added iterable<> on > > > NodeList. > > > > Can you describe what means "the site is working" vs "the site is not > > working"? > > That might help me trying to investigate further the issue on my local > > machine. > > This was explained on the other bug. The site content at the bottom of the > page no longer loads, we just see a spinner. You may be able to reproduce in > a simulator. I tried on mini browser this morning but was not sure what to search for. I will try again. 1204557 16 cdumez 2016-06-22 10:20:19 -0700 (In reply to comment #15) > (In reply to comment #13) > > (In reply to comment #12) > > > (In reply to comment #11) > > > > (In reply to comment #10) > > > > > > Not sure I understand the question, I commented out the whole > > > > > > "iterable<Node>;" in NodeList so there is no forEach property in > > > > > > JSNodeList.cpp already. > > > > > > > > > > iterable<Node> also triggers methods like keys, values which may or may not > > > > > be used in the code. > > > > > > > > Hmm, ok but the site was working before > > > > <http://trac.webkit.org/changeset/200619> where you added iterable<> on > > > > NodeList. > > > > > > Can you describe what means "the site is working" vs "the site is not > > > working"? > > > That might help me trying to investigate further the issue on my local > > > machine. > > > > This was explained on the other bug. The site content at the bottom of the > > page no longer loads, we just see a spinner. You may be able to reproduce in > > a simulator. > > I tried on mini browser this morning but was not sure what to search for. > I will try again. FYI, I am doing more testing. It seems I can no longer reproduce for some reason. Trying to figure out what I changed. 1204559 17 cdumez 2016-06-22 10:22:13 -0700 (In reply to comment #15) > (In reply to comment #13) > > (In reply to comment #12) > > > (In reply to comment #11) > > > > (In reply to comment #10) > > > > > > Not sure I understand the question, I commented out the whole > > > > > > "iterable<Node>;" in NodeList so there is no forEach property in > > > > > > JSNodeList.cpp already. > > > > > > > > > > iterable<Node> also triggers methods like keys, values which may or may not > > > > > be used in the code. > > > > > > > > Hmm, ok but the site was working before > > > > <http://trac.webkit.org/changeset/200619> where you added iterable<> on > > > > NodeList. > > > > > > Can you describe what means "the site is working" vs "the site is not > > > working"? > > > That might help me trying to investigate further the issue on my local > > > machine. > > > > This was explained on the other bug. The site content at the bottom of the > > page no longer loads, we just see a spinner. You may be able to reproduce in > > a simulator. > > I tried on mini browser this morning but was not sure what to search for. > I will try again. This is on iOS with the mobile site. 1204561 18 cdumez 2016-06-22 10:32:02 -0700 So I cannot reproduce the bottom of the site not loading anymore. However, I can confirm that the forEach() JS exceptions are present without the patch attached to this bug and that they're gone with the patch. Therefore, I think yahoo.co.jp does require the support for the second parameter on forEach and we should land your patch. 1204563 19 281830 cdumez 2016-06-22 10:34:15 -0700 Comment on attachment 281830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281830&action=review > LayoutTests/fast/dom/nodeListIterator.html:51 > + shouldBe('thisValue', 'window'); Looking at the spec (http://heycam.github.io/webidl/#es-forEach), shouldn't this be undefined rather than window? 1204564 20 281830 cdumez 2016-06-22 10:34:45 -0700 Comment on attachment 281830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281830&action=review >> LayoutTests/fast/dom/nodeListIterator.html:51 >> + shouldBe('thisValue', 'window'); > > Looking at the spec (http://heycam.github.io/webidl/#es-forEach), shouldn't this be undefined rather than window? Referring to step 4.4 Invoke callback with thisArg (or undefined, if the argument was not supplied) as the callback this value and value, key and O as its arguments. 1204565 21 281830 cdumez 2016-06-22 10:36:34 -0700 Comment on attachment 281830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281830&action=review >>> LayoutTests/fast/dom/nodeListIterator.html:51 >>> + shouldBe('thisValue', 'window'); >> >> Looking at the spec (http://heycam.github.io/webidl/#es-forEach), shouldn't this be undefined rather than window? > > Referring to step 4.4 Invoke callback with thisArg (or undefined, if the argument was not supplied) as the callback this value and value, key and O as its arguments. Hmm, Chrome seems to agree with you though.. 1204567 22 281830 cdumez 2016-06-22 10:42:05 -0700 Comment on attachment 281830 Patch Nevermind, I am mis-interpreting the spec. You do call JSC::call() with undefined as thisValue in this case. 1204568 23 cdumez 2016-06-22 10:49:53 -0700 Note that on Chrome, a few checks are failing: FAIL iterator.next().value should be [object HTMLDivElement] (of type object). Was 0 (of type number). FAIL iterator.next().value should be [object HTMLOListElement] (of type object). Was 1 (of type number). I have checked yet who is right. 1204569 24 281830 cdumez 2016-06-22 10:50:27 -0700 Comment on attachment 281830 Patch Clearing flags on attachment: 281830 Committed r202334: <http://trac.webkit.org/changeset/202334> 1204570 25 cdumez 2016-06-22 10:50:32 -0700 All reviewed patches have been landed. Closing bug. 281830 2016-06-22 02:42:04 -0700 2016-06-22 10:50:27 -0700 Patch bug-159020-20160622114155.patch text/plain 5270 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc2OTJiYjYwOTY5ZmM2 MGJmZGZiY2ZmODk2Njk2YWQzZGI1ZGY1ZC4uMDQxOTUyMTA1OTg2NjNkY2I4ZmFhZGVlN2QwNDgz ZjY0ZjI3ODUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTIyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uZkBnbWFpbC5jb20+CisKKyAgICAgICAgSlNET01JdGVyYXRvciBm b3JFYWNoIHNob3VsZCBzdXBwb3J0IHNlY29uZCBvcHRpb25hbCBwYXJhbWV0ZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTAyMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgYmVlZmVk IHVwIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmg6CisgICAg ICAgIChXZWJDb3JlOjppdGVyYXRvckZvckVhY2gpOiBTZXR0aW5nIGNhbGxiYWNrIHRoaXNWYWx1 ZSB0byB0aGUgc2Vjb25kIGFyZ3VtZW50IHBhc3NlZCB0byBmb3JFYWNoLgorCiAyMDE2LTA2LTIx ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIDpob3Zl ciBDU1MgcHNldWRvLWNsYXNzIHNvbWV0aW1lcyBrZWVwcyBtYXRjaGluZyBldmVyIGFmdGVyIG1v dXNlIGhhcyBsZWZ0IHRoZSBlbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUl0ZXJhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RP TUl0ZXJhdG9yLmgKaW5kZXggMzAzNzJlYjAyMTQ5YmRlNzFlNTQyODZkN2E1MzVjYjVjM2U2NWRh My4uNWU0YzcxMzdlNTY5ODMzYTM4ZjQ5ODc4MGU1ZWM2MWExN2EyOWM5MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01JdGVyYXRvci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NSXRlcmF0b3IuaApAQCAtMTgyLDggKzE4MiwxMSBAQCBK U0M6OkVuY29kZWRKU1ZhbHVlIGl0ZXJhdG9yRm9yRWFjaChKU0M6OkV4ZWNTdGF0ZSYgc3RhdGUs IGNvbnN0IGNoYXIqIHByb3BlcnR5TgogICAgIGlmIChVTkxJS0VMWSghd3JhcHBlcikpCiAgICAg ICAgIHJldHVybiB0aHJvd1RoaXNUeXBlRXJyb3Ioc3RhdGUsIEpTV3JhcHBlcjo6aW5mbygpLT5j bGFzc05hbWUsIHByb3BlcnR5TmFtZSk7CiAKKyAgICBKU0M6OkpTVmFsdWUgY2FsbGJhY2sgPSBz dGF0ZS5hcmd1bWVudCgwKTsKKyAgICBKU0M6OkpTVmFsdWUgdGhpc1ZhbHVlID0gc3RhdGUuYXJn dW1lbnQoMSk7CisKICAgICBKU0M6OkNhbGxEYXRhIGNhbGxEYXRhOwotICAgIEpTQzo6Q2FsbFR5 cGUgY2FsbFR5cGUgPSBKU0M6OmdldENhbGxEYXRhKHN0YXRlLmFyZ3VtZW50KDApLCBjYWxsRGF0 YSk7CisgICAgSlNDOjpDYWxsVHlwZSBjYWxsVHlwZSA9IEpTQzo6Z2V0Q2FsbERhdGEoY2FsbGJh Y2ssIGNhbGxEYXRhKTsKICAgICBpZiAoY2FsbFR5cGUgPT0gSlNDOjpDYWxsVHlwZTo6Tm9uZSkK ICAgICAgICAgcmV0dXJuIHRocm93Vk1UeXBlRXJyb3IoJnN0YXRlKTsKIApAQCAtMTkzLDEwICsx OTYsMTAgQEAgSlNDOjpFbmNvZGVkSlNWYWx1ZSBpdGVyYXRvckZvckVhY2goSlNDOjpFeGVjU3Rh dGUmIHN0YXRlLCBjb25zdCBjaGFyKiBwcm9wZXJ0eU4KICAgICAgICAgSlNDOjpNYXJrZWRBcmd1 bWVudEJ1ZmZlciBhcmd1bWVudHM7CiAgICAgICAgIGFwcGVuZEZvckVhY2hBcmd1bWVudHMoc3Rh dGUsIHdyYXBwZXItPmdsb2JhbE9iamVjdCgpLCBhcmd1bWVudHMsIHZhbHVlLCBpbmRleCk7CiAg ICAgICAgIGFyZ3VtZW50cy5hcHBlbmQod3JhcHBlcik7Ci0gICAgICAgIEpTQzo6Y2FsbCgmc3Rh dGUsIHN0YXRlLmFyZ3VtZW50KDApLCBjYWxsVHlwZSwgY2FsbERhdGEsIHdyYXBwZXIsIGFyZ3Vt ZW50cyk7CisgICAgICAgIEpTQzo6Y2FsbCgmc3RhdGUsIGNhbGxiYWNrLCBjYWxsVHlwZSwgY2Fs bERhdGEsIHRoaXNWYWx1ZSwgYXJndW1lbnRzKTsKICAgICAgICAgaWYgKHN0YXRlLmhhZEV4Y2Vw dGlvbigpKQogICAgICAgICAgICAgYnJlYWs7Ci0gICAgfSAKKyAgICB9CiAgICAgcmV0dXJuIEpT Qzo6SlNWYWx1ZTo6ZW5jb2RlKEpTQzo6anNVbmRlZmluZWQoKSk7CiB9CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZDQ5 MmJiNzA2ZGVjM2FlZTYyMjAyZjJmYjY0OGVlY2IzNWRhMDE1Li45ZDFlM2FiY2E5OGUyNTExMWIw MjZmYzYxYzZmMGViMTBhMzIxZWRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDYtMjIg IFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5mQGdtYWlsLmNvbT4KKworICAgICAgICBKU0RPTUl0ZXJh dG9yIGZvckVhY2ggc2hvdWxkIHN1cHBvcnQgc2Vjb25kIG9wdGlvbmFsIHBhcmFtZXRlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MDIwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2RvbS9u b2RlTGlzdEl0ZXJhdG9yLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9ub2RlTGlz dEl0ZXJhdG9yLmh0bWw6IEFkZGluZyAndGhpc1ZhbHVlJyB2YXJpb3VzIGNoZWNrcy4KKwogMjAx Ni0wNi0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBM YW5kIHRlc3QgZXhwZWN0YXRpb25zIGZvciByZGFyOi8vcHJvYmxlbS8yNjQyMjA1MS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3ItZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxpc3RJdGVyYXRvci1leHBlY3RlZC50eHQKaW5k ZXggNzY4MTU2MjRkNzRiMmFmZWNlZjRmZmM2YTBhM2FhOTA1MjFiN2NjMS4uZDdkYmRjZDliYjZm NmI0N2U2ODgxYjIzZTExODhjNDI3NzZmNmYzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vbm9kZUxpc3RJdGVyYXRvci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vbm9kZUxpc3RJdGVyYXRvci1leHBlY3RlZC50eHQKQEAgLTExLDkgKzExLDE1IEBAIFBB U1MgcGFpclsxXSBpcyBjaGlsZHJlblsxXQogUEFTUyBmb3JFYWNoQ29udGFpbmVyIGlzIG5vZGVM aXN0CiBQQVNTIGZvckVhY2hJbmRleCBpcyBpbmRleAogUEFTUyBub2RlIGlzIGNoaWxkcmVuW2lu ZGV4KytdCitQQVNTIHRoaXNWYWx1ZSBpcyB3aW5kb3cKIFBBU1MgZm9yRWFjaENvbnRhaW5lciBp cyBub2RlTGlzdAogUEFTUyBmb3JFYWNoSW5kZXggaXMgaW5kZXgKIFBBU1Mgbm9kZSBpcyBjaGls ZHJlbltpbmRleCsrXQorUEFTUyB0aGlzVmFsdWUgaXMgd2luZG93CitQQVNTIHRoaXNWYWx1ZSBp cyB3aW5kb3cKK1BBU1MgdGhpc1ZhbHVlIGlzIHdpbmRvdworUEFTUyB0aGlzVmFsdWUgaXMgZ2l2 ZW5UaGlzVmFsdWUKK1BBU1MgdGhpc1ZhbHVlIGlzIGdpdmVuVGhpc1ZhbHVlCiBQQVNTIGl0ZXJh dG9yLm5leHQoKS52YWx1ZSBpcyBjaGlsZHJlblswXQogUEFTUyBpdGVyYXRvci5uZXh0KCkudmFs dWUgaXMgY2hpbGRyZW5bMV0KIFBBU1MgZW5kLmRvbmUgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vbm9kZUxpc3RJdGVyYXRvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9kb20vbm9kZUxpc3RJdGVyYXRvci5odG1sCmluZGV4IDgyYTM3YjE2YjU3YTc0NDlhMmRjOTdm ZTRlOGNjNGRjZTBiZGJhZjAuLjRjNDUxMDQ0ZDc3N2E1ZTdmYzU1MDk1NmViNjE3MDQwNGFhZGNh ODUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vZGVMaXN0SXRlcmF0b3IuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub2RlTGlzdEl0ZXJhdG9yLmh0bWwKQEAgLTM5 LDE1ICszOSwyOSBAQAogICAgICAgICAgICAgdmFyIG5vZGU7CiAgICAgICAgICAgICB2YXIgZm9y RWFjaEluZGV4OwogICAgICAgICAgICAgdmFyIGZvckVhY2hDb250YWluZXI7CisgICAgICAgICAg ICB2YXIgdGhpc1ZhbHVlOwogICAgICAgICAgICAgbm9kZUxpc3QuZm9yRWFjaChmdW5jdGlvbihu LCBpLCBjKSB7CiAgICAgICAgICAgICAgICAgbm9kZSA9IG47CiAgICAgICAgICAgICAgICAgZm9y RWFjaEluZGV4ID0gaTsKICAgICAgICAgICAgICAgICBmb3JFYWNoQ29udGFpbmVyID0gYzsKKyAg ICAgICAgICAgICAgICB0aGlzVmFsdWUgPSB0aGlzOwogICAgICAgICAgICAgICAgIHNob3VsZEJl KCdmb3JFYWNoQ29udGFpbmVyJywgJ25vZGVMaXN0Jyk7CiAgICAgICAgICAgICAgICAgc2hvdWxk QmUoJ2ZvckVhY2hJbmRleCcsICdpbmRleCcpOwogICAgICAgICAgICAgICAgIHNob3VsZEJlKCdu b2RlJywgJ2NoaWxkcmVuW2luZGV4KytdJyk7CisgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3Ro aXNWYWx1ZScsICd3aW5kb3cnKTsKICAgICAgICAgICAgIH0pOwotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorCisgICAg ICAgICAgICBub2RlTGlzdC5mb3JFYWNoKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgIHRo aXNWYWx1ZSA9IHRoaXM7CisgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3RoaXNWYWx1ZScsICd3 aW5kb3cnKTsKKyAgICAgICAgICAgIH0sIHVuZGVmaW5lZCk7CisKKyAgICAgICAgICAgIHZhciBn aXZlblRoaXNWYWx1ZSA9IG5vZGVMaXN0OworICAgICAgICAgICAgbm9kZUxpc3QuZm9yRWFjaChm dW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICB0aGlzVmFsdWUgPSB0aGlzOworICAgICAgICAg ICAgICAgIHNob3VsZEJlKCd0aGlzVmFsdWUnLCAnZ2l2ZW5UaGlzVmFsdWUnKTsKKyAgICAgICAg ICAgIH0sIGdpdmVuVGhpc1ZhbHVlKTsKKwogICAgICAgICAgICAgdmFyIGl0ZXJhdG9yID0gbm9k ZUxpc3Qua2V5cygpOwogICAgICAgICAgICAgc2hvdWxkQmUoJ2l0ZXJhdG9yLm5leHQoKS52YWx1 ZScsICdjaGlsZHJlblswXScpOwogICAgICAgICAgICAgc2hvdWxkQmUoJ2l0ZXJhdG9yLm5leHQo KS52YWx1ZScsICdjaGlsZHJlblsxXScpOwo=