158994 2016-06-21 11:29:26 -0700 CodeBlock::shrinkToFit is racy 2016-06-21 13:14:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1204216 0 saam 2016-06-21 11:29:26 -0700 Let's say CodeBlock A is finalizing its baseline compile. Let's say CodeBlock B is inlining A, and asks A for a result profile. This happens as the finalizing step of the baseline compile calls shrinkToFit on its m_resultProfiles field without grabbing lock. This leads to a bad time. 1204218 1 saam 2016-06-21 11:30:43 -0700 <rdar://problem/26920212> 1204225 2 281762 saam 2016-06-21 11:49:05 -0700 Created attachment 281762 patch 1204226 3 281763 saam 2016-06-21 11:51:36 -0700 Created attachment 281763 patch 1204258 4 281763 commit-queue 2016-06-21 13:14:10 -0700 Comment on attachment 281763 patch Clearing flags on attachment: 281763 Committed r202288: <http://trac.webkit.org/changeset/202288> 1204259 5 commit-queue 2016-06-21 13:14:15 -0700 All reviewed patches have been landed. Closing bug. 281762 2016-06-21 11:49:05 -0700 2016-06-21 11:51:36 -0700 patch a-backup.diff text/plain 1916 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyMjg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE2LTA2LTIxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENvZGVCbG9jazo6c2hyaW5rVG9GaXQgaXMgcmFjeQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4OTk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NjkyMDIxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUbyBzZWUgd2h5IHRoaXMgaXMgcmFjeSwgY29uc2lkZXIgdGhlIGZvbGxvd2luZyBzY2VuYXJp bzoKKyAgICAgICAgLSBDb2RlQmxvY2sgQSBpcyBsaW5rKClpbmcgaXRzIGJhc2VsaW5lIGNvbXBp bGUuCisgICAgICAgIC0gQ29kZUJsb2NrIEIgaXMgaW5saW5pbmcgQSwgYW5kIGFza3MgQSBmb3Ig YSByZXN1bHQgcHJvZmlsZSBpbiBERkdCeXRlY29kZVBhcnNlci4KKyAgICAgICAgLSBUaGUgcmFj ZSBvY2N1cnMgd2hlbiB0aGUgbGluaygpIHN0ZXAgb2YgdGhlIGJhc2VsaW5lIGNvbXBpbGUgY2Fs bHMgc2hyaW5rVG9GaXQKKyAgICAgICAgICBvbiBpdHMgbV9yZXN1bHRQcm9maWxlcyBmaWVsZCB3 aXRob3V0IGdyYWJiaW5nIGEgbG9jay4gVGhpcyBsZWFkcyB0byBhIGJhZAorICAgICAgICAgIHRp bWUgYmVjYXVzZSB0aGUgREZHIGNvbXBpbGUgd2lsbCBiZSByZWFkaW5nIGZyb20gdGhhdCB2ZWN0 b3IgYXMgaXQgZ2V0dGluZworICAgICAgICAgIGNoYW5nZWQgYnkgdGhlIGJhc2VsaW5lIGxpbmso KSBtZXRob2QuCisKKyAgICAgICAgVGhpcyByYWNlIGhhcyBhbHdheXMgZXhpc3RlZCwgdGhvdWdo IHRoZSBtb3ZlIHRvIGEgY29uY3VycmVudCBiYXNlbGluZQorICAgICAgICBKSVQgaGFzIG1hZGUg aXQgbW9yZSBsaWtlbHkgdG8gb2NjdXIuIFRoZSBzb2x1dGlvbiBpcyB0byBoYXZlIENvZGVCbG9j azo6c2hyaW5rVG9GaXQKKyAgICAgICAgZ3JhYiBpdHMgbG9jayBiZWZvcmUgc2hyaW5raW5nIHRo ZSB2ZWN0b3IuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAo SlNDOjpDb2RlQmxvY2s6OnNocmlua1RvRml0KToKKwogMjAxNi0wNi0yMSAgS2VpdGggTWlsbGVy ICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBJdCBzaG91bGQgYmUgZWFzeSB0 byBhZGQgYSBwcml2YXRlIGdsb2JhbCBoZWxwZXIgZnVuY3Rpb24gZm9yIGJ1aWx0aW5zCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2aXNp b24gMjAyMjMxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMzYsNiArMzIzNiw4IEBAIGJvb2wgQ29kZUJsb2NrOjpo YXNPcERlYnVnRm9yTGluZUFuZENvbHUKIAogdm9pZCBDb2RlQmxvY2s6OnNocmlua1RvRml0KFNo cmlua01vZGUgc2hyaW5rTW9kZSkKIHsKKyAgICBDb25jdXJyZW50SklUTG9ja2VyIGxvY2tlciht X2xvY2spOworCiAgICAgbV9yYXJlQ2FzZVByb2ZpbGVzLnNocmlua1RvRml0KCk7CiAgICAgbV9y ZXN1bHRQcm9maWxlcy5zaHJpbmtUb0ZpdCgpOwogICAgIAo= 281763 2016-06-21 11:51:36 -0700 2016-06-21 13:14:10 -0700 patch a-backup.diff text/plain 1918 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyMjg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE2LTA2LTIxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENvZGVCbG9jazo6c2hyaW5rVG9GaXQgaXMgcmFjeQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4OTk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NjkyMDIxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUbyBzZWUgd2h5IHRoaXMgaXMgcmFjeSwgY29uc2lkZXIgdGhlIGZvbGxvd2luZyBzY2VuYXJp bzoKKyAgICAgICAgLSBDb2RlQmxvY2sgQSBpcyBsaW5rKClpbmcgaXRzIGJhc2VsaW5lIGNvbXBp bGUuCisgICAgICAgIC0gQ29kZUJsb2NrIEIgaXMgaW5saW5pbmcgQSwgYW5kIGFza3MgQSBmb3Ig YSByZXN1bHQgcHJvZmlsZSBpbiBERkdCeXRlY29kZVBhcnNlci4KKyAgICAgICAgLSBUaGUgcmFj ZSBvY2N1cnMgd2hlbiB0aGUgbGluaygpIHN0ZXAgb2YgdGhlIGJhc2VsaW5lIGNvbXBpbGUgY2Fs bHMgc2hyaW5rVG9GaXQKKyAgICAgICAgICBvbiBpdHMgbV9yZXN1bHRQcm9maWxlcyBmaWVsZCB3 aXRob3V0IGdyYWJiaW5nIGEgbG9jay4gVGhpcyBsZWFkcyB0byBhIGJhZAorICAgICAgICAgIHRp bWUgYmVjYXVzZSB0aGUgREZHIGNvbXBpbGUgd2lsbCBiZSByZWFkaW5nIGZyb20gdGhhdCB2ZWN0 b3IgYXMgaXQncyBnZXR0aW5nCisgICAgICAgICAgY2hhbmdlZCBieSB0aGUgYmFzZWxpbmUgbGlu aygpIG1ldGhvZC4KKworICAgICAgICBUaGlzIHJhY2UgaGFzIGFsd2F5cyBleGlzdGVkLCB0aG91 Z2ggdGhlIG1vdmUgdG8gYSBjb25jdXJyZW50IGJhc2VsaW5lCisgICAgICAgIEpJVCBoYXMgbWFk ZSBpdCBtb3JlIGxpa2VseSB0byBvY2N1ci4gVGhlIHNvbHV0aW9uIGlzIHRvIGhhdmUgQ29kZUJs b2NrOjpzaHJpbmtUb0ZpdAorICAgICAgICBncmFiIGl0cyBsb2NrIGJlZm9yZSBzaHJpbmtpbmcg dGhlIHZlY3Rvci4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAg IChKU0M6OkNvZGVCbG9jazo6c2hyaW5rVG9GaXQpOgorCiAyMDE2LTA2LTIxICBLZWl0aCBNaWxs ZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEl0IHNob3VsZCBiZSBlYXN5 IHRvIGFkZCBhIHByaXZhdGUgZ2xvYmFsIGhlbHBlciBmdW5jdGlvbiBmb3IgYnVpbHRpbnMKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZp c2lvbiAyMDIyMzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2Nr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIzNiw2ICszMjM2LDggQEAgYm9vbCBDb2RlQmxvY2s6 Omhhc09wRGVidWdGb3JMaW5lQW5kQ29sdQogCiB2b2lkIENvZGVCbG9jazo6c2hyaW5rVG9GaXQo U2hyaW5rTW9kZSBzaHJpbmtNb2RlKQogeworICAgIENvbmN1cnJlbnRKSVRMb2NrZXIgbG9ja2Vy KG1fbG9jayk7CisKICAgICBtX3JhcmVDYXNlUHJvZmlsZXMuc2hyaW5rVG9GaXQoKTsKICAgICBt X3Jlc3VsdFByb2ZpbGVzLnNocmlua1RvRml0KCk7CiAgICAgCg==