158987 2016-06-21 09:39:46 -0700 Move shouldInheritSecurityOriginFromOwner() from URL to Document 2016-07-08 17:29:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=158855 P2 Normal --- 1 wilander dbates achristensen aestes ap bfulgham cdumez commit-queue dbates esprehn+autocc kangil.han mkwst oldest_to_newest 1204172 0 wilander 2016-06-21 09:39:46 -0700 We should move shouldInheritSecurityOriginFromOwner from URL to SecurityOrigin to keep the URL class free of policy decisions and the notion of origins. 1209227 1 dbates 2016-07-08 12:10:51 -0700 I suggest that we move URL::shouldInheritSecurityOriginFromOwner() back to Document because it implements the origin inheritance policy for Document objects per section Origin of the HTML5 spec., <https://html.spec.whatwg.org/multipage/browsers.html#origin> (8 July 2016). This policy is only applicable to Documents. 1209228 2 283186 dbates 2016-07-08 12:11:37 -0700 Created attachment 283186 Patch 1209230 3 dbates 2016-07-08 12:17:10 -0700 Although Darin Adler suggested that in comment 22, bug 158855 that we move shouldInheritSecurityOriginFromOwner() to SecurityOrigin.h, I choose to move it to Document because the policy shouldInheritSecurityOriginFromOwner() implements is only applicable to Document objects by <https://html.spec.whatwg.org/multipage/browsers.html#origin> and this function is only used in Document.cpp (as expected given that it is only applicable to Document objects). 1209231 4 achristensen 2016-07-08 12:18:02 -0700 It definitely shouldn't be in URL 1209362 5 283186 dbates 2016-07-08 17:29:04 -0700 Comment on attachment 283186 Patch Clearing flags on attachment: 283186 Committed r203013: <http://trac.webkit.org/changeset/203013> 1209363 6 dbates 2016-07-08 17:29:09 -0700 All reviewed patches have been landed. Closing bug. 283186 2016-07-08 12:11:37 -0700 2016-07-08 17:29:04 -0700 Patch bug-158987-20160708121101.patch text/plain 4933 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc1ODFhNzc4MzdmNzI3 YjA4NDQzMGEwOWI1OGY3ZGIxNjAxZjM5Yy4uZmRhN2FjMzRiN2UyZGU0MGMzYWMzZTAzNTViZjhl MWQ4ZGJlZWZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA3LTA4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIHNob3VsZEluaGVy aXRTZWN1cml0eU9yaWdpbkZyb21Pd25lcigpIGZyb20gVVJMIHRvIERvY3VtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg5ODcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgVVJMIGNsYXNzIHNo b3VsZCBub3QgaGF2ZSBrbm93bGVkZ2Ugb2YgdGhlIGNvbmNlcHQgb2YgYW4gb3JpZ2luIG9yIHRo ZSBzZW1hbnRpY3Mgb2Ygb3JpZ2luCisgICAgICAgIGluaGVyaXRhbmNlIGFzIHRoZXNlIGFyZSBo aWdoZXIgbGV2ZWwgY29uY2VwdHMuIFdlIHNob3VsZCBtYWtlIFVSTDo6c2hvdWxkSW5oZXJpdFNl Y3VyaXR5T3JpZ2luRnJvbU93bmVyKCkKKyAgICAgICAgYSBzdGF0aWMgbm9uLW1lbWJlciwgbm9u LWZyaWVuZCBmdW5jdGlvbiBvZiBEb2N1bWVudCBiZWNhdXNlIGl0cyBpbXBsZW1lbnRzIHRoZSBv cmlnaW4gc2VtYW50aWNzCisgICAgICAgIGZvciBhIERvY3VtZW50IG9iamVjdCBhcyBkZXNjcmli ZWQgaW4gc2VjdGlvbiBPcmlnaW4gb2YgdGhlIEhUTUw1IHNwZWMuLCA8aHR0cHM6Ly9odG1sLnNw ZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvYnJvd3NlcnMuaHRtbCNvcmlnaW4+ICg4IEp1bHkgMjAx NikuCisgICAgICAgIFRoZXNlIHNlbWFudGljcyBvbmx5IGFwcGx5IHRvIERvY3VtZW50cy4KKwor ICAgICAgICBObyBmdW5jdGlvbmFsaXR5IGNoYW5nZWQuIFNvLCBubyBuZXcgdGVzdHMuCisKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkSW5oZXJp dFNlY3VyaXR5T3JpZ2luRnJvbU93bmVyKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpEb2N1 bWVudDo6aW5pdFNlY3VyaXR5Q29udGV4dCk6IE1vZGlmaWVkIHRvIGNhbGwgV2ViQ29yZTo6c2hv dWxkSW5oZXJpdFNlY3VyaXR5T3JpZ2luRnJvbU93bmVyKCkuCisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6aW5pdENvbnRlbnRTZWN1cml0eVBvbGljeSk6IERpdHRvLgorICAgICAgICAqIHBs YXRmb3JtL1VSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVUkw6OnNob3VsZEluaGVyaXRTZWN1 cml0eU9yaWdpbkZyb21Pd25lcik6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vVVJMLmg6 CisKIDIwMTYtMDctMDggIE5hZWwgT3VlZHJhb2dvICA8bmFlbC5vdWVkcmFvZ29AY3JmLmNhbm9u LmZyPgogCiAgICAgICAgIEV4ZWNTdGF0ZSBzaG91bGQgYmUgcGFzc2VkIGJ5IHJlZmVyZW5jZSBp biBKUyBiaW5kaW5ncyBnZW5lcmF0b3IgZm9yIGN1c3RvbSBjb25zdHJ1Y3RvcnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IDZkMjc3YWM2MmYyYzg2MjllYzNkNDM2YWFhZTU4ZjhkNDBhZGU1 MzQuLjI0OWUyOWI1YTY5ZTBmMWVlZjNiYThhOWQ3M2U2NTFhMTMwNDQzN2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcApAQCAtNTI0OCw2ICs1MjQ4LDIwIEBAIFJlZlB0cjxYUGF0aFJlc3VsdD4g RG9jdW1lbnQ6OmV2YWx1YXRlKGNvbnN0IFN0cmluZyYgZXhwcmVzc2lvbiwgTm9kZSogY29udGV4 dE5vCiAgICAgcmV0dXJuIG1feHBhdGhFdmFsdWF0b3ItPmV2YWx1YXRlKGV4cHJlc3Npb24sIGNv bnRleHROb2RlLCBXVEZNb3ZlKHJlc29sdmVyKSwgdHlwZSwgcmVzdWx0LCBlYyk7CiB9CiAKK3N0 YXRpYyBib29sIHNob3VsZEluaGVyaXRTZWN1cml0eU9yaWdpbkZyb21Pd25lcihjb25zdCBVUkwm IHVybCkKK3sKKyAgICAvLyBQYXJhcGhyYXNlZCBmcm9tIDxodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnL211bHRpcGFnZS9icm93c2Vycy5odG1sI29yaWdpbj4gKDggSnVseSAyMDE2KQorICAg IC8vCisgICAgLy8gSWYgYSBEb2N1bWVudCBoYXMgdGhlIGFkZHJlc3MgImFib3V0OmJsYW5rIgor ICAgIC8vICAgICAgVGhlIG9yaWdpbiBvZiB0aGUgZG9jdW1lbnQgaXMgdGhlIG9yaWdpbiBpdCB3 YXMgYXNzaWduZWQgd2hlbiBpdHMgYnJvd3NpbmcgY29udGV4dCB3YXMgY3JlYXRlZC4KKyAgICAv LyBJZiBhIERvY3VtZW50IGhhcyB0aGUgYWRkcmVzcyAiYWJvdXQ6c3JjZG9jIgorICAgIC8vICAg ICAgVGhlIG9yaWdpbiBvZiB0aGUgZG9jdW1lbnQgaXMgdGhlIG9yaWdpbiBvZiBpdHMgcGFyZW50 IGRvY3VtZW50LgorICAgIC8vCisgICAgLy8gTm90ZTogV2UgZ2VuZXJhbGl6ZSB0aGlzIHRvIGlu dmFsaWQgVVJMcyBiZWNhdXNlIHdlIHRyZWF0IHN1Y2ggVVJMcyBhcyBhYm91dDpibGFuay4KKyAg ICAvLworICAgIHJldHVybiB1cmwuaXNFbXB0eSgpIHx8IGVxdWFsSWdub3JpbmdBU0NJSUNhc2Uo dXJsLnN0cmluZygpLCBibGFua1VSTCgpKSB8fCBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2Fz ZSh1cmwuc3RyaW5nKCksICJhYm91dDpzcmNkb2MiKTsKK30KKwogdm9pZCBEb2N1bWVudDo6aW5p dFNlY3VyaXR5Q29udGV4dCgpCiB7CiAgICAgaWYgKGhhdmVJbml0aWFsaXplZFNlY3VyaXR5T3Jp Z2luKCkpIHsKQEAgLTUzMDAsNyArNTMxNCw3IEBAIHZvaWQgRG9jdW1lbnQ6OmluaXRTZWN1cml0 eUNvbnRleHQoKQogICAgICAgICBzZXRCYXNlVVJMT3ZlcnJpZGUocGFyZW50RG9jdW1lbnQtPmJh c2VVUkwoKSk7CiAgICAgfQogCi0gICAgaWYgKCFtX3VybC5zaG91bGRJbmhlcml0U2VjdXJpdHlP cmlnaW5Gcm9tT3duZXIoKSkKKyAgICBpZiAoIXNob3VsZEluaGVyaXRTZWN1cml0eU9yaWdpbkZy b21Pd25lcihtX3VybCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIElmIHdlIGRvIG5vdCBv YnRhaW4gYSBtZWFuaW5nZnVsIG9yaWdpbiBmcm9tIHRoZSBVUkwsIHRoZW4gd2UgdHJ5IHRvCkBA IC01MzQzLDcgKzUzNTcsNyBAQCB2b2lkIERvY3VtZW50Ojppbml0U2VjdXJpdHlDb250ZXh0KCkK IAogdm9pZCBEb2N1bWVudDo6aW5pdENvbnRlbnRTZWN1cml0eVBvbGljeSgpCiB7Ci0gICAgaWYg KCFtX2ZyYW1lLT50cmVlKCkucGFyZW50KCkgfHwgKCFtX3VybC5zaG91bGRJbmhlcml0U2VjdXJp dHlPcmlnaW5Gcm9tT3duZXIoKSAmJiAhaXNQbHVnaW5Eb2N1bWVudCgpKSkKKyAgICBpZiAoIW1f ZnJhbWUtPnRyZWUoKS5wYXJlbnQoKSB8fCAoIXNob3VsZEluaGVyaXRTZWN1cml0eU9yaWdpbkZy b21Pd25lcihtX3VybCkgJiYgIWlzUGx1Z2luRG9jdW1lbnQoKSkpCiAgICAgICAgIHJldHVybjsK IAogICAgIGNvbnRlbnRTZWN1cml0eVBvbGljeSgpLT5jb3B5U3RhdGVGcm9tKG1fZnJhbWUtPnRy ZWUoKS5wYXJlbnQoKS0+ZG9jdW1lbnQoKS0+Y29udGVudFNlY3VyaXR5UG9saWN5KCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1VSTC5jcHAKaW5kZXggMDg4MmJhNDRmM2MzNTM1ZDk3ZjUyYzVkYWVlYmI0NzNh NGNiMTdiMy4uZjM3MjViY2VmMDQ1MGNmMWYwNmU3NTZjMzFiMzk4NzE4OTgwNDQwZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9VUkwuY3BwCkBAIC0yMDYyLDEzICsyMDYyLDYgQEAgYm9vbCBVUkw6OmlzQmxh bmtVUkwoKSBjb25zdAogICAgIHJldHVybiBwcm90b2NvbElzKCJhYm91dCIpOwogfQogCi1ib29s IFVSTDo6c2hvdWxkSW5oZXJpdFNlY3VyaXR5T3JpZ2luRnJvbU93bmVyKCkgY29uc3QKLXsKLSAg ICByZXR1cm4gaXNFbXB0eSgpCi0gICAgICAgIHx8IGVxdWFsSWdub3JpbmdBU0NJSUNhc2UobV9z dHJpbmcsIGJsYW5rVVJMKCkuc3RyaW5nKCkpCi0gICAgICAgIHx8IGVxdWFsTGV0dGVyc0lnbm9y aW5nQVNDSUlDYXNlKG1fc3RyaW5nLCAiYWJvdXQ6c3JjZG9jIik7Ci19Ci0KIHR5cGVkZWYgSGFz aE1hcDxTdHJpbmcsIHVuc2lnbmVkIHNob3J0LCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+IERl ZmF1bHRQb3J0c01hcDsKIHN0YXRpYyBjb25zdCBEZWZhdWx0UG9ydHNNYXAmIGRlZmF1bHRQb3J0 c01hcCgpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5oCmluZGV4IGY3N2UyY2M2ZWU1M2Q5ZjkzMWYxNWIz OWM0YzVlY2Y2ODBlZDY1NmQuLmU2ZTJiYTZiZjM3NDFmZmE0NWEwMDFiNzhlMWEzOWJmZjQxZTE3 OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5oCkBAIC0xMzEsNyArMTMxLDYgQEAgcHVibGljOgogICAg IGJvb2wgcHJvdG9jb2xJc0luSFRUUEZhbWlseSgpIGNvbnN0OwogICAgIFdFQkNPUkVfRVhQT1JU IGJvb2wgaXNMb2NhbEZpbGUoKSBjb25zdDsKICAgICBib29sIGlzQmxhbmtVUkwoKSBjb25zdDsK LSAgICBib29sIHNob3VsZEluaGVyaXRTZWN1cml0eU9yaWdpbkZyb21Pd25lcigpIGNvbnN0Owog CiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBzZXRQcm90b2NvbChjb25zdCBTdHJpbmcmKTsKICAg ICB2b2lkIHNldEhvc3QoY29uc3QgU3RyaW5nJik7Cg==