158986 2016-06-21 06:53:28 -0700 WebRTC: Remove unused MediaEndpointClient::gotRemoteSource function 2016-06-21 13:58:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned commit-queue oldest_to_newest 1204125 0 adam.bergkvist 2016-06-21 06:53:28 -0700 Remote sources are explicitly created with MediaEndpoint::createMutedRemoteSource so the MediaEndpointClient::gotRemoteSource should be removed. 1204126 1 281738 adam.bergkvist 2016-06-21 06:56:28 -0700 Created attachment 281738 Proposed patch 1204262 2 281738 adam.bergkvist 2016-06-21 13:37:31 -0700 Comment on attachment 281738 Proposed patch Thanks Eric 1204272 3 281738 commit-queue 2016-06-21 13:58:37 -0700 Comment on attachment 281738 Proposed patch Clearing flags on attachment: 281738 Committed r202293: <http://trac.webkit.org/changeset/202293> 1204273 4 commit-queue 2016-06-21 13:58:41 -0700 All reviewed patches have been landed. Closing bug. 281738 2016-06-21 06:56:28 -0700 2016-06-21 13:58:37 -0700 Proposed patch remove-got-remote-source_0.patch text/plain 3146 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNDZkNmViLi4wYzFjZTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTYtMDYtMjEgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFdlYlJUQzogUmVtb3ZlIHVudXNlZCBNZWRpYUVuZHBvaW50Q2xpZW50 Ojpnb3RSZW1vdGVTb3VyY2UgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1ODk4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW90ZSBzb3VyY2VzIGFyZSBleHBsaWNpdGx5IGNyZWF0ZWQg d2l0aCBNZWRpYUVuZHBvaW50OjpjcmVhdGVNdXRlZFJlbW90ZVNvdXJjZSBzbyB0aGUKKyAgICAg ICAgTWVkaWFFbmRwb2ludENsaWVudDo6Z290UmVtb3RlU291cmNlIGNhbiBiZSByZW1vdmVkLgor CisgICAgICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIE1vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlvbjo6Z290UmVtb3RlU291cmNlKTogRGVsZXRl ZC4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVj dGlvbi5oOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnQuaDoK KwogMjAxNi0wNi0xOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgVXNlIHRpbWUgbGl0ZXJhbHMgaW4gV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5l Y3Rpb24uY3BwCmluZGV4IDViYWI1OGYuLjcxMTA0YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVy Q29ubmVjdGlvbi5jcHAKQEAgLTgwNiwxNiArODA2LDYgQEAgdm9pZCBNZWRpYUVuZHBvaW50UGVl ckNvbm5lY3Rpb246OmRvbmVHYXRoZXJpbmdDYW5kaWRhdGVzKHVuc2lnbmVkIG1kZXNjSW5kZXgp CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAotdm9pZCBNZWRpYUVuZHBvaW50UGVlckNvbm5l Y3Rpb246OmdvdFJlbW90ZVNvdXJjZSh1bnNpZ25lZCBtZGVzY0luZGV4LCBSZWZQdHI8UmVhbHRp bWVNZWRpYVNvdXJjZT4mJiBzb3VyY2UpCi17Ci0gICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK LQotICAgIFVOVVNFRF9QQVJBTShtZGVzY0luZGV4KTsKLSAgICBVTlVTRURfUEFSQU0oc291cmNl KTsKLQotICAgIG5vdEltcGxlbWVudGVkKCk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK IAogI2VuZGlmIC8vIEVOQUJMRShXRUJfUlRDKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uaCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFFbmRwb2ludFBlZXJDb25uZWN0aW9u LmgKaW5kZXggY2Y3NmI1Zi4uN2I0NjlmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50UGVlckNvbm5lY3Rpb24uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnRQZWVyQ29ubmVjdGlv bi5oCkBAIC0xMDcsNyArMTA3LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIGdvdER0bHNGaW5nZXJw cmludChjb25zdCBTdHJpbmcmIGZpbmdlcnByaW50LCBjb25zdCBTdHJpbmcmIGZpbmdlcnByaW50 RnVuY3Rpb24pIG92ZXJyaWRlOwogICAgIHZvaWQgZ290SWNlQ2FuZGlkYXRlKHVuc2lnbmVkIG1k ZXNjSW5kZXgsIFJlZlB0cjxJY2VDYW5kaWRhdGU+JiYpIG92ZXJyaWRlOwogICAgIHZvaWQgZG9u ZUdhdGhlcmluZ0NhbmRpZGF0ZXModW5zaWduZWQgbWRlc2NJbmRleCkgb3ZlcnJpZGU7Ci0gICAg dm9pZCBnb3RSZW1vdGVTb3VyY2UodW5zaWduZWQgbWRlc2NJbmRleCwgUmVmUHRyPFJlYWx0aW1l TWVkaWFTb3VyY2U+JiYpIG92ZXJyaWRlOwogCiAgICAgUGVlckNvbm5lY3Rpb25CYWNrZW5kQ2xp ZW50KiBtX2NsaWVudDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8TWVkaWFFbmRwb2ludD4gbV9tZWRp YUVuZHBvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vTWVkaWFFbmRwb2ludC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v TWVkaWFFbmRwb2ludC5oCmluZGV4IDZkMmQ2MWIuLmEwOGU1NjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhRW5kcG9pbnQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYUVuZHBvaW50LmgKQEAgLTUwLDcg KzUwLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBnb3REdGxzRmluZ2VycHJpbnQoY29u c3QgU3RyaW5nJiBmaW5nZXJwcmludCwgY29uc3QgU3RyaW5nJiBmaW5nZXJwcmludEZ1bmN0aW9u KSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGdvdEljZUNhbmRpZGF0ZSh1bnNpZ25lZCBtZGVzY0lu ZGV4LCBSZWZQdHI8SWNlQ2FuZGlkYXRlPiYmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRvbmVH YXRoZXJpbmdDYW5kaWRhdGVzKHVuc2lnbmVkIG1kZXNjSW5kZXgpID0gMDsKLSAgICB2aXJ0dWFs IHZvaWQgZ290UmVtb3RlU291cmNlKHVuc2lnbmVkIG1kZXNjSW5kZXgsIFJlZlB0cjxSZWFsdGlt ZU1lZGlhU291cmNlPiYmKSA9IDA7CiAKICAgICB2aXJ0dWFsIH5NZWRpYUVuZHBvaW50Q2xpZW50 KCkgeyB9CiB9Owo=