158970 2016-06-20 18:52:14 -0700 [iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry) 2016-06-21 15:20:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser enrica rniwa simon.fraser oldest_to_newest 1203978 0 simon.fraser 2016-06-20 18:52:14 -0700 [iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry) 1203979 1 281692 simon.fraser 2016-06-20 18:53:29 -0700 Created attachment 281692 Patch 1203981 2 simon.fraser 2016-06-20 18:55:07 -0700 *** Bug 158969 has been marked as a duplicate of this bug. *** 1204037 3 281692 rniwa 2016-06-20 21:07:37 -0700 Comment on attachment 281692 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281692&action=review > Source/WebCore/editing/Editor.cpp:1210 > + SelectionRevealMode revealMode = SelectionRevealMode::Reveal; > +#if PLATFORM(IOS) > + revealMode = SelectionRevealMode::RevealUpToMainFrame; > +#endif Can we instead do #if PLATFORM(IOS) #else? I think that'll make the semantics clear. Also, we can use auto here. 1204038 4 rniwa 2016-06-20 21:09:41 -0700 <rdar://problem/26805722> 1204320 5 simon.fraser 2016-06-21 15:20:59 -0700 https://trac.webkit.org/r202295 281692 2016-06-20 18:53:29 -0700 2016-06-20 21:07:37 -0700 Patch bug-158970-20160620185322.patch text/plain 6475 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMyYTE1NDIzMzNhYjFj MDYzZjgyYmU3YjFjYjhkODAwNTRlYzkyMC4uYmVjNGVjNWViZmE1MGRkY2I0Nzc3MjkyZjFjZjQ0 ZDUxMTVmNzQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA2LTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIFR5cGlu ZyB0ZXh0IGludG8gYSB0ZXh0IGZpZWxkIG9yIHRleHQgYXJlYSBjYXVzZXMgc2NyZWVuIHRvIHNj cm9sbCBkb3duIChoaWRpbmcgdGV4dCBlbnRyeSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODk3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaW5zZXJ0VGV4dFdpdGhvdXRTZW5kaW5nVGV4 dEV2ZW50KCkgc2hvdWxkIG9ubHkgcmV2ZWFsIHRoZSBzZWxlY3Rpb24gdXAgdG8gdGhlIG1haW4g ZnJhbWUgb24gaU9TLAorICAgICAgICBzaW5jZSB0aGUgVUkgcHJvY2VzcyBjYW4gem9vbSBhbmQg c2Nyb2xsIHRoZSB2aWV3IHRvIHRoZSB0ZXh0IGlucHV0LgorCisgICAgICAgIFRlc3Q6IGZhc3Qv Zm9ybXMvaW9zL3R5cGluZy1pbi1pbnB1dC1pbi1pZnJhbWUuaHRtbAorCisgICAgICAgICogZWRp dGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjppbnNlcnRUZXh0V2l0 aG91dFNlbmRpbmdUZXh0RXZlbnQpOgorCisyMDE2LTA2LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEZvY3VzIGV2ZW50IGRpc3BhdGNoZWQgaW4g aWZyYW1lIGNhdXNlcyBwYXJlbnQgZG9jdW1lbnQgdG8gc2Nyb2xsIGluY29ycmVjdGx5CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg2MjkKICAgICAg ICAgcmRhcjovL3Byb2JsZW0vMjY1MjE2MTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAppbmRl eCBjZDdmZjUzN2FmZWRjYzViNmJjOTUyZGM3ZTljOTliNDAyZGFjNjZmLi44ZmFhYjI5ODRhYTQ2 MGQxMWQyN2VlZmVhMTFlMDU4MzQwM2IxNDMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0VkaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3Bw CkBAIC0xMjAzLDggKzEyMDMsMTMgQEAgYm9vbCBFZGl0b3I6Omluc2VydFRleHRXaXRob3V0U2Vu ZGluZ1RleHRFdmVudChjb25zdCBTdHJpbmcmIHRleHQsIGJvb2wgc2VsZWN0SW4KIAogICAgICAg ICAgICAgLy8gUmV2ZWFsIHRoZSBjdXJyZW50IHNlbGVjdGlvbgogICAgICAgICAgICAgaWYgKEZy YW1lKiBlZGl0ZWRGcmFtZSA9IGRvY3VtZW50LT5mcmFtZSgpKQotICAgICAgICAgICAgICAgIGlm IChQYWdlKiBwYWdlID0gZWRpdGVkRnJhbWUtPnBhZ2UoKSkKLSAgICAgICAgICAgICAgICAgICAg cGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCkuc2VsZWN0aW9uKCku cmV2ZWFsU2VsZWN0aW9uKFNlbGVjdGlvblJldmVhbE1vZGU6OlJldmVhbCwgU2Nyb2xsQWxpZ25t ZW50OjphbGlnbkNlbnRlcklmTmVlZGVkKTsKKyAgICAgICAgICAgICAgICBpZiAoUGFnZSogcGFn ZSA9IGVkaXRlZEZyYW1lLT5wYWdlKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgU2VsZWN0aW9u UmV2ZWFsTW9kZSByZXZlYWxNb2RlID0gU2VsZWN0aW9uUmV2ZWFsTW9kZTo6UmV2ZWFsOworI2lm IFBMQVRGT1JNKElPUykKKyAgICAgICAgICAgICAgICAgICAgcmV2ZWFsTW9kZSA9IFNlbGVjdGlv blJldmVhbE1vZGU6OlJldmVhbFVwVG9NYWluRnJhbWU7CisjZW5kaWYKKyAgICAgICAgICAgICAg ICAgICAgcGFnZS0+Zm9jdXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCkuc2VsZWN0 aW9uKCkucmV2ZWFsU2VsZWN0aW9uKHJldmVhbE1vZGUsIFNjcm9sbEFsaWdubWVudDo6YWxpZ25D ZW50ZXJJZk5lZWRlZCk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggYTYwYzEzOWI1MDZiYTc5YzUwMzA5NjNkZmNlZDA4YjEzYzhhZWM1MS4uZDY3Yjg3NmMw NTg4YjhmMTIyMGEzNmI5MWQ3NmU0YjVjNjYwZDkyZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAy MDE2LTA2LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAg ICAgIFtpT1NdIFR5cGluZyB0ZXh0IGludG8gYSB0ZXh0IGZpZWxkIG9yIHRleHQgYXJlYSBjYXVz ZXMgc2NyZWVuIHRvIHNjcm9sbCBkb3duIChoaWRpbmcgdGV4dCBlbnRyeSkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODk3MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGVzdCB0aGF0IGZv Y3VzZXMgYW4gaW5wdXQgaW4gYSBmcmFtZSBhbmQgdGhlbiB0eXBlcyBhIGNoYXJhY3RlciwgdGhl biBjaGVja3MgZm9yIHNjcm9sbGluZy4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL3R5cGlu Zy1pbi1pbnB1dC1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2Zvcm1zL2lvcy90eXBpbmctaW4taW5wdXQtaW4taWZyYW1lLmh0bWw6IEFkZGVkLgorCisyMDE2 LTA2LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAg IEZvY3VzIGV2ZW50IGRpc3BhdGNoZWQgaW4gaWZyYW1lIGNhdXNlcyBwYXJlbnQgZG9jdW1lbnQg dG8gc2Nyb2xsIGluY29ycmVjdGx5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTg2MjkKICAgICAgICAgcmRhcjovL3Byb2JsZW0vMjY1MjE2MTYKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL3R5cGluZy1pbi1pbnB1dC1pbi1p ZnJhbWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvdHlwaW5nLWlu LWlucHV0LWluLWlmcmFtZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOThkNGRkZmVjNjJiYTE5 YjVmZDVkZTk2MzgyYTYwYTMxNjkzZjNlYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW9zL3R5cGluZy1pbi1pbnB1dC1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsNSBAQAorVGVzdHMgdGhhdCB0eXBpbmcgaW50byBhIHRleHQgaW5wdXQgaW4gYW4g aWZyYW1lIHNob3VsZCBub3Qgc2Nyb2xsLgorCitQQVNTOiBwYWdlIGRpZCBub3Qgc2Nyb2xsLgor Q2xpY2sgdG8gZm9jdXMgaW5wdXQKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9pb3MvdHlwaW5nLWluLWlucHV0LWluLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pb3MvdHlwaW5nLWluLWlucHV0LWluLWlmcmFtZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNhZTlm MGIxY2FkMDRiZmNiMzZhYTBlZGM2MTkzMWZlMmJlMTZkNzUKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy90eXBpbmctaW4taW5wdXQtaW4taWZyYW1lLmh0bWwK QEAgLTAsMCArMSw4OSBAQAorPCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVy IFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlIF0gLS0+CisKKzxodG1sPgorPGhlYWQ+CisgICAg PG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9ImluaXRpYWwtc2NhbGU9MC41Ij4KKyAgICA8 c3R5bGU+CisgICAgICAgIGJ1dHRvbiB7CisgICAgICAgICAgICBkaXNwbGF5OiBibG9jazsKKyAg ICAgICAgfQorICAgICAgICBpZnJhbWUgeworICAgICAgICAgICAgbWFyZ2luLXRvcDogODAwcHg7 CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIAorICAgIDxzY3JpcHQgc3JjPSJyZXNvdXJj ZXMvem9vbWluZy10ZXN0LXV0aWxzLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgaWYgKHdp bmRvdy5pbnRlcm5hbHMpCisgICAgICAgIGludGVybmFscy5zZXR0aW5ncy5zZXRGcmFtZUZsYXR0 ZW5pbmdFbmFibGVkKHRydWUpOworCisgICAgZnVuY3Rpb24gZ2V0VHlwaW5nVUlTY3JpcHQoKQor ICAgIHsKKyAgICAgICAgcmV0dXJuIGAKKyAgICAgICAgICAgIChmdW5jdGlvbigpIHsKKyAgICAg ICAgICAgICAgICB1aUNvbnRyb2xsZXIudHlwZUNoYXJhY3RlclVzaW5nSGFyZHdhcmVLZXlib2Fy ZCgnYScsIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIudWlT Y3JpcHRDb21wbGV0ZSgpOworICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSkoKTtg CisgICAgfQorCisgICAgZnVuY3Rpb24gYnV0dG9uQ2xpY2tlZCgpCisgICAgeworICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZnJhbWUnKS5jb250ZW50RG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2lucHV0JykuZm9jdXMoKTsKKyAgICB9CisgICAgCisgICAgZnVuY3Rpb24gcGFnZURp ZFNjcm9sbCgpCisgICAgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0 JykudGV4dENvbnRlbnQgPSAnRkFJTDogcGFnZSBzY3JvbGxlZCB0byAnICsgZG9jdW1lbnQuc2Ny b2xsaW5nRWxlbWVudC5zY3JvbGxUb3A7CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdFR5cGlu ZygpCisgICAgeworICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignc2Nyb2xsJywgcGFn ZURpZFNjcm9sbCwgZmFsc2UpOworCisgICAgICAgIHZhciB1aVNjcmlwdCA9IGdldFR5cGluZ1VJ U2NyaXB0KCk7CisgICAgICAgIHRlc3RSdW5uZXIucnVuVUlTY3JpcHQodWlTY3JpcHQsIGZ1bmN0 aW9uKCkgeworICAgICAgICAgICAgLy8gV2FpdCBmb3IgYW55IHNjcm9sbCB0byBoYXBwZW4uCisg ICAgICAgICAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIu bm90aWZ5RG9uZSgpOworICAgICAgICAgICAgfSwgMTAwKTsKKyAgICAgICAgfSk7CisgICAgfQor CisgICAgZnVuY3Rpb24gZG9UZXN0KCkKKyAgICB7CisgICAgICAgIC8vIEdldCB0aGUgdGV4dCBm aWVsZCBmb2N1c2VkIHZpYSBhIHVzZXIgZXZlbnQgc28gd2Ugem9vbSB0byBpdC4KKyAgICAgICAg dmFyIHBvaW50ID0gZ2V0UG9pbnRJbnNpZGVFbGVtZW50KGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0YXJnZXQnKSwgMTAsIDEwKTsKKworICAgICAgICB2YXIgdWlTY3JpcHQgPSB6b29tQWZ0ZXJT aW5nbGVUYXBVSVNjcmlwdChwb2ludC54LCBwb2ludC55LCB0cnVlKTsKKyAgICAgICAgdGVzdFJ1 bm5lci5ydW5VSVNjcmlwdCh1aVNjcmlwdCwgZnVuY3Rpb24ocmVzdWx0KSB7CisgICAgICAgICAg ICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICB0ZXN0VHlw aW5nKCk7CisgICAgICAgICAgICB9LCAwKTsKKyAgICAgICAgfSk7CisgICAgfQorCisgICAgd2lu ZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3QsIGZhbHNlKTsKKyAgICA8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorCis8cD5UZXN0cyB0aGF0IHR5cGluZyBpbnRvIGEgdGV4dCBp bnB1dCBpbiBhbiBpZnJhbWUgc2hvdWxkIG5vdCBzY3JvbGwuPC9wPgorPGRpdiBpZD0icmVzdWx0 Ij4KKyAgICBQQVNTOiBwYWdlIGRpZCBub3Qgc2Nyb2xsLgorPC9kaXY+CisKKzxidXR0b24gaWQ9 InRhcmdldCIgb25jbGljaz0iYnV0dG9uQ2xpY2tlZCgpIj5DbGljayB0byBmb2N1cyBpbnB1dDwv YnV0dG9uPgorCis8aWZyYW1lIGlkPSJmcmFtZSIgc3JjZG9jPSI8c3R5bGU+aW5wdXQgeyBtYXJn aW46IDQwMHB4IDIwcHg7IH08L3N0eWxlPgorPGlucHV0IGlkPSdpbnB1dCcgdHlwZT0ndGV4dCc+ CisiPjwvaWZyYW1lPgorCis8L2JvZHk+Cis8L2h0bWw+Cg==