158886 2016-06-17 14:10:16 -0700 REGRESSION: Double tap to zoom does not work on yahoo finance 2016-06-22 15:52:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 158946 1 dino dino commit-queue oldest_to_newest 1203412 0 dino 2016-06-17 14:10:16 -0700 REGRESSION: Double tap to zoom does not work on yahoo finance 1203413 1 dino 2016-06-17 14:10:43 -0700 <rdar://problem/24917760> 1203418 2 281589 dino 2016-06-17 14:21:08 -0700 Created attachment 281589 Patch 1203419 3 dino 2016-06-17 14:22:25 -0700 Committed r202179: <http://trac.webkit.org/changeset/202179> 1203770 4 ap 2016-06-20 10:11:38 -0700 The test passes on open source bots, but either fails or times out 100% of the time on internal ones. I'll have to roll out. Will send links over e-mail. 1203789 5 ap 2016-06-20 10:40:24 -0700 Ugh, can't roll out using webkitbot, and don't have the time for manual rollout right now :( 1203793 6 commit-queue 2016-06-20 10:47:32 -0700 Re-opened since this is blocked by bug 158946 1203880 7 ap 2016-06-20 13:40:42 -0700 Rolled out in r202239. 1204701 8 dino 2016-06-22 15:52:44 -0700 Committed r202354: <http://trac.webkit.org/changeset/202354> 281589 2016-06-17 14:21:08 -0700 2016-06-17 14:21:28 -0700 Patch bug-158886-20160617142104.patch text/plain 6123 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTdmZjM0MmI0YzFkNzY1 OTU2MThmOTExOTJjNWM1ZjdmMjBkZjFjMi4uNGEyNjE2YjI0OGFmNjg0OTA2OTVlZWRhMGM3ZWI0 ZGEzOGFkMjVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA2LTE3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBEb3VibGUg dGFwIHRvIHpvb20gZG9lcyBub3Qgd29yayBvbiB5YWhvbyBmaW5hbmNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg4ODYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI0OTE3NzYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K KworICAgICAgICBXZSBzaG91bGRuJ3QgZW5hYmxlIGZhc3QgY2xpY2sgb24gcGFnZXMgdGhhdCBo YXZlCisgICAgICAgIGhhZCB0byBzaHJpbmsgdG8gZml0LiBJbiBvdGhlciB3b3Jkcywgd2Ugc2hv dWxkIGVuYWJsZQorICAgICAgICBkb3VibGUtdGFwLXRvLXpvb20gaWYgdGhlIHBhZ2UgaGFzIGFs cmVhZHkgem9vbWVkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2lvcy92aWV3cG9ydC1z aHJpbmstdG8tZml0LWFsbG93cy1kb3VibGUtdGFwLmh0bWwKKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2FsbG93c0Rv dWJsZVRhcEdlc3R1cmVzXSk6CisKIDIwMTYtMDYtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3NlIF9zaG91bGRFeHBhbmRDb250ZW50VG9W aWV3SGVpZ2h0Rm9yQXV0b0xheW91dCBTUEkgb24gV0tXZWJWaWV3CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDE2M2Y1YjMwMmUwYjNh OWI1NzI1ODg3OWFhNzY1MDg5MDdjNjNjNjkuLjI3NzAyYzFjZGI2N2FhNWIwOGU2YzMzMzE2NDA4 ZWJlZmUyYzUzYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tCkBAIC0xNzM1LDExICsxNzM1LDE2IEBAIHN0YXRpYyBXZWJDb3JlOjpGbG9h dFBvaW50IGNvbnN0cmFpbkNvbnRlbnRPZmZzZXQoV2ViQ29yZTo6RmxvYXRQb2ludCBjb250ZW50 T2ZmCiAgICAgaWYgKCFfdmlld3BvcnRNZXRhVGFnV2lkdGhXYXNFeHBsaWNpdCB8fCBfdmlld3Bv cnRNZXRhVGFnQ2FtZUZyb21JbWFnZURvY3VtZW50KQogICAgICAgICByZXR1cm4gWUVTOwogCi0g ICAgLy8gRm9yIHNjYWxhYmxlIHZpZXdwb3J0cywgb25seSBkaXNhYmxlIGRvdWJsZSB0YXAgZ2Vz dHVyZXMgaWYgdGhlIHZpZXdwb3J0IHdpZHRoIGlzIGRldmljZSB3aWR0aC4KKyAgICAvLyBJZiB0 aGUgcGFnZSBzZXQgYSB2aWV3cG9ydCB3aWR0aCB0aGF0IHdhc24ndCB0aGUgZGV2aWNlIHdpZHRo LCB0aGVuIGl0IHdhcworICAgIC8vIHNjYWxlZCBhbmQgdGh1cyB3aWxsIHByb2JhYmx5IG5lZWQg dG8gem9vbS4KICAgICBpZiAoX3ZpZXdwb3J0TWV0YVRhZ1dpZHRoICE9IFdlYkNvcmU6OlZpZXdw b3J0QXJndW1lbnRzOjpWYWx1ZURldmljZVdpZHRoKQogICAgICAgICByZXR1cm4gWUVTOwogCi0g ICAgcmV0dXJuICFhcmVFc3NlbnRpYWxseUVxdWFsQXNGbG9hdChjb250ZW50Wm9vbVNjYWxlKHNl bGYpLCBfaW5pdGlhbFNjYWxlRmFjdG9yKTsKKyAgICAvLyBBdCB0aGlzIHBvaW50LCB3ZSBoYXZl IGEgcGFnZSB0aGF0IGFza2VkIGZvciB3aWR0aCA9IGRldmljZS13aWR0aC4gSG93ZXZlciwKKyAg ICAvLyBpZiB0aGUgY29udGVudCdzIHdpZHRoIGFuZCBoZWlnaHQgd2VyZSBsYXJnZSwgd2UgbWln aHQgaGF2ZSBoYWQgdG8gc2hyaW5rIGl0LgorICAgIC8vIFNpbmNlIHdlJ2xsIGVuYWJsZSBkb3Vi bGUgdGFwIHpvb20gd2hlbmV2ZXIgd2UncmUgbm90IGF0IHRoZSBhY3R1YWwKKyAgICAvLyBpbml0 aWFsIHNjYWxlLCB0aGlzIHNpbXBseSBiZWNvbWVzIGEgdGVzdCBvZiB0aGUgY3VycmVudCBzY2Fs ZSBhZ2FpbnN0IDEuCisgICAgcmV0dXJuICFhcmVFc3NlbnRpYWxseUVxdWFsQXNGbG9hdChjb250 ZW50Wm9vbVNjYWxlKHNlbGYpLCAxKTsKIH0KIAogI3ByYWdtYSBtYXJrIC0gVUlTY3JvbGxWaWV3 RGVsZWdhdGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCBjMDRhOGEzZDFjMTNiMjZhMjU2YmI2NDA2MTlhZmM2ZWVlYzVjM2E0 Li5iZTNjM2E2ODQ2MWQzODZhZjQ5OTYyYWVkNTBhMTgwOTM3Y2JiYmU1IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTYtMDYtMTcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT046IERvdWJsZSB0YXAgdG8gem9vbSBkb2VzIG5vdCB3b3JrIG9uIHlh aG9vIGZpbmFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1ODg4NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQ5MTc3NjA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgICogZmFzdC9ldmVudHMvaW9zL3Zp ZXdwb3J0LXNocmluay10by1maXQtYWxsb3dzLWRvdWJsZS10YXAtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3Mvdmlld3BvcnQtc2hyaW5rLXRvLWZpdC1hbGxv d3MtZG91YmxlLXRhcC5odG1sOiBBZGRlZC4KKwogMjAxNi0wNi0xNiAgRGVhbiBKYWNrc29uICA8 ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgW21hY10gTGF5b3V0VGVzdCB0cmFuc2Zvcm1zL3Vu ZGVjb21wb3NhYmxlLmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9pb3Mvdmlld3BvcnQtc2hyaW5rLXRvLWZpdC1hbGxvd3MtZG91Ymxl LXRhcC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mvdmlld3BvcnQt c2hyaW5rLXRvLWZpdC1hbGxvd3MtZG91YmxlLXRhcC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MTIzMDI3MzZlYjQwY2I0YTA1MmQyMmI3ZTVmNWZjMzRiZjc4NjAxOQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy92aWV3cG9ydC1zaHJpbmstdG8tZml0LWFs bG93cy1kb3VibGUtdGFwLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1RoZSB2aWV3cG9y dCB6b29tZWQgdG8gc2NhbGU6IDEuNgorVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBhIHBhZ2Ugd2l0 aCB3aWR0aD1kZXZpY2Utd2lkdGggYnV0IGNvbnRlbnQgdGhhdCBjYXVzZXMgYSBzaHJpbmstdG8t Zml0IHdpbGwgbm90IGJsb2NrIGRvdWJsZS10YXAtdG8tem9vbS4gSXQgcnVucyBhdXRvbWF0aWNh bGx5IGluIFdlYktpdCB0ZXN0cy4gSWYgeW91J3JlIHZpZXdpbmcgdGhpcyBtYW51YWxseSwgZG91 YmxlIHRhcCBvbiB0aGlzIHRleHQgYW5kIHRoZSBwYWdlIHNob3VsZCB6b29tIGluLgorCitUaGlz IGlzIGFuIGVsZW1lbnQgdGhhdCB3aWxsIGNhdXNlIHNocmlua2FnZS4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy92aWV3cG9ydC1zaHJpbmstdG8tZml0LWFsbG93cy1k b3VibGUtdGFwLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mvdmlld3BvcnQtc2hy aW5rLXRvLWZpdC1hbGxvd3MtZG91YmxlLXRhcC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmVmY2IwZjBlMTM1 MTZlYjVhM2E4OTU5Mzc3ODIzNjBkNDhmNzliYzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9pb3Mvdmlld3BvcnQtc2hyaW5rLXRvLWZpdC1hbGxvd3MtZG91Ymxl LXRhcC5odG1sCkBAIC0wLDAgKzEsNjEgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10 ZXN0LXJ1bm5lciBbIHVzZUZsZXhpYmxlVmlld3BvcnQ9dHJ1ZSBdIC0tPgorCis8aHRtbD4KKzxt ZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiPgorPGhlYWQ+ CisgICAgPHNjcmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAg ICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIud2Fp dFVudGlsRG9uZSgpOworICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gZ2V0VUlTY3JpcHQo KQorICAgICAgICB7CisgICAgICAgICAgICByZXR1cm4gYAorICAgICAgICAgICAgICAgIChmdW5j dGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLmRpZEVuZFpvb21pbmdD YWxsYmFjayA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgICAgICAgICAgdWlDb250cm9s bGVyLnVpU2NyaXB0Q29tcGxldGUodWlDb250cm9sbGVyLnpvb21TY2FsZSk7CisgICAgICAgICAg ICAgICAgICAgIH07CisgICAgICAgICAgICAgICAgICAgIHVpQ29udHJvbGxlci5kb3VibGVUYXBB dFBvaW50KDE1LCAxNSwgZnVuY3Rpb24oKSB7fSk7CisgICAgICAgICAgICAgICAgfSkoKTtgOwor ICAgICAgICB9CisKKyAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgpCisgICAgICAgIHsKKyAgICAg ICAgICAgIGlmICghd2luZG93LmV2ZW50U2VuZGVyIHx8ICF0ZXN0UnVubmVyLnJ1blVJU2NyaXB0 KQorICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgdGVzdFJ1bm5lci5ydW5V SVNjcmlwdChnZXRVSVNjcmlwdCgpLCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuaW5uZXJUZXh0ID0gIlRoZSB2aWV3 cG9ydCB6b29tZWQgdG8gc2NhbGU6ICIgKyByZXN1bHQ7CisgICAgICAgICAgICAgICAgdGVzdFJ1 bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfQorICAgIDwvc2Ny aXB0PgorICAgIDxzdHlsZT4KKyAgICAgICAgYm9keSB7CisgICAgICAgICAgICBtYXJnaW46IDA7 CisgICAgICAgICAgICBtaW4td2lkdGg6IDgwMHB4OworICAgICAgICB9CisgICAgICAgIHAgewor ICAgICAgICAgICAgd2lkdGg6IDMwMHB4OworICAgICAgICB9CisgICAgICAgICN0YXJnZXQgewor ICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAg ICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsKKyAgICAgICAgfQorICAgIDwvc3R5 bGU+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8ZGl2IGlkPSJ0YXJnZXQi PjwvZGl2PgorPHA+CisgICAgVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBhIHBhZ2Ugd2l0aCB3aWR0 aD1kZXZpY2Utd2lkdGggYnV0IGNvbnRlbnQgdGhhdAorICAgIGNhdXNlcyBhIHNocmluay10by1m aXQgd2lsbCBub3QgYmxvY2sgZG91YmxlLXRhcC10by16b29tLiBJdCBydW5zIGF1dG9tYXRpY2Fs bHkKKyAgICBpbiBXZWJLaXQgdGVzdHMuIElmIHlvdSdyZSB2aWV3aW5nIHRoaXMgbWFudWFsbHks IGRvdWJsZSB0YXAgb24gdGhpcyB0ZXh0IGFuZAorICAgIHRoZSBwYWdlIHNob3VsZCB6b29tIGlu LgorPC9wPgorPHAgc3R5bGU9ImhlaWdodDogMzAwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiAjZjBl MGYwIj4KKyAgICBUaGlzIGlzIGFuIGVsZW1lbnQgdGhhdCB3aWxsIGNhdXNlIHNocmlua2FnZS4K KzwvcD4KKzwvYm9keT4KKzwvaHRtbD4K