158879 2016-06-17 11:15:04 -0700 Potential null dereferencing on a detached positioned renderer. 2016-06-17 13:21:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1203347 0 zalan 2016-06-17 11:15:04 -0700 in RenderBlock::markFixedPositionObjectForLayoutIfNeeded() 1203385 1 281578 zalan 2016-06-17 12:44:00 -0700 Created attachment 281578 Patch 1203386 2 281578 simon.fraser 2016-06-17 12:47:33 -0700 Comment on attachment 281578 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281578&action=review > Source/WebCore/ChangeLog:5 > + https://bugs.webkit.org/show_bug.cgi?id=158879 > + Radar? 1203395 3 281578 commit-queue 2016-06-17 13:21:18 -0700 Comment on attachment 281578 Patch Clearing flags on attachment: 281578 Committed r202177: <http://trac.webkit.org/changeset/202177> 1203396 4 commit-queue 2016-06-17 13:21:22 -0700 All reviewed patches have been landed. Closing bug. 281578 2016-06-17 12:44:00 -0700 2016-06-17 13:21:18 -0700 Patch bug-158879-20160617124357.patch text/plain 4350 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgwZTZiMzVmY2RkNmVl M2E0ZTMzZGExZDQxNDdhZTFhYjdjNjVjZC4uNGNhYzdhYjU1NjMzZDJlOTQwYTUyOTFhMzE0YTVi MDc3NTlmNGZlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA2LTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUG90ZW50aWFsIG51bGwgZGVy ZWZlcmVuY2luZyBvbiBhIGRldGFjaGVkIHBvc2l0aW9uZWQgcmVuZGVyZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg4NzkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRo ZSBjYXNlIHdoZW4gdGhlIHdoaWxlIGxvb3AgdG8gc2VhcmNoIGZvciB0aGUgYWJzb2x1dGUgcG9z aXRpb25lZCBhbmNlc3RvcgorICAgICAgICByZXR1cm5zIG51bGwgKGl0IGhhcHBlbnMgd2hlbiBw b3NpdGlvbmVkIHJlbmRlcmVyIGhhcyBiZWVuIGRldGFjaGVkIGZyb20gdGhlIHJlbmRlciB0cmVl KS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXguCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6Om1hcmtGaXhlZFBv c2l0aW9uT2JqZWN0Rm9yTGF5b3V0SWZOZWVkZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCbG9jay5oOgorCiAyMDE2LTA2LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRGVjb3VwbGUgdGhlIHBlcmNlbnQgaGVpZ2h0IGFuZCBwb3NpdGlvbmVkIGRl c2NlbmRhbnRzIG1hcHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApp bmRleCBlY2YxODhlODNlZGY1MDM4NzgwNTUyZmQyNmFmNTYzNGYwYjg2ZWRlLi5lMzU0NjAzMTk1 MDMyNThjZjI5Zjc0M2E1Yjg0MTBmZjI0ZTllZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHAKQEAgLTEzOTIsMzQgKzEzOTIsMzMgQEAgYm9vbCBSZW5kZXJCbG9j azo6c2ltcGxpZmllZExheW91dCgpCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgUmVuZGVy QmxvY2s6Om1hcmtGaXhlZFBvc2l0aW9uT2JqZWN0Rm9yTGF5b3V0SWZOZWVkZWQoUmVuZGVyT2Jq ZWN0JiBjaGlsZCkKK3ZvaWQgUmVuZGVyQmxvY2s6Om1hcmtGaXhlZFBvc2l0aW9uT2JqZWN0Rm9y TGF5b3V0SWZOZWVkZWQoUmVuZGVyQm94JiBwb3NpdGlvbmVkQ2hpbGQpCiB7Ci0gICAgaWYgKGNo aWxkLnN0eWxlKCkucG9zaXRpb24oKSAhPSBGaXhlZFBvc2l0aW9uKQorICAgIGlmIChwb3NpdGlv bmVkQ2hpbGQuc3R5bGUoKS5wb3NpdGlvbigpICE9IEZpeGVkUG9zaXRpb24pCiAgICAgICAgIHJl dHVybjsKIAotICAgIGJvb2wgaGFzU3RhdGljQmxvY2tQb3NpdGlvbiA9IGNoaWxkLnN0eWxlKCku aGFzU3RhdGljQmxvY2tQb3NpdGlvbihpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKTsKLSAgICBi b29sIGhhc1N0YXRpY0lubGluZVBvc2l0aW9uID0gY2hpbGQuc3R5bGUoKS5oYXNTdGF0aWNJbmxp bmVQb3NpdGlvbihpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKTsKKyAgICBib29sIGhhc1N0YXRp Y0Jsb2NrUG9zaXRpb24gPSBwb3NpdGlvbmVkQ2hpbGQuc3R5bGUoKS5oYXNTdGF0aWNCbG9ja1Bv c2l0aW9uKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpOworICAgIGJvb2wgaGFzU3RhdGljSW5s aW5lUG9zaXRpb24gPSBwb3NpdGlvbmVkQ2hpbGQuc3R5bGUoKS5oYXNTdGF0aWNJbmxpbmVQb3Np dGlvbihpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKTsKICAgICBpZiAoIWhhc1N0YXRpY0Jsb2Nr UG9zaXRpb24gJiYgIWhhc1N0YXRpY0lubGluZVBvc2l0aW9uKQogICAgICAgICByZXR1cm47CiAK LSAgICBhdXRvIG8gPSBjaGlsZC5wYXJlbnQoKTsKLSAgICB3aGlsZSAobyAmJiAhaXM8UmVuZGVy Vmlldz4oKm8pICYmIG8tPnN0eWxlKCkucG9zaXRpb24oKSAhPSBBYnNvbHV0ZVBvc2l0aW9uKQot ICAgICAgICBvID0gby0+cGFyZW50KCk7Ci0gICAgaWYgKG8tPnN0eWxlKCkucG9zaXRpb24oKSAh PSBBYnNvbHV0ZVBvc2l0aW9uKQorICAgIGF1dG8qIHBhcmVudCA9IHBvc2l0aW9uZWRDaGlsZC5w YXJlbnQoKTsKKyAgICB3aGlsZSAocGFyZW50ICYmICFpczxSZW5kZXJWaWV3PigqcGFyZW50KSAm JiBwYXJlbnQtPnN0eWxlKCkucG9zaXRpb24oKSAhPSBBYnNvbHV0ZVBvc2l0aW9uKQorICAgICAg ICBwYXJlbnQgPSBwYXJlbnQtPnBhcmVudCgpOworICAgIGlmICghcGFyZW50IHx8IHBhcmVudC0+ c3R5bGUoKS5wb3NpdGlvbigpICE9IEFic29sdXRlUG9zaXRpb24pCiAgICAgICAgIHJldHVybjsK IAotICAgIGF1dG8mIGJveCA9IGRvd25jYXN0PFJlbmRlckJveD4oY2hpbGQpOwogICAgIGlmICho YXNTdGF0aWNJbmxpbmVQb3NpdGlvbikgewogICAgICAgICBMb2dpY2FsRXh0ZW50Q29tcHV0ZWRW YWx1ZXMgY29tcHV0ZWRWYWx1ZXM7Ci0gICAgICAgIGJveC5jb21wdXRlTG9naWNhbFdpZHRoSW5S ZWdpb24oY29tcHV0ZWRWYWx1ZXMpOworICAgICAgICBwb3NpdGlvbmVkQ2hpbGQuY29tcHV0ZUxv Z2ljYWxXaWR0aEluUmVnaW9uKGNvbXB1dGVkVmFsdWVzKTsKICAgICAgICAgTGF5b3V0VW5pdCBu ZXdMZWZ0ID0gY29tcHV0ZWRWYWx1ZXMubV9wb3NpdGlvbjsKLSAgICAgICAgaWYgKG5ld0xlZnQg IT0gYm94LmxvZ2ljYWxMZWZ0KCkpCi0gICAgICAgICAgICBib3guc2V0Q2hpbGROZWVkc0xheW91 dChNYXJrT25seVRoaXMpOworICAgICAgICBpZiAobmV3TGVmdCAhPSBwb3NpdGlvbmVkQ2hpbGQu bG9naWNhbExlZnQoKSkKKyAgICAgICAgICAgIHBvc2l0aW9uZWRDaGlsZC5zZXRDaGlsZE5lZWRz TGF5b3V0KE1hcmtPbmx5VGhpcyk7CiAgICAgfSBlbHNlIGlmIChoYXNTdGF0aWNCbG9ja1Bvc2l0 aW9uKSB7Ci0gICAgICAgIExheW91dFVuaXQgb2xkVG9wID0gYm94LmxvZ2ljYWxUb3AoKTsKLSAg ICAgICAgYm94LnVwZGF0ZUxvZ2ljYWxIZWlnaHQoKTsKLSAgICAgICAgaWYgKGJveC5sb2dpY2Fs VG9wKCkgIT0gb2xkVG9wKQotICAgICAgICAgICAgYm94LnNldENoaWxkTmVlZHNMYXlvdXQoTWFy a09ubHlUaGlzKTsKKyAgICAgICAgTGF5b3V0VW5pdCBvbGRUb3AgPSBwb3NpdGlvbmVkQ2hpbGQu bG9naWNhbFRvcCgpOworICAgICAgICBwb3NpdGlvbmVkQ2hpbGQudXBkYXRlTG9naWNhbEhlaWdo dCgpOworICAgICAgICBpZiAocG9zaXRpb25lZENoaWxkLmxvZ2ljYWxUb3AoKSAhPSBvbGRUb3Ap CisgICAgICAgICAgICBwb3NpdGlvbmVkQ2hpbGQuc2V0Q2hpbGROZWVkc0xheW91dChNYXJrT25s eVRoaXMpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaApp bmRleCAxY2M0ZmJhMGEzNGNiZDU1YjY1MGEyZjdiZjkxOGRhZGRlMmViNjhhLi5lMWM4NzgxY2M0 MzcyZDUyOWNiZTg3OTI3NmRiNTY0OTVkYzAzNjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suaApAQCAtMzE0LDcgKzMxNCw3IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGxh eW91dFBvc2l0aW9uZWRPYmplY3RzKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgYm9vbCBmaXhlZFBv c2l0aW9uT2JqZWN0c09ubHkgPSBmYWxzZSk7CiAgICAgdmlydHVhbCB2b2lkIGxheW91dFBvc2l0 aW9uZWRPYmplY3QoUmVuZGVyQm94JiwgYm9vbCByZWxheW91dENoaWxkcmVuLCBib29sIGZpeGVk UG9zaXRpb25PYmplY3RzT25seSk7CiAgICAgCi0gICAgdm9pZCBtYXJrRml4ZWRQb3NpdGlvbk9i amVjdEZvckxheW91dElmTmVlZGVkKFJlbmRlck9iamVjdCYgY2hpbGQpOworICAgIHZvaWQgbWFy a0ZpeGVkUG9zaXRpb25PYmplY3RGb3JMYXlvdXRJZk5lZWRlZChSZW5kZXJCb3gmIGNoaWxkKTsK IAogICAgIExheW91dFVuaXQgbWFyZ2luSW50cmluc2ljTG9naWNhbFdpZHRoRm9yQ2hpbGQoUmVu ZGVyQm94JikgY29uc3Q7CiAK