<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>158857</bug_id>
          
          <creation_ts>2016-06-16 16:34:44 -0700</creation_ts>
          <short_desc>Add HTTPHeaderMap::set() overload taking a NSString*</short_desc>
          <delta_ts>2016-06-16 19:30:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>158827</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>kling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1203090</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-06-16 16:34:44 -0700</bug_when>
    <thetext>Add HTTPHeaderMap::set() overloading taking a NSString* in addition to the one taking a CFStringRef. It is useful for the Cocoa implementation of ResourceRequest::doUpdateResourceRequest() which does:
[[m_nsRequest allHTTPHeaderFields] enumerateKeysAndObjectsUsingBlock: ^(NSString *name, NSString *value, BOOL *) {
        m_httpHeaderFields.set(name, value);
    }];</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1203091</commentid>
    <comment_count>1</comment_count>
      <attachid>281501</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-06-16 16:35:59 -0700</bug_when>
    <thetext>Created attachment 281501
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1203092</commentid>
    <comment_count>2</comment_count>
      <attachid>281502</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-06-16 16:36:29 -0700</bug_when>
    <thetext>Created attachment 281502
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1203176</commentid>
    <comment_count>3</comment_count>
      <attachid>281502</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-16 19:30:43 -0700</bug_when>
    <thetext>Comment on attachment 281502
Patch

Clearing flags on attachment: 281502

Committed r202153: &lt;http://trac.webkit.org/changeset/202153&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1203177</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-16 19:30:48 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>281501</attachid>
            <date>2016-06-16 16:35:59 -0700</date>
            <delta_ts>2016-06-16 16:36:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-158857-20160616163557.patch</filename>
            <type>text/plain</type>
            <size>1536</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA2ZmI3ZDI3YzIwY2Y1
NGQ3OTkyYmNmNzQ2ZDM4ODlkNDZjMTNjYS4uMjJlMzgxOTc1NDlkMzZjZTc4YzZhZWMzODdlNTNl
MzUxZDk2ZDM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA2LTE2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhUVFBIZWFkZXJNYXA6
OnNldCgpIG92ZXJsb2FkaW5nIHRha2luZyBhIE5TU3RyaW5nKgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4ODU3CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEhUVFBIZWFkZXJNYXA6OnNldCgpIG92
ZXJsb2FkaW5nIHRha2luZyBhIE5TU3RyaW5nKiBpbiBhZGRpdGlvbiB0bworICAgICAgICB0aGUg
b25lIHRha2luZyBhIENGU3RyaW5nUmVmLiBJdCBpcyB1c2VmdWwgZm9yIHRoZSBDb2NvYSBpbXBs
ZW1lbnRhdGlvbgorICAgICAgICBvZiBSZXNvdXJjZVJlcXVlc3Q6OmRvVXBkYXRlUmVzb3VyY2VS
ZXF1ZXN0KCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaDoK
KyAgICAgICAgKFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA6OnNldCk6CisKIDIwMTYtMDYtMTYgIEJl
bmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgOmluLXJhbmdl
ICYgOm91dC1vZi1yYW5nZSBDU1MgcHNldWRvLWNsYXNzZXMgc2hvdWxkbid0IG1hdGNoIGlucHV0
cyB3aXRob3V0IHJhbmdlIGxpbWl0YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L25ldHdvcmsvSFRUUEhlYWRlck1hcC5oCmluZGV4IGM1ZGUyYTFmZDg4MjYzZmYyNWJmMTI2ZmFj
YWM0ZmY0YzU1ODNhNTYuLjM3MDlmMjU3M2YyMDdkMGI3OTdlZWU5ZTYzYjY3ZjA4YTNmNWRjMjYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1h
cC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5o
CkBAIC0xMzMsNiArMTMzLDkgQEAgcHVibGljOgogCiAjaWYgVVNFKENGKQogICAgIHZvaWQgc2V0
KENGU3RyaW5nUmVmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpOworI2lmZGVmIF9fT0JKQ19f
CisgICAgdm9pZCBzZXQoTlNTdHJpbmcgKm5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpIHsgc2V0
KChfX2JyaWRnZSBDRlN0cmluZ1JlZiluYW1lLCB2YWx1ZSk7IH0KKyNlbmRpZgogI2VuZGlmCiAK
ICAgICBXRUJDT1JFX0VYUE9SVCBTdHJpbmcgZ2V0KEhUVFBIZWFkZXJOYW1lKSBjb25zdDsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>281502</attachid>
            <date>2016-06-16 16:36:29 -0700</date>
            <delta_ts>2016-06-16 19:30:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-158857-20160616163626.patch</filename>
            <type>text/plain</type>
            <size>1533</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA2ZmI3ZDI3YzIwY2Y1
NGQ3OTkyYmNmNzQ2ZDM4ODlkNDZjMTNjYS4uYzI1OWIwNTI4MzE5YTc1MDJjNmZkNjFhMWMyMzdk
ZmFhMzMwMDczYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA2LTE2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEhUVFBIZWFkZXJNYXA6
OnNldCgpIG92ZXJsb2FkIHRha2luZyBhIE5TU3RyaW5nKgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4ODU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEhUVFBIZWFkZXJNYXA6OnNldCgpIG92ZXJs
b2FkaW5nIHRha2luZyBhIE5TU3RyaW5nKiBpbiBhZGRpdGlvbiB0bworICAgICAgICB0aGUgb25l
IHRha2luZyBhIENGU3RyaW5nUmVmLiBJdCBpcyB1c2VmdWwgZm9yIHRoZSBDb2NvYSBpbXBsZW1l
bnRhdGlvbgorICAgICAgICBvZiBSZXNvdXJjZVJlcXVlc3Q6OmRvVXBkYXRlUmVzb3VyY2VSZXF1
ZXN0KCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhUVFBIZWFkZXJNYXA6OnNldCk6CisKIDIwMTYtMDYtMTYgIEJlbmph
bWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgOmluLXJhbmdlICYg
Om91dC1vZi1yYW5nZSBDU1MgcHNldWRvLWNsYXNzZXMgc2hvdWxkbid0IG1hdGNoIGlucHV0cyB3
aXRob3V0IHJhbmdlIGxpbWl0YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l
dHdvcmsvSFRUUEhlYWRlck1hcC5oCmluZGV4IGM1ZGUyYTFmZDg4MjYzZmYyNWJmMTI2ZmFjYWM0
ZmY0YzU1ODNhNTYuLjM3MDlmMjU3M2YyMDdkMGI3OTdlZWU5ZTYzYjY3ZjA4YTNmNWRjMjYgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5o
CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5oCkBA
IC0xMzMsNiArMTMzLDkgQEAgcHVibGljOgogCiAjaWYgVVNFKENGKQogICAgIHZvaWQgc2V0KENG
U3RyaW5nUmVmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpOworI2lmZGVmIF9fT0JKQ19fCisg
ICAgdm9pZCBzZXQoTlNTdHJpbmcgKm5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpIHsgc2V0KChf
X2JyaWRnZSBDRlN0cmluZ1JlZiluYW1lLCB2YWx1ZSk7IH0KKyNlbmRpZgogI2VuZGlmCiAKICAg
ICBXRUJDT1JFX0VYUE9SVCBTdHJpbmcgZ2V0KEhUVFBIZWFkZXJOYW1lKSBjb25zdDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>