<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>158852</bug_id>
          
          <creation_ts>2016-06-16 15:17:25 -0700</creation_ts>
          <short_desc>Opcode.h requires Bytecodes.h, but it is not found</short_desc>
          <delta_ts>2016-09-01 09:24:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>bmalloc</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>157261</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rafael Fontenelle">rafaelff</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>fujii</cc>
    
    <cc>ggaren</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1203024</commentid>
    <comment_count>0</comment_count>
    <who name="Rafael Fontenelle">rafaelff</who>
    <bug_when>2016-06-16 15:17:25 -0700</bug_when>
    <thetext>Compilation fails when Opcode.h tries to include the header file &apos;Bytecodes.h&apos;, but there is no such file

See build and configure log: https://gist.github.com/josephgbr/b62ff3b2ba70d1ce523593a2d0335924</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1204788</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2016-06-23 00:35:46 -0700</bug_when>
    <thetext>Reproduced on GTK port.
I think this is CMake build dependency issue. Bytecodes.h generation should be done before building any other cpps out of JSC.
Currently, it seems that WebCore binding code build starts before generating Bytecodes.h.

I think I saw such a problem in GYP in chromium...
Building the object files itself can be done without the shared library (libjavascriptcoregtk.so). Building WebCore and JavaScriptCore in parallel can be done if there are no such generated header dependencies.

So I guess that we need to explicitly say that these building depends on the Bytecodes.h header generation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1223403</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2016-08-25 20:58:00 -0700</bug_when>
    <thetext>In https://trac.webkit.org/changeset/204994, I appended Bytecodes.h to JavaScriptCore_HEADERS in CMakeLists.txt.
Does this issue still remain?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225239</commentid>
    <comment_count>3</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2016-08-31 21:03:50 -0700</bug_when>
    <thetext>Hm, the issue still remains.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225317</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-09-01 07:01:40 -0700</bug_when>
    <thetext>Same?
  Bug 161477 – webkit-gtk 2.13.90 fails to build due to missing Bytecodes.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1225338</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2016-09-01 09:24:36 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Same?
&gt;   Bug 161477 – webkit-gtk 2.13.90 fails to build due to missing Bytecodes.h

Nice!

*** This bug has been marked as a duplicate of bug 157261 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>