158850 2016-06-16 14:58:35 -0700 Kraken/stanford-crypto-pbkdf2.js sometimes crashes with an OSR assertion in FTL 2016-06-16 15:18:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1203013 0 fpizlo 2016-06-16 14:58:35 -0700 Patch forthcoming. 1203014 1 281477 fpizlo 2016-06-16 15:01:25 -0700 Created attachment 281477 the patch 1203015 2 281477 keith_miller 2016-06-16 15:03:59 -0700 Comment on attachment 281477 the patch r=me. 1203025 3 fpizlo 2016-06-16 15:18:29 -0700 Landed in http://trac.webkit.org/changeset/202141 281477 2016-06-16 15:01:25 -0700 2016-06-16 15:03:59 -0700 the patch blah.patch text/plain 5852 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyMTM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTA2LTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg S3Jha2VuL3N0YW5mb3JkLWNyeXB0by1wYmtkZjIuanMgc29tZXRpbWVzIGNyYXNoZXMgd2l0aCBh biBPU1IgYXNzZXJ0aW9uIGluIEZUTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU4ODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBCeXRlY29kZSBsaXZlbmVzcyB3YXMgaW5jb3JyZWN0bHkg Y2xhaW1pbmcgdGhhdCBhbGwgdGFpbC1kZWxldGVkIGxvY2FscyBhcmUgbGl2ZSEgVGhhdCdzCisg ICAgICAgIGNyYXp5ISBXZSBuZXZlciBub3RpY2VkIHRoaXMgYmVjYXVzZSBleHRlbmRpbmcgT1NS IGxpdmVuZXNzIGlzIHVzdWFsbHkgbm90IGEgc2hvd3N0b3BwZXIgYW5kCisgICAgICAgIHVudGls IHJlY2VudGx5IHdlIGRpZG4ndCBoYXZlIGEgbG90IG9mIHRhaWwtY2FsbCB0ZXN0IGNhc2VzIHRv IHBsYXkgd2l0aC4gV2VsbCwgd2UgZG8gbm93LAorICAgICAgICB0aGFua3MgdG8gdGhlIGluY3Jl YXNpbmcgcmVsaWFuY2Ugb24gdGFpbCBjYWxscyBpbiBvdXIgYnVpbHRpbnMuCisKKyAgICAgICAg KiBkZmcvREZHR3JhcGguY3BwOgorICAgICAgICAoSlNDOjpERkc6OkdyYXBoOjpsb2NhbHNMaXZl SW5CeXRlY29kZSk6IEZpeCB0aGUgYnVnIGFuZCBhZGQgc29tZSBvcHRpb25hbCB0cmFjaW5nLiBB bHNvIHJlc3RydWN0dXJlIHRoZSBjb2RlIHNvIHRoYXQgd2UgZG9uJ3QgYnJlYWsgdG8gcmV0dXJu IHRydWUsIHNpbmNlIHRoYXQncyBjb3VudGVyaW50dWl0aXZlLgorICAgICAgICAqIGZ0bC9GVExM b3dlckRGR1RvQjMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpi dWlsZEV4aXRBcmd1bWVudHMpOiBNYWtlIHRoaXMgYXNzZXJ0aW9uIHByaW50IG1vcmUgdXNlZnVs IGluZm9ybWF0aW9uLgorCiAyMDE2LTA2LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgY29sbGVjdGluZyBvZiBMTElOVCBzbG93IHBhdGggc3RhdHMuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAkocmV2aXNpb24gMjAyMTMy KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk5Nyw0OCArOTk3LDcyIEBAIEJ5dGVjb2RlS2lsbHMmIEdyYXBoOjpraWxsc0ZvcihJ bmxpbmVDYWwKIAogYm9vbCBHcmFwaDo6aXNMaXZlSW5CeXRlY29kZShWaXJ0dWFsUmVnaXN0ZXIg b3BlcmFuZCwgQ29kZU9yaWdpbiBjb2RlT3JpZ2luKQogeworICAgIHN0YXRpYyBjb25zdCBib29s IHZlcmJvc2UgPSBmYWxzZTsKKyAgICAKKyAgICBpZiAodmVyYm9zZSkKKyAgICAgICAgZGF0YUxv ZygiQ2hlY2tpbmcgb2Ygb3BlcmFuZCBpcyBsaXZlOiAiLCBvcGVyYW5kLCAiXG4iKTsKICAgICBD b2RlT3JpZ2luKiBjb2RlT3JpZ2luUHRyID0gJmNvZGVPcmlnaW47CiAgICAgZm9yICg7Oykgewog ICAgICAgICBWaXJ0dWFsUmVnaXN0ZXIgcmVnID0gVmlydHVhbFJlZ2lzdGVyKAogICAgICAgICAg ICAgb3BlcmFuZC5vZmZzZXQoKSAtIGNvZGVPcmlnaW5QdHItPnN0YWNrT2Zmc2V0KCkpOwogICAg ICAgICAKKyAgICAgICAgaWYgKHZlcmJvc2UpCisgICAgICAgICAgICBkYXRhTG9nKCJyZWcgPSAi LCByZWcsICJcbiIpOworICAgICAgICAKICAgICAgICAgaWYgKG9wZXJhbmQub2Zmc2V0KCkgPCBj b2RlT3JpZ2luUHRyLT5zdGFja09mZnNldCgpICsgSlNTdGFjazo6Q2FsbEZyYW1lSGVhZGVyU2l6 ZSkgewogICAgICAgICAgICAgaWYgKHJlZy5pc0FyZ3VtZW50KCkpIHsKICAgICAgICAgICAgICAg ICBSRUxFQVNFX0FTU0VSVChyZWcub2Zmc2V0KCkgPCBKU1N0YWNrOjpDYWxsRnJhbWVIZWFkZXJT aXplKTsKICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoY29kZU9yaWdpblB0 ci0+aW5saW5lQ2FsbEZyYW1lLT5pc0Nsb3N1cmVDYWxsCi0gICAgICAgICAgICAgICAgICAgICYm IHJlZy5vZmZzZXQoKSA9PSBKU1N0YWNrOjpDYWxsZWUpCisgICAgICAgICAgICAgICAgICAgICYm IHJlZy5vZmZzZXQoKSA9PSBKU1N0YWNrOjpDYWxsZWUpIHsKKyAgICAgICAgICAgICAgICAgICAg aWYgKHZlcmJvc2UpCisgICAgICAgICAgICAgICAgICAgICAgICBkYXRhTG9nKCJMb29rcyBsaWtl IGEgY2FsbGVlLlxuIik7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAg ICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoY29kZU9y aWdpblB0ci0+aW5saW5lQ2FsbEZyYW1lLT5pc1ZhcmFyZ3MoKQotICAgICAgICAgICAgICAgICAg ICAmJiByZWcub2Zmc2V0KCkgPT0gSlNTdGFjazo6QXJndW1lbnRDb3VudCkKKyAgICAgICAgICAg ICAgICAgICAgJiYgcmVnLm9mZnNldCgpID09IEpTU3RhY2s6OkFyZ3VtZW50Q291bnQpIHsKKyAg ICAgICAgICAgICAgICAgICAgaWYgKHZlcmJvc2UpCisgICAgICAgICAgICAgICAgICAgICAgICBk YXRhTG9nKCJMb29rcyBsaWtlIHRoZSBhcmd1bWVudCBjb3VudC5cbiIpOwogICAgICAgICAgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgfQotICAgICAgICAg ICAgCisKKyAgICAgICAgICAgIGlmICh2ZXJib3NlKQorICAgICAgICAgICAgICAgIGRhdGFMb2co IkFza2luZyB0aGUgYnl0ZWNvZGUgbGl2ZW5lc3MuXG4iKTsKICAgICAgICAgICAgIHJldHVybiBs aXZlbmVzc0Zvcihjb2RlT3JpZ2luUHRyLT5pbmxpbmVDYWxsRnJhbWUpLm9wZXJhbmRJc0xpdmUo CiAgICAgICAgICAgICAgICAgcmVnLm9mZnNldCgpLCBjb2RlT3JpZ2luUHRyLT5ieXRlY29kZUlu ZGV4KTsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgSW5saW5lQ2FsbEZyYW1lKiBpbmxp bmVDYWxsRnJhbWUgPSBjb2RlT3JpZ2luUHRyLT5pbmxpbmVDYWxsRnJhbWU7Ci0gICAgICAgIGlm ICghaW5saW5lQ2FsbEZyYW1lKQotICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGlmICghaW5s aW5lQ2FsbEZyYW1lKSB7CisgICAgICAgICAgICBpZiAodmVyYm9zZSkKKyAgICAgICAgICAgICAg ICBkYXRhTG9nKCJSYW4gb3V0IG9mIHN0YWNrLCByZXR1cm5pbmcgdHJ1ZS5cbiIpOworICAgICAg ICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KIAogICAgICAgICAvLyBBcmd1bWVudHMgYXJl IGFsd2F5cyBsaXZlLiBUaGlzIHdvdWxkIGJlIHJlZHVuZGFudCBpZiBpdCB3YXNuJ3QgZm9yIG91 cgogICAgICAgICAvLyBvcF9jYWxsX3ZhcmFyZ3MgaW5saW5pbmcuCiAgICAgICAgIGlmIChyZWcu aXNBcmd1bWVudCgpCi0gICAgICAgICAgICAmJiBzdGF0aWNfY2FzdDxzaXplX3Q+KHJlZy50b0Fy Z3VtZW50KCkpIDwgaW5saW5lQ2FsbEZyYW1lLT5hcmd1bWVudHMuc2l6ZSgpKQorICAgICAgICAg ICAgJiYgc3RhdGljX2Nhc3Q8c2l6ZV90PihyZWcudG9Bcmd1bWVudCgpKSA8IGlubGluZUNhbGxG cmFtZS0+YXJndW1lbnRzLnNpemUoKSkgeworICAgICAgICAgICAgaWYgKHZlcmJvc2UpCisgICAg ICAgICAgICAgICAgZGF0YUxvZygiQXJndW1lbnQgaXMgbGl2ZS5cbiIpOwogICAgICAgICAgICAg cmV0dXJuIHRydWU7CisgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIGNvZGVPcmlnaW5QdHIg PSBpbmxpbmVDYWxsRnJhbWUtPmdldENhbGxlclNraXBwaW5nVGFpbENhbGxzKCk7CiAKICAgICAg ICAgLy8gVGhlIGZpcnN0IGlubGluZSBjYWxsIGZyYW1lIGNvdWxkIGJlIGFuIGlubGluZSB0YWls IGNhbGwKLSAgICAgICAgaWYgKCFjb2RlT3JpZ2luUHRyKQotICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIGlmICghY29kZU9yaWdpblB0cikgeworICAgICAgICAgICAgaWYgKHZlcmJvc2UpCisg ICAgICAgICAgICAgICAgZGF0YUxvZygiRGVhZCBiZWNhdXNlIG9mIHRhaWwgaW5saW5pbmcuXG4i KTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAgIH0KICAgICAKLSAg ICByZXR1cm4gdHJ1ZTsKKyAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCiBC aXRWZWN0b3IgR3JhcGg6OmxvY2Fsc0xpdmVJbkJ5dGVjb2RlKENvZGVPcmlnaW4gY29kZU9yaWdp bikKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j cHAJKHJldmlzaW9uIDIwMjEzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0IzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA4MTAsMTAgKzEwODEwLDExIEBAIHBy aXZhdGU6CiAgICAgICAgICAgICAKICAgICAgICAgICAgIEF2YWlsYWJpbGl0eSBhdmFpbGFiaWxp dHkgPSBhdmFpbGFiaWxpdHlNYXAubV9sb2NhbHNbaV07CiAgICAgICAgICAgICAKLSAgICAgICAg ICAgIGlmIChPcHRpb25zOjp2YWxpZGF0ZUZUTE9TUkV4aXRMaXZlbmVzcygpKSB7Ci0gICAgICAg ICAgICAgICAgREZHX0FTU0VSVCgKLSAgICAgICAgICAgICAgICAgICAgbV9ncmFwaCwgbV9ub2Rl LAotICAgICAgICAgICAgICAgICAgICAoIShhdmFpbGFiaWxpdHkuaXNEZWFkKCkgJiYgbV9ncmFw aC5pc0xpdmVJbkJ5dGVjb2RlKFZpcnR1YWxSZWdpc3RlcihvcGVyYW5kKSwgZXhpdE9yaWdpbikp KSB8fCBtX2dyYXBoLm1fcGxhbi5tb2RlID09IEZUTEZvck9TUkVudHJ5TW9kZSk7CisgICAgICAg ICAgICBpZiAoT3B0aW9uczo6dmFsaWRhdGVGVExPU1JFeGl0TGl2ZW5lc3MoKQorICAgICAgICAg ICAgICAgICYmIG1fZ3JhcGgubV9wbGFuLm1vZGUgIT0gRlRMRm9yT1NSRW50cnlNb2RlKSB7Cisg ICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgaWYgKGF2YWlsYWJpbGl0eS5pc0RlYWQo KSAmJiBtX2dyYXBoLmlzTGl2ZUluQnl0ZWNvZGUoVmlydHVhbFJlZ2lzdGVyKG9wZXJhbmQpLCBl eGl0T3JpZ2luKSkKKyAgICAgICAgICAgICAgICAgICAgREZHX0NSQVNIKG1fZ3JhcGgsIG1fbm9k ZSwgdG9DU3RyaW5nKCJMaXZlIGJ5dGVjb2RlIGxvY2FsIG5vdCBhdmFpbGFibGU6IG9wZXJhbmQg PSAiLCBWaXJ0dWFsUmVnaXN0ZXIob3BlcmFuZCksICIsIGF2YWlsYWJpbGl0eSA9ICIsIGF2YWls YWJpbGl0eSwgIiwgb3JpZ2luID0gIiwgZXhpdE9yaWdpbikuZGF0YSgpKTsKICAgICAgICAgICAg IH0KICAgICAgICAgICAgIEV4aXRWYWx1ZSBleGl0VmFsdWUgPSBleGl0VmFsdWVGb3JBdmFpbGFi aWxpdHkoYXJndW1lbnRzLCBtYXAsIGF2YWlsYWJpbGl0eSk7CiAgICAgICAgICAgICBpZiAoZXhp dFZhbHVlLmhhc0luZGV4SW5TdGFja21hcExvY2F0aW9ucygpKQo=