158838 2016-06-16 08:46:22 -0700 Update test-expected file for failing fullscreen test 2016-06-17 08:22:04 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 romain.wkt webkit-unassigned bfulgham cgarcia commit-queue eric.carlson lforschler oldest_to_newest 1202931 0 romain.wkt 2016-06-16 08:46:22 -0700 fullscreen/video-controls-override.html fails with GTK because the GTK test-expected file was not updated after an update of the test. MAC was version was updated, but not the default test-expected, nor EFL. GTK produces the same result as MAC, and other ports skip the test. Therefore, it seems that the MAC version could be used as the default version and dedicated versions could be removed. 1202937 1 281460 romain.wkt 2016-06-16 08:54:34 -0700 Created attachment 281460 Patch 1203286 2 281460 commit-queue 2016-06-17 04:46:14 -0700 Comment on attachment 281460 Patch Clearing flags on attachment: 281460 Committed r202164: <http://trac.webkit.org/changeset/202164> 1203287 3 commit-queue 2016-06-17 04:46:18 -0700 All reviewed patches have been landed. Closing bug. 1203306 4 281460 eric.carlson 2016-06-17 07:20:11 -0700 Comment on attachment 281460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281460&action=review > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL This isn't right, the test results shouldn't have a failure. If the test is incorrect the test should be fixed. If the observed behavior is incorrect, that should be fixed. 1203312 5 cgarcia 2016-06-17 08:22:04 -0700 (In reply to comment #4) > Comment on attachment 281460 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281460&action=review > > > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL > > This isn't right, the test results shouldn't have a failure. > > If the test is incorrect the test should be fixed. If the observed behavior > is incorrect, that should be fixed. oops, sorry, I missed that, I assumed that the current result was ok and just copied 281460 2016-06-16 08:54:34 -0700 2016-06-17 04:46:14 -0700 Patch bug-158838-20160616175432.patch text/plain 5814 romain.wkt U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGE3YjVkYmE5MjcxMmI4OWE4YjIw NDNhNDA3MzhhYzNhOWUxYzVjMi4uZDM4YTQ5NDRjYmQyYjM3YzE3NWRkZDRjNDU4M2M3ZGRlYTEw NzZmZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA2LTE2ICBSb21haW4gQmVsbGVzc29y dCAgPHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KKworICAgICAgICBVcGRhdGUgdGVz dC1leHBlY3RlZCBmaWxlIGZvciBmYWlsaW5nIGZ1bGxzY3JlZW4gdGVzdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4ODM4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlZCBNQUMgdmVyc2lvbiBvZiB0 aGUgdGVzdCBhcyB0aGUgZGVmYXVsdCB2ZXJzaW9uIHNpbmNlIG9ubHkgTUFDIGFuZAorICAgICAg ICBHVEsgZG8gbm90IHNraXAgdGhpcyB0ZXN0IGFuZCBleHBlY3QgdGhlIHNhbWUgcmVzdWx0LiBS ZW1vdmVkIAorICAgICAgICB0ZXN0LWV4cGVjdGVkIGZpbGVzIHNwZWNpZmljIHRvIGVhY2ggcG9y dCB3aGVuIHRoZXJlIHdhcyBvbmUuIFByaW9yIHRvCisgICAgICAgIHRoaXMgcGF0Y2gsIEdUSyB0 ZXN0IHdhcyBmYWlsaW5nIHVuZXhwZWN0ZWRseS4KKworICAgICAgICAqIGZ1bGxzY3JlZW4vdmlk ZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL2Vm bC9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dDogUmVtb3Zl ZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVy cmlkZS1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Z1bGxz Y3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorCiAy MDE2LTA2LTE1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBTeW1ib2wuaXNDb25jYXRTcHJlYWRhYmxlIChyb3VuZCAyKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlk ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92 ZXJyaWRlLWV4cGVjdGVkLnR4dAppbmRleCBhNzAyYmI4ZTM1NGU1MDI5NjNkMDZmMTJhNjM5YmI0 MGMyMGQyZGY2Li5hYjYwNDE0MTNjNGVhZDIwYmY2MTE5ODMxOGNiZjdhYzgwNWJlZWY0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92 ZXJyaWRlLWV4cGVjdGVkLnR4dApAQCAtNiw4ICs2LDggQEAgRVhQRUNURUQgKHNoYWRvd1Jvb3Qg PSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251bGwnKSBPSwogRVhQRUNURUQgKHBh bmVsID0gbWVkaWFDb250cm9sc0VsZW1lbnQoc2hhZG93Um9vdC5maXJzdENoaWxkLCAnLXdlYmtp dC1tZWRpYS1jb250cm9scy1wYW5lbCcpICE9ICdudWxsJykgT0sKIEVYUEVDVEVEIChpbnRlcm5h bHMuc2hhZG93UHNldWRvSWQocGFuZWwpID09ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVs JykgT0sKIEVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBh bmVsKVsnZGlzcGxheSddICE9ICdub25lJykgT0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0 Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10gPj0gJzIwcHgnKSBPSworRVhQ RUNURUQgKHBhcnNlSW50KGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFu ZWwpWydoZWlnaHQnXSkgPj0gJzIwJykgT0sKIEVWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2Up Ci1FWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClb J2Rpc3BsYXknXSA9PSAnbm9uZScpIE9LCitFWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVsdFZpZXcu Z2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSA9PSAnbm9uZScpLCBPQlNFUlZFRCAn JyBGQUlMCiBFTkQgT0YgVEVTVAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9lZmwvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS1l eHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDA2MjI1YTEwMDM5YzIz NWI5MzRkZGVhMzUzM2EwMDE2OTk4MDlmMDguLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Z1bGxzY3JlZW4vdmlk ZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0CisrKyAvZGV2L251bGwKQEAgLTEsMTMg KzAsMCBAQAotVGhpcyB0ZXN0cyB0aGF0IHRoZSB2aWRlbyBlbGVtZW50J3MgImNvbnRyb2xzIiBh dHRyaWJ1dGUgaXMgb3ZlcnJpZGRlbiBpbiBmdWxsIHNjcmVlbiBtb2RlLCBhbmQgdGhhdCB0aGUg Y29udHJvbHMgYXJlIGNvcnJlY3RseSBoaWRkZW4gdXBvbiBleGl0aW5nIGZ1bGwgc2NyZWVuLiBQ cmVzcyBhbnkga2V5IHRvIGNvbnRpbnVlLgotCi0KLUVWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFu Z2UpCi1FWFBFQ1RFRCAoc2hhZG93Um9vdCA9IGludGVybmFscy5zaGFkb3dSb290KHZpZGVvKSAh PSAnbnVsbCcpIE9LCi1FWFBFQ1RFRCAocGFuZWwgPSBtZWRpYUNvbnRyb2xzRWxlbWVudChzaGFk b3dSb290LmZpcnN0Q2hpbGQsICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsJykgIT0gJ251 bGwnKSBPSwotRVhQRUNURUQgKGludGVybmFscy5zaGFkb3dQc2V1ZG9JZChwYW5lbCkgPT0gJy13 ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSBPSwotRVhQRUNURUQgKGRvY3VtZW50LmRlZmF1 bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNwbGF5J10gIT0gJ25vbmUnKSBPSwot RVhQRUNURUQgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydo ZWlnaHQnXSA+PSAnMjBweCcpIE9LCi1FVkVOVCh3ZWJraXRmdWxsc2NyZWVuY2hhbmdlKQotRVhQ RUNURUQgKGRvY3VtZW50LmRlZmF1bHRWaWV3LmdldENvbXB1dGVkU3R5bGUocGFuZWwpWydkaXNw bGF5J10gPT0gJ25vbmUnKSwgT0JTRVJWRUQgJycgRkFJTAotRU5EIE9GIFRFU1QKLQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMt b3ZlcnJpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Z1bGxzY3Jl ZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUtZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwNjIyNWExMDAzOWMyMzViOTM0ZGRlYTM1MzNhMDAxNjk5ODA5ZjA4Li4w MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVk LnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDEzICswLDAgQEAKLVRoaXMgdGVzdHMgdGhhdCB0aGUg dmlkZW8gZWxlbWVudCdzICJjb250cm9scyIgYXR0cmlidXRlIGlzIG92ZXJyaWRkZW4gaW4gZnVs bCBzY3JlZW4gbW9kZSwgYW5kIHRoYXQgdGhlIGNvbnRyb2xzIGFyZSBjb3JyZWN0bHkgaGlkZGVu IHVwb24gZXhpdGluZyBmdWxsIHNjcmVlbi4gUHJlc3MgYW55IGtleSB0byBjb250aW51ZS4KLQot Ci1FVkVOVCh3ZWJraXRmdWxsc2NyZWVuY2hhbmdlKQotRVhQRUNURUQgKHNoYWRvd1Jvb3QgPSBp bnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykgIT0gJ251bGwnKSBPSwotRVhQRUNURUQgKHBhbmVs ID0gbWVkaWFDb250cm9sc0VsZW1lbnQoc2hhZG93Um9vdC5maXJzdENoaWxkLCAnLXdlYmtpdC1t ZWRpYS1jb250cm9scy1wYW5lbCcpICE9ICdudWxsJykgT0sKLUVYUEVDVEVEIChpbnRlcm5hbHMu c2hhZG93UHNldWRvSWQocGFuZWwpID09ICctd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsJykg T0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVs KVsnZGlzcGxheSddICE9ICdub25lJykgT0sKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmll dy5nZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnaGVpZ2h0J10gPj0gJzIwcHgnKSBPSwotRVZFTlQo d2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5n ZXRDb21wdXRlZFN0eWxlKHBhbmVsKVsnZGlzcGxheSddID09ICdub25lJyksIE9CU0VSVkVEICcn IEZBSUwKLUVORCBPRiBURVNUCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLW92ZXJyaWRlLWV4 cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYWI2MDQxNDEzYzRlYWQy MGJmNjExOTgzMThjYmY3YWM4MDViZWVmNC4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZnVsbHNjcmVlbi92aWRl by1jb250cm9scy1vdmVycmlkZS1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSwxMyAr MCwwIEBACi1UaGlzIHRlc3RzIHRoYXQgdGhlIHZpZGVvIGVsZW1lbnQncyAiY29udHJvbHMiIGF0 dHJpYnV0ZSBpcyBvdmVycmlkZGVuIGluIGZ1bGwgc2NyZWVuIG1vZGUsIGFuZCB0aGF0IHRoZSBj b250cm9scyBhcmUgY29ycmVjdGx5IGhpZGRlbiB1cG9uIGV4aXRpbmcgZnVsbCBzY3JlZW4uIFBy ZXNzIGFueSBrZXkgdG8gY29udGludWUuCi0KLQotRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5n ZSkKLUVYUEVDVEVEIChzaGFkb3dSb290ID0gaW50ZXJuYWxzLnNoYWRvd1Jvb3QodmlkZW8pICE9 ICdudWxsJykgT0sKLUVYUEVDVEVEIChwYW5lbCA9IG1lZGlhQ29udHJvbHNFbGVtZW50KHNoYWRv d1Jvb3QuZmlyc3RDaGlsZCwgJy13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwnKSAhPSAnbnVs bCcpIE9LCi1FWFBFQ1RFRCAoaW50ZXJuYWxzLnNoYWRvd1BzZXVkb0lkKHBhbmVsKSA9PSAnLXdl YmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCcpIE9LCi1FWFBFQ1RFRCAoZG9jdW1lbnQuZGVmYXVs dFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShwYW5lbClbJ2Rpc3BsYXknXSAhPSAnbm9uZScpIE9LCi1F WFBFQ1RFRCAocGFyc2VJbnQoZG9jdW1lbnQuZGVmYXVsdFZpZXcuZ2V0Q29tcHV0ZWRTdHlsZShw YW5lbClbJ2hlaWdodCddKSA+PSAnMjAnKSBPSwotRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5n ZSkKLUVYUEVDVEVEIChkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKHBhbmVs KVsnZGlzcGxheSddID09ICdub25lJyksIE9CU0VSVkVEICcnIEZBSUwKLUVORCBPRiBURVNUCi0K