158834 2016-06-16 05:47:05 -0700 The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface 2016-06-19 10:52:04 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 158832 1 adam.bergkvist youennf cdumez cgarcia commit-queue youennf oldest_to_newest 1202903 0 adam.bergkvist 2016-06-16 05:47:05 -0700 For example: interface RTCPeerConnection : EventTarget 1202904 1 281451 youennf 2016-06-16 06:06:54 -0700 Created attachment 281451 Patch 1202905 2 youennf 2016-06-16 06:07:55 -0700 (In reply to comment #1) > Created attachment 281451 [details] > Patch Adam, can you check whether that patch is working for you? 1202932 3 adam.bergkvist 2016-06-16 08:48:28 -0700 The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with this change applied. Haven't looked into the cause yet. 1203251 4 adam.bergkvist 2016-06-17 00:18:35 -0700 (In reply to comment #3) > The test fast/mediastream/RTCRtpSender-replaceTrack.html seem to crash with > this change applied. Haven't looked into the cause yet. Don't mind the above comment. The patch works for me. 1203580 5 adam.bergkvist 2016-06-18 06:40:42 -0700 youenn, are you planning to update this patch any further or can we commit it? Many thanks for the fix btw :) 1203581 6 youennf 2016-06-18 08:18:06 -0700 Sure, I cannot follow the CQ right now, but will do tomorrow or Monday. Feel free to CQ+ it in the meantime if you prefer 1203617 7 281451 commit-queue 2016-06-19 10:51:59 -0700 Comment on attachment 281451 Patch Clearing flags on attachment: 281451 Committed r202211: <http://trac.webkit.org/changeset/202211> 1203618 8 commit-queue 2016-06-19 10:52:04 -0700 All reviewed patches have been landed. Closing bug. 281451 2016-06-16 06:06:54 -0700 2016-06-19 10:51:59 -0700 Patch bug-158834-20160616150652.patch text/plain 3364 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgwZTZiMzVmY2RkNmVl M2E0ZTMzZGExZDQxNDdhZTFhYjdjNjVjZC4uNzYyMDhmMTE2MDgwNGIyNDBkNjA3YmE4ODFlZjIy YWVhMjE0ZjEwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgVGhlIEpT QnVpbHRpbkNvbnN0cnVjdG9yIGZlYXR1cmUgY2FuJ3QgaGFuZGxlIGEgSlMgaW50ZXJmYWNlIGV4 dGVuZGluZyBhbiBvdGhlciBKUyBpbnRlcmZhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKworICAgICAgICAq IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVI ZWFkZXIpOiBFeHBsaWNpdGx5IHNldHRpbmcgRE9NV3JhcHBlZCB0eXBlIGRlZmluaXRpb24gZnJv bQorICAgICAgICBKU1hYIGNsYXNzIGRlcml2aW5nIGZyb20gYW5vdGhlciBKU1lZIGNsYXNzLgor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RFdmVudFRhcmdldC5oOiBS ZWJhc2VkLgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmg6 IERpdHRvLgorCiAyMDE2LTA2LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRGVjb3VwbGUgdGhlIHBlcmNlbnQgaGVpZ2h0IGFuZCBwb3NpdGlvbmVkIGRlc2Nl bmRhbnRzIG1hcHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCmluZGV4IDE1MzFmYWU3OTFjOTU1OGFkOGIwOGNlZjgyNmFjZDg0MWQ2 YzlhNmYuLmMyYjI0YmUyNDBkZjE1ZTA2NjRiODU3M2JmYWQwZmQ4ZTk5ZmRjOTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBA IC0xMTA0LDYgKzExMDQsOCBAQCBzdWIgR2VuZXJhdGVIZWFkZXIKICAgICAjIFN0YXRpYyBjcmVh dGUgbWV0aG9kcwogICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJwdWJsaWM6XG4iKTsKICAgICBw dXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHR5cGVkZWYgJHBhcmVudENsYXNzTmFtZSBCYXNlO1xu Iik7CisgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICB0eXBlZGVmICRpbXBsVHlwZSBET01X cmFwcGVkO1xuIikgaWYgJGludGVyZmFjZS0+cGFyZW50OworCiAgICAgaWYgKCRpbnRlcmZhY2VO YW1lIGVxICJET01XaW5kb3ciKSB7CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAg c3RhdGljICRjbGFzc05hbWUqIGNyZWF0ZShKU0M6OlZNJiB2bSwgSlNDOjpTdHJ1Y3R1cmUqIHN0 cnVjdHVyZSwgUmVmPCRpbXBsVHlwZT4mJiBpbXBsLCBKU0RPTVdpbmRvd1NoZWxsKiB3aW5kb3dT aGVsbClcbiIpOwogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHtcbiIpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEV2 ZW50VGFyZ2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNU ZXN0RXZlbnRUYXJnZXQuaAppbmRleCBhNjQ3NTVlMTZiZDViNjc0ZjBmNmU3MTg2YTMxZWJhNjM1 MzMxOGNiLi5hZTg3ZWRhM2ZiODhhMDk0MjVmZWNiYmNlNmYwOGRiY2Q1N2UzZThhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0RXZlbnRU YXJnZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNU ZXN0RXZlbnRUYXJnZXQuaApAQCAtMjgsNiArMjgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBj bGFzcyBKU1Rlc3RFdmVudFRhcmdldCA6IHB1YmxpYyBKU0V2ZW50VGFyZ2V0IHsKIHB1YmxpYzoK ICAgICB0eXBlZGVmIEpTRXZlbnRUYXJnZXQgQmFzZTsKKyAgICB0eXBlZGVmIFRlc3RFdmVudFRh cmdldCBET01XcmFwcGVkOwogICAgIHN0YXRpYyBKU1Rlc3RFdmVudFRhcmdldCogY3JlYXRlKEpT Qzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3Qs IFJlZjxUZXN0RXZlbnRUYXJnZXQ+JiYgaW1wbCkKICAgICB7CiAgICAgICAgIGdsb2JhbE9iamVj dC0+bWFzcXVlcmFkZXNBc1VuZGVmaW5lZFdhdGNocG9pbnQoKS0+ZmlyZUFsbCgiQWxsb2NhdGVk IG1hc3F1ZXJhZGluZyBvYmplY3QiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5oCmluZGV4IDQyNjg4NDJlOWYwZWY5YmIxZWYx MTU1ODVkMWIyZDRiM2VlYmM5YjguLjYyODI0MTE1OTExNjY4MDU2ZWQyMTI0NDFlNDRkMzdmYjg2 ZmMwZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9K Uy9KU1Rlc3ROb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdE5vZGUuaApAQCAtMjgsNiArMjgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBj bGFzcyBXRUJDT1JFX1RFU1RTVVBQT1JUX0VYUE9SVCBKU1Rlc3ROb2RlIDogcHVibGljIEpTTm9k ZSB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBKU05vZGUgQmFzZTsKKyAgICB0eXBlZGVmIFRlc3RO b2RlIERPTVdyYXBwZWQ7CiAgICAgc3RhdGljIEpTVGVzdE5vZGUqIGNyZWF0ZShKU0M6OlN0cnVj dHVyZSogc3RydWN0dXJlLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBSZWY8VGVz dE5vZGU+JiYgaW1wbCkKICAgICB7CiAgICAgICAgIEpTVGVzdE5vZGUqIHB0ciA9IG5ldyAoTm90 TnVsbCwgSlNDOjphbGxvY2F0ZUNlbGw8SlNUZXN0Tm9kZT4oZ2xvYmFsT2JqZWN0LT52bSgpLmhl YXApKSBKU1Rlc3ROb2RlKHN0cnVjdHVyZSwgKmdsb2JhbE9iamVjdCwgV1RGTW92ZShpbXBsKSk7 Cg==