158808 2016-06-15 13:36:52 -0700 Uncaught Exception: TypeError: undefined is not an object (evaluating 'imageElement.classList') 2016-06-15 14:15:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://www.apple.com/watch/ InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1202669 0 joepeck 2016-06-15 13:36:52 -0700 I see this occasionally. ------- Auto-generated details: Inspected URL: http://www.apple.com/watch/ Uncaught exceptions: - TypeError: undefined is not an object (evaluating 'imageElement.classList') (at HeapAllocationsTimelineOverviewGraph.js:112:21) _updateSnapshotMarkers @ HeapAllocationsTimelineOverviewGraph.js:112:21 updateSelectedRecord @ HeapAllocationsTimelineOverviewGraph.js:95:36 ? @ TimelineOverviewGraph.js:248:38 ------- * STEPS TO REPRODUCE 1. Inspect apple.com/watch/ 2. Start a timeline recording and stop 3. Add Allocations timeline 4. Wait 10 seconds so a new recording would be offscreen of the overview graph 5. Take a heap snapshot 6. Go into that heap snapshot => Exception * NOTES I think the issue here is that the snapshot doesn't have an image element in the overview graph, so we should have bailed earlier. 1202670 1 webkit-bug-importer 2016-06-15 13:38:54 -0700 <rdar://problem/26821034> 1202671 2 281385 joepeck 2016-06-15 13:42:35 -0700 Created attachment 281385 [PATCH] Proposed Fix 1202678 3 281385 bburg 2016-06-15 13:54:42 -0700 Comment on attachment 281385 [PATCH] Proposed Fix r=me 1202686 4 281385 commit-queue 2016-06-15 14:15:12 -0700 Comment on attachment 281385 [PATCH] Proposed Fix Clearing flags on attachment: 281385 Committed r202106: <http://trac.webkit.org/changeset/202106> 1202687 5 commit-queue 2016-06-15 14:15:16 -0700 All reviewed patches have been landed. Closing bug. 281385 2016-06-15 13:42:35 -0700 2016-06-15 14:15:12 -0700 [PATCH] Proposed Fix fix-uncaught.patch text/plain 1956 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUyZDFiN2YuLmFlNjNlMmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA2LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBU eXBlRXJyb3I6IHVuZGVmaW5lZCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdpbWFnZUVs ZW1lbnQuY2xhc3NMaXN0JykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1ODgwOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY4MjEwMzQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJv dG90eXBlLl91cGRhdGVTbmFwc2hvdE1hcmtlcnMpOgorICAgICAgICBJZiB0aGUgcmVjb3JkIGlz IG91dCBvZiB0aGUgbGF5b3V0IGJvdW5kcyBvZiB0aGUgb3ZlcnZpZXcgZ3JhcGgsIHRoZSBvdmVy dmlldyBncmFwaAorICAgICAgICBtYXkgbm90IGhhdmUgY3JlYXRlZCBhbiBpbWFnZSBlbGVtZW50 IHlldCwgc28gYmFpbC4gTGF0ZXIsIHdoZW4gdGhlIGltYWdlIGVsZW1lbnQKKyAgICAgICAgaXMg Y3JlYXRlZCwgaXQgd291bGQgZ2V0IHRoZSBhcHByb3ByaWF0ZSBzdHlsZSBpZiB0aGUgcmVjb3Jk IGlzIHNlbGVjdGVkLgorCiAyMDE2LTA2LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY29uc29sZS5wcm9maWxlIHNob3Vs ZCB1c2UgdGhlIG5ldyBTYW1wbGluZyBQcm9maWxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVPdmVy dmlld0dyYXBoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv SGVhcEFsbG9jYXRpb25zVGltZWxpbmVPdmVydmlld0dyYXBoLmpzCmluZGV4IDBhOTcxZGUuLmIy YjI2NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGlu ZU92ZXJ2aWV3R3JhcGguanMKQEAgLTEwOCw3ICsxMDgsOSBAQCBXZWJJbnNwZWN0b3IuSGVhcEFs bG9jYXRpb25zVGltZWxpbmVPdmVydmlld0dyYXBoID0gY2xhc3MgSGVhcEFsbG9jYXRpb25zVGlt ZWxpbgogICAgICAgICB9CiAKICAgICAgICAgbGV0IGltYWdlRWxlbWVudCA9IHRoaXMuc2VsZWN0 ZWRSZWNvcmRbV2ViSW5zcGVjdG9yLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lT3ZlcnZpZXdHcmFw aC5SZWNvcmRFbGVtZW50QXNzb2NpYXRpb25TeW1ib2xdOwotICAgICAgICBjb25zb2xlLmFzc2Vy dChpbWFnZUVsZW1lbnQsICJNaXNzaW5nIHNuYXBzaG90IGltYWdlIGVsZW1lbnQgZm9yIHNlbGVj dGVkIHJlY29yZCIsIHRoaXMuc2VsZWN0ZWRSZWNvcmQpOworICAgICAgICBpZiAoIWltYWdlRWxl bWVudCkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBpbWFnZUVsZW1lbnQuY2xhc3NM aXN0LmFkZCgic2VsZWN0ZWQiKTsKIAogICAgICAgICB0aGlzLl9zZWxlY3RlZEltYWdlRWxlbWVu dCA9IGltYWdlRWxlbWVudDsK