158805 2016-06-15 12:29:09 -0700 Revert part of r196034 2016-06-15 18:29:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1202652 0 achristensen 2016-06-15 12:29:09 -0700 Revert part of r196034 1202654 1 281381 achristensen 2016-06-15 12:32:23 -0700 Created attachment 281381 Patch 1202663 2 281382 achristensen 2016-06-15 12:44:51 -0700 Created attachment 281382 Patch 1202665 3 achristensen 2016-06-15 12:55:19 -0700 The intent of that change in r196034 was to make sure the completion handler is always called. Adding the calling of the completion handler in the destructor accomplishes this. 1202808 4 achristensen 2016-06-15 18:29:21 -0700 http://trac.webkit.org/changeset/202119 281381 2016-06-15 12:32:23 -0700 2016-06-15 12:44:48 -0700 Patch bug-158805-20160615123224.patch text/plain 1589 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjA5OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2ZXJ0IHBh cnQgb2YgcjE5NjAzNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU4ODA1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI2Nzg4MTM4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdv cmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxv YWRlcjo6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZSk6CisgICAgICAgIElm IHRoZXJlJ3Mgbm8gY29yZSBsb2FkZXIsIHdlIGNhbid0IHNlbmQgSVBDLgorCiAyMDE2LTA2LTE1 ICBSb21haW4gQmVsbGVzc29ydCAgPHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KIAog ICAgICAgICBFbmFibGluZyBTaGFkb3cgRE9NIGZvciBhbGwgcGxhdGZvcm1zCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxv YWRlci5jcHAJKHJldmlzaW9uIDIwMjA1MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv TmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxNCw4ICsy MTQsMTEgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc291cgogI2lmIFVT RShQUk9URUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJBQ0spCiB2b2lkIFdlYlJlc291cmNlTG9hZGVy OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKGNvbnN0IFByb3RlY3Rpb25T cGFjZSYgcHJvdGVjdGlvblNwYWNlKQogewotICAgIGJvb2wgcmVzdWx0ID0gbV9jb3JlTG9hZGVy ID8gbV9jb3JlTG9hZGVyLT5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKHBy b3RlY3Rpb25TcGFjZSkgOiBmYWxzZTsKLQorICAgIGlmICghbV9jb3JlTG9hZGVyKQorICAgICAg ICByZXR1cm47CisgICAgCisgICAgYm9vbCByZXN1bHQgPSBtX2NvcmVMb2FkZXItPmNhbkF1dGhl bnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UocHJvdGVjdGlvblNwYWNlKTsKKyAgICAKICAg ICBzZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OkNvbnRpbnVlQ2FuQXV0aGVu dGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZShyZXN1bHQpKTsKIH0KICNlbmRpZgo= 281382 2016-06-15 12:44:51 -0700 2016-06-15 18:29:29 -0700 Patch bug-158805-20160615124452.patch text/plain 2624 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjEwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA2LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2ZXJ0IHBh cnQgb2YgcjE5NjAzNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU4ODA1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI2Nzg4MTM4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrTG9hZC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjp+TmV0d29ya0xv YWQpOgorICAgICAgICBJZiB0aGUgV2ViUmVzb3VyY2VMb2FkZXIgd2FzIGRlc3Ryb3llZCBhbmQg cmVjZWl2ZWQgYSBjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlCisgICAgICAg IGJ1dCBkaWQgbm90IHNlbmQgYSBjb250aW51ZUNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0 aW9uU3BhY2UgYW5zd2VyIGJlY2F1c2UgdGhlcmUncyBubworICAgICAgICBjb3JlIGxvYWRlciwg dGhlbiB0aGUgTmV0d29ya0xvYWQgd2lsbCBiZSBkZXN0cm95ZWQuICBXaGVuIHRoaXMgaGFwcGVu cywgd2Ugc3RpbGwgbmVlZCB0byBjYWxsCisgICAgICAgIHRoZSBjYWxsYmFjayBmb3IgdGhlIGNo YWxsZW5nZS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRlcjo6Y2FuQXV0aGVudGljYXRl QWdhaW5zdFByb3RlY3Rpb25TcGFjZSk6CisgICAgICAgIElmIHRoZXJlJ3Mgbm8gY29yZSBsb2Fk ZXIsIHdlIGNhbid0IHNlbmQgSVBDLgorCiAyMDE2LTA2LTE1ICBSb21haW4gQmVsbGVzc29ydCAg PHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBFbmFibGluZyBTaGFk b3cgRE9NIGZvciBhbGwgcGxhdGZvcm1zCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrTG9hZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCShyZXZpc2lvbiAyMDIwNTMpCisrKyBTb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1 LDYgKzc1LDggQEAgTmV0d29ya0xvYWQ6On5OZXR3b3JrTG9hZCgpCiAjaWYgVVNFKE5FVFdPUktf U0VTU0lPTikKICAgICBpZiAobV9yZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyKQogICAgICAgICBt X3Jlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIoUG9saWN5SWdub3JlKTsKKyAgICBpZiAobV9jaGFs bGVuZ2VDb21wbGV0aW9uSGFuZGxlcikKKyAgICAgICAgbV9jaGFsbGVuZ2VDb21wbGV0aW9uSGFu ZGxlcihBdXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpDYW5jZWwsIHsgfSk7CiAg ICAgaWYgKG1fdGFzaykKICAgICAgICAgbV90YXNrLT5jbGVhckNsaWVudCgpOwogI2VuZGlmCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJS ZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDIwMjA1MykKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIxNCw4ICsyMTQsMTEgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc291 cgogI2lmIFVTRShQUk9URUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJBQ0spCiB2b2lkIFdlYlJlc291 cmNlTG9hZGVyOjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKGNvbnN0IFBy b3RlY3Rpb25TcGFjZSYgcHJvdGVjdGlvblNwYWNlKQogewotICAgIGJvb2wgcmVzdWx0ID0gbV9j b3JlTG9hZGVyID8gbV9jb3JlTG9hZGVyLT5jYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlv blNwYWNlKHByb3RlY3Rpb25TcGFjZSkgOiBmYWxzZTsKLQorICAgIGlmICghbV9jb3JlTG9hZGVy KQorICAgICAgICByZXR1cm47CisgICAgCisgICAgYm9vbCByZXN1bHQgPSBtX2NvcmVMb2FkZXIt PmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UocHJvdGVjdGlvblNwYWNlKTsK KyAgICAKICAgICBzZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OkNvbnRpbnVl Q2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZShyZXN1bHQpKTsKIH0KICNlbmRp Zgo=