158781 2016-06-15 06:18:37 -0700 [Win] Rendering is not scaled correctly if process is DPI aware. 2016-06-17 04:21:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham oldest_to_newest 1202546 0 pvollan 2016-06-15 06:18:37 -0700 This only happens in accelerated compositing mode. 1202548 1 281353 pvollan 2016-06-15 06:24:48 -0700 Created attachment 281353 Patch 1202554 2 281353 bfulgham 2016-06-15 06:41:23 -0700 Comment on attachment 281353 Patch This change looks reasonable, but I wish we had a test case that protected us from this happening again. Do we have any test cases to show this problem? How did you realize this was not working properly? 1202560 3 pvollan 2016-06-15 07:09:31 -0700 (In reply to comment #2) > Comment on attachment 281353 [details] > Patch > > This change looks reasonable, but I wish we had a test case that protected > us from this happening again. Do we have any test cases to show this > problem? How did you realize this was not working properly? I don't think we currently have any test cases since DumpRenderTree is not DPI aware. I noticed the bug when browsing with MiniBrowser, which is DPI aware now. Maybe we should create some tests where DumpRenderTree is DPI aware? Thanks for reviewing :) 1203285 4 pvollan 2016-06-17 04:21:15 -0700 Committed r202163: <https://trac.webkit.org/changeset/202163> 281353 2016-06-15 06:24:48 -0700 2016-06-15 06:41:23 -0700 Patch bug-158781-20160615062625.patch text/plain 1593 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjA4OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTE1 ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBS ZW5kZXJpbmcgaXMgbm90IHNjYWxlZCBjb3JyZWN0bHkgaWYgcHJvY2VzcyBpcyBEUEkgYXdhcmUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3ODEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTY2FsZSB0 aGUgcm9vdCBncmFwaGljcyBsYXllciB3aXRoIHRoZSBkZXZpY2Ugc2NhbGUgZmFjdG9yLgorCisg ICAgICAgICogV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJWaWV3OjpzZXRBY2NlbGVyYXRlZENv bXBvc2l0aW5nKToKKwogMjAxNi0wNi0xMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBXZWJTb2NrZXRQcm92aWRlciBzdHViCkluZGV4 OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMjAyMDg4KQorKysgU291cmNlL1dlYktpdC93 aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5NDQsNiArNjk0NCwxMSBAQCB2b2lk IFdlYlZpZXc6OnNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoCiAgICAgICAgICAgICBtX2JhY2tp bmdMYXllci0+c2V0TmVlZHNEaXNwbGF5KCk7CiAgICAgICAgICAgICBtX2xheWVyVHJlZUhvc3Qt PnNldFJvb3RDaGlsZExheWVyKFBsYXRmb3JtQ0FMYXllcjo6cGxhdGZvcm1DQUxheWVyKG1fYmFj a2luZ0xheWVyLT5wbGF0Zm9ybUxheWVyKCkpKTsKIAorICAgICAgICAgICAgVHJhbnNmb3JtYXRp b25NYXRyaXggbTsKKyAgICAgICAgICAgIG0uc2NhbGUoZGV2aWNlU2NhbGVGYWN0b3IoKSk7Cisg ICAgICAgICAgICBtX2JhY2tpbmdMYXllci0+c2V0QW5jaG9yUG9pbnQoRmxvYXRQb2ludDNEKCkp OworICAgICAgICAgICAgbV9iYWNraW5nTGF5ZXItPnNldFRyYW5zZm9ybShtKTsKKwogICAgICAg ICAgICAgLy8gV2UgYXJlbid0IGdvaW5nIHRvIGJlIHVzaW5nIG91ciBiYWNraW5nIHN0b3JlIHdo aWxlIHdlJ3JlIGluIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nCiAgICAgICAgICAgICAvLyBtb2Rl LiBCdXQgZG9uJ3QgZGVsZXRlIGl0IGltbWVkaWF0ZWx5LCBpbiBjYXNlIHdlIHN3aXRjaCBvdXQg b2YgYWNjZWxlcmF0ZWQKICAgICAgICAgICAgIC8vIGNvbXBvc2l0aW5nIG1vZGUgc29vbiAoZS5n LiwgaWYgd2UncmUgb25seSBjb21wb3NpdGluZyBmb3IgYSA6aG92ZXIgYW5pbWF0aW9uKS4K