158779 2016-06-15 02:01:50 -0700 WebRTC: (Refactor) Align the structure of RTCPeerConnection.idl with the header file 2016-06-15 14:27:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned commit-queue oldest_to_newest 1202530 0 adam.bergkvist 2016-06-15 02:01:50 -0700 Align the structure of RTCPeerConnection.idl with the corresponding header file to make it easier to read and extend in the future. 1202533 1 281346 adam.bergkvist 2016-06-15 02:08:12 -0700 Created attachment 281346 Proposed patch 1202684 2 281346 adam.bergkvist 2016-06-15 14:05:38 -0700 Comment on attachment 281346 Proposed patch Thanks for reviewing Eric! 1202692 3 281346 commit-queue 2016-06-15 14:27:35 -0700 Comment on attachment 281346 Proposed patch Clearing flags on attachment: 281346 Committed r202109: <http://trac.webkit.org/changeset/202109> 1202693 4 commit-queue 2016-06-15 14:27:38 -0700 All reviewed patches have been landed. Closing bug. 281346 2016-06-15 02:08:12 -0700 2016-06-15 14:27:35 -0700 Proposed patch pc-idl-structure_0.patch text/plain 4562 adam.bergkvist ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NzcxMTRhLi5kYzJmMDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTYtMDYtMTUgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgorCisgICAgICAgIFdlYlJUQzogKFJlZmFjdG9yKSBBbGlnbiB0aGUgc3RydWN0dXJlIG9m IFJUQ1BlZXJDb25uZWN0aW9uLmlkbCB3aXRoIHRoZSBoZWFkZXIgZmlsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4Nzc5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzdHJ1Y3R1cmUgUlRDUGVlckNv bm5lY3Rpb24uaWRsIHRvIG1ha2UgaXQgZWFzZXIgdG8gcmVhZCBhbmQgZXh0ZW5kIGluIHRoZSBm dXR1cmUuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5pZGw6CisKIDIwMTYtMDYtMTQgIENv bW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIyMDIwNTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaWRsCmluZGV4IGY3NzkzZTIuLjkw ODI4MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD UGVlckNvbm5lY3Rpb24uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vUlRDUGVlckNvbm5lY3Rpb24uaWRsCkBAIC0zOCwxNSArMzgsMTYgQEAKICAgICBDdXN0b21D b25zdHJ1Y3RvcihEaWN0aW9uYXJ5IHJ0Y0NvbmZpZ3VyYXRpb24pLAogICAgIEludGVyZmFjZU5h bWU9d2Via2l0UlRDUGVlckNvbm5lY3Rpb24sCiBdIGludGVyZmFjZSBSVENQZWVyQ29ubmVjdGlv biA6IEV2ZW50VGFyZ2V0IHsKKyAgICAvLyBSVFAgTWVkaWEgQVBJIGV4dGVuc2lvbnMKKyAgICBz ZXF1ZW5jZTxSVENSdHBTZW5kZXI+IGdldFNlbmRlcnMoKTsKKyAgICBzZXF1ZW5jZTxSVENSdHBS ZWNlaXZlcj4gZ2V0UmVjZWl2ZXJzKCk7CisgICAgc2VxdWVuY2U8UlRDUnRwVHJhbnNjZWl2ZXI+ IGdldFRyYW5zY2VpdmVycygpOwogCi0gICAgLy8gUHJpdmF0ZSBmdW5jdGlvbnMgY2FsbGVkIGJ5 IHJ1blF1ZXVlZE9wZXJhdGlvbigpIChSVENQZWVyQ29ubmVjdGlvbkludGVybmFscy5qcykKLSAg ICBbUHJpdmF0ZV0gUHJvbWlzZSBxdWV1ZWRDcmVhdGVPZmZlcihvcHRpb25hbCBEaWN0aW9uYXJ5 IG9mZmVyT3B0aW9ucyk7Ci0gICAgW1ByaXZhdGVdIFByb21pc2UgcXVldWVkQ3JlYXRlQW5zd2Vy KG9wdGlvbmFsIERpY3Rpb25hcnkgYW5zd2VyT3B0aW9ucyk7Ci0gICAgW1ByaXZhdGVdIFByb21p c2UgcXVldWVkU2V0TG9jYWxEZXNjcmlwdGlvbihSVENTZXNzaW9uRGVzY3JpcHRpb24gZGVzY3Jp cHRpb24pOwotICAgIFtQcml2YXRlXSBQcm9taXNlIHF1ZXVlZFNldFJlbW90ZURlc2NyaXB0aW9u KFJUQ1Nlc3Npb25EZXNjcmlwdGlvbiBkZXNjcmlwdGlvbik7Ci0gICAgW1ByaXZhdGVdIFByb21p c2UgcXVldWVkQWRkSWNlQ2FuZGlkYXRlKFJUQ0ljZUNhbmRpZGF0ZSBjYW5kaWRhdGUpOworICAg IFtTdHJpY3RUeXBlQ2hlY2tpbmcsIFJhaXNlc0V4Y2VwdGlvbl0gUlRDUnRwU2VuZGVyIGFkZFRy YWNrKE1lZGlhU3RyZWFtVHJhY2sgdHJhY2ssIE1lZGlhU3RyZWFtLi4uIHN0cmVhbXMpOworICAg IFtTdHJpY3RUeXBlQ2hlY2tpbmcsIFJhaXNlc0V4Y2VwdGlvbl0gdm9pZCByZW1vdmVUcmFjayhS VENSdHBTZW5kZXIgc2VuZGVyKTsKIAotICAgIFtQcml2YXRlXSBQcm9taXNlIHByaXZhdGVHZXRT dGF0cyhNZWRpYVN0cmVhbVRyYWNrPyBzZWxlY3Rvcik7CisgICAgW1N0cmljdFR5cGVDaGVja2lu ZywgUmFpc2VzRXhjZXB0aW9uXSBSVENSdHBUcmFuc2NlaXZlciBhZGRUcmFuc2NlaXZlcihNZWRp YVN0cmVhbVRyYWNrIHRyYWNrLCBvcHRpb25hbCBSVENSdHBUcmFuc2NlaXZlckluaXQgaW5pdCk7 CisgICAgW1N0cmljdFR5cGVDaGVja2luZywgUmFpc2VzRXhjZXB0aW9uXSBSVENSdHBUcmFuc2Nl aXZlciBhZGRUcmFuc2NlaXZlcihET01TdHJpbmcga2luZCwgb3B0aW9uYWwgUlRDUnRwVHJhbnNj ZWl2ZXJJbml0IGluaXQpOwogCiAgICAgW0pTQnVpbHRpbl0gUHJvbWlzZSBjcmVhdGVPZmZlcihv cHRpb25hbCBEaWN0aW9uYXJ5IG9mZmVyT3B0aW9ucyk7CiAgICAgLy8gTGVnYWN5IHNpZ25hdHVy ZTogUHJvbWlzZSBjcmVhdGVPZmZlcihSVENTZXNzaW9uRGVzY3JpcHRpb25DYWxsYmFjayBzdWNj ZXNzQ2FsbGJhY2sKQEAgLTU4LDE2ICs1OSw2IEBACiAgICAgLy8gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgUlRDUGVlckNvbm5lY3Rpb25FcnJvckNhbGxiYWNrIGVycm9y Q2FsbGJhY2ssCiAgICAgLy8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg b3B0aW9uYWwgRGljdGlvbmFyeSBhbnN3ZXJPcHRpb25zKTsKIAotICAgIHNlcXVlbmNlPFJUQ1J0 cFNlbmRlcj4gZ2V0U2VuZGVycygpOwotICAgIHNlcXVlbmNlPFJUQ1J0cFJlY2VpdmVyPiBnZXRS ZWNlaXZlcnMoKTsKLSAgICBzZXF1ZW5jZTxSVENSdHBUcmFuc2NlaXZlcj4gZ2V0VHJhbnNjZWl2 ZXJzKCk7Ci0KLSAgICBbU3RyaWN0VHlwZUNoZWNraW5nLCBSYWlzZXNFeGNlcHRpb25dIFJUQ1J0 cFNlbmRlciBhZGRUcmFjayhNZWRpYVN0cmVhbVRyYWNrIHRyYWNrLCBNZWRpYVN0cmVhbS4uLiBz dHJlYW1zKTsKLSAgICBbU3RyaWN0VHlwZUNoZWNraW5nLCBSYWlzZXNFeGNlcHRpb25dIHZvaWQg cmVtb3ZlVHJhY2soUlRDUnRwU2VuZGVyIHNlbmRlcik7Ci0KLSAgICBbU3RyaWN0VHlwZUNoZWNr aW5nLCBSYWlzZXNFeGNlcHRpb25dIFJUQ1J0cFRyYW5zY2VpdmVyIGFkZFRyYW5zY2VpdmVyKE1l ZGlhU3RyZWFtVHJhY2sgdHJhY2ssIG9wdGlvbmFsIFJUQ1J0cFRyYW5zY2VpdmVySW5pdCBpbml0 KTsKLSAgICBbU3RyaWN0VHlwZUNoZWNraW5nLCBSYWlzZXNFeGNlcHRpb25dIFJUQ1J0cFRyYW5z Y2VpdmVyIGFkZFRyYW5zY2VpdmVyKERPTVN0cmluZyBraW5kLCBvcHRpb25hbCBSVENSdHBUcmFu c2NlaXZlckluaXQgaW5pdCk7Ci0KICAgICBbSlNCdWlsdGluXSBQcm9taXNlIHNldExvY2FsRGVz Y3JpcHRpb24oUlRDU2Vzc2lvbkRlc2NyaXB0aW9uIGRlc2NyaXB0aW9uKTsKICAgICAvLyBMZWdh Y3kgc2lnbmF0dXJlOiBQcm9taXNlIHNldExvY2FsRGVzY3JpcHRpb24oUlRDU2Vzc2lvbkRlc2Ny aXB0aW9uIGRlc2NyaXB0aW9uCiAgICAgLy8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFZvaWRDYWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssCkBAIC0xMDQsNiAr OTUsMTUgQEAKICAgICAvLyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFJUQ1N0 YXRzQ2FsbGJhY2sgc3VjY2Vzc0NhbGxiYWNrLAogICAgIC8vICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgUlRDUGVlckNvbm5lY3Rpb25FcnJvckNhbGxiYWNrIGVycm9yQ2FsbGJh Y2spOwogCisgICAgLy8gUHJpdmF0ZSBBUEkgdXNlZCB0byBpbXBsZW1lbnQgdGhlIG92ZXJsb2Fk ZWQgb3BlcmF0aW9ucyBhYm92ZS4gUXVldWVkIGZ1bmN0aW9ucyBhcmUgY2FsbGVkIGJ5CisgICAg Ly8gcnVuUXVldWVkT3BlcmF0aW9uKCkgKGRlZmluZWQgaW4gUlRDUGVlckNvbm5lY3Rpb25JbnRl cm5hbHMuanMpLgorICAgIFtQcml2YXRlXSBQcm9taXNlIHF1ZXVlZENyZWF0ZU9mZmVyKG9wdGlv bmFsIERpY3Rpb25hcnkgb2ZmZXJPcHRpb25zKTsKKyAgICBbUHJpdmF0ZV0gUHJvbWlzZSBxdWV1 ZWRDcmVhdGVBbnN3ZXIob3B0aW9uYWwgRGljdGlvbmFyeSBhbnN3ZXJPcHRpb25zKTsKKyAgICBb UHJpdmF0ZV0gUHJvbWlzZSBxdWV1ZWRTZXRMb2NhbERlc2NyaXB0aW9uKFJUQ1Nlc3Npb25EZXNj cmlwdGlvbiBkZXNjcmlwdGlvbik7CisgICAgW1ByaXZhdGVdIFByb21pc2UgcXVldWVkU2V0UmVt b3RlRGVzY3JpcHRpb24oUlRDU2Vzc2lvbkRlc2NyaXB0aW9uIGRlc2NyaXB0aW9uKTsKKyAgICBb UHJpdmF0ZV0gUHJvbWlzZSBxdWV1ZWRBZGRJY2VDYW5kaWRhdGUoUlRDSWNlQ2FuZGlkYXRlIGNh bmRpZGF0ZSk7CisgICAgW1ByaXZhdGVdIFByb21pc2UgcHJpdmF0ZUdldFN0YXRzKE1lZGlhU3Ry ZWFtVHJhY2s/IHNlbGVjdG9yKTsKKwogICAgIFtSYWlzZXNFeGNlcHRpb25dIFJUQ0RhdGFDaGFu bmVsIGNyZWF0ZURhdGFDaGFubmVsKFtUcmVhdE51bGxBcz1FbXB0eVN0cmluZ10gRE9NU3RyaW5n IGxhYmVsLCBvcHRpb25hbCBEaWN0aW9uYXJ5IG9wdGlvbnMpOwogCiAgICAgdm9pZCBjbG9zZSgp Owo=