158770 2016-06-14 18:23:07 -0700 [iOS] Play glyph is pixelated when the page zoom is large 2016-06-14 19:06:04 -0700 1 1 1 Unclassified WebKit Media Other iPhone / iPad iOS 9.3 RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts webkit-bug-importer oldest_to_newest 1202421 0 281307 graouts 2016-06-14 18:23:07 -0700 Created attachment 281307 Testcase See the attached test case which has a <video> element with a rather large viewport width forcing a lot of page zoom. In that situation, the play glyph over the video is very pixelated. 1202422 1 graouts 2016-06-14 18:23:23 -0700 <rdar://problem/26092124> 1202425 2 281308 graouts 2016-06-14 18:25:18 -0700 Created attachment 281308 Patch 1202426 3 281308 darin 2016-06-14 18:27:06 -0700 Comment on attachment 281308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281308&action=review > Source/WebCore/ChangeLog:11 > + Use the same technique that we use to scale the video controls by using a combination > + of CSS "zoom" and "transform" properties to have the video play glyph scaled at its > + native size regardless of page zoom. Should we make a helper function for this to avoid repeating the code? 1202429 4 graouts 2016-06-14 18:32:27 -0700 (In reply to comment #3) > Comment on attachment 281308 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281308&action=review > > > Source/WebCore/ChangeLog:11 > > + Use the same technique that we use to scale the video controls by using a combination > > + of CSS "zoom" and "transform" properties to have the video play glyph scaled at its > > + native size regardless of page zoom. > > Should we make a helper function for this to avoid repeating the code? Sure thing. I'll add an inline function to the `scaleFactor` setter. 1202431 5 281310 graouts 2016-06-14 18:37:06 -0700 Created attachment 281310 Patch for landing 1202439 6 281310 commit-queue 2016-06-14 19:06:01 -0700 Comment on attachment 281310 Patch for landing Clearing flags on attachment: 281310 Committed r202079: <http://trac.webkit.org/changeset/202079> 1202440 7 commit-queue 2016-06-14 19:06:04 -0700 All reviewed patches have been landed. Closing bug. 281307 2016-06-14 18:23:07 -0700 2016-06-14 18:23:07 -0700 Testcase simple-video.html text/html 521 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJ3aWR0aD0yMDQ4Ij4KICAgIDx0aXRsZT5SZWR1Y3Rpb24gZm9yIHBpeGVsYXRlZCBw bGF5IGdseXBoPC90aXRsZT4KICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVl biI+CgogICAgdmlkZW8gewogICAgICAgIHdpZHRoOiA1MDBweDsKICAgICAgICBoZWlnaHQ6IDUw MHB4OwogICAgfQoKICAgIDwvc3R5bGU+CjwvaGVhZD4KPGJvZHk+CiAgICA8dmlkZW8gcHJlbG9h ZD0iYXV0byIgc3JjPSJodHRwOi8vcC5ldmVudHMtZGVsaXZlcnkuYXBwbGUuY29tLmVkZ2VzdWl0 ZS5uZXQvMTYwM2tqYm5hZGNwamhiYXNkdnBqYmFzZHZwamIvbTN1OC9obHNfdm9kMTFfbXZwLm0z dTgiIGNvbnRyb2xzIHBvc3Rlcj0iaHR0cDovL2ltYWdlcy5hcHBsZS5jb20vYXBwbGUtZXZlbnRz L21hcmNoLTIwMTYvdmlkZW8vcG9zdGVyX21lZGl1bV8yeC5qcGciPjwvdmlkZW8+CjwvYm9keT4K PC9odG1sPgo= 281308 2016-06-14 18:25:18 -0700 2016-06-14 18:37:03 -0700 Patch bug-158770-20160614182654.patch text/plain 2188 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTc3MTE0YWE0MWZkMTlm NDM4YTY4MDU2YTdmM2Y1MzI0MGZkYjM0Mi4uZDEyMzlhMzE4OGI0NDY3MGZiZTk1MWIzMDkwNzZi MjJmYTRkODQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUGxheSBnbHlw aCBpcyBwaXhlbGF0ZWQgd2hlbiB0aGUgcGFnZSB6b29tIGlzIGxhcmdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3NzAKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2MDkyMTI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVzZSB0aGUgc2FtZSB0ZWNobmlxdWUgdGhhdCB3ZSB1c2UgdG8gc2NhbGUg dGhlIHZpZGVvIGNvbnRyb2xzIGJ5IHVzaW5nIGEgY29tYmluYXRpb24KKyAgICAgICAgb2YgQ1NT ICJ6b29tIiBhbmQgInRyYW5zZm9ybSIgcHJvcGVydGllcyB0byBoYXZlIHRoZSB2aWRlbyBwbGF5 IGdseXBoIHNjYWxlZCBhdCBpdHMKKyAgICAgICAgbmF0aXZlIHNpemUgcmVnYXJkbGVzcyBvZiBw YWdlIHpvb20uCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c2lPUy5qczoKKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLnNldCBwYWdlU2NhbGVG YWN0b3IpOgorCiAyMDE2LTA2LTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjAyMDU3LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNp T1MuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c2lPUy5qcwppbmRleCBmYmMwMmUyNmJkNjMwMjA4MDMzZmZmN2YzYzk3ZjNmYzE2ZGEyN2E0Li4x ZGE0NjliZDkyMjMxYmFmMjIwMzJhZTExODQxZTU1NTcwN2I3MWNhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5q cwpAQCAtNTg0LDggKzU4NCwxNSBAQCBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsKIAogICAg ICAgICB2YXIgc2NhbGVWYWx1ZSA9IDEgLyBuZXdTY2FsZUZhY3RvcjsKICAgICAgICAgdmFyIHNj YWxlVHJhbnNmb3JtID0gInNjYWxlKCIgKyBzY2FsZVZhbHVlICsgIikiOwotICAgICAgICBpZiAo dGhpcy5jb250cm9scy5zdGFydFBsYXliYWNrQnV0dG9uKQotICAgICAgICAgICAgdGhpcy5jb250 cm9scy5zdGFydFBsYXliYWNrQnV0dG9uLnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9IHNjYWxlVHJh bnNmb3JtOworICAgICAgICBpZiAodGhpcy5jb250cm9scy5zdGFydFBsYXliYWNrQnV0dG9uKSB7 CisgICAgICAgICAgICBpZiAoc2NhbGVWYWx1ZSA+IDEpIHsKKyAgICAgICAgICAgICAgICB0aGlz LmNvbnRyb2xzLnN0YXJ0UGxheWJhY2tCdXR0b24uc3R5bGUuem9vbSA9IHNjYWxlVmFsdWU7Cisg ICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5zdGFydFBsYXliYWNrQnV0dG9uLnN0eWxlLndl YmtpdFRyYW5zZm9ybSA9ICJzY2FsZSgxKSI7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgICAgIHRoaXMuY29udHJvbHMuc3RhcnRQbGF5YmFja0J1dHRvbi5zdHlsZS56b29tID0g MTsKKyAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnN0YXJ0UGxheWJhY2tCdXR0b24uc3R5 bGUud2Via2l0VHJhbnNmb3JtID0gc2NhbGVUcmFuc2Zvcm07CisgICAgICAgICAgICB9CisgICAg ICAgIH0KICAgICAgICAgaWYgKHRoaXMuY29udHJvbHMucGFuZWwpIHsKICAgICAgICAgICAgIGlm IChzY2FsZVZhbHVlID4gMSkgewogICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwu c3R5bGUud2lkdGggPSAiMTAwJSI7Cg== 281310 2016-06-14 18:37:06 -0700 2016-06-14 19:06:01 -0700 Patch for landing bug-158770-20160614183842.patch text/plain 3117 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTc3MTE0YWE0MWZkMTlm NDM4YTY4MDU2YTdmM2Y1MzI0MGZkYjM0Mi4uYWMzZTE3NDJmZDE2NmYwMWQzYTg2Zjc2NjA4MDRi ZmZiZjQyZDVjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTE0ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUGxheSBnbHlw aCBpcyBwaXhlbGF0ZWQgd2hlbiB0aGUgcGFnZSB6b29tIGlzIGxhcmdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3NzAKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2MDkyMTI0PgorCisgICAgICAgIFJldmlld2VkIGJ5IERlYW4gSmFja3Nvbi4K KworICAgICAgICBVc2UgdGhlIHNhbWUgdGVjaG5pcXVlIHRoYXQgd2UgdXNlIHRvIHNjYWxlIHRo ZSB2aWRlbyBjb250cm9scyBieSB1c2luZyBhIGNvbWJpbmF0aW9uCisgICAgICAgIG9mIENTUyAi em9vbSIgYW5kICJ0cmFuc2Zvcm0iIHByb3BlcnRpZXMgdG8gaGF2ZSB0aGUgdmlkZW8gcGxheSBn bHlwaCBzY2FsZWQgYXQgaXRzCisgICAgICAgIG5hdGl2ZSBzaXplIHJlZ2FyZGxlc3Mgb2YgcGFn ZSB6b29tLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNp T1MuanM6CisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5zZXQgcGFnZVNjYWxlRmFj dG9yKToKKwogMjAxNi0wNi0xNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwMjA1Ny4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9T LmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNp T1MuanMKaW5kZXggZmJjMDJlMjZiZDYzMDIwODAzM2ZmZjdmM2M5N2YzZmMxNmRhMjdhNC4uOTFj ZWI1YjM0NDUwNzhhNDI0MmI2NTcxNmRjNzNlMjFlNWI5ZWExNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMK QEAgLTU4NCwyMiArNTg0LDMwIEBAIENvbnRyb2xsZXJJT1MucHJvdG90eXBlID0gewogCiAgICAg ICAgIHZhciBzY2FsZVZhbHVlID0gMSAvIG5ld1NjYWxlRmFjdG9yOwogICAgICAgICB2YXIgc2Nh bGVUcmFuc2Zvcm0gPSAic2NhbGUoIiArIHNjYWxlVmFsdWUgKyAiKSI7CisKKyAgICAgICAgZnVu Y3Rpb24gYXBwbHlTY2FsZUZhY3RvclRvRWxlbWVudChlbGVtZW50KSB7CisgICAgICAgICAgICBp ZiAoc2NhbGVWYWx1ZSA+IDEpIHsKKyAgICAgICAgICAgICAgICBlbGVtZW50LnN0eWxlLnpvb20g PSBzY2FsZVZhbHVlOworICAgICAgICAgICAgICAgIGVsZW1lbnQuc3R5bGUud2Via2l0VHJhbnNm b3JtID0gInNjYWxlKDEpIjsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAg ZWxlbWVudC5zdHlsZS56b29tID0gMTsKKyAgICAgICAgICAgICAgICBlbGVtZW50LnN0eWxlLndl YmtpdFRyYW5zZm9ybSA9IHNjYWxlVHJhbnNmb3JtOworICAgICAgICAgICAgfQorICAgICAgICB9 CisKICAgICAgICAgaWYgKHRoaXMuY29udHJvbHMuc3RhcnRQbGF5YmFja0J1dHRvbikKLSAgICAg ICAgICAgIHRoaXMuY29udHJvbHMuc3RhcnRQbGF5YmFja0J1dHRvbi5zdHlsZS53ZWJraXRUcmFu c2Zvcm0gPSBzY2FsZVRyYW5zZm9ybTsKKyAgICAgICAgICAgIGFwcGx5U2NhbGVGYWN0b3JUb0Vs ZW1lbnQodGhpcy5jb250cm9scy5zdGFydFBsYXliYWNrQnV0dG9uKTsKICAgICAgICAgaWYgKHRo aXMuY29udHJvbHMucGFuZWwpIHsKKyAgICAgICAgICAgIGFwcGx5U2NhbGVGYWN0b3JUb0VsZW1l bnQodGhpcy5jb250cm9scy5wYW5lbCk7CiAgICAgICAgICAgICBpZiAoc2NhbGVWYWx1ZSA+IDEp IHsKICAgICAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLnN0eWxlLndpZHRoID0gIjEw MCUiOwotICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuc3R5bGUuem9vbSA9IHNj YWxlVmFsdWU7Ci0gICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5zdHlsZS53ZWJr aXRUcmFuc2Zvcm0gPSAic2NhbGUoMSkiOwogICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMu dGltZWxpbmVCb3guc3R5bGUud2Via2l0VGV4dFNpemVBZGp1c3QgPSAoMTAwICogc2NhbGVWYWx1 ZSkgKyAiJSI7CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgIHZhciBib3R0 b21BbGlnbWVudCA9IC0yICogc2NhbGVWYWx1ZTsKICAgICAgICAgICAgICAgICB0aGlzLmNvbnRy b2xzLnBhbmVsLnN0eWxlLmJvdHRvbSA9IGJvdHRvbUFsaWdtZW50ICsgInB4IjsKICAgICAgICAg ICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsLnN0eWxlLnBhZGRpbmdCb3R0b20gPSAtKG5ld1Nj YWxlRmFjdG9yICogYm90dG9tQWxpZ21lbnQpICsgInB4IjsKICAgICAgICAgICAgICAgICB0aGlz LmNvbnRyb2xzLnBhbmVsLnN0eWxlLndpZHRoID0gTWF0aC5yb3VuZChuZXdTY2FsZUZhY3RvciAq IDEwMCkgKyAiJSI7Ci0gICAgICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5zdHlsZS53 ZWJraXRUcmFuc2Zvcm0gPSBzY2FsZVRyYW5zZm9ybTsKICAgICAgICAgICAgICAgICB0aGlzLmNv bnRyb2xzLnRpbWVsaW5lQm94LnN0eWxlLndlYmtpdFRleHRTaXplQWRqdXN0ID0gImF1dG8iOwot ICAgICAgICAgICAgICAgIHRoaXMuY29udHJvbHMucGFuZWwuc3R5bGUuem9vbSA9IDE7CiAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB0aGlzLmNvbnRyb2xzLnBhbmVsQmFja2dyb3VuZC5zdHls ZS5oZWlnaHQgPSAoNTAgKiBzY2FsZVZhbHVlKSArICJweCI7CiAK