158764 2016-06-14 16:06:30 -0700 Web Inspector: Rename DataGrid.showColumn to setColumnVisible 2016-06-14 19:51:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1202375 0 mattbaker 2016-06-14 16:06:30 -0700 * SUMMARY Rename DataGrid.showColumn to setColumnVisible. The name change better expresses the method's behavior (this is a follow up to https://bugs.webkit.org/show_bug.cgi?id=158676). 1202378 1 webkit-bug-importer 2016-06-14 16:09:43 -0700 <rdar://problem/26801448> 1202411 2 281303 mattbaker 2016-06-14 17:54:33 -0700 Created attachment 281303 [Patch] Proposed Fix 1202447 3 281303 joepeck 2016-06-14 19:28:55 -0700 Comment on attachment 281303 [Patch] Proposed Fix r=me, thanks! 1202454 4 281303 commit-queue 2016-06-14 19:50:57 -0700 Comment on attachment 281303 [Patch] Proposed Fix Clearing flags on attachment: 281303 Committed r202082: <http://trac.webkit.org/changeset/202082> 1202455 5 commit-queue 2016-06-14 19:51:02 -0700 All reviewed patches have been landed. Closing bug. 281303 2016-06-14 17:54:33 -0700 2016-06-14 19:50:57 -0700 [Patch] Proposed Fix bug-158764-20160614175609.patch text/plain 4485 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm MjMxMWNiNGEyYzA4YjFjODM4ZTdiMDZiMTgxYTNmMjQ4ZDQ2OTgyLi40N2QwM2ExOWZhMTg3N2Vm YzcyMTcxYjhkOTM4ZjJkMDM3YmIyMzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNi0wNi0xNCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVuYW1lIERhdGFHcmlkLnNob3dDb2x1bW4gdG8g c2V0Q29sdW1uVmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU4NzY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjgwMTQ0OD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQpOgor ICAgICAgICBEcml2ZS1ieSB1cGRhdGUgdG8gaW5pdGlhbGl6ZSAidGhpcy5fY29sdW1uQ2hvb3Nl ckVuYWJsZWQiLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLnNl dCBpZGVudGlmaWVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUu aW5zZXJ0Q29sdW1uKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUu X2NvbGxhcHNlQ29sdW1uR3JvdXBXaXRoQ2VsbCk6CisgICAgICAgIFVzZSBuZXcgbWV0aG9kIG5h bWUuCisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvbnRleHRN ZW51SW5IZWFkZXIpOgorICAgICAgICBEcml2ZS1ieSBzdHlsZSB1cGRhdGUuCisKIDIwMTYtMDYt MTQgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHRoZSB1bnByZWZpeGVkIHZlcnNpb24gb2YgdGhlIHBzZXVkbyBlbGVtZW50IDo6cGxhY2Vob2xk ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RGF0YUdyaWQuanMKaW5kZXggODBlZGYzY2RmNWRjMjQxMzEwMzk5ZDk0ZjQ5NzgzMjllZDZkZjY0 YS4uNDYwYjE4YThjYmEwMGM1OGFkYTdhM2Y3MTM4MzAzNWE2YjUwNjQ5OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMK QEAgLTM4LDYgKzM4LDcgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICB0aGlzLl9zb3J0T3JkZXIgPSBXZWJJ bnNwZWN0b3IuRGF0YUdyaWQuU29ydE9yZGVyLkluZGV0ZXJtaW5hdGU7CiAgICAgICAgIHRoaXMu X3NvcnRPcmRlclNldHRpbmcgPSBudWxsOwogICAgICAgICB0aGlzLl9oaWRkZW5Db2x1bW5TZXR0 aW5nID0gbnVsbDsKKyAgICAgICAgdGhpcy5fY29sdW1uQ2hvb3NlckVuYWJsZWQgPSBmYWxzZTsK IAogICAgICAgICB0aGlzLl9yb3dzID0gW107CiAKQEAgLTIyNiw3ICsyMjcsNyBAQCBXZWJJbnNw ZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3 CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgZm9yIChsZXQgY29sdW1uSWRlbnRpZmll ciBvZiB0aGlzLl9oaWRkZW5Db2x1bW5TZXR0aW5nLnZhbHVlKQotICAgICAgICAgICAgdGhpcy5z aG93Q29sdW1uKGNvbHVtbklkZW50aWZpZXIsIGZhbHNlKTsKKyAgICAgICAgICAgIHRoaXMuc2V0 Q29sdW1uVmlzaWJsZShjb2x1bW5JZGVudGlmaWVyLCBmYWxzZSk7CiAgICAgfQogCiAgICAgZ2V0 IGNvbHVtbkNob29zZXJFbmFibGVkKCkgeyByZXR1cm4gdGhpcy5fY29sdW1uQ2hvb3NlckVuYWJs ZWQ7IH0KQEAgLTc2OSw3ICs3NzAsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBE YXRhR3JpZCBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAKICAgICAgICAgbGlzdGVuZXJzLmlu c3RhbGwoKTsKIAotICAgICAgICB0aGlzLnNob3dDb2x1bW4oY29sdW1uSWRlbnRpZmllciwgIWNv bHVtbi5oaWRkZW4pOworICAgICAgICB0aGlzLnNldENvbHVtblZpc2libGUoY29sdW1uSWRlbnRp ZmllciwgIWNvbHVtbi5oaWRkZW4pOwogICAgIH0KIAogICAgIHJlbW92ZUNvbHVtbihjb2x1bW5J ZGVudGlmaWVyKQpAQCAtOTA4LDcgKzkwOSw3IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNs YXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAgcmV0dXJuICF0 aGlzLmNvbHVtbnMuZ2V0KGNvbHVtbklkZW50aWZpZXIpWyJoaWRkZW4iXTsKICAgICB9CiAKLSAg ICBzaG93Q29sdW1uKGNvbHVtbklkZW50aWZpZXIsIHZpc2libGUpCisgICAgc2V0Q29sdW1uVmlz aWJsZShjb2x1bW5JZGVudGlmaWVyLCB2aXNpYmxlKQogICAgIHsKICAgICAgICAgbGV0IGNvbHVt biA9IHRoaXMuY29sdW1ucy5nZXQoY29sdW1uSWRlbnRpZmllcik7CiAgICAgICAgIGNvbnNvbGUu YXNzZXJ0KGNvbHVtbiwgIk1pc3NpbmcgY29sdW1uIGluZm8gZm9yIGlkZW50aWZpZXI6ICIgKyBj b2x1bW5JZGVudGlmaWVyKTsKQEAgLTE1MzksNyArMTU0MCw3IEBAIFdlYkluc3BlY3Rvci5EYXRh R3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAg ICBmb3IgKHZhciBbaWRlbnRpZmllciwgY29sdW1uXSBvZiB0aGlzLmNvbHVtbnMpIHsKICAgICAg ICAgICAgIGlmIChjb2x1bW5bImdyb3VwIl0gPT09IGNlbGwuY29sbGFwc2VzR3JvdXApCi0gICAg ICAgICAgICAgICAgdGhpcy5zaG93Q29sdW1uKGlkZW50aWZpZXIsICFjb2x1bW5zV2lsbENvbGxh cHNlKTsKKyAgICAgICAgICAgICAgICB0aGlzLnNldENvbHVtblZpc2libGUoaWRlbnRpZmllciwg IWNvbHVtbnNXaWxsQ29sbGFwc2UpOwogICAgICAgICB9CiAKICAgICAgICAgdmFyIGNvbGxhcHNl ckJ1dHRvbiA9IGNlbGwucXVlcnlTZWxlY3RvcigiLmNvbGxhcHNlci1idXR0b24iKTsKQEAgLTE2 MjUsMjEgKzE2MjYsMjAgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAg ICAgICAgaWYgKCF0aGlzLl9jb2x1bW5DaG9vc2VyRW5hYmxlZCkKLSAgICAgICAgICAgIHJldHVy bjsKKyAgICAgICAgaWYgKHRoaXMuX2NvbHVtbkNob29zZXJFbmFibGVkKSB7CisgICAgICAgICAg ICBsZXQgZGlkQWRkU2VwYXJhdG9yID0gZmFsc2U7CiAKLSAgICAgICAgbGV0IGRpZEFkZFNlcGFy YXRvciA9IGZhbHNlOworICAgICAgICAgICAgZm9yIChsZXQgW2lkZW50aWZpZXIsIGNvbHVtbklu Zm9dIG9mIHRoaXMuY29sdW1ucykgeworICAgICAgICAgICAgICAgIGlmIChjb2x1bW5JbmZvLmxv Y2tlZCkKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgZm9yIChsZXQg W2lkZW50aWZpZXIsIGNvbHVtbkluZm9dIG9mIHRoaXMuY29sdW1ucykgewotICAgICAgICAgICAg aWYgKGNvbHVtbkluZm8ubG9ja2VkKQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAg ICAgICAgICAgIGlmICghZGlkQWRkU2VwYXJhdG9yKSB7CisgICAgICAgICAgICAgICAgICAgIGNv bnRleHRNZW51LmFwcGVuZFNlcGFyYXRvcigpOworICAgICAgICAgICAgICAgICAgICBkaWRBZGRT ZXBhcmF0b3IgPSB0cnVlOworICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgaWYgKCFk aWRBZGRTZXBhcmF0b3IpIHsKLSAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRTZXBh cmF0b3IoKTsKLSAgICAgICAgICAgICAgICBkaWRBZGRTZXBhcmF0b3IgPSB0cnVlOworICAgICAg ICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZENoZWNrYm94SXRlbShjb2x1bW5JbmZvLnRpdGxl LCAoKSA9PiB7IHRoaXMuc2V0Q29sdW1uVmlzaWJsZShpZGVudGlmaWVyLCBjb2x1bW5JbmZvLmhp ZGRlbik7IH0sICFjb2x1bW5JbmZvLmhpZGRlbik7CiAgICAgICAgICAgICB9Ci0KLSAgICAgICAg ICAgIGNvbnRleHRNZW51LmFwcGVuZENoZWNrYm94SXRlbShjb2x1bW5JbmZvLnRpdGxlLCAoKSA9 PiB7IHRoaXMuc2hvd0NvbHVtbihpZGVudGlmaWVyLCBjb2x1bW5JbmZvLmhpZGRlbik7IH0sICFj b2x1bW5JbmZvLmhpZGRlbik7CiAgICAgICAgIH0KICAgICB9CiAK