158758 2016-06-14 14:57:58 -0700 Web Inspector: Visual Sidebar: Remove "Text -> Content" subsection 2016-06-14 17:41:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1202331 0 nvasilyev 2016-06-14 14:57:58 -0700 We should remove for now because: 1. "content" CSS property only works with pseudo elements ::before and ::after. It doesn't do anything for regular (non pseudo) elements. 2. It is practically unusable due to bug 158757 and bug 158271. 1202332 1 webkit-bug-importer 2016-06-14 14:58:58 -0700 <rdar://problem/26799628> 1202344 2 281286 nvasilyev 2016-06-14 15:10:02 -0700 Created attachment 281286 Patch 1202346 3 nvasilyev 2016-06-14 15:11:06 -0700 This patch reverts http://trac.webkit.org/changeset/194876. 1202403 4 281286 commit-queue 2016-06-14 17:41:45 -0700 Comment on attachment 281286 Patch Clearing flags on attachment: 281286 Committed r202073: <http://trac.webkit.org/changeset/202073> 1202404 5 commit-queue 2016-06-14 17:41:49 -0700 All reviewed patches have been landed. Closing bug. 281286 2016-06-14 15:10:02 -0700 2016-06-14 17:41:45 -0700 Patch patch.txt text/plain 4357 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJiZmJiOTcuLmMwMGY2ZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTA2LTE0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFZpc3Vh bCBTaWRlYmFyOiBSZW1vdmUgIlRleHQgLT4gQ29udGVudCIgc3Vic2VjdGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzU4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yNjc5OTYyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAiY29udGVudCIgQ1NTIHByb3BlcnR5IG9ubHkgd29ya3Mgd2l0aCBw c2V1ZG8gZWxlbWVudHMgOjpiZWZvcmUgYW5kIDo6YWZ0ZXIuCisgICAgICAgIEl0IGRvZXNuJ3Qg ZG8gYW55dGhpbmcgZm9yIHJlZ3VsYXIgKG5vbiBwc2V1ZG8pIGVsZW1lbnRzLiBSZW1vdmUgaXQg dG8KKyAgICAgICAgcmVkdWNlIFVJIGNsdXR0ZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5pbml0aWFsTGF5b3V0KToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQYW5lbC5wcm90b3R5cGUuX3BvcHVs YXRlQ29udGVudFNlY3Rpb24pOiBEZWxldGVkLgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvVmlzdWFsU3R5bGVQcm9wZXJ0eUVkaXRvci5jc3M6CisgICAgICAgICgudmlzdWFsLXN0eWxl LXByb3BlcnR5LWNvbnRhaW5lciA+ICo6Zmlyc3QtY2hpbGQ6bWF0Y2hlcygudmlzdWFsLXN0eWxl LXByb3BlcnR5LXZhbHVlLWNvbnRhaW5lcikpOiBEZWxldGVkLgorCisyMDE2LTA2LTE0ICBOaWtp dGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEludHJvZHVjZSAtLW5hdmlnYXRpb24tYmFyLWhlaWdodCBDU1MgdmFyaWFibGUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODc1MgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxT dHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IDczNWIwZWIuLmVmOWE4NTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zp c3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC05MSwxNCArOTEs MTMgQEAgV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsID0gY2xhc3MgVmlzdWFs U3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5kcyBXZWIKICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVu ZENoaWxkKHRoaXMuX3NlY3Rpb25zLmxheW91dC5lbGVtZW50KTsKIAogICAgICAgICAvLyBUZXh0 IFNlY3Rpb24KLSAgICAgICAgdGhpcy5fZ2VuZXJhdGVTZWN0aW9uKCJjb250ZW50IiwgV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJDb250ZW50IikpOwogICAgICAgICB0aGlzLl9nZW5lcmF0ZVNlY3Rp b24oInRleHQtc3R5bGUiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlN0eWxlIikpOwogICAgICAg ICB0aGlzLl9nZW5lcmF0ZVNlY3Rpb24oImZvbnQiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkZv bnQiKSk7CiAgICAgICAgIHRoaXMuX2dlbmVyYXRlU2VjdGlvbigiZm9udC12YXJpYW50cyIsIFdl Ykluc3BlY3Rvci5VSVN0cmluZygiVmFyaWFudHMiKSk7CiAgICAgICAgIHRoaXMuX2dlbmVyYXRl U2VjdGlvbigidGV4dC1zcGFjaW5nIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTcGFjaW5nIikp OwogICAgICAgICB0aGlzLl9nZW5lcmF0ZVNlY3Rpb24oInRleHQtc2hhZG93IiwgV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJTaGFkb3ciKSk7CiAKLSAgICAgICAgdGhpcy5fc2VjdGlvbnMudGV4dCA9 IG5ldyBXZWJJbnNwZWN0b3IuRGV0YWlsc1NlY3Rpb24oInRleHQiLCBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlRleHQiKSwgW3RoaXMuX2dyb3Vwcy5jb250ZW50LnNlY3Rpb24sIHRoaXMuX2dyb3Vw cy50ZXh0U3R5bGUuc2VjdGlvbiwgdGhpcy5fZ3JvdXBzLmZvbnQuc2VjdGlvbiwgdGhpcy5fZ3Jv dXBzLmZvbnRWYXJpYW50cy5zZWN0aW9uLCB0aGlzLl9ncm91cHMudGV4dFNwYWNpbmcuc2VjdGlv biwgdGhpcy5fZ3JvdXBzLnRleHRTaGFkb3cuc2VjdGlvbl0pOworICAgICAgICB0aGlzLl9zZWN0 aW9ucy50ZXh0ID0gbmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvbigidGV4dCIsIFdlYklu c3BlY3Rvci5VSVN0cmluZygiVGV4dCIpLCBbdGhpcy5fZ3JvdXBzLnRleHRTdHlsZS5zZWN0aW9u LCB0aGlzLl9ncm91cHMuZm9udC5zZWN0aW9uLCB0aGlzLl9ncm91cHMuZm9udFZhcmlhbnRzLnNl Y3Rpb24sIHRoaXMuX2dyb3Vwcy50ZXh0U3BhY2luZy5zZWN0aW9uLCB0aGlzLl9ncm91cHMudGV4 dFNoYWRvdy5zZWN0aW9uXSk7CiAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlz Ll9zZWN0aW9ucy50ZXh0LmVsZW1lbnQpOwogCiAgICAgICAgIC8vIEJhY2tncm91bmQgU2VjdGlv bgpAQCAtNjUwLDIxICs2NDksNiBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVEZXRhaWxzUGFu ZWwgPSBjbGFzcyBWaXN1YWxTdHlsZURldGFpbHNQYW5lbCBleHRlbmRzIFdlYgogICAgICAgICBw cm9wZXJ0aWVzLmFsaWduU2VsZi5hZGREZXBlbmRlbmN5KCJkaXNwbGF5IiwgYWxsb3dlZERpc3Bs YXlWYWx1ZXMpOwogICAgIH0KIAotICAgIF9wb3B1bGF0ZUNvbnRlbnRTZWN0aW9uKCkKLSAgICB7 Ci0gICAgICAgIGxldCBncm91cCA9IHRoaXMuX2dyb3Vwcy5jb250ZW50OwotICAgICAgICBsZXQg cHJvcGVydGllcyA9IGdyb3VwLnByb3BlcnRpZXM7Ci0KLSAgICAgICAgbGV0IGNvbnRlbnRSb3cg PSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9uUm93OwotCi0gICAgICAgIHByb3BlcnRp ZXMuY29udGVudCA9IG5ldyBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVCYXNpY0lucHV0KCJjb250 ZW50IiwgbnVsbCwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFbnRlciBhIHZhbHVlIikpOwotCi0g ICAgICAgIGNvbnRlbnRSb3cuZWxlbWVudC5hcHBlbmRDaGlsZChwcm9wZXJ0aWVzLmNvbnRlbnQu ZWxlbWVudCk7Ci0KLSAgICAgICAgbGV0IGNvbnRlbnRHcm91cCA9IG5ldyBXZWJJbnNwZWN0b3Iu RGV0YWlsc1NlY3Rpb25Hcm91cChbY29udGVudFJvd10pOwotICAgICAgICB0aGlzLl9wb3B1bGF0 ZVNlY3Rpb24oZ3JvdXAsIFtjb250ZW50R3JvdXBdKTsKLSAgICB9Ci0KICAgICBfcG9wdWxhdGVU ZXh0U3R5bGVTZWN0aW9uKCkKICAgICB7CiAgICAgICAgIGxldCBncm91cCA9IHRoaXMuX2dyb3Vw cy50ZXh0U3R5bGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yLmNzcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlUHJvcGVydHlFZGl0b3IuY3Nz CmluZGV4IDczOGQ4ZDkuLjkwZDNjMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlUHJvcGVydHlFZGl0b3IuY3NzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlUHJv cGVydHlFZGl0b3IuY3NzCkBAIC04OSwxMCArODksNiBAQAogICAgIG9wYWNpdHk6IDAuNDsKIH0K IAotLnZpc3VhbC1zdHlsZS1wcm9wZXJ0eS1jb250YWluZXIgPiAqOmZpcnN0LWNoaWxkOm1hdGNo ZXMoLnZpc3VhbC1zdHlsZS1wcm9wZXJ0eS12YWx1ZS1jb250YWluZXIpIHsKLSAgICBtYXJnaW4t bGVmdDogMTFweDsKLX0KLQogLnZpc3VhbC1zdHlsZS1wcm9wZXJ0eS1jb250YWluZXIgPiAudmlz dWFsLXN0eWxlLXByb3BlcnR5LXZhbHVlLWNvbnRhaW5lciBzZWxlY3QgewogICAgIHdpZHRoOiAx MDAlOwogICAgIG1hcmdpbjogMXB4IDA7Cg==