158756 2016-06-14 14:50:16 -0700 Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly 2016-06-14 16:26:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=152719 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue glenn lforschler oldest_to_newest 1202326 0 aakash_jain 2016-06-14 14:50:16 -0700 While simulators are booting up, if someone manually kills a simulator (or simulator gets killed for some reason), we notice following continuos error messages in logs: 14:36:13.791 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:14.875 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:15.961 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:17.050 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:18.137 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:19.224 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 1202327 1 aakash_jain 2016-06-14 14:51:32 -0700 This happens because the command use to check the Simulator boot status fails, and we keep retrying every second until timeout is hit (default timeout is 5 mins). 1202350 2 281288 aakash_jain 2016-06-14 15:13:16 -0700 Created attachment 281288 Proposed patch 1202359 3 281288 ap 2016-06-14 15:31:18 -0700 Comment on attachment 281288 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281288&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:288 > + _log.warn("Error in checking Simulator boot status. Will retry in 1 second.") > + if Simulator.device_state(udid) != Simulator.DeviceState.BOOTED: > + raise RuntimeError('Simuator device quit unexpectedly.') Can't the "will retry" message be untrue now? 1202361 4 aakash_jain 2016-06-14 15:34:58 -0700 It is still true. Even if the simulator device is booted, sometimes "xcrun simctl spawan uddid launchctl" command fails for unknown reasons, in that case we do retry after 1 seconds. 1202366 5 ap 2016-06-14 15:51:16 -0700 What if we raise the exception instead of waiting? 1202371 6 281293 aakash_jain 2016-06-14 15:55:04 -0700 Created attachment 281293 Updated patch 1202381 7 281293 commit-queue 2016-06-14 16:26:34 -0700 Comment on attachment 281293 Updated patch Clearing flags on attachment: 281293 Committed r202070: <http://trac.webkit.org/changeset/202070> 1202382 8 commit-queue 2016-06-14 16:26:38 -0700 All reviewed patches have been landed. Closing bug. 281288 2016-06-14 15:13:16 -0700 2016-06-14 15:55:04 -0700 Proposed patch patch_simulator_quit text/plain 1798 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjA2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA2LTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBDb250aW51b3VzICJSZWVudHJhbmN5IGF2b2lkZWQiIGVycm9yIG1lc3Nh Z2VzIGluIHJ1bi13ZWJraXQtdGVzdHMgaWYgU2ltdWxhdG9yIHF1aXRzIHVuZXhwZWN0ZWRseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzU2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weToKKyAgICAgICAgKFNpbXVsYXRvci53YWl0X3Vu dGlsX2RldmljZV9pc19ib290ZWQpOiBJZiBjaGVja2luZyBTaW11bGF0b3IgYm9vdCBzdGF0ZSBm YWlscywgdmVyaWZ5IGlmCisgICAgICAgIHRoZSAic2ltdWxhdG9yIGRldmljZSIgaXMgc3RpbGwg aW4gYm9vdGVkIHN0YXRlLiBTaW5jZSB3ZSBlbnN1cmVkIHRoYXQgc2ltdWxhdG9yIGRldmljZSAK KyAgICAgICAgd2FzIGluIGJvb3RlZCBzdGF0ZSBlYXJsaWVyIGluIHRoaXMgbWV0aG9kLCB0aGlz IGluZGljYXRlcyB0aGF0IHNpbXVsYXRvciBkZXZpY2UgaGFzIHNodXQgZG93bgorICAgICAgICB1 bmV4cGVjdGVkbHkuCisKIDIwMTYtMDYtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBGb2xsb3ctdXAgZml4ICMyOiBSRUdSRVNTSU9OIChyMjAyMDIwKTog RWwgQ2FwaXRhbiBDTWFrZSBEZWJ1ZyBidWlsZCBicm9rZW4KSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMDIwNjQpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkod29ya2luZyBjb3B5KQpAQCAtMjgz LDcgKzI4Myw5IEBAIGNsYXNzIFNpbXVsYXRvcihvYmplY3QpOgogICAgICAgICAgICAgICAgICAg ICBpZiByZS5zZWFyY2goIkFbXHNdK2NvbS5hcHBsZS5zcHJpbmdib2FyZC5zZXJ2aWNlcyIsIHN0 YXRlKToKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybgogICAgICAgICAgICAgICAgIGV4 Y2VwdCBzdWJwcm9jZXNzLkNhbGxlZFByb2Nlc3NFcnJvcjoKLSAgICAgICAgICAgICAgICAgICAg X2xvZy53YXJuKCJFcnJvciBpbiBjaGVja2luZyBTaW11bGF0b3IgYm9vdCBzdGF0dXMuIikKKyAg ICAgICAgICAgICAgICAgICAgX2xvZy53YXJuKCJFcnJvciBpbiBjaGVja2luZyBTaW11bGF0b3Ig Ym9vdCBzdGF0dXMuIFdpbGwgcmV0cnkgaW4gMSBzZWNvbmQuIikKKyAgICAgICAgICAgICAgICAg ICAgaWYgU2ltdWxhdG9yLmRldmljZV9zdGF0ZSh1ZGlkKSAhPSBTaW11bGF0b3IuRGV2aWNlU3Rh dGUuQk9PVEVEOgorICAgICAgICAgICAgICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdT aW11YXRvciBkZXZpY2UgcXVpdCB1bmV4cGVjdGVkbHkuJykKICAgICAgICAgICAgICAgICB0aW1l LnNsZWVwKDEpCiAKICAgICBAc3RhdGljbWV0aG9kCg== 281293 2016-06-14 15:55:04 -0700 2016-06-14 16:26:34 -0700 Updated patch patch_simulator_quit1 text/plain 1798 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMjA2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA2LTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBDb250aW51b3VzICJSZWVudHJhbmN5IGF2b2lkZWQiIGVycm9yIG1lc3Nh Z2VzIGluIHJ1bi13ZWJraXQtdGVzdHMgaWYgU2ltdWxhdG9yIHF1aXRzIHVuZXhwZWN0ZWRseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzU2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weToKKyAgICAgICAgKFNpbXVsYXRvci53YWl0X3Vu dGlsX2RldmljZV9pc19ib290ZWQpOiBJZiBjaGVja2luZyBTaW11bGF0b3IgYm9vdCBzdGF0ZSBm YWlscywgdmVyaWZ5IGlmCisgICAgICAgIHRoZSAic2ltdWxhdG9yIGRldmljZSIgaXMgc3RpbGwg aW4gYm9vdGVkIHN0YXRlLiBTaW5jZSB3ZSBlbnN1cmVkIHRoYXQgc2ltdWxhdG9yIGRldmljZSAK KyAgICAgICAgd2FzIGluIGJvb3RlZCBzdGF0ZSBlYXJsaWVyIGluIHRoaXMgbWV0aG9kLCB0aGlz IGluZGljYXRlcyB0aGF0IHNpbXVsYXRvciBkZXZpY2UgaGFzIHNodXQgZG93bgorICAgICAgICB1 bmV4cGVjdGVkbHkuCisKIDIwMTYtMDYtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBGb2xsb3ctdXAgZml4ICMyOiBSRUdSRVNTSU9OIChyMjAyMDIwKTog RWwgQ2FwaXRhbiBDTWFrZSBEZWJ1ZyBidWlsZCBicm9rZW4KSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMDIwNjQpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkod29ya2luZyBjb3B5KQpAQCAtMjgz LDcgKzI4Myw5IEBAIGNsYXNzIFNpbXVsYXRvcihvYmplY3QpOgogICAgICAgICAgICAgICAgICAg ICBpZiByZS5zZWFyY2goIkFbXHNdK2NvbS5hcHBsZS5zcHJpbmdib2FyZC5zZXJ2aWNlcyIsIHN0 YXRlKToKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybgogICAgICAgICAgICAgICAgIGV4 Y2VwdCBzdWJwcm9jZXNzLkNhbGxlZFByb2Nlc3NFcnJvcjoKLSAgICAgICAgICAgICAgICAgICAg X2xvZy53YXJuKCJFcnJvciBpbiBjaGVja2luZyBTaW11bGF0b3IgYm9vdCBzdGF0dXMuIikKKyAg ICAgICAgICAgICAgICAgICAgaWYgU2ltdWxhdG9yLmRldmljZV9zdGF0ZSh1ZGlkKSAhPSBTaW11 bGF0b3IuRGV2aWNlU3RhdGUuQk9PVEVEOgorICAgICAgICAgICAgICAgICAgICAgICAgcmFpc2Ug UnVudGltZUVycm9yKCdTaW11YXRvciBkZXZpY2UgcXVpdCB1bmV4cGVjdGVkbHkuJykKKyAgICAg ICAgICAgICAgICAgICAgX2xvZy53YXJuKCJFcnJvciBpbiBjaGVja2luZyBTaW11bGF0b3IgYm9v dCBzdGF0dXMuIFdpbGwgcmV0cnkgaW4gMSBzZWNvbmQuIikKICAgICAgICAgICAgICAgICB0aW1l LnNsZWVwKDEpCiAKICAgICBAc3RhdGljbWV0aG9kCg==