158750 2016-06-14 13:25:24 -0700 [mac-wk1 debug] LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky 2016-07-22 15:00:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=160101 P2 Normal --- 1 ryanhaddad ryanhaddad joepeck oldest_to_newest 1202291 0 ryanhaddad 2016-06-14 13:25:24 -0700 LayoutTest userscripts/window-onerror-for-isolated-world-3.html is flaky <https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/5940> <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=userscripts%2Fwindow-onerror-for-isolated-world-3.html> --- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/userscripts/window-onerror-for-isolated-world-3-actual.txt @@ -8,12 +8,11 @@ Main world error event listener: [object Window] at undefined:0:0 null Main World +Isolated World Main world window.onerror: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world) Main world error event listener: SerializableError from (main world) at window-onerror-for-isolated-world-3.html:49:59 SerializableError from (main world) Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window] Main world error event listener: [object Window] at window-onerror-for-isolated-world-3.html:55:27 [object Window] - -Isolated World Main world window.onerror: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script) Main world error event listener: SerializableError from (isolated script) at window-onerror-for-isolated-world-3.html:5:59 SerializableError from (isolated script) Main world window.onerror: [object Window] at window-onerror-for-isolated-world-3.html:11:27 null 1202292 1 joepeck 2016-06-14 13:25:52 -0700 Let me bump up the timeouts just a tad. 1202293 2 281275 ryanhaddad 2016-06-14 13:30:48 -0700 Created attachment 281275 Patch 1202294 3 281275 joepeck 2016-06-14 13:32:11 -0700 Comment on attachment 281275 Patch r=me! 1202295 4 281275 ryanhaddad 2016-06-14 13:33:47 -0700 Comment on attachment 281275 Patch Clearing flags on attachment: 281275 Committed r202061: <http://trac.webkit.org/changeset/202061> 1202296 5 ryanhaddad 2016-06-14 13:33:52 -0700 All reviewed patches have been landed. Closing bug. 1202297 6 ap 2016-06-14 13:40:03 -0700 Is there any way to avoid having timeouts in the normal execution path? It is normal for a regression test to stall for a couple seconds, so doubling a timeout is not a reliable fix. 1202304 7 joepeck 2016-06-14 13:55:17 -0700 Yes, it could be possible with more hardcoding of expected messages. Expect 4 messages => advance() Expect 4 messages => advance() Expect 4 messages => advance() => end 281275 2016-06-14 13:30:48 -0700 2016-06-14 13:33:47 -0700 Patch bug-158750-20160614133224.patch text/plain 1470 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDYwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDJhN2Y0NzIxMWU0NWU0NjVhMmRl NjJjOTE1ZjNmY2FmZDNjNGRmNy4uZTY5ZDA4ZjNiYjY3NDE1ZTk3OWRmMDA4Mzk4NDhjMzIyMzRm NjhhYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA2LTE0ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIEluY3JlYXNlIHRpbWVvdXRzIGZvciB1c2Vy c2NyaXB0cy93aW5kb3ctb25lcnJvci1mb3ItaXNvbGF0ZWQtd29ybGQtMy5odG1sIHRvIGZpeCBm bGFraW5lc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTg3NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHVzZXJzY3JpcHRzL3dpbmRvdy1vbmVycm9yLWZvci1pc29sYXRlZC13b3JsZC0zLmh0bWw6 CisKIDIwMTYtMDYtMTQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDIwNTcuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy91c2Vyc2NyaXB0cy93aW5kb3ctb25lcnJvci1mb3ItaXNvbGF0ZWQtd29ybGQt My5odG1sIGIvTGF5b3V0VGVzdHMvdXNlcnNjcmlwdHMvd2luZG93LW9uZXJyb3ItZm9yLWlzb2xh dGVkLXdvcmxkLTMuaHRtbAppbmRleCAyMDdkM2RhZjgyYjI0ZjIwNjY3Y2E4ZWNmNDljMGZjMmEw MzQ4MTMxLi4yOWM2MTdhODAyNDdkZDc1NzRiNTllOWM5ZjFmZWQ2OWNhM2ZiOTczIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy91c2Vyc2NyaXB0cy93aW5kb3ctb25lcnJvci1mb3ItaXNvbGF0ZWQt d29ybGQtMy5odG1sCisrKyBiL0xheW91dFRlc3RzL3VzZXJzY3JpcHRzL3dpbmRvdy1vbmVycm9y LWZvci1pc29sYXRlZC13b3JsZC0zLmh0bWwKQEAgLTY3LDEyICs2NywxMiBAQCB0ZXN0UnVubmVy LmFkZFVzZXJTY3JpcHQoIigiICsgdHJpZ2dlckV4Y2VwdGlvbnMgKyAiKSgndXNlciBzY3JpcHQn KSIsIGZhbHNlLCB0cgogc2V0VGltZW91dChmdW5jdGlvbigpIHsKICAgICBoZWFkZXIoIk1haW4g V29ybGQiKTsKICAgICB0cmlnZ2VyRXhjZXB0aW9ucygibWFpbiB3b3JsZCIpOwotfSwgNTApOwor fSwgMTAwKTsKIAogc2V0VGltZW91dChmdW5jdGlvbigpIHsKICAgICBoZWFkZXIoIklzb2xhdGVk IFdvcmxkIik7CiAgICAgdGVzdFJ1bm5lci5ldmFsdWF0ZVNjcmlwdEluSXNvbGF0ZWRXb3JsZCgw LCAiKCIgKyB0cmlnZ2VyRXhjZXB0aW9ucyArICIpKCdpc29sYXRlZCBzY3JpcHQnKSIpOwotfSwg MTAwKTsKK30sIDIwMCk7CiA8L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRtbD4K