158746 2016-06-14 11:48:00 -0700 Avoid constructing a AuthenticationChallenge unnecessarily in the NetworkLoad constructor 2016-06-14 19:16:54 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen commit-queue darin oldest_to_newest 1202259 0 cdumez 2016-06-14 11:48:00 -0700 Avoid constructing a AuthenticationChallenge unnecessarily in the NetworkLoad constructor. 1202260 1 281270 cdumez 2016-06-14 11:49:10 -0700 Created attachment 281270 Patch 1202444 2 281270 cdumez 2016-06-14 19:16:38 -0700 Comment on attachment 281270 Patch Clearing flags on attachment: 281270 Committed r202080: <http://trac.webkit.org/changeset/202080> 1202445 3 cdumez 2016-06-14 19:16:54 -0700 All reviewed patches have been landed. Closing bug. 281270 2016-06-14 11:49:10 -0700 2016-06-14 19:16:38 -0700 Patch bug-158746-20160614115046.patch text/plain 4470 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWUzYTFkY2U0ZWY5ZDM1 OTExOTY4NTk4N2Q3OTAxOTNjNDgxZTU1MS4uZmU1M2I4YWZhMzdlMTc1MjFlODFmM2NjMDMyMjJm YTIzYzkwNDg2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTA2LTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQXZvaWQgY29uc3RydWN0aW5n IGEgQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgdW5uZWNlc3NhcmlseSBpbiB0aGUgTmV0d29ya0xv YWQgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1ODc0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEF2b2lkIGNvbnN0cnVjdGluZyBhIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIHVubmVj ZXNzYXJpbHkgaW4gdGhlCisgICAgICAgIE5ldHdvcmtMb2FkIGNvbnN0cnVjdG9yIGJ5IHVzaW5n IFdURjo6T3B0aW9uYWw8PiBmb3IgdGhpcyBkYXRhCisgICAgICAgIG1lbWJlci4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya0xvYWQ6OmNvbnRpbnVlQ2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZSk6 CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuaDoKKworMjAxNi0wNi0xNCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFJlZHVjZSBjb3B5aW5n IG9mIE5ldHdvcmtMb2FkUGFyYW1ldGVycwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzQ0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL05ldHdvcmtMb2FkLmNwcAppbmRleCBiMjAyZjEyYmIwZGY4ZTNjZTkyODE5MDYzMzMwZTNl ZDNlZDhhNjY2Li5mOWE0NmZhMzg0MmJmYzQwNWUxYTIzZjM1MDdkNTY0ZjBiYzdlMmEwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCkBAIC0zNTks MTUgKzM1OSwxNSBAQCB2b2lkIE5ldHdvcmtMb2FkOjpjb250aW51ZUNhbkF1dGhlbnRpY2F0ZUFn YWluc3RQcm90ZWN0aW9uU3BhY2UoYm9vbCByZXN1bHQpCiAgICAgQVNTRVJUKG1fY2hhbGxlbmdl Q29tcGxldGlvbkhhbmRsZXIpOwogICAgIGF1dG8gY29tcGxldGlvbkhhbmRsZXIgPSBzdGQ6OmV4 Y2hhbmdlKG1fY2hhbGxlbmdlQ29tcGxldGlvbkhhbmRsZXIsIG51bGxwdHIpOwogICAgIGlmICgh cmVzdWx0KSB7Ci0gICAgICAgIGlmIChtX3Rhc2sgJiYgbV90YXNrLT5hbGxvd3NTcGVjaWZpY0hU VFBTQ2VydGlmaWNhdGVGb3JIb3N0KG1fY2hhbGxlbmdlKSkKLSAgICAgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlRGlzcG9zaXRpb246OlVzZUNyZWRlbnRp YWwsIHNlcnZlclRydXN0Q3JlZGVudGlhbChtX2NoYWxsZW5nZSkpOworICAgICAgICBpZiAobV90 YXNrICYmIG1fdGFzay0+YWxsb3dzU3BlY2lmaWNIVFRQU0NlcnRpZmljYXRlRm9ySG9zdCgqbV9j aGFsbGVuZ2UpKQorICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25D aGFsbGVuZ2VEaXNwb3NpdGlvbjo6VXNlQ3JlZGVudGlhbCwgc2VydmVyVHJ1c3RDcmVkZW50aWFs KCptX2NoYWxsZW5nZSkpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBjb21wbGV0aW9uSGFu ZGxlcihBdXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpSZWplY3RQcm90ZWN0aW9u U3BhY2UsIHsgfSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCi0gICAgaWYgKG1fY2hh bGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpLmF1dGhlbnRpY2F0aW9uU2NoZW1lKCkgPT0gUHJvdGVj dGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVTZXJ2ZXJUcnVzdEV2YWx1YXRpb25SZXF1ZXN0 ZWQpIHsKLSAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGljYXRpb25DaGFsbGVuZ2VE aXNwb3NpdGlvbjo6VXNlQ3JlZGVudGlhbCwgc2VydmVyVHJ1c3RDcmVkZW50aWFsKG1fY2hhbGxl bmdlKSk7CisgICAgaWYgKG1fY2hhbGxlbmdlLT5wcm90ZWN0aW9uU3BhY2UoKS5hdXRoZW50aWNh dGlvblNjaGVtZSgpID09IFByb3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lU2VydmVy VHJ1c3RFdmFsdWF0aW9uUmVxdWVzdGVkKSB7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKEF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlRGlzcG9zaXRpb246OlVzZUNyZWRlbnRpYWwsIHNlcnZlclRy dXN0Q3JlZGVudGlhbCgqbV9jaGFsbGVuZ2UpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAg ICAKQEAgLTM3OCw5ICszNzgsOSBAQCB2b2lkIE5ldHdvcmtMb2FkOjpjb250aW51ZUNhbkF1dGhl bnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UoYm9vbCByZXN1bHQpCiAgICAgCiAgICAgaWYg KG1fdGFzaykgewogICAgICAgICBpZiAoYXV0byogcGVuZGluZ0Rvd25sb2FkID0gbV90YXNrLT5w ZW5kaW5nRG93bmxvYWQoKSkKLSAgICAgICAgICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5nbGV0b24o KS5hdXRoZW50aWNhdGlvbk1hbmFnZXIoKS5kaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVu Z2UoKnBlbmRpbmdEb3dubG9hZCwgbV9jaGFsbGVuZ2UsIGNvbXBsZXRpb25IYW5kbGVyKTsKKyAg ICAgICAgICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5nbGV0b24oKS5hdXRoZW50aWNhdGlvbk1hbmFn ZXIoKS5kaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKnBlbmRpbmdEb3dubG9hZCwg Km1fY2hhbGxlbmdlLCBjb21wbGV0aW9uSGFuZGxlcik7CiAgICAgICAgIGVsc2UKLSAgICAgICAg ICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5nbGV0b24oKS5hdXRoZW50aWNhdGlvbk1hbmFnZXIoKS5k aWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UobV9wYXJhbWV0ZXJzLndlYlBhZ2VJRCwg bV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQsIG1fY2hhbGxlbmdlLCBjb21wbGV0aW9uSGFuZGxlcik7 CisgICAgICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuYXV0aGVudGljYXRpb25N YW5hZ2VyKCkuZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fcGFyYW1ldGVycy53 ZWJQYWdlSUQsIG1fcGFyYW1ldGVycy53ZWJGcmFtZUlELCAqbV9jaGFsbGVuZ2UsIGNvbXBsZXRp b25IYW5kbGVyKTsKICAgICB9CiAjZW5kaWYKICAgICBpZiAobV9oYW5kbGUpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuaAppbmRleCA0NzU2Y2E4ZWM2ZjUwMTYx ODJhZDI3NDIwZjFhMjI3ZDAyNTRiMTIzLi42OWQ0Y2FiYjMzNzVkNTFiOWY3N2EyZWE4M2I1NTU2 NzUyOWNhZjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrTG9hZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2Fk LmgKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJOZXR3b3JrTG9hZFBhcmFtZXRlcnMuaCIK ICNpbmNsdWRlICJSZW1vdGVOZXR3b3JraW5nQ29udGV4dC5oIgogI2luY2x1ZGUgPFdlYkNvcmUv UmVzb3VyY2VIYW5kbGVDbGllbnQuaD4KKyNpbmNsdWRlIDx3dGYvT3B0aW9uYWwuaD4KIAogI2lm IFVTRShORVRXT1JLX1NFU1NJT04pCiAjaW5jbHVkZSAiRG93bmxvYWRJRC5oIgpAQCAtMTIzLDcg KzEyNCw3IEBAIHByaXZhdGU6CiAgICAgY29uc3QgTmV0d29ya0xvYWRQYXJhbWV0ZXJzIG1fcGFy YW1ldGVyczsKICNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQogICAgIFJlZlB0cjxOZXR3b3JrRGF0 YVRhc2s+IG1fdGFzazsKLSAgICBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSBtX2No YWxsZW5nZTsKKyAgICBPcHRpb25hbDxXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZT4g bV9jaGFsbGVuZ2U7CiAgICAgQ2hhbGxlbmdlQ29tcGxldGlvbkhhbmRsZXIgbV9jaGFsbGVuZ2VD b21wbGV0aW9uSGFuZGxlcjsKICAgICBSZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyIG1fcmVzcG9u c2VDb21wbGV0aW9uSGFuZGxlcjsKICAgICBSZWRpcmVjdENvbXBsZXRpb25IYW5kbGVyIG1fcmVk aXJlY3RDb21wbGV0aW9uSGFuZGxlcjsK