158735 2016-06-14 07:02:23 -0700 WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError instead of InvalidModificationError. 2016-06-14 09:44:53 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nael.ouedp nael.ouedp adam.bergkvist commit-queue eric.carlson youennf oldest_to_newest 1202169 0 nael.ouedp 2016-06-14 07:02:23 -0700 WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError exception when track already exists in connection's set of senders. 1202171 1 281257 nael.ouedp 2016-06-14 07:18:59 -0700 Created attachment 281257 Patch 1202175 2 281257 eric.carlson 2016-06-14 07:46:33 -0700 Comment on attachment 281257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281257&action=review > Source/WebCore/ChangeLog:10 > + Throw InvalidAccessError instead of InvalidModificationError when track already exists in connection's > + set of senders as per specification (https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtrack). > + Please note that the results for an existing test were updated for this fix, e.g. something like: Updated existing test results: fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt 1202205 3 281262 nael.ouedp 2016-06-14 09:34:21 -0700 Created attachment 281262 Patch for landing 1202207 4 nael.ouedp 2016-06-14 09:39:12 -0700 I landed a new patch with proposed modification in ChangeLog. Thanks for the review. 1202211 5 281262 commit-queue 2016-06-14 09:44:49 -0700 Comment on attachment 281262 Patch for landing Clearing flags on attachment: 281262 Committed r202049: <http://trac.webkit.org/changeset/202049> 1202212 6 commit-queue 2016-06-14 09:44:53 -0700 All reviewed patches have been landed. Closing bug. 281257 2016-06-14 07:18:59 -0700 2016-06-14 09:34:15 -0700 Patch bug-158735-20160614162034.patch text/plain 3599 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJhMzcyZmIwYzBhZThk NTI4YzBhNzA2Mzc3ZjExZTI1ZGYyYWNhZi4uYzViYzNkZmMxNDJlMTM1ZDEzY2VmZGFiMWRhZTM0 MjViM2Y4OTdmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA2LTE0ICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KIAorICAgICAgICBXZWJS VEM6IFJUQ1BlZXJDb25uZWN0aW9uOjphZGRUcmFjaygpIHNob3VsZCB0aHJvdyBJbnZhbGlkQWNj ZXNzRXJyb3IgaW5zdGVhZCBvZiBJbnZhbGlkTW9kaWZpY2F0aW9uRXJyb3IuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3MzUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaHJvdyBJbnZhbGlkQWNjZXNz RXJyb3IgaW5zdGVhZCBvZiBJbnZhbGlkTW9kaWZpY2F0aW9uRXJyb3Igd2hlbiB0cmFjayBhbHJl YWR5IGV4aXN0cyBpbiBjb25uZWN0aW9uJ3MKKyAgICAgICAgc2V0IG9mIHNlbmRlcnMgYXMgcGVy IHNwZWNpZmljYXRpb24gKGh0dHBzOi8vdzNjLmdpdGh1Yi5pby93ZWJydGMtcGMvI2RvbS1ydGNw ZWVyY29ubmVjdGlvbi1hZGR0cmFjaykuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L1JUQ1BlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0 aW9uOjphZGRUcmFjayk6CisKKzIwMTYtMDYtMTQgIE5hZWwgT3VlZHJhb2dvICA8bmFlbC5vdWVk cmFvZ29AY3JmLmNhbm9uLmZyPgorCiAgICAgICAgIFRoZSB2ZWN0b3Igb2YgbWVkaWFzdHJlYW1z IHNob3VsZCBiZSBwYXNzZWQgdmlhIGEgcmVmZXJlbmNlIHRvIFJUQ1BlZXJDb25uZWN0aW9uOjph ZGRUcmFjaygpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTg3MDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRleCBlMWQ3NzdhNzExZjc4Nzk0MzJjZTQ0OWQx Y2NlZmJkYmY3MjVkOGZhLi4xYzhhMWRlOTg5MDE3ZjE4ODNmNDU1NjgyZjlkMDM1OTkzZGRkZTFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJD b25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JU Q1BlZXJDb25uZWN0aW9uLmNwcApAQCAtMTE1LDggKzExNSw3IEBAIFJlZlB0cjxSVENSdHBTZW5k ZXI+IFJUQ1BlZXJDb25uZWN0aW9uOjphZGRUcmFjayhSZWY8TWVkaWFTdHJlYW1UcmFjaz4mJiB0 cmFjaywKIAogICAgIGZvciAoYXV0byYgc2VuZGVyIDogbV90cmFuc2NlaXZlclNldC0+Z2V0U2Vu ZGVycygpKSB7CiAgICAgICAgIGlmIChzZW5kZXItPnRyYWNrSWQoKSA9PSB0cmFjay0+aWQoKSkg ewotICAgICAgICAgICAgLy8gRklYTUU6IFNwZWMgc2F5cyBJbnZhbGlkUGFyYW1ldGVyCi0gICAg ICAgICAgICBlYyA9IElOVkFMSURfTU9ESUZJQ0FUSU9OX0VSUjsKKyAgICAgICAgICAgIGVjID0g SU5WQUxJRF9BQ0NFU1NfRVJSOwogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAg IH0KICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggZTAwYjYxNzEzODhkYWUyN2QyMzE5NTQ4M2M5Mjg0OTA1YjYwYThl MC4uYTU5MjFhZTkwMThlYjQwYTYwMTYyMDk2Y2U0MThmZWJkNDRjYjJjNCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA2LTE0ICBOYWVsIE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNy Zi5jYW5vbi5mcj4KKworICAgICAgICBXZWJSVEM6IFJUQ1BlZXJDb25uZWN0aW9uOjphZGRUcmFj aygpIHNob3VsZCB0aHJvdyBJbnZhbGlkQWNjZXNzRXJyb3IgaW5zdGVhZCBvZiBJbnZhbGlkTW9k aWZpY2F0aW9uRXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTg3MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGVjayB0aGF0IGFuIEludmFsaWRBY2Nlc3NFcnJvciBleGNlcHRpb24gaXMgdGhy b3duIHdoZW4gdGhlIHRyYWNrIGFscmVhZHkgZXhpc3RzIGluIHNldCBvZiBzZW5kZXJzLgorCisg ICAgICAgICogZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1hZGQtcmVtb3ZlVHJh Y2stZXhwZWN0ZWQudHh0OgorCiAyMDE2LTA2LTEzICBBZGFtIEJlcmdrdmlzdCAgPGFkYW0uYmVy Z2t2aXN0QGVyaWNzc29uLmNvbT4KIAogICAgICAgICBXZWJSVEM6IEltbGVtZW50IE1lZGlhRW5k cG9pbnRQZWVyQ29ubmVjdGlvbjo6cmVwbGFjZVRyYWNrKCkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24tYWRkLXJlbW92ZVRyYWNrLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rp b24tYWRkLXJlbW92ZVRyYWNrLWV4cGVjdGVkLnR4dAppbmRleCBjMzRkOGRlNzVjYWFjMjg2OWMx MDFkMTg1OTVlMjYzMjE2Y2MxNTgxLi42MTMxYjlhYTBiN2EzZDI4YTZjYTcxNTRlNzZhOTQ4Zjky NTg4NzA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJD b25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1hZGQtcmVtb3ZlVHJhY2stZXhwZWN0 ZWQudHh0CkBAIC0zMiw3ICszMiw3IEBAIFBBU1MgdHJhbnNjZWl2ZXIuc2VuZGVyIGlzIHNlbmRl cgogUEFTUyB0cmFuc2NlaXZlci5yZWNlaXZlciBpcyByZWNlaXZlcgogUEFTUyB0cmFuc2NlaXZl ci5zdG9wcGVkIGlzIGZhbHNlCiBUcnkgdG8gYWRkIHNhbWUgdHJhY2sgYWdhaW4KLVBBU1Mgc2Vu ZGVyID0gcGMuYWRkVHJhY2sodHJhY2ssIHN0cmVhbSkgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBJ bnZhbGlkTW9kaWZpY2F0aW9uRXJyb3I6IERPTSBFeGNlcHRpb24gMTMuCitQQVNTIHNlbmRlciA9 IHBjLmFkZFRyYWNrKHRyYWNrLCBzdHJlYW0pIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSW52YWxp ZEFjY2Vzc0Vycm9yOiBET00gRXhjZXB0aW9uIDE1LgogUEFTUyBzZW5kZXIyID0gcGMuYWRkVHJh Y2sodHJhY2syLCBzdHJlYW0sIHN0cmVhbTIpIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgogUEFT UyBwYy5nZXRTZW5kZXJzKCkubGVuZ3RoIGlzIDIKIFBBU1MgcGMuZ2V0U2VuZGVycygpWzBdIGlz IHNlbmRlcgo= 281262 2016-06-14 09:34:21 -0700 2016-06-14 09:44:49 -0700 Patch for landing bug-158735-20160614183556.patch text/plain 3630 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QzZDY4ZGM3MTAzODJj YTQ5ZjJiNDlhMjFhMmJkNTY5YzRjNGQ2My4uNWQxODg1OGJiOWZkNWRlYzQ4YzExYTg0NmIxNmJj NWJmYzg0Njg0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA2LTE0ICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBXZWJS VEM6IFJUQ1BlZXJDb25uZWN0aW9uOjphZGRUcmFjaygpIHNob3VsZCB0aHJvdyBJbnZhbGlkQWNj ZXNzRXJyb3IgaW5zdGVhZCBvZiBJbnZhbGlkTW9kaWZpY2F0aW9uRXJyb3IuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3MzUKKworICAgICAgICBS ZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgVGhyb3cgSW52YWxpZEFjY2Vzc0Vy cm9yIGluc3RlYWQgb2YgSW52YWxpZE1vZGlmaWNhdGlvbkVycm9yIHdoZW4gdHJhY2sgYWxyZWFk eSBleGlzdHMgaW4gY29ubmVjdGlvbidzCisgICAgICAgIHNldCBvZiBzZW5kZXJzIGFzIHBlciBz cGVjaWZpY2F0aW9uIChodHRwczovL3czYy5naXRodWIuaW8vd2VicnRjLXBjLyNkb20tcnRjcGVl cmNvbm5lY3Rpb24tYWRkdHJhY2spLgorCisgICAgICAgIFVwZGF0ZWQgZXhpc3RpbmcgdGVzdCBy ZXN1bHRzOiBmYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFj ay1leHBlY3RlZC50eHQKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmFkZFRy YWNrKToKKwogMjAxNi0wNi0xNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIE1ha2UgUmVuZGVyQmxvY2s6Omluc2VydEludG8vUmVtb3ZlRnJvbVRyYWNrZWRSZW5k ZXJlck1hcHMgZnVuY3Rpb25zIHN0YXRpYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKaW5kZXggZTFkNzc3YTcx MWY3ODc5NDMyY2U0NDlkMWNjZWZiZGJmNzI1ZDhmYS4uMWM4YTFkZTk4OTAxN2YxODgzZjQ1NTY4 MmY5ZDAzNTk5M2RkZGUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAKQEAgLTExNSw4ICsxMTUsNyBAQCBS ZWZQdHI8UlRDUnRwU2VuZGVyPiBSVENQZWVyQ29ubmVjdGlvbjo6YWRkVHJhY2soUmVmPE1lZGlh U3RyZWFtVHJhY2s+JiYgdHJhY2ssCiAKICAgICBmb3IgKGF1dG8mIHNlbmRlciA6IG1fdHJhbnNj ZWl2ZXJTZXQtPmdldFNlbmRlcnMoKSkgewogICAgICAgICBpZiAoc2VuZGVyLT50cmFja0lkKCkg PT0gdHJhY2stPmlkKCkpIHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBTcGVjIHNheXMgSW52YWxp ZFBhcmFtZXRlcgotICAgICAgICAgICAgZWMgPSBJTlZBTElEX01PRElGSUNBVElPTl9FUlI7Cisg ICAgICAgICAgICBlYyA9IElOVkFMSURfQUNDRVNTX0VSUjsKICAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI4ZDMzY2U2ODI4NmFhMGQxMDliNDUw OGJlOTdmNjY4MzViYmYzZjAuLjY0MjMyOTEwY2UwOGQ4ZDE4MWQyZGRhMDcwODk3M2ZiMDQ1NjY0 MGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0wNi0xNCAgTmFlbCBPdWVkcmFvZ28gIDxu YWVsLm91ZWRyYW9nb0BjcmYuY2Fub24uZnI+CisKKyAgICAgICAgV2ViUlRDOiBSVENQZWVyQ29u bmVjdGlvbjo6YWRkVHJhY2soKSBzaG91bGQgdGhyb3cgSW52YWxpZEFjY2Vzc0Vycm9yIGluc3Rl YWQgb2YgSW52YWxpZE1vZGlmaWNhdGlvbkVycm9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBDYXJsc29uLgorCisgICAgICAgIENoZWNrIHRoYXQgYW4gSW52YWxpZEFjY2Vzc0Vycm9yIGV4 Y2VwdGlvbiBpcyB0aHJvd24gd2hlbiB0aGUgdHJhY2sgYWxyZWFkeSBleGlzdHMgaW4gc2V0IG9m IHNlbmRlcnMuCisKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9u LWFkZC1yZW1vdmVUcmFjay1leHBlY3RlZC50eHQ6CisKIDIwMTYtMDYtMTQgIEFkYW0gQmVyZ2t2 aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgogCiAgICAgICAgIFdlYlJUQzogQWRk IG1lZGlhIHNldHVwIHRlc3Qgd2hlcmUgbWVkaWEgaXMgc2V0IHVwIGluIG9uZSBkaXJlY3Rpb24g YXQgYSB0aW1lCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1Bl ZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWFkZC1yZW1vdmVUcmFjay1leHBlY3Rl ZC50eHQKaW5kZXggYzM0ZDhkZTc1Y2FhYzI4NjljMTAxZDE4NTk1ZTI2MzIxNmNjMTU4MS4uNjEz MWI5YWEwYjdhM2QyOGE2Y2E3MTU0ZTc2YTk0OGY5MjU4ODcwOCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1hZGQtcmVtb3ZlVHJhY2st ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24tYWRkLXJlbW92ZVRyYWNrLWV4cGVjdGVkLnR4dApAQCAtMzIsNyArMzIsNyBAQCBQ QVNTIHRyYW5zY2VpdmVyLnNlbmRlciBpcyBzZW5kZXIKIFBBU1MgdHJhbnNjZWl2ZXIucmVjZWl2 ZXIgaXMgcmVjZWl2ZXIKIFBBU1MgdHJhbnNjZWl2ZXIuc3RvcHBlZCBpcyBmYWxzZQogVHJ5IHRv IGFkZCBzYW1lIHRyYWNrIGFnYWluCi1QQVNTIHNlbmRlciA9IHBjLmFkZFRyYWNrKHRyYWNrLCBz dHJlYW0pIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogSW52YWxpZE1vZGlmaWNhdGlvbkVycm9yOiBE T00gRXhjZXB0aW9uIDEzLgorUEFTUyBzZW5kZXIgPSBwYy5hZGRUcmFjayh0cmFjaywgc3RyZWFt KSB0aHJldyBleGNlcHRpb24gRXJyb3I6IEludmFsaWRBY2Nlc3NFcnJvcjogRE9NIEV4Y2VwdGlv biAxNS4KIFBBU1Mgc2VuZGVyMiA9IHBjLmFkZFRyYWNrKHRyYWNrMiwgc3RyZWFtLCBzdHJlYW0y KSBkaWQgbm90IHRocm93IGV4Y2VwdGlvbi4KIFBBU1MgcGMuZ2V0U2VuZGVycygpLmxlbmd0aCBp cyAyCiBQQVNTIHBjLmdldFNlbmRlcnMoKVswXSBpcyBzZW5kZXIK