<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>158734</bug_id>
          
          <creation_ts>2016-06-14 07:00:52 -0700</creation_ts>
          <short_desc>Activate CMake export compile commands option</short_desc>
          <delta_ts>2016-06-21 06:07:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>achristensen</cc>
    
    <cc>changseok</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1202168</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-06-14 07:00:52 -0700</bug_when>
    <thetext>This CMake option is activated for GTK only currently.
But it might also be handy for other ports that use CMake.
This option allows using ymcd autocompletion and is not consuming a lot of time according bug 131591.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202170</commentid>
    <comment_count>1</comment_count>
      <attachid>281256</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-06-14 07:05:45 -0700</bug_when>
    <thetext>Created attachment 281256
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202199</commentid>
    <comment_count>2</comment_count>
      <attachid>281256</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-06-14 09:08:19 -0700</bug_when>
    <thetext>Comment on attachment 281256
Patch

OMG YES!!!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202203</commentid>
    <comment_count>3</comment_count>
      <attachid>281256</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-14 09:31:13 -0700</bug_when>
    <thetext>Comment on attachment 281256
Patch

Clearing flags on attachment: 281256

Committed r202046: &lt;http://trac.webkit.org/changeset/202046&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202204</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-06-14 09:31:17 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202213</commentid>
    <comment_count>5</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-06-14 09:45:00 -0700</bug_when>
    <thetext>youcompleteme is working on my setup for both gtk and mac platforms using the same config in Tools/gtk.
Maybe we should move that config in a non gtk-folder?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202303</commentid>
    <comment_count>6</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2016-06-14 13:54:56 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; youcompleteme is working on my setup for both gtk and mac platforms using
&gt; the same config in Tools/gtk.
&gt; Maybe we should move that config in a non gtk-folder?

Interesting. Youenn, does cmake build work for mac port now? When I tried it few weeks ago, it was broken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1202527</commentid>
    <comment_count>7</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-06-15 01:45:49 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #5)
&gt; &gt; youcompleteme is working on my setup for both gtk and mac platforms using
&gt; &gt; the same config in Tools/gtk.
&gt; &gt; Maybe we should move that config in a non gtk-folder?
&gt; 
&gt; Interesting. Youenn, does cmake build work for mac port now? When I tried it
&gt; few weeks ago, it was broken.

I think it compiles JSC and WebCore but fails generating some executables like DRT/WTR (compilation, link?).
For the purpose of ycmd conf generation, it works just fine.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>281256</attachid>
            <date>2016-06-14 07:05:45 -0700</date>
            <delta_ts>2016-06-14 09:31:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-158734-20160614160719.patch</filename>
            <type>text/plain</type>
            <size>1379</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2VhZWFhN2QwODY4ODg1MTNkMzdjZTBjZjQ5ZTRiOTA4
MmQ2YzI4OC4uNzI0YzA3ZTdjYmFjOGU4MDU4MTdmOTFjMGYxNTdmMTQ4NGU5ZjY3ZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDE2LTA2LTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u
ZnI+CisKKyAgICAgICAgQWN0aXZhdGUgQ01ha2UgZXhwb3J0IGNvbXBpbGUgY29tbWFuZHMgb3B0
aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg3
MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj
cmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01h
a2VQcm9qZWN0KTogQWN0aXZhdGluZyB0aGlzIG9wdGlvbiBmb3IgYWxsIENNYWtlIGJ1aWxkcy4K
KyAgICAgICAgVGhpcyBhbGxvd3MgdXNpbmcgeW1jZCBmb3IgV2ViS2l0IGhhY2tpbmcuCisKIDIw
MTYtMDYtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBN
b2Rlcm5pemUgRHVtcFJlbmRlclRyZWVNYWMuaApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93
ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDRhODQ5M2E3
MWFmNjk5YjUwODgwOWFjZTM4YjAxOGMyNDJjN2UxYjguLjQxMDYzYjRhYmU3NWE1YjFmNDMxMTEy
YzdiZDc3N2JhODExNDYxNWMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w
bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5NzUsNyArMTk3NSw3IEBA
IHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogICAgIG15IEBhcmdzOwog
ICAgIHB1c2ggQGFyZ3MsICItRFBPUlQ9XCIkcG9ydFwiIjsKICAgICBwdXNoIEBhcmdzLCAiLURD
TUFLRV9JTlNUQUxMX1BSRUZJWD1cIiRwcmVmaXhQYXRoXCIiIGlmICRwcmVmaXhQYXRoOwotICAg
IHB1c2ggQGFyZ3MsICItRENNQUtFX0VYUE9SVF9DT01QSUxFX0NPTU1BTkRTPU9OIiBpZiBpc0d0
aygpOworICAgIHB1c2ggQGFyZ3MsICItRENNQUtFX0VYUE9SVF9DT01QSUxFX0NPTU1BTkRTPU9O
IjsKICAgICBpZiAoJGNvbmZpZyA9fiAvcmVsZWFzZS9pKSB7CiAgICAgICAgIHB1c2ggQGFyZ3Ms
ICItRENNQUtFX0JVSUxEX1RZUEU9UmVsZWFzZSI7CiAgICAgfSBlbHNpZiAoJGNvbmZpZyA9fiAv
ZGVidWcvaSkgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>