158732 2016-06-14 06:07:16 -0700 [Win] The test accessibility/selected-text-range-aria-elements.html is failing. 2016-06-15 02:55:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan aboxhall achristensen apinheiro bfulgham cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white oldest_to_newest 1202157 0 pvollan 2016-06-14 06:07:16 -0700 The method AccessibilityUIElement::selectedTextRange() is not implemented. 1202162 1 281253 pvollan 2016-06-14 06:40:43 -0700 Created attachment 281253 Patch 1202177 2 281253 bfulgham 2016-06-14 07:51:02 -0700 Comment on attachment 281253 Patch r=me. 1202178 3 281253 bfulgham 2016-06-14 07:51:42 -0700 Comment on attachment 281253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281253&action=review r=me. > Source/WebCore/ChangeLog:8 > + Implement support for getting selected text range. Does this allow us to unskip any tests? 1202188 4 pvollan 2016-06-14 08:12:37 -0700 (In reply to comment #3) > Comment on attachment 281253 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281253&action=review > > r=me. > > > Source/WebCore/ChangeLog:8 > > + Implement support for getting selected text range. > > Does this allow us to unskip any tests? I will have a look in the test expectations :) Thanks for reviewing! 1202538 5 pvollan 2016-06-15 02:55:58 -0700 Committed r202088: <https://trac.webkit.org/changeset/202088> 281253 2016-06-14 06:40:43 -0700 2016-06-14 07:51:02 -0700 Patch bug-158732-20160614064218.patch text/plain 3374 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjAzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA2LTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBUaGUgdGVzdCBh Y2Nlc3NpYmlsaXR5L3NlbGVjdGVkLXRleHQtcmFuZ2UtYXJpYS1lbGVtZW50cy5odG1sIGlzIGZh aWxpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTg3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bXBsZW1lbnQgc3VwcG9ydCBmb3IgZ2V0dGluZyBzZWxlY3RlZCB0ZXh0IHJhbmdlLgorCisgICAg ICAgICogYWNjZXNzaWJpbGl0eS93aW4vQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJXaW4uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXI6OmFjY2Vzc2li aWxpdHlBdHRyaWJ1dGVWYWx1ZSk6CisKIDIwMTYtMDYtMTQgIE5hZWwgT3VlZHJhb2dvICA8bmFl bC5vdWVkcmFvZ29AY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFRoZSB2ZWN0b3Igb2YgbWVkaWFz dHJlYW1zIHNob3VsZCBiZSBwYXNzZWQgdmlhIGEgcmVmZXJlbmNlIHRvIFJUQ1BlZXJDb25uZWN0 aW9uOjphZGRUcmFjaygpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L3dpbi9B Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcldpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS93aW4vQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJXaW4uY3Bw CShyZXZpc2lvbiAyMDIwMzkpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L3dpbi9B Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYg KzY1LDE1IEBAIHZvaWQgQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXI6OmFjY2Vzc2kKICAgICAg ICAgVl9CU1RSKHJlc3VsdCkgPSBXZWJDb3JlOjpCU3RyaW5nKG1fb2JqZWN0LT5nZXRBdHRyaWJ1 dGUoV2ViQ29yZTo6SFRNTE5hbWVzOjppZEF0dHIpKS5yZWxlYXNlKCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CisKKyAgICBpZiAoYXR0cmlidXRlTmFtZSA9PSAiQVhTZWxlY3RlZFRleHRSYW5n ZUF0dHJpYnV0ZSIpIHsKKyAgICAgICAgQVNTRVJUKFZfVlQocmVzdWx0KSA9PSBWVF9FTVBUWSk7 CisgICAgICAgIFZfVlQocmVzdWx0KSA9IFZUX0JTVFI7CisgICAgICAgIFBsYWluVGV4dFJhbmdl IHRleHRSYW5nZSA9IG1fb2JqZWN0LT5zZWxlY3RlZFRleHRSYW5nZSgpOworICAgICAgICBTdHJp bmcgcmFuZ2UgPSBTdHJpbmc6OmZvcm1hdCgieyV1LCAldX0iLCB0ZXh0UmFuZ2Uuc3RhcnQsIHRl eHRSYW5nZS5sZW5ndGgpOworICAgICAgICBWX0JTVFIocmVzdWx0KSA9IFdlYkNvcmU6OkJTdHJp bmcocmFuZ2UpLnJlbGVhc2UoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KIH0KIAogCkluZGV4 OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lv biAyMDIwNDEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NSBAQAorMjAxNi0wNi0xNCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisK KyAgICAgICAgW1dpbl0gVGhlIHRlc3QgYWNjZXNzaWJpbGl0eS9zZWxlY3RlZC10ZXh0LXJhbmdl LWFyaWEtZWxlbWVudHMuaHRtbCBpcyBmYWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IHNlbGVjdGVkVGV4dFJhbmdlKCkgbWV0 aG9kLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRXaW4uY3BwOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2VsZWN0ZWRUZXh0 UmFuZ2UpOgorCiAyMDE2LTA2LTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CiAKICAgICAgICAgTW9kZXJuaXplIER1bXBSZW5kZXJUcmVlTWFjLmgKSW5kZXg6IFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3dpbi9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50V2luLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vQWNjZXNzaWJpbGl0eVVJRWxlbWVudFdpbi5j cHAJKHJldmlzaW9uIDIwMjAzOSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjg2LDcgKzY4NiwxNiBA QCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsCiAKIEpTU3RyaW5nUmVm IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnNlbGVjdGVkVGV4dFJhbmdlKCkKIHsKLSAgICByZXR1 cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsgICAgCisgICAgQ09NUHRyPElB Y2Nlc3NpYmxlQ29tcGFyYWJsZT4gY29tcGFyYWJsZSA9IGNvbXBhcmFibGVPYmplY3QocGxhdGZv cm1VSUVsZW1lbnQoKS5nZXQoKSk7CisgICAgaWYgKCFjb21wYXJhYmxlKQorICAgICAgICByZXR1 cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsKKworICAgIF92YXJpYW50X3Qg dmFsdWU7CisgICAgaWYgKEZBSUxFRChjb21wYXJhYmxlLT5nZXRfYXR0cmlidXRlKF9ic3RyX3Qo TCJBWFNlbGVjdGVkVGV4dFJhbmdlQXR0cmlidXRlIiksICZ2YWx1ZS5HZXRWQVJJQU5UKCkpKSkK KyAgICAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aENoYXJhY3RlcnMoMCwgMCk7ICAgIAor CisgICAgQVNTRVJUKFZfVlQoJnZhbHVlKSA9PSBWVF9CU1RSKTsKKyAgICByZXR1cm4gSlNTdHJp bmdDcmVhdGVXaXRoQlNUUih2YWx1ZS5ic3RyVmFsKTsKIH0KIAogdm9pZCBBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50OjpzZXRTZWxlY3RlZFRleHRSYW5nZSh1bnNpZ25lZCBsb2NhdGlvbiwgdW5zaWdu ZWQgbGVuZ3RoKQo=