158729 2016-06-14 01:28:21 -0700 REGRESSION (r151608): Leak of QTMovieLayer or AVPlayerLayer in -[WebVideoFullscreenController setVideoElement:] 2016-06-14 06:09:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117597 1 ddkilzer ddkilzer commit-queue eric.carlson jer.noble oldest_to_newest 1202135 0 ddkilzer 2016-06-14 01:28:21 -0700 -[WebVideoFullscreenController setVideoElement:] leaks either a QTMovieLayer or AVPlayerLayer depending on the type of video. Regressed in r151608: Bug 117597: Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController. <https://bugs.webkit.org/show_bug.cgi?id=117597> <http://trac.webkit.org/changeset/151608> 1202138 1 281246 ddkilzer 2016-06-14 01:37:16 -0700 Created attachment 281246 Patch v1 1202158 2 281246 commit-queue 2016-06-14 06:09:20 -0700 Comment on attachment 281246 Patch v1 Clearing flags on attachment: 281246 Committed r202041: <http://trac.webkit.org/changeset/202041> 1202159 3 commit-queue 2016-06-14 06:09:24 -0700 All reviewed patches have been landed. Closing bug. 281246 2016-06-14 01:37:16 -0700 2016-06-14 06:09:20 -0700 Patch v1 bug-158729-20160614013851.patch text/plain 4076 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI5NTAwMTg1MzJkNTc5 NzkwOTc1NjYzMTU0MGZkZjk4NzNjYmFmZi4uMDRhMjQ2MGVlM2Y1NTA5MjZjMDJmMDcxMzViZGQ4 MDBkNmZkYzAwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA2LTE0ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE1 MTYwOCk6IExlYWsgb2YgUVRNb3ZpZUxheWVyIG9yIEFWUGxheWVyTGF5ZXIgaW4gLVtXZWJWaWRl b0Z1bGxzY3JlZW5Db250cm9sbGVyIHNldFZpZGVvRWxlbWVudDpdCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xNTg3Mjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxl ci5tbToKKyAgICAgICAgKC1bV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlciBzZXRWaWRlb0Vs ZW1lbnQ6XSk6IFVzZQorICAgICAgICBSZXRhaW5QdHI8PiB0byBwcmV2ZW50IGxlYWtzLgorICAg ICAgICAqIHBsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5IVURXaW5kb3dDb250cm9sbGVy Lm1tOgorICAgICAgICBEcml2ZS1ieSBmaXggdG8gcmVtb3ZlIHVudXNlZCA8d3RmL1JldGFpblB0 ci5oPiBpbXBvcnQuCisKIDIwMTYtMDYtMTMgIEdhdmluICYgRWxsaWUgQmFycmFjbG91Z2ggIDxi YXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGhhc1N0YXRpY1Byb3BlcnR5 VGFibGUgKHBhcnQgMzogSlNMb2NhdGlvbjo6cHV0RGVsZWdhdGUpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlci5tbSBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVy Lm1tCmluZGV4IDI4MDE3YWJmN2M1NDQ4N2QxYzA1OTg1YzE3MGExZjI5ZmRjYmZlZDIuLmM4MmUz MmI3NzNhYjJlN2Q2MmI1MzI1YTdhNmViMjRjMmZlNDk0ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVy Lm1tCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOSBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDktMjAxNiBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK QEAgLTM3LDYgKzM3LDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvSFRNTFZpZGVvRWxlbWVudC5oPgog I2ltcG9ydCA8V2ViQ29yZS9Tb2Z0TGlua2luZy5oPgogI2ltcG9ydCA8b2JqYy9ydW50aW1lLmg+ CisjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAKICNpZiBVU0UoUVRLSVQpCiAjaW1wb3J0ICJR VEtpdFNQSS5oIgpAQCAtMTMwLDkgKzEzMSw5IEBAIFNPRlRfTElOS19DTEFTUyhBVkZvdW5kYXRp b24sIEFWUGxheWVyTGF5ZXIpCiAjaWYgVVNFKFFUS0lUKQogICAgICAgICBpZiAoX3ZpZGVvRWxl bWVudC0+cGxhdGZvcm1NZWRpYSgpLnR5cGUgPT0gUGxhdGZvcm1NZWRpYTo6UVRNb3ZpZVR5cGUp IHsKICAgICAgICAgICAgIFFUTW92aWUgKm1vdmllID0gX3ZpZGVvRWxlbWVudC0+cGxhdGZvcm1N ZWRpYSgpLm1lZGlhLnF0TW92aWU7Ci0gICAgICAgICAgICBRVE1vdmllTGF5ZXIgKmxheWVyID0g W2FsbG9jUVRNb3ZpZUxheWVySW5zdGFuY2UoKSBpbml0XTsKLSAgICAgICAgICAgIFtsYXllciBz ZXRNb3ZpZTptb3ZpZV07Ci0gICAgICAgICAgICBbc2VsZiBzZXR1cFZpZGVvT3ZlcmxheTpsYXll cl07CisgICAgICAgICAgICBSZXRhaW5QdHI8UVRNb3ZpZUxheWVyPiBsYXllciA9IGFkb3B0TlMo W2FsbG9jUVRNb3ZpZUxheWVySW5zdGFuY2UoKSBpbml0XSk7CisgICAgICAgICAgICBbbGF5ZXIu Z2V0KCkgc2V0TW92aWU6bW92aWVdOworICAgICAgICAgICAgW3NlbGYgc2V0dXBWaWRlb092ZXJs YXk6bGF5ZXIuZ2V0KCldOwogCiAgICAgICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRl ZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZWN0b3I6QHNlbGVjdG9yKHJhdGVDaGFuZ2Vk OikKQEAgLTE0Myw5ICsxNDQsOSBAQCBTT0ZUX0xJTktfQ0xBU1MoQVZGb3VuZGF0aW9uLCBBVlBs YXllckxheWVyKQogI2VuZGlmCiAgICAgICAgIGlmIChfdmlkZW9FbGVtZW50LT5wbGF0Zm9ybU1l ZGlhKCkudHlwZSA9PSBQbGF0Zm9ybU1lZGlhOjpBVkZvdW5kYXRpb25NZWRpYVBsYXllclR5cGUp IHsKICAgICAgICAgICAgIEFWUGxheWVyICpwbGF5ZXIgPSBfdmlkZW9FbGVtZW50LT5wbGF0Zm9y bU1lZGlhKCkubWVkaWEuYXZmTWVkaWFQbGF5ZXI7Ci0gICAgICAgICAgICBBVlBsYXllckxheWVy ICpsYXllciA9IFthbGxvY0FWUGxheWVyTGF5ZXJJbnN0YW5jZSgpIGluaXRdOwotICAgICAgICAg ICAgW3NlbGYgc2V0dXBWaWRlb092ZXJsYXk6bGF5ZXJdOwotICAgICAgICAgICAgW2xheWVyIHNl dFBsYXllcjpwbGF5ZXJdOworICAgICAgICAgICAgUmV0YWluUHRyPEFWUGxheWVyTGF5ZXI+IGxh eWVyID0gYWRvcHROUyhbYWxsb2NBVlBsYXllckxheWVySW5zdGFuY2UoKSBpbml0XSk7CisgICAg ICAgICAgICBbc2VsZiBzZXR1cFZpZGVvT3ZlcmxheTpsYXllci5nZXQoKV07CisgICAgICAgICAg ICBbbGF5ZXIuZ2V0KCkgc2V0UGxheWVyOnBsYXllcl07CiAKICAgICAgICAgICAgIFtwbGF5ZXIg YWRkT2JzZXJ2ZXI6c2VsZiBmb3JLZXlQYXRoOkAicmF0ZSIgb3B0aW9uczowIGNvbnRleHQ6bnVs bHB0cl07CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJWaWRlb0Z1bGxzY3JlZW5IVURXaW5kb3dDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkhVRFdpbmRvd0NvbnRyb2xsZXIubW0K aW5kZXggYzg2YWYwZjY4YTFhZTU0Yzg3YjkwNDIyNWFiY2Q2NzA1NGI3OGQxZS4uYjY1NWRhYzEz YzQzZDExM2E1NzRhNzU2MzBkYjRhMmU4MmUxYzc4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkhVRFdpbmRvd0NvbnRyb2xsZXIubW0K KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkhVRFdp bmRvd0NvbnRyb2xsZXIubW0KQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAy MDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAw OS0yMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucwpAQCAtMzMsNyArMzMsNiBAQAogI2ltcG9ydCA8V2ViQ29yZS9Db3JlR3Jh cGhpY3NTUEkuaD4KICNpbXBvcnQgPFdlYkNvcmUvSFRNTFZpZGVvRWxlbWVudC5oPgogI2ltcG9y dCA8V2ViQ29yZVN5c3RlbUludGVyZmFjZS5oPgotI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgog CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAo=