158717 2016-06-13 18:49:23 -0700 [Cocoa] Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit() 2016-06-14 07:29:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen ap commit-queue darin oldest_to_newest 1202044 0 cdumez 2016-06-13 18:49:23 -0700 Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit() by calling CFHTTPMessageCopyAllHeaderFields() instead of [NSURLResponse allHeaderFields]. 1202045 1 cdumez 2016-06-13 18:49:29 -0700 rdar://problem/26778863 1202047 2 281224 cdumez 2016-06-13 18:52:07 -0700 Created attachment 281224 Patch 1202112 3 281224 achristensen 2016-06-14 00:07:31 -0700 Comment on attachment 281224 Patch Woohoo!!! Fewer copies!!! R=me allHeaderFields is marked in the public API with @property (readonly, copy) NSDictionary *allHeaderFields; 1202172 4 281224 commit-queue 2016-06-14 07:29:49 -0700 Comment on attachment 281224 Patch Clearing flags on attachment: 281224 Committed r202042: <http://trac.webkit.org/changeset/202042> 1202173 5 commit-queue 2016-06-14 07:29:55 -0700 All reviewed patches have been landed. Closing bug. 281224 2016-06-13 18:52:07 -0700 2016-06-14 07:29:49 -0700 Patch bug-158717-20160613185341.patch text/plain 4054 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI3ZDk4ZWE2ZDlmMmJl ZDViMmY3MjY1OWMxMzc5ZjFlNDMyNDIwOC4uMDA5NGVhY2NjODNlZTllYzI0NzBlMDc5NTg2ZTBj M2Q3MzNjYWM1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA2LTEzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBdm9pZCBleHRy YSBjb3B5IG9mIGhlYWRlcnMgZGljdGlvbmFyeSBpbiBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9y bUxhenlJbml0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1ODcxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEF2b2lkIGV4dHJhIGNvcHkgb2YgaGVhZGVycyBkaWN0aW9uYXJ5IGluIFJlc291cmNlUmVz cG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoKSBieQorICAgICAgICBjYWxsaW5nIENGSFRUUE1lc3Nh Z2VDb3B5QWxsSGVhZGVyRmllbGRzKCkgaW5zdGVhZCBvZiBbTlNVUkxSZXNwb25zZSBhbGxIZWFk ZXJGaWVsZHNdLgorCisgICAgICAgIENGSFRUUE1lc3NhZ2VDb3B5QWxsSGVhZGVyRmllbGRzKCkg Y3JlYXRlcyBvbmx5IDEgY29weSB3aGlsZQorICAgICAgICBbTlNVUkxSZXNwb25zZSBhbGxIZWFk ZXJGaWVsZHNdIGNyZWF0ZXMgMiAoc2VlIDxyZGFyOi8vcHJvYmxlbS8yNjc3ODg2Mz4pLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW06 CisgICAgICAgIChXZWJDb3JlOjphZGRUb0hUVFBIZWFkZXJNYXApOgorICAgICAgICAoV2ViQ29y ZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdCk6CisKIDIwMTYtMDYtMTMgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2hU cmFjZXI6IGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBhdCBXZWJDb3JlOjpBY2Nlc3NpYmls aXR5UmVuZGVyT2JqZWN0OjpyZW1vdGVTVkdSb290RWxlbWVudCBjb25zdCArIDIyNwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3Bv bnNlQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291 cmNlUmVzcG9uc2VDb2NvYS5tbQppbmRleCA5MzU3OWFkNjEyYWNkYjA1NzUzZGIxYzkwMWFjYTFl NGNmZmM5Y2YyLi5hNjFkNmI4ZWVhMDI1NThlZDA2NmQ5YjRmZTA5OGYwNjZiZDc5MDczIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jlc291cmNlUmVz cG9uc2VDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29h L1Jlc291cmNlUmVzcG9uc2VDb2NvYS5tbQpAQCAtMTU5LDYgKzE1OSwxMiBAQCBzdGF0aWMgTlNT dHJpbmcgKmNvcHlOU1VSTFJlc3BvbnNlU3RhdHVzTGluZShOU1VSTFJlc3BvbnNlICpyZXNwb25z ZSkKICAgICByZXR1cm4gKE5TU3RyaW5nICopQ0ZIVFRQTWVzc2FnZUNvcHlSZXNwb25zZVN0YXR1 c0xpbmUoY2ZIVFRQTWVzc2FnZSk7CiB9CiAKK3N0YXRpYyB2b2lkIGFkZFRvSFRUUEhlYWRlck1h cChjb25zdCB2b2lkKiBrZXksIGNvbnN0IHZvaWQqIHZhbHVlLCB2b2lkKiBjb250ZXh0KQorewor ICAgIEhUVFBIZWFkZXJNYXAqIGh0dHBIZWFkZXJNYXAgPSAoSFRUUEhlYWRlck1hcCopY29udGV4 dDsKKyAgICBodHRwSGVhZGVyTWFwLT5zZXQoKENGU3RyaW5nUmVmKWtleSwgKENGU3RyaW5nUmVm KXZhbHVlKTsKK30KKwogdm9pZCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJbml0KElu aXRMZXZlbCBpbml0TGV2ZWwpCiB7CiAgICAgaWYgKG1faW5pdExldmVsID49IGluaXRMZXZlbCkK QEAgLTE4NywxMCArMTkzLDE0IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5 SW5pdChJbml0TGV2ZWwgaW5pdExldmVsKQogICAgICAgICAgICAgbV9odHRwU3RhdHVzQ29kZSA9 IFtodHRwUmVzcG9uc2Ugc3RhdHVzQ29kZV07CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGlm IChpbml0TGV2ZWwgPCBBbGxGaWVsZHMpIHsKLSAgICAgICAgICAgICAgICBOU0RpY3Rpb25hcnkg KmhlYWRlcnMgPSBbaHR0cFJlc3BvbnNlIGFsbEhlYWRlckZpZWxkc107Ci0gICAgICAgICAgICAg ICAgZm9yIChOU1N0cmluZyAqbmFtZSA6IGNvbW1vbkhlYWRlckZpZWxkcykgewotICAgICAgICAg ICAgICAgICAgICBpZiAoTlNTdHJpbmcqIGhlYWRlclZhbHVlID0gW2hlYWRlcnMgb2JqZWN0Rm9y S2V5Om5hbWVdKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9odHRwSGVhZGVyRmllbGRzLnNl dChuYW1lLCBoZWFkZXJWYWx1ZSk7CisgICAgICAgICAgICAgICAgQ0ZIVFRQTWVzc2FnZVJlZiBt ZXNzYWdlUmVmID0gQ0ZVUkxSZXNwb25zZUdldEhUVFBSZXNwb25zZShbaHR0cFJlc3BvbnNlIF9D RlVSTFJlc3BvbnNlXSk7CisKKyAgICAgICAgICAgICAgICAvLyBBdm9pZCBjYWxsaW5nIFtOU1VS TFJlc3BvbnNlIGFsbEhlYWRlckZpZWxkc10gdG8gbWluaW1pemUgY29weWluZyAoPHJkYXI6Ly9w cm9ibGVtLzI2Nzc4ODYzPikuCisgICAgICAgICAgICAgICAgUmV0YWluUHRyPENGRGljdGlvbmFy eVJlZj4gaGVhZGVycyA9IGFkb3B0Q0YoQ0ZIVFRQTWVzc2FnZUNvcHlBbGxIZWFkZXJGaWVsZHMo bWVzc2FnZVJlZikpOworICAgICAgICAgICAgICAgIGZvciAoYXV0byYgY29tbW9uSGVhZGVyIDog Y29tbW9uSGVhZGVyRmllbGRzKSB7CisgICAgICAgICAgICAgICAgICAgIENGU3RyaW5nUmVmIHZh bHVlOworICAgICAgICAgICAgICAgICAgICBpZiAoQ0ZEaWN0aW9uYXJ5R2V0VmFsdWVJZlByZXNl bnQoaGVhZGVycy5nZXQoKSwgY29tbW9uSGVhZGVyLCAoY29uc3Qgdm9pZCAqKikmdmFsdWUpKQor ICAgICAgICAgICAgICAgICAgICAgICAgbV9odHRwSGVhZGVyRmllbGRzLnNldChjb21tb25IZWFk ZXIsIHZhbHVlKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0g ZWxzZQpAQCAtMjEyLDkgKzIyMiw5IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1M YXp5SW5pdChJbml0TGV2ZWwgaW5pdExldmVsKQogICAgICAgICAgICAgQ0ZIVFRQTWVzc2FnZVJl ZiBtZXNzYWdlUmVmID0gQ0ZVUkxSZXNwb25zZUdldEhUVFBSZXNwb25zZShbaHR0cFJlc3BvbnNl IF9DRlVSTFJlc3BvbnNlXSk7CiAgICAgICAgICAgICBtX2h0dHBWZXJzaW9uID0gU3RyaW5nKGFk b3B0Q0YoQ0ZIVFRQTWVzc2FnZUNvcHlWZXJzaW9uKG1lc3NhZ2VSZWYpKS5nZXQoKSkuY29udmVy dFRvQVNDSUlVcHBlcmNhc2UoKTsKIAotICAgICAgICAgICAgTlNEaWN0aW9uYXJ5ICpoZWFkZXJz ID0gW2h0dHBSZXNwb25zZSBhbGxIZWFkZXJGaWVsZHNdOwotICAgICAgICAgICAgZm9yIChOU1N0 cmluZyAqbmFtZSBpbiBoZWFkZXJzKQotICAgICAgICAgICAgICAgIG1faHR0cEhlYWRlckZpZWxk cy5zZXQobmFtZSwgW2hlYWRlcnMgb2JqZWN0Rm9yS2V5Om5hbWVdKTsKKyAgICAgICAgICAgIC8v IEF2b2lkIGNhbGxpbmcgW05TVVJMUmVzcG9uc2UgYWxsSGVhZGVyRmllbGRzXSB0byBtaW5pbWl6 ZSBjb3B5aW5nICg8cmRhcjovL3Byb2JsZW0vMjY3Nzg4NjM+KS4KKyAgICAgICAgICAgIFJldGFp blB0cjxDRkRpY3Rpb25hcnlSZWY+IGhlYWRlcnMgPSBhZG9wdENGKENGSFRUUE1lc3NhZ2VDb3B5 QWxsSGVhZGVyRmllbGRzKG1lc3NhZ2VSZWYpKTsKKyAgICAgICAgICAgIENGRGljdGlvbmFyeUFw cGx5RnVuY3Rpb24oaGVhZGVycy5nZXQoKSwgYWRkVG9IVFRQSGVhZGVyTWFwLCAmbV9odHRwSGVh ZGVyRmllbGRzKTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgW3Bvb2wgZHJhaW5dOwogICAg ICAgICB9Cg==