158711 2016-06-13 16:34:06 -0700 Drop HipChat hack introduced in r197548 2016-06-13 21:24:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez ap cdumez commit-queue darin rniwa oldest_to_newest 1202010 0 cdumez 2016-06-13 16:34:06 -0700 Drop HipChat hack introduced in r197548. This hack is no longer needed as the bug was fixed in HipChat since then: https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532 I have confirmed locally that the latest version (4.0.12.665) is able to connect without the hack. 1202011 1 281213 cdumez 2016-06-13 16:36:44 -0700 Created attachment 281213 Patch 1202012 2 281213 ggaren 2016-06-13 16:38:26 -0700 Comment on attachment 281213 Patch r=me 1202022 3 281213 commit-queue 2016-06-13 17:09:40 -0700 Comment on attachment 281213 Patch Clearing flags on attachment: 281213 Committed r202017: <http://trac.webkit.org/changeset/202017> 1202023 4 commit-queue 2016-06-13 17:09:44 -0700 All reviewed patches have been landed. Closing bug. 1202083 5 rniwa 2016-06-13 21:24:44 -0700 Nice! 281213 2016-06-13 16:36:44 -0700 2016-06-13 17:09:40 -0700 Patch bug-158711-20160613163819.patch text/plain 3151 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWYzMTNiNzczMjAxMzBi NzY4NWFmMmIwOWNlOTIyZjhhNDg0ZWRjZS4uOTNlMmJhNjQwMWRlZWU0MDkxYjc2ZDI3NjVlODY0 YjI0ZjZhYzRjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA2LTEzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBIaXBDaGF0IGhhY2sg aW50cm9kdWNlZCBpbiByMTk3NTQ4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTg3MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBEcm9wIEhpcENoYXQgaGFjayBpbnRyb2R1Y2VkIGluIHIxOTc1NDguIFRo aXMgaGFjayBpcyBubyBsb25nZXIgbmVlZGVkCisgICAgICAgIGFzIHRoZSBidWcgd2FzIGZpeGVk IGluIEhpcENoYXQgc2luY2UgdGhlbjoKKyAgICAgICAgaHR0cHM6Ly9zdXBwb3J0LmF0bGFzc2lh bi5jb20vc2VydmljZWRlc2svY3VzdG9tZXIvcG9ydGFsLzMyL0hDUC03NTMyCisKKyAgICAgICAg SSBoYXZlIGNvbmZpcm1lZCBsb2NhbGx5IHRoYXQgdGhlIGxhdGVzdCB2ZXJzaW9uICg0LjAuMTIu NjY1KSBpcyBhYmxlCisgICAgICAgIHRvIGNvbm5lY3Qgd2l0aG91dCB0aGUgaGFjay4KKworICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTTG9jYXRpb25DdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SlNMb2NhdGlvbjo6cHV0RGVsZWdhdGUpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3Jt L1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oOgorICAgICAgICAqIHBsYXRmb3JtL1J1bnRpbWVB cHBsaWNhdGlvbkNoZWNrcy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1hY0FwcGxpY2F0aW9uOjpp c0hpcENoYXQpOiBEZWxldGVkLgorCiAyMDE2LTA2LTEzICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaGVzIGluIFdlYkNvcmU6OklEQlNlcnZlcjo6VW5p cXVlSURCRGF0YWJhc2U6OmV4ZWN1dGVOZXh0RGF0YWJhc2VUYXNrLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNMb2NhdGlvbkN1c3RvbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0xvY2F0aW9uQ3VzdG9tLmNwcAppbmRleCA4ZmZkYTEyNmUzMDcz YTM2NTYzMGE0NGMxNTk1NTEwZjgxYTk3OTU5Li5kMDU2NThkMzhhZjY4MWNlODhlZDg5M2ZmZGQ2 ZjE3ZmFhODdjMTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0xv Y2F0aW9uQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0xvY2F0 aW9uQ3VzdG9tLmNwcApAQCAtODYsMTIgKzg2LDYgQEAgYm9vbCBKU0xvY2F0aW9uOjpwdXREZWxl Z2F0ZShFeGVjU3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUK ICAgICBpZiAocHJvcGVydHlOYW1lICE9IGV4ZWMtPnByb3BlcnR5TmFtZXMoKS5ocmVmICYmICFz YW1lRG9tYWluQWNjZXNzKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotI2lmIFBMQVRGT1JNKE1B QykKLSAgICAvLyBGSVhNRTogSGlwQ2hhdCB0cmllcyB0byBzZXQgTG9jYXRpb24ucmVsb2FkIHdo aWNoIGNhdXNlcyBhbiBleGNlcHRpb24gdG8gYmUgdGhyb3duIGluIHN0cmljdCBtb2RlIChzZWUg PHJkYXI6Ly9wcm9ibGVtLzI0OTMxOTU5PikuCi0gICAgaWYgKE1hY0FwcGxpY2F0aW9uOjppc0hp cENoYXQoKSkKLSAgICAgICAgc2xvdC5zZXRTdHJpY3RNb2RlKGZhbHNlKTsKLSNlbmRpZgotCiAg ICAgcmV0dXJuIGZhbHNlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1 bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oCmluZGV4IDBlYzFiMmJkN2FkMTFiZmRkMmEyMjdkZDAz OTM4ZGE2NmRhZmQyNjUuLmZiNDVjNTg2OWE0YzI5ZWU2MzEwNWI3ZTcxOGZhNTE1OWUzMjAwNzIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrcy5oCkBAIC01MSw3ICs1MSw2IEBAIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNTYWZhcmkoKTsK IGJvb2wgaXNTb2xpZFN0YXRlTmV0d29ya3NEb3dubG9hZGVyKCk7CiBXRUJDT1JFX0VYUE9SVCBi b29sIGlzVmVyc2lvbnMoKTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNIUkJsb2NrKCk7Ci1XRUJD T1JFX0VYUE9SVCBib29sIGlzSGlwQ2hhdCgpOwogCiB9IC8vIE1hY0FwcGxpY2F0aW9uCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNr cy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5t bQppbmRleCBmODk5NDhlMjEwMzczODk3Mzk5YzNjMTFiNDVjODE0MmI2NDkwOWFhLi4xMmU5ZjIz YzljZmUzMDRiYjc5MzFjODA0ZGM0NWNiMTllNTgyZDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLm1tCkBAIC0xNTQsMTIgKzE1 NCw2IEBAIGJvb2wgTWFjQXBwbGljYXRpb246OmlzU29saWRTdGF0ZU5ldHdvcmtzRG93bmxvYWRl cigpCiAgICAgcmV0dXJuIGlzU29saWRTdGF0ZU5ldHdvcmtzRG93bmxvYWRlcjsKIH0KIAotYm9v bCBNYWNBcHBsaWNhdGlvbjo6aXNIaXBDaGF0KCkKLXsKLSAgICBzdGF0aWMgYm9vbCBpc0hpcENo YXQgPSBhcHBsaWNhdGlvbkJ1bmRsZUlzRXF1YWxUbygiY29tLmhpcGNoYXQuSGlwQ2hhdCIpOwot ICAgIHJldHVybiBpc0hpcENoYXQ7Ci19Ci0KICNlbmRpZiAvLyBQTEFURk9STShNQUMpCiAKICNp ZiBQTEFURk9STShJT1MpCg==