158699 2016-06-13 11:27:04 -0700 DFG Validation fails when performing a concatenation with only a single entry 2016-06-13 16:15:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 oliver saam commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1201885 0 oliver 2016-06-13 11:27:04 -0700 Fairly simple failure: function f() { for (;;)`${1}` } f(); The issue is that we appear to be issuing a str_concat with a single child, which the DFG thinks is invalid. The obvious solutions are to either: * don't emit str_concat from a single child template literal * Have the DFG acknowledge this can happen I think the former is the better option. 1201962 1 webkit-bug-importer 2016-06-13 14:26:18 -0700 <rdar://problem/26775638> 1201985 2 281211 oliver 2016-06-13 15:35:57 -0700 Created attachment 281211 Patch 1201986 3 281211 saam 2016-06-13 15:38:39 -0700 Comment on attachment 281211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281211&action=review r=me > Source/JavaScriptCore/tests/stress/template-literal.js:209 > +function testSingleNode() { Can you also add other tests for valueOf, etc 1201993 4 281211 oliver 2016-06-13 15:51:22 -0700 Comment on attachment 281211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281211&action=review >> Source/JavaScriptCore/tests/stress/template-literal.js:209 >> +function testSingleNode() { > > Can you also add other tests for valueOf, etc Unrealted to this bug you mean? This bug is specifically because template literals would alway plant a strcat, even if there was only a single node. 1202001 5 oliver 2016-06-13 16:15:41 -0700 Committed r202015: <http://trac.webkit.org/changeset/202015> 281211 2016-06-13 15:35:57 -0700 2016-06-13 15:38:39 -0700 Patch bug-158699-20160613153732.patch text/plain 2449 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyMDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDNlMzZjYzg0MTMyMTIzYTlhOGI1ZWYyMTVkZjRlYWI1NWU0OTJhLi41N2Y5N2UxN2M1OWNmMjNj YmFjYTU0OWY0ZGY0Y2VlNzFmNjZkMGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wNi0xMyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIERGRyBWYWxpZGF0aW9uIGZhaWxzIHdoZW4gcGVyZm9ybWluZyBhIGNvbmNhdGVu YXRpb24gd2l0aCBvbmx5IGEgc2luZ2xlIGVudHJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg2OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGYWlybHkgc2ltcGxlIHNob3J0IGNpcmN1aXRpbmcgb2Yg YSBzaW5nbGUgcmVwbGFjZW1lbnQgdGVtcGxhdGUgc3RyaW5nCisgICAgICAgIHdpdGhvdXQgYW55 IHBhZGRpbmcgdG8gYmUgcGxhbnRlZCBhcyBhIHNpbXBsZSB0byBzdHJpbmcgcmF0aGVyIHRoYW4K KyAgICAgICAgb3Bfc3RyY2F0LgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdl bi5jcHA6CisgICAgICAgIChKU0M6OlRlbXBsYXRlTGl0ZXJhbE5vZGU6OmVtaXRCeXRlY29kZSk6 CisgICAgICAgICogdGVzdHMvc3RyZXNzL3RlbXBsYXRlLWxpdGVyYWwuanM6CisgICAgICAgICh0 ZXN0U2luZ2xlTm9kZSk6CisKIDIwMTYtMDYtMTMgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRl YUBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZm9sbG93IHVwIHBhdGNoIGZvciBy MjAxOTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05v ZGVzQ29kZWdlbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVz Q29kZWdlbi5jcHAKaW5kZXggZGZiNDE2N2YxOGIzZTE0NzVhMjNlMjBlMWYxNGM1NWNhODA0MDNi ZC4uNmI5YTI2ZGYxZjE5NGZhMjViNDFlYTNjMjMxZjIwZDAxZTk0YzVhYiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcApAQCAt MjcyLDYgKzI3Miw5IEBAIFJlZ2lzdGVySUQqIFRlbXBsYXRlTGl0ZXJhbE5vZGU6OmVtaXRCeXRl Y29kZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpCiAgICAgICAgIGdlbmVyYXRv ci5lbWl0Tm9kZSh0ZW1wb3JhcnlSZWdpc3RlcnMubGFzdCgpLmdldCgpLCB0ZW1wbGF0ZVN0cmlu Zy0+dmFsdWUoKSk7CiAgICAgfQogCisgICAgaWYgKHRlbXBvcmFyeVJlZ2lzdGVycy5zaXplKCkg PT0gMSkKKyAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0VG9TdHJpbmcoZ2VuZXJhdG9yLmZp bmFsRGVzdGluYXRpb24oZHN0LCB0ZW1wb3JhcnlSZWdpc3RlcnNbMF0uZ2V0KCkpLCB0ZW1wb3Jh cnlSZWdpc3RlcnNbMF0uZ2V0KCkpOworCiAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0U3RyY2F0 KGdlbmVyYXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCwgdGVtcG9yYXJ5UmVnaXN0ZXJzWzBdLmdl dCgpKSwgdGVtcG9yYXJ5UmVnaXN0ZXJzWzBdLmdldCgpLCB0ZW1wb3JhcnlSZWdpc3RlcnMuc2l6 ZSgpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy90ZW1wbGF0ZS1saXRlcmFsLmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy90ZW1wbGF0ZS1saXRlcmFsLmpzCmluZGV4IDI4YjQ0NzJjYTZhMzZhZTgzNTA0NzcxNWIwNGU1 YjU2OTFiYzE0N2MuLjY4YTZlZGM3ZDE3NjNlNDg4MTlhNTk0YTQ1ZTE5YWFlYWQ1Y2E2MDkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvdGVtcGxhdGUtbGl0 ZXJhbC5qcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3RlbXBsYXRl LWxpdGVyYWwuanMKQEAgLTIwNSwzICsyMDUsMTEgQEAgdGVzdChgSGVsbG8gJHsgYENvJHtgY2B9 b2FgIH1gLCAiSGVsbG8gQ29jb2EiKTsKICAgICB0ZXN0KHN0YXRbMV0sIHVuZGVmaW5lZCk7CiAg ICAgdGVzdChzdGF0WzJdLCB1bmRlZmluZWQpOwogfSgpKTsKKworZnVuY3Rpb24gdGVzdFNpbmds ZU5vZGUoKSB7CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwOyBpKyspCisgICAgICAgIGAk ezF9YAorfQorbm9JbmxpbmUodGVzdFNpbmdsZU5vZGUpCit0ZXN0U2luZ2xlTm9kZSgpOworCg==