158681 2016-06-12 19:38:52 -0700 std::atexit used without including cstdlib 2016-06-16 16:03:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned commit-queue oldest_to_newest 1201758 0 lantw44 2016-06-12 19:38:52 -0700 This causes compilation error on FreeBSD: /home/lantw44/webkit/source/WebKit/Source/WebCore/platform/graphics/PlatformDisplay.cpp:169:5: error: no member named 'atexit' in namespace 'std'; did you mean simply 'atexit'? std::atexit([] { PlatformDisplay::sharedDisplay().terminateEGLDisplay(); }); ^~~~~~~~~~~ atexit /usr/include/stdlib.h:84:6: note: 'atexit' declared here int atexit(void (*)(void)); ^ 1 error generated. 1201761 1 281145 lantw44 2016-06-12 19:40:06 -0700 Created attachment 281145 Patch 1201762 2 commit-queue 2016-06-12 19:41:28 -0700 Attachment 281145 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1201764 3 281146 lantw44 2016-06-12 19:47:02 -0700 Created attachment 281146 Patch 1203039 4 281146 bfulgham 2016-06-16 15:41:04 -0700 Comment on attachment 281146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281146&action=review > Source/WebCore/platform/graphics/PlatformDisplay.cpp:29 > +#include <cstdlib> Was this causing a build error for you? 1203040 5 281146 bfulgham 2016-06-16 15:41:33 -0700 Comment on attachment 281146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281146&action=review r=me >> Source/WebCore/platform/graphics/PlatformDisplay.cpp:29 >> +#include <cstdlib> > > Was this causing a build error for you? Oh -- for BSD builds. Ok. 1203067 6 281146 commit-queue 2016-06-16 16:03:01 -0700 Comment on attachment 281146 Patch Clearing flags on attachment: 281146 Committed r202145: <http://trac.webkit.org/changeset/202145> 1203068 7 commit-queue 2016-06-16 16:03:04 -0700 All reviewed patches have been landed. Closing bug. 281145 2016-06-12 19:40:06 -0700 2016-06-12 19:46:57 -0700 Patch bug-158681-20160613024012.patch text/plain 1129 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxOTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRkMDcyZTVjODJmZTEw MjJhYzgxOGEyNjg4MTIzMjFiYWZjNDA1YS4uM2FjM2UzOTgxNmI5MWNkMDhiNGUxOWZkMDIyNmFk NTVlYzFlMzg3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA2LTEyICBUaW5n LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBJbmNsdWRlIGNzdGRsaWIg YmVmb3JlIHVzaW5nIHN0ZDo6YXRleGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTg2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHA6CisKIDIwMTYtMDYtMTIgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwIFJlbmRlckJsb2NrOjpy ZW1vdmVQb3NpdGlvbmVkT2JqZWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKaW5kZXggOGQ1YzdkMzNjZDA5N2JiNzVkNmQ1 Y2JlMDNjN2Y3M2U4YmMxY2ZkNC4uYmRhZTVmNDVmOTU5NDg5YWMwYjYxNWM0MGZjMTc3NzgyZWFl OWI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZv cm1EaXNwbGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0 Zm9ybURpc3BsYXkuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAiUGxhdGZvcm1EaXNwbGF5LmgiCiAKKyNpbmNsdWRlIDxjc3RkbGliPgogI2luY2x1 ZGUgPG11dGV4PgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgogCg== 281146 2016-06-12 19:47:02 -0700 2016-06-16 16:03:01 -0700 Patch bug-158681-20160613024708.patch text/plain 1096 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxOTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRkMDcyZTVjODJmZTEw MjJhYzgxOGEyNjg4MTIzMjFiYWZjNDA1YS4uODUzY2Y4MWI2Mjg3MmNiYTI3M2ZmODVhMzM5NDA4 ZDlkNTZiMTkzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA2LTEyICBUaW5n LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBJbmNsdWRlIGNzdGRsaWIg YmVmb3JlIHVzaW5nIHN0ZDo6YXRleGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTg2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHA6 CisKIDIwMTYtMDYtMTIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBDbGVhbnVwIFJlbmRlckJsb2NrOjpyZW1vdmVQb3NpdGlvbmVkT2JqZWN0cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKaW5k ZXggOGQ1YzdkMzNjZDA5N2JiNzVkNmQ1Y2JlMDNjN2Y3M2U4YmMxY2ZkNC4uYmRhZTVmNDVmOTU5 NDg5YWMwYjYxNWM0MGZjMTc3NzgyZWFlOWI5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCkBAIC0yNiw2ICsyNiw3IEBA CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1EaXNwbGF5LmgiCiAKKyNp bmNsdWRlIDxjc3RkbGliPgogI2luY2x1ZGUgPG11dGV4PgogI2luY2x1ZGUgPHd0Zi9OZXZlckRl c3Ryb3llZC5oPgogCg==