158654 2016-06-10 21:57:54 -0700 Web Inspector: <template> content should not be hidden as Shadow Content 2016-06-10 22:31:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev rniwa timothy webkit-bug-importer oldest_to_newest 1201497 0 joepeck 2016-06-10 21:57:54 -0700 Summary: <template> content should not be hidden as Shadow Content, it should show like a document fragment. Steps To Reproduce: 1. Inspect about:blank 2. js> t = document.createElement("template"); t.innerHTML = "hello world"; document.body.appendChild(t); t => Expanding <template> in console should not be say "Shadow Root" it should be a Document Fragment => Same in the DOM Tree Notes: - While this is a Document Fragment, lets customize the string in the UI to say "Template Content" instead of "Document Fragment". 1201498 1 webkit-bug-importer 2016-06-10 21:58:17 -0700 <rdar://problem/26753415> 1201499 2 281076 joepeck 2016-06-10 21:59:02 -0700 Created attachment 281076 [PATCH] Proposed Fix 1201510 3 281076 commit-queue 2016-06-10 22:31:12 -0700 Comment on attachment 281076 [PATCH] Proposed Fix Clearing flags on attachment: 281076 Committed r201965: <http://trac.webkit.org/changeset/201965> 1201511 4 commit-queue 2016-06-10 22:31:16 -0700 All reviewed patches have been landed. Closing bug. 281076 2016-06-10 21:59:02 -0700 2016-06-10 22:31:12 -0700 [PATCH] Proposed Fix template-1.patch text/plain 3648 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcwZjQ5MDIuLjJlYWRiYmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA2LTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogPHRlbXBs YXRlPiBjb250ZW50IHNob3VsZCBub3QgYmUgaGlkZGVuIGFzIFNoYWRvdyBDb250ZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg2NTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIExvY2FsaXphdGlv bnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgTmV3ICJUZW1wbGF0ZSBD b250ZW50IiBzdHJpbmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9ET01Ob2Rl LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5vZGUpOgorICAgICAgICBEb24ndCB0cmVh dCB0ZW1wbGF0ZSBjb250ZW50IGFzIHNoYWRvdyBjb250ZW50LgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5E T01UcmVlRWxlbWVudC5wcm90b3R5cGUuX25vZGVUaXRsZUluZm8pOgorICAgICAgICBDdXN0b20g c3RyaW5nIGZvciB0ZW1wbGF0ZSBjb250ZW50IGZyYWdtZW50LgorCiAyMDE2LTA2LTEwICBNYXR0 IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBy ZW5kZXJpbmcgZnJhbWVzIHRpbWVsaW5lICI2MGZwcyIgaG9yaXpvbnRhbCBndWlkZSBpcyBtaXNw b3NpdGlvbmVkIGFmdGVyIHN3aXRjaGluZyB0aW1lbGluZSBtb2RlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5n cy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMKaW5kZXggYTQzYzhhZWYxM2NkYWY0NWRmYmM0YTQ0MGIzNDdkMjk3Y2Ix NTg5MC4uZTAwOWY4YzY3MzgzYzViMmM0Yjc1NWU1YTJiNjNhYjk3Y2Y2NWRlMyAxMDA2NDQKR0lU IGJpbmFyeSBwYXRjaApkZWx0YSAxMzMKemNtWnA7IzUmfiE+eFN2dG4+bHJFckFAQSUhbSZBWUAo SiRFPD99RGBPdW9QNyNPQlpJPUNFeFItUykrNmBkbWd2Cnp4I2B0aGpDfFlzODUjUXx3KWFhaDle O3QpU0RCRy1gZkZ9UnVJWD04N2BlNnN4aGhoZXhlTnNpSVNoI21DRFhJUwpoODBHbXg3KlpNRkxK WDxYNEhPdXl4NjlmdyNfKEB7P2FMQEM0RkViQ0Y1M1ZBCgpkZWx0YSA1MzIKemNtYlBvZzA8bGk+ eFN2dG9UJmB5NDREamgzPHtHeU95cyRwNyFkcTQ2V2gmR3dlT0BjciQ4anhVNGhDI1lAbyNDCnpg SUM3elM1Nyo/JjhSd0FaLU1NJlcqKXVDPjxqb2RKST1lciEpP1cmekBRM0okKUdYJDlrPUFmPVh7 Z1R1SHIlJAp6cDNLZ3VHa05fZ3VGMmlFITE5eHxTOHRmaXlfIW9OcCpARDdsKTtGPmZXZVQjN157 KHIjU0JDIWhGSyZKUVNIWiYKejVBO1ZXKDc8M0luRkdZaDM/KUReVyU3WWw7KnZQa09pdEtrSTV+ Ul8qSlJsPllMakM+YSV+bn5sZnVSdTFrX2puCnpHJGZJczUqUlF3O2otYyR6fGMkcWlZaFJtJUZQ SjMta2lKWHBWI0UqaSMoR2p7fXF9cHVnaj5sSXI4cnJpT0ckKAp6QiZNR2dYNV5WSkZVSDY9UyNo PTVeamF9U3NwJHVXODZga00wXjM4eTdeaVZ5K0JOO0pKUj12SEZ3bU9tQHA2bkAKeih8UDM/YExf UipXMy1Va3pUQT5BZmA5Vi0wfXw3OWVIYn5XJi1HO0ZuMCk/IyNkTGN3QWc+PEMreTIqc1FDdTFU CkRjO2t9KAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9ET01Ob2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0RPTU5vZGUuanMKaW5kZXggYmU0ZDdhZC4uZWFlMmQxYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RPTU5vZGUuanMKQEAg LTgzLDcgKzgzLDcgQEAgV2ViSW5zcGVjdG9yLkRPTU5vZGUgPSBjbGFzcyBET01Ob2RlIGV4dGVu ZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICB9CiAKICAgICAgICAgaWYgKHBheWxvYWQu dGVtcGxhdGVDb250ZW50KSB7Ci0gICAgICAgICAgICB0aGlzLl90ZW1wbGF0ZUNvbnRlbnQgPSBu ZXcgV2ViSW5zcGVjdG9yLkRPTU5vZGUodGhpcy5fZG9tVHJlZU1hbmFnZXIsIHRoaXMub3duZXJE b2N1bWVudCwgdHJ1ZSwgcGF5bG9hZC50ZW1wbGF0ZUNvbnRlbnQpOworICAgICAgICAgICAgdGhp cy5fdGVtcGxhdGVDb250ZW50ID0gbmV3IFdlYkluc3BlY3Rvci5ET01Ob2RlKHRoaXMuX2RvbVRy ZWVNYW5hZ2VyLCB0aGlzLm93bmVyRG9jdW1lbnQsIGZhbHNlLCBwYXlsb2FkLnRlbXBsYXRlQ29u dGVudCk7CiAgICAgICAgICAgICB0aGlzLl90ZW1wbGF0ZUNvbnRlbnQucGFyZW50Tm9kZSA9IHRo aXM7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwppbmRleCA2Y2QzOTYzLi5hNjU2 YmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9ET01UcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwpAQCAtMTE5OCw3ICsxMTk4LDkgQEAgV2ViSW5z cGVjdG9yLkRPTVRyZWVFbGVtZW50ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJ bnNwZWN0b3IuVHJlZUVsZW0KICAgICAgICAgICAgICAgICBpZiAobm9kZS5pc0luU2hhZG93VHJl ZSgpKSB7CiAgICAgICAgICAgICAgICAgICAgIGZyYWdtZW50RWxlbWVudC50ZXh0Q29udGVudCA9 IFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2hhZG93IENvbnRlbnQiKTsKICAgICAgICAgICAgICAg ICAgICAgZnJhZ21lbnRFbGVtZW50LmNsYXNzTGlzdC5hZGQoInNoYWRvdyIpOwotICAgICAgICAg ICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAobm9kZS5wYXJlbnROb2Rl ICYmIG5vZGUucGFyZW50Tm9kZS50ZW1wbGF0ZUNvbnRlbnQoKSA9PT0gbm9kZSkKKyAgICAgICAg ICAgICAgICAgICAgZnJhZ21lbnRFbGVtZW50LnRleHRDb250ZW50ID0gV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJUZW1wbGF0ZSBDb250ZW50Iik7CisgICAgICAgICAgICAgICAgZWxzZQogICAgICAg ICAgICAgICAgICAgICBmcmFnbWVudEVsZW1lbnQudGV4dENvbnRlbnQgPSBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIkRvY3VtZW50IEZyYWdtZW50Iik7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAK