158631 2016-06-10 12:18:53 -0700 The backend should be happy to compile Unreachable even if AI didn't prove it to be unreachable 2016-06-10 13:56:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 157379 1 fpizlo fpizlo barraclough benjamin commit-queue ddkilzer ggaren keith_miller mark.lam mhahnenb msaboff oliver saam sam oldest_to_newest 1201328 0 fpizlo 2016-06-10 12:18:53 -0700 It's possible that due to concurrency, we invalidate the compilation after the last run of the CFA phase but before the backend. Then, when AI runs during the backend, it might think that some code that was previously thought to be Unreachable is now reachable. We shouldn't crash when this happens. 1201332 1 281032 fpizlo 2016-06-10 12:31:37 -0700 Created attachment 281032 the patch 1201341 2 281032 keith_miller 2016-06-10 12:52:03 -0700 Comment on attachment 281032 the patch r=me. 1201342 3 fpizlo 2016-06-10 12:56:04 -0700 Landed in http://trac.webkit.org/changeset/201936 1201365 4 ddkilzer 2016-06-10 13:56:23 -0700 <rdar://problem/26540392> 281032 2016-06-10 12:31:37 -0700 2016-06-10 12:52:03 -0700 the patch blah.patch text/plain 7102 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxOTMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBA CisyMDE2LTA2LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg VGhlIGJhY2tlbmQgc2hvdWxkIGJlIGhhcHB5IHRvIGNvbXBpbGUgVW5yZWFjaGFibGUgZXZlbiBp ZiBBSSBkaWRuJ3QgcHJvdmUgaXQgdG8gYmUgdW5yZWFjaGFibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODYzMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV2UndmUgYmVlbiBzbG93bHkg bWFraW5nIHRoZSBERkcgVW5yZWFjaGFibGUgb3Bjb2RlIGJlaGF2ZSBsaWtlIGEgZ3Jvd24tdXAu IFdoZW4gd2UgZmlyc3QKKyAgICAgICAgYWRkZWQgaXQsIGl0IHdhcyBhIGhhY2sgZm9yIFRocm93 LCBhbmQgd2UgY291bGQgYWx3YXlzIHJlbHkgb24gQUkgcHJvdmluZyB0aGF0IFVucmVhY2hhYmxl CisgICAgICAgIHdhcyBub3QgcmVhY2hhYmxlLiBCdXQgdGhlbiB3ZSBzdGFydGVkIHVzaW5nIFVu cmVhY2hhYmxlIGFzIGEgcHJvcGVyIFVucmVhY2hhYmxlIG9wY29kZSwKKyAgICAgICAgbGlrZSBP b3BzIGluIEIzIGZvciBleGFtcGxlLCB3aGljaCBoYXMgYSBtb3JlIG51YW5jZWQgbWVhbmluZzog eW91IHVzZSBpdCB3aGVuZXZlciB5b3UKKyAgICAgICAgZW1pdCBjb2RlIHRoYXQgKnlvdSoga25v dyB3aWxsIG5vdCByZXR1cm4sIGFuZCB5b3UgbmVlZCBzb21lIHdheSBvZiB0ZXJtaW5hdGluZyB0 aGUgYmFzaWMKKyAgICAgICAgYmxvY2suIFRoZSBERkcgaXMgbm90IGEgcHJvb2YtY2Fycnlpbmcg Y29tcGlsZXIsIGFuZCBpdCBuZXZlciB3aWxsIGJlLiBTbywgd2hlbiB5b3UgaGF2ZQorICAgICAg ICBwcm92ZWQgdGhhdCBzb21ldGhpbmcgaXMgbm90IHJlYWNoYWJsZSwgeW91IHNob3VsZCBiZSBh YmxlIHRvIHVzZSBVbnJlYWNoYWJsZSBldmVuIGlmCisgICAgICAgIHRoZXJlIGlzIG5vIGd1YXJh bnRlZSB0aGF0IHRoZSBjb21waWxlciB3aWxsIGxhdGVyIGJlIGFibGUgdG8gcmVwbGljYXRlIHlv dXIgcHJvb2YuIFRoaXMKKyAgICAgICAgbWVhbnMgdGhhdCB0aGUgYmFja2VuZCBtYXkgZmluZCBp dHNlbGYgY29tcGlsaW5nIFVucmVhY2hhYmxlIGJlY2F1c2UgQUkgZGlkIG5vdCBwcm92ZSB0aGF0 CisgICAgICAgIGl0IHdhcyB1bnJlYWNoYWJsZS4KKyAgICAgICAgCisgICAgICAgIFByaW9yIHRv IHRoaXMgY2hhbmdlLCB3ZSB3b3VsZCBjcmFzaCBjb21waWxpbmcgVW5yZWFjaGFibGUgYmVjYXVz ZSB3ZSB3b3VsZCByZWx5IG9uIEFJCisgICAgICAgIHByZXZlbnRpbmcgdXMgZnJvbSByZWFjaGlu ZyBVbnJlYWNoYWJsZSBpbiB0aGUgYmFja2VuZC4gQnV0IHRoYXQncyBzaWxseSEgV2UgZG9uJ3Qg d2FudAorICAgICAgICB1c2VycyBvZiBVbnJlYWNoYWJsZSB0byBoYXZlIHRvIGFsc28gY29udmlu Y2UgQUkgdGhhdCB0aGVpciBVbnJlYWNoYWJsZSBpcyByZWFsbHkKKyAgICAgICAgVW5yZWFjaGFi bGUuCisgICAgICAgIAorICAgICAgICBUaGlzIGZpeGVzIGNyYXNoZXMgb24gcmVhbCB3ZWJzaXRl cy4gSSBjb3VsZG4ndCB3b3JrIG91dCBob3cgdG8gdHVybiB0aGVtIGludG8gYSByZWR1Y2VkCisg ICAgICAgIHRlc3QuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQWJvcnRSZWFzb24uaDoKKyAgICAg ICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjplbWl0SW52YWxpZGF0aW9uUG9pbnQpOgorICAgICAgICAoSlNDOjpERkc6OlNw ZWN1bGF0aXZlSklUOjp1bnJlYWNoYWJsZSk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRp dmVKSVQ6OnRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKToKKyAgICAgICAgKiBkZmcvREZH U3BlY3VsYXRpdmVKSVQuaDoKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAg ICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6 CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVOb2RlKToKKyAg ICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6Y29tcGlsZVB1dER5bmFtaWNWYXIp OgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21waWxlVW5yZWFjaGFi bGUpOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0IzOjpjb21wYXJlRXFPYmpl Y3RPck90aGVyVG9PYmplY3QpOgorCiAyMDE2LTA2LTA5ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2xlYW4gdXAgSmF2YVNjcmlwdENvcmUu dmN4cHJvaiBkaXJlY3RvcnkgYWZ0ZXIgc3dpdGNoaW5nIHRvIENNYWtlLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYm9ydFJlYXNvbi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQWJvcnRSZWFzb24uaAkocmV2aXNpb24gMjAx OTMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYm9ydFJlYXNvbi5oCSh3 b3JraW5nIGNvcHkpCkBAIC01Nyw2ICs1Nyw3IEBAIGVudW0gQWJvcnRSZWFzb24gewogICAgIERG R05lZ2F0aXZlU3RyaW5nTGVuZ3RoICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAyMDAsCiAg ICAgREZHU2xvd1BhdGhHZW5lcmF0b3JGZWxsVGhyb3VnaCAgICAgICAgICAgICAgICAgICA9IDIx MCwKICAgICBERkdVbnJlYWNoYWJsZUJhc2ljQmxvY2sgICAgICAgICAgICAgICAgICAgICAgICAg ID0gMjIwLAorICAgIERGR1VucmVhY2hhYmxlTm9kZSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgPSAyMjUsCiAgICAgREZHVW5yZWFzb25hYmxlT1NSRW50cnlKdW1wRGVzdGluYXRpb24g ICAgICAgICAgICA9IDIzMCwKICAgICBERkdWYXJhcmdzVGhyb3dpbmdQYXRoRGlkTm90VGhyb3cg ICAgICAgICAgICAgICAgID0gMjM1LAogICAgIEpJVERpZFJldHVybkZyb21UYWlsQ2FsbCAgICAg ICAgICAgICAgICAgICAgICAgICAgPSAyMzcsCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDIwMTkz MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUyNzMsNyArNTI3Myw3IEBAIHZvaWQgU3BlY3VsYXRpdmVK SVQ6OmNvbXBpbGUoTm9kZSogbm9kZSkKICAgICB9CiAKICAgICBjYXNlIFVucmVhY2hhYmxlOgot ICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICB1bnJlYWNoYWJs ZShub2RlKTsKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIExhc3ROb2RlVHlwZToKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNw cAkocmV2aXNpb24gMjAxOTMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgwMSw3ICs0ODAxLDcgQEAgdm9p ZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICBicmVhazsKIAog ICAgIGNhc2UgVW5yZWFjaGFibGU6Ci0gICAgICAgIERGR19DUkFTSChtX2ppdC5ncmFwaCgpLCBu b2RlLCAiVW5leHBlY3RlZCBVbnJlYWNoYWJsZSBub2RlIik7CisgICAgICAgIHVucmVhY2hhYmxl KG5vZGUpOwogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgU3RvcmVCYXJyaWVyOiB7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAko cmV2aXNpb24gMjAxOTMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNyw2ICszMDcsMTIgQEAgdm9pZCBTcGVj dWxhdGl2ZUpJVDo6ZW1pdEludmFsaWRhdGlvblBvaQogICAgIG5vUmVzdWx0KG5vZGUpOwogfQog Cit2b2lkIFNwZWN1bGF0aXZlSklUOjp1bnJlYWNoYWJsZShOb2RlKiBub2RlKQoreworICAgIG1f Y29tcGlsZU9rYXkgPSBmYWxzZTsKKyAgICBtX2ppdC5hYm9ydFdpdGhSZWFzb24oREZHVW5yZWFj aGFibGVOb2RlLCBub2RlLT5vcCgpKTsKK30KKwogdm9pZCBTcGVjdWxhdGl2ZUpJVDo6dGVybWlu YXRlU3BlY3VsYXRpdmVFeGVjdXRpb24oRXhpdEtpbmQga2luZCwgSlNWYWx1ZVJlZ3MganNWYWx1 ZVJlZ3MsIE5vZGUqIG5vZGUpCiB7CiAgICAgaWYgKCFtX2NvbXBpbGVPa2F5KQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAkocmV2aXNpb24g MjAxOTMwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNjYxLDYgKzI2NjEsOCBAQCBwdWJsaWM6CiAgICAgCiAgICAg dm9pZCBlbWl0SW52YWxpZGF0aW9uUG9pbnQoTm9kZSopOwogICAgIAorICAgIHZvaWQgdW5yZWFj aGFibGUoTm9kZSopOworICAgIAogICAgIC8vIENhbGxlZCB3aGVuIHdlIHN0YXRpY2FsbHkgZGV0 ZXJtaW5lIHRoYXQgYSBzcGVjdWxhdGlvbiB3aWxsIGZhaWwuCiAgICAgdm9pZCB0ZXJtaW5hdGVT cGVjdWxhdGl2ZUV4ZWN1dGlvbihFeGl0S2luZCwgSlNWYWx1ZVJlZ3MsIE5vZGUqKTsKICAgICB2 b2lkIHRlcm1pbmF0ZVNwZWN1bGF0aXZlRXhlY3V0aW9uKEV4aXRLaW5kLCBKU1ZhbHVlUmVncywg RWRnZSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1Rv QjMuY3BwCShyZXZpc2lvbiAyMDE5MzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9CMy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMDAsNiArMTAwMCw5IEBAIHBy aXZhdGU6CiAgICAgICAgIGNhc2UgUHV0RHluYW1pY1ZhcjoKICAgICAgICAgICAgIGNvbXBpbGVQ dXREeW5hbWljVmFyKCk7CiAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBVbnJlYWNo YWJsZToKKyAgICAgICAgICAgIGNvbXBpbGVVbnJlYWNoYWJsZSgpOworICAgICAgICAgICAgYnJl YWs7CiAKICAgICAgICAgY2FzZSBQaGFudG9tTG9jYWw6CiAgICAgICAgIGNhc2UgTG9vcEhpbnQ6 CkBAIC03Njg0LDYgKzc2ODcsMTggQEAgcHJpdmF0ZToKICAgICAgICAgICAgIG1fY2FsbEZyYW1l LCBsb3dDZWxsKG1fbm9kZS0+Y2hpbGQxKCkpLCBsb3dKU1ZhbHVlKG1fbm9kZS0+Y2hpbGQyKCkp LCBtX291dC5jb25zdEludFB0cih1aWQpLCBtX291dC5jb25zdEludDMyKG1fbm9kZS0+Z2V0UHV0 SW5mbygpKSkpOwogICAgIH0KICAgICAKKyAgICB2b2lkIGNvbXBpbGVVbnJlYWNoYWJsZSgpCisg ICAgeworICAgICAgICAvLyBJdCdzIHNvIHRlbXB0aW5nIHRvIGFzc2VydCB0aGF0IEFJIGhhcyBw cm92ZWQgdGhhdCB0aGlzIGlzIHVucmVhY2hhYmxlLiBCdXQgdGhhdCdzCisgICAgICAgIC8vIHNp bXBseSBub3QgYSByZXF1aXJlbWVudCBvZiB0aGUgVW5yZWFjaGFibGUgb3Bjb2RlIGF0IGFsbC4g SWYgeW91IGVtaXQgYW4gb3Bjb2RlIHRoYXQKKyAgICAgICAgLy8gKnlvdSoga25vdyB3aWxsIG5v dCByZXR1cm4sIHRoZW4gaXQncyBmaW5lIHRvIGVuZCB0aGUgYmFzaWMgYmxvY2sgd2l0aCBVbnJl YWNoYWJsZQorICAgICAgICAvLyBhZnRlciB0aGF0IG9wY29kZS4gWW91IGRvbid0IGhhdmUgdG8g YWxzbyBwcm92ZSB0byBBSSB0aGF0IHlvdXIgb3Bjb2RlIGRvZXMgbm90IHJldHVybi4KKyAgICAg ICAgLy8gSGVuY2UsIHRoZXJlIGlzIG5vdGhpbmcgdG8gZG8gaGVyZSBidXQgZW1pdCBjb2RlIHRo YXQgd2lsbCBjcmFzaCwgc28gdGhhdCB3ZSBjYXRjaAorICAgICAgICAvLyBjYXNlcyB3aGVyZSB5 b3Ugc2FpZCBVbnJlYWNoYWJsZSBidXQgeW91IGxpZWQuCisgICAgICAgIAorICAgICAgICBjcmFz aCgpOworICAgIH0KKyAgICAKICAgICB2b2lkIGNvbXBhcmVFcU9iamVjdE9yT3RoZXJUb09iamVj dChFZGdlIGxlZnRDaGlsZCwgRWRnZSByaWdodENoaWxkKQogICAgIHsKICAgICAgICAgTFZhbHVl IHJpZ2h0Q2VsbCA9IGxvd0NlbGwocmlnaHRDaGlsZCk7Cg==