158613 2016-06-09 22:59:18 -0700 REGRESSION(r201880): WebSockets based remote inspector is broken since r201880 2016-06-22 23:11:09 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply darin oldest_to_newest 1201177 0 cgarcia 2016-06-09 22:59:18 -0700 It times out running the first test case, so my guess is that remote inspector is not working, probably due to web sockets being broken after r201880. I haven't looked at it in detail, though. TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer: TIMEOUT 1204503 1 cgarcia 2016-06-22 07:48:29 -0700 Not really GTK+ specific. 1204504 2 281838 cgarcia 2016-06-22 07:53:09 -0700 Created attachment 281838 Patch 1204516 3 281838 mcatanzaro 2016-06-22 09:25:10 -0700 Comment on attachment 281838 Patch Looks straightforward. It needs an owner to rubber stamp before you commit. Darin? 1204775 4 cgarcia 2016-06-22 23:07:38 -0700 (In reply to comment #3) > Comment on attachment 281838 [details] > Patch > > Looks straightforward. It needs an owner to rubber stamp before you commit. > Darin? This is not exactly cross-platform code, it's only used by GTK+ and EFL, that's why it has been broken for so long and nobody noticed it. 1204776 5 cgarcia 2016-06-22 23:11:09 -0700 Committed r202367: <http://trac.webkit.org/changeset/202367> 281838 2016-06-22 07:53:09 -0700 2016-06-22 09:25:10 -0700 Patch wk2-remote-inspector.diff text/plain 6849 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZjEyOWQ4Li4xZThkNjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTYtMDYtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwMTg4MCk6IFdlYlNvY2tldHMgYmFzZWQgcmVtb3Rl IGluc3BlY3RvciBpcyBicm9rZW4gc2luY2UgcjIwMTg4MAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjIwMTg4MCBTb2NrZXRTdHJlYW1IYW5kbGVD bGllbnQgd2FzIG1vZGlmaWVkIHRvIHJlY2VpdmUgcmVmZXJlbmNlcyBpbnN0ZWFkIG9mCisgICAg ICAgIHBvaW50ZXJzLiBXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uIGFsc28gaW1wbGVtZW50cyBT b2NrZXRTdHJlYW1IYW5kbGVDbGllbnQgYnV0IHNpbmNlIGl0J3MgZG9lc24ndCB1c2UKKyAgICAg ICAgb3ZlcnJpZGUsIGl0IHdhcyB1bm5vdGljZWQgYW5kIG5vdCB1cGRhdGVkLCBzbyB3ZSBlbmRl ZCB1cCB1c2luZyB0aGUgZGVmYXVsdCBlbXB0eSBpbXBsZW1lbnRhdGlvbiBpbnN0ZWFkIG9mCisg ICAgICAgIHRoZSBXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uIG9uZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlNvY2tldFNlcnZlckNvbm5lY3Rpb246OldlYlNvY2tldFNlcnZl ckNvbm5lY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9u OjpzZXRTb2NrZXRIYW5kbGUpOgorICAgICAgICAoV2ViS2l0OjpXZWJTb2NrZXRTZXJ2ZXJDb25u ZWN0aW9uOjpzaHV0ZG93bk5vdyk6CisgICAgICAgIChXZWJLaXQ6OldlYlNvY2tldFNlcnZlckNv bm5lY3Rpb246OmRpZENsb3NlU29ja2V0U3RyZWFtKToKKyAgICAgICAgKFdlYktpdDo6V2ViU29j a2V0U2VydmVyQ29ubmVjdGlvbjo6ZGlkUmVjZWl2ZVNvY2tldFN0cmVhbURhdGEpOgorICAgICAg ICAoV2ViS2l0OjpXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uOjpkaWRVcGRhdGVCdWZmZXJlZEFt b3VudCk6CisgICAgICAgIChXZWJLaXQ6OldlYlNvY2tldFNlcnZlckNvbm5lY3Rpb246OmRpZEZh aWxTb2NrZXRTdHJlYW0pOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3JT ZXJ2ZXIvV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5oOgorCiAyMDE2LTA2LTIxICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjIwMjI5Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0 b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL1dlYlNvY2tldFNlcnZlckNvbm5lY3Rpb24uY3BwCmlu ZGV4IDk0YTI0YzkuLjJhNmQ0YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9XZWJTb2NrZXRTZXJ2ZXJDb25u ZWN0aW9uLmNwcApAQCAtNDcsMTEgKzQ3LDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiBu YW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbjo6V2ViU29ja2V0 U2VydmVyQ29ubmVjdGlvbihXZWJTb2NrZXRTZXJ2ZXJDbGllbnQqIGNsaWVudCwgV2ViU29ja2V0 U2VydmVyKiBzZXJ2ZXIpCi0gICAgOiBtX2lkZW50aWZpZXIoMCkKLSAgICAsIG1fbW9kZShIVFRQ KQotICAgICwgbV9zZXJ2ZXIoc2VydmVyKQorICAgIDogbV9zZXJ2ZXIoc2VydmVyKQogICAgICwg bV9jbGllbnQoY2xpZW50KQotICAgICwgbV9zaHV0ZG93bkFmdGVyU2VuZChmYWxzZSkKIHsKIH0K IApAQCAtNjAsMTcgKzU3LDE3IEBAIFdlYlNvY2tldFNlcnZlckNvbm5lY3Rpb246On5XZWJTb2Nr ZXRTZXJ2ZXJDb25uZWN0aW9uKCkKICAgICBzaHV0ZG93bk5vdygpOwogfQogCi12b2lkIFdlYlNv Y2tldFNlcnZlckNvbm5lY3Rpb246OnNldFNvY2tldEhhbmRsZShQYXNzUmVmUHRyPFdlYkNvcmU6 OlNvY2tldFN0cmVhbUhhbmRsZT4gc29ja2V0KQordm9pZCBXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0 aW9uOjpzZXRTb2NrZXRIYW5kbGUoUmVmPFNvY2tldFN0cmVhbUhhbmRsZT4mJiBzb2NrZXQpCiB7 CiAgICAgQVNTRVJUKCFtX3NvY2tldCk7Ci0gICAgbV9zb2NrZXQgPSBzb2NrZXQ7CisgICAgbV9z b2NrZXQgPSBXVEZNb3ZlKHNvY2tldCk7CiB9CiAKIHZvaWQgV2ViU29ja2V0U2VydmVyQ29ubmVj dGlvbjo6c2h1dGRvd25Ob3coKQogewogICAgIGlmICghbV9zb2NrZXQpCiAgICAgICAgIHJldHVy bjsKLSAgICBSZWZQdHI8U29ja2V0U3RyZWFtSGFuZGxlPiBzb2NrZXQgPSBtX3NvY2tldC5yZWxl YXNlKCk7CisgICAgYXV0byBzb2NrZXQgPSBXVEZNb3ZlKG1fc29ja2V0KTsKICAgICBzb2NrZXQt PmNsb3NlKCk7CiAgICAgbV9zaHV0ZG93bkFmdGVyU2VuZCA9IGZhbHNlOwogfQpAQCAtMTIzLDcg KzEyMCw3IEBAIHZvaWQgV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbjo6c2VuZFJhd0RhdGEoY29u c3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCkKICAgICBtX3NvY2tldC0+c2VuZChkYXRhLCBs ZW5ndGgpOwogfQogCi12b2lkIFdlYlNvY2tldFNlcnZlckNvbm5lY3Rpb246OmRpZENsb3NlU29j a2V0U3RyZWFtKFNvY2tldFN0cmVhbUhhbmRsZSopCit2b2lkIFdlYlNvY2tldFNlcnZlckNvbm5l Y3Rpb246OmRpZENsb3NlU29ja2V0U3RyZWFtKFNvY2tldFN0cmVhbUhhbmRsZSYpCiB7CiAgICAg Ly8gRGVzdHJveSB0aGUgU29ja2V0U3RyZWFtSGFuZGxlIG5vdyB0byBwcmV2ZW50IGNsb3Npbmcg YW4gYWxyZWFkeSBjbG9zZWQgc29ja2V0IGxhdGVyLgogICAgIG1fc29ja2V0ID0gbnVsbHB0cjsK QEAgLTEzNiw3ICsxMzMsNyBAQCB2b2lkIFdlYlNvY2tldFNlcnZlckNvbm5lY3Rpb246OmRpZENs b3NlU29ja2V0U3RyZWFtKFNvY2tldFN0cmVhbUhhbmRsZSopCiAgICAgbV9zZXJ2ZXItPmRpZENs b3NlV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbih0aGlzKTsKIH0KIAotdm9pZCBXZWJTb2NrZXRT ZXJ2ZXJDb25uZWN0aW9uOjpkaWRSZWNlaXZlU29ja2V0U3RyZWFtRGF0YShTb2NrZXRTdHJlYW1I YW5kbGUqLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQordm9pZCBXZWJTb2NrZXRTZXJ2 ZXJDb25uZWN0aW9uOjpkaWRSZWNlaXZlU29ja2V0U3RyZWFtRGF0YShTb2NrZXRTdHJlYW1IYW5k bGUmLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQogewogICAgIC8vIEVhY2ggZGlkUmVj ZWl2ZURhdGEgY2FsbCBhZGRzIG1vcmUgZGF0YSB0byBvdXIgYnVmZmVyLgogICAgIC8vIFdlIGNs ZWFyIHRoZSBidWZmZXIgd2hlbiB3ZSBoYXZlIGhhbmRsZWQgZGF0YSBmcm9tIGl0LgpAQCAtMTU1 LDE3ICsxNTIsMTIgQEAgdm9pZCBXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uOjpkaWRSZWNlaXZl U29ja2V0U3RyZWFtRGF0YShTb2NrZXRTdHJlYW1IYW5kbGUqLAogICAgIH0KIH0KIAotdm9pZCBX ZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uOjpkaWRVcGRhdGVCdWZmZXJlZEFtb3VudChXZWJDb3Jl OjpTb2NrZXRTdHJlYW1IYW5kbGUqLCBzaXplX3QpCit2b2lkIFdlYlNvY2tldFNlcnZlckNvbm5l Y3Rpb246OmRpZFVwZGF0ZUJ1ZmZlcmVkQW1vdW50KFNvY2tldFN0cmVhbUhhbmRsZSYsIHNpemVf dCkKIHsKICAgICBpZiAobV9zaHV0ZG93bkFmdGVyU2VuZCAmJiAhbV9zb2NrZXQtPmJ1ZmZlcmVk QW1vdW50KCkpCiAgICAgICAgIHNodXRkb3duTm93KCk7CiB9CiAKLXZvaWQgV2ViU29ja2V0U2Vy dmVyQ29ubmVjdGlvbjo6ZGlkRmFpbFNvY2tldFN0cmVhbShTb2NrZXRTdHJlYW1IYW5kbGUqLCBj b25zdCBTb2NrZXRTdHJlYW1FcnJvciYpCi17Ci0gICAgLy8gUG9zc2libGUgcmVhZCBvciB3cml0 ZSBlcnJvci4KLX0KLQogdm9pZCBXZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uOjpyZWFkSFRUUE1l c3NhZ2UoKQogewogICAgIFN0cmluZyBmYWlsdXJlUmVhc29uOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9XZWJTb2NrZXRTZXJ2ZXJDb25uZWN0 aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL1dlYlNvY2tl dFNlcnZlckNvbm5lY3Rpb24uaAppbmRleCAxM2M1NTE2Li4yYmJlNTQ4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL1dlYlNvY2tldFNlcnZlckNv bm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVy L1dlYlNvY2tldFNlcnZlckNvbm5lY3Rpb24uaApAQCAtNDYsNyArNDYsNyBAQCBjbGFzcyBIVFRQ UmVxdWVzdDsKIGNsYXNzIFdlYlNvY2tldFNlcnZlcjsKIGNsYXNzIFdlYlNvY2tldFNlcnZlckNs aWVudDsKIAotY2xhc3MgV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbiA6IHB1YmxpYyBXZWJDb3Jl OjpTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQgeworY2xhc3MgV2ViU29ja2V0U2VydmVyQ29ubmVj dGlvbiBmaW5hbCA6IHB1YmxpYyBXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQgewog cHVibGljOgogICAgIGVudW0gV2ViU29ja2V0U2VydmVyTW9kZSB7IEhUVFAsIFdlYlNvY2tldCB9 OwogICAgIFdlYlNvY2tldFNlcnZlckNvbm5lY3Rpb24oV2ViU29ja2V0U2VydmVyQ2xpZW50Kiwg V2ViU29ja2V0U2VydmVyKik7CkBAIC01NCw3ICs1NCw3IEBAIHB1YmxpYzoKIAogICAgIHVuc2ln bmVkIGlkZW50aWZpZXIoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXI7IH0KICAgICB2b2lk IHNldElkZW50aWZpZXIodW5zaWduZWQgaWQpIHsgbV9pZGVudGlmaWVyID0gaWQ7IH0KLSAgICB2 b2lkIHNldFNvY2tldEhhbmRsZShQYXNzUmVmUHRyPFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRs ZT4pOworICAgIHZvaWQgc2V0U29ja2V0SGFuZGxlKFJlZjxXZWJDb3JlOjpTb2NrZXRTdHJlYW1I YW5kbGU+JiYpOwogCiAgICAgLy8gU2VuZGluZyBkYXRhIG92ZXIgdGhlIGNvbm5lY3Rpb24uCiAg ICAgdm9pZCBzZW5kV2ViU29ja2V0TWVzc2FnZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UpOwpAQCAt NjUsMTMgKzY1LDEyIEBAIHB1YmxpYzoKICAgICB2b2lkIHNodXRkb3duTm93KCk7CiAgICAgdm9p ZCBzaHV0ZG93bkFmdGVyU2VuZE9yTm93KCk7CiAKK3ByaXZhdGU6CiAgICAgLy8gU29ja2V0U3Ry ZWFtSGFuZGxlQ2xpZW50IGltcGxlbWVudGF0aW9uLgotICAgIHZpcnR1YWwgdm9pZCBkaWRDbG9z ZVNvY2tldFN0cmVhbShXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGUqKTsKLSAgICB2aXJ0dWFs IHZvaWQgZGlkUmVjZWl2ZVNvY2tldFN0cmVhbURhdGEoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFu ZGxlKiwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCk7Ci0gICAgdmlydHVhbCB2b2lkIGRp ZFVwZGF0ZUJ1ZmZlcmVkQW1vdW50KFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZSosIHNpemVf dCBidWZmZXJlZEFtb3VudCk7Ci0gICAgdmlydHVhbCB2b2lkIGRpZEZhaWxTb2NrZXRTdHJlYW0o V2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlKiwgY29uc3QgV2ViQ29yZTo6U29ja2V0U3RyZWFt RXJyb3ImKTsKKyAgICB2b2lkIGRpZENsb3NlU29ja2V0U3RyZWFtKFdlYkNvcmU6OlNvY2tldFN0 cmVhbUhhbmRsZSYpIG92ZXJyaWRlOworICAgIHZvaWQgZGlkUmVjZWl2ZVNvY2tldFN0cmVhbURh dGEoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlJiwgY29uc3QgY2hhciogZGF0YSwgaW50IGxl bmd0aCkgb3ZlcnJpZGU7CisgICAgdm9pZCBkaWRVcGRhdGVCdWZmZXJlZEFtb3VudChXZWJDb3Jl OjpTb2NrZXRTdHJlYW1IYW5kbGUmLCBzaXplX3QgYnVmZmVyZWRBbW91bnQpIG92ZXJyaWRlOwog Ci1wcml2YXRlOgogICAgIC8vIEhUVFAgTW9kZS4KICAgICB2b2lkIHJlYWRIVFRQTWVzc2FnZSgp OwogCkBAIC04MCwxNCArNzksMTMgQEAgcHJpdmF0ZToKICAgICB2b2lkIHJlYWRXZWJTb2NrZXRG cmFtZXMoKTsKICAgICBib29sIHJlYWRXZWJTb2NrZXRGcmFtZSgpOwogCi1wcm90ZWN0ZWQ6Ci0g ICAgdW5zaWduZWQgbV9pZGVudGlmaWVyOworICAgIHVuc2lnbmVkIG1faWRlbnRpZmllciB7IDAg fTsKICAgICBWZWN0b3I8Y2hhcj4gbV9idWZmZXJlZERhdGE7Ci0gICAgV2ViU29ja2V0U2VydmVy TW9kZSBtX21vZGU7CisgICAgV2ViU29ja2V0U2VydmVyTW9kZSBtX21vZGUgeyBIVFRQIH07CiAg ICAgUmVmUHRyPFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZT4gbV9zb2NrZXQ7Ci0gICAgV2Vi U29ja2V0U2VydmVyKiBtX3NlcnZlcjsKLSAgICBXZWJTb2NrZXRTZXJ2ZXJDbGllbnQqIG1fY2xp ZW50OwotICAgIGJvb2wgbV9zaHV0ZG93bkFmdGVyU2VuZDsKKyAgICBXZWJTb2NrZXRTZXJ2ZXIq IG1fc2VydmVyIHsgbnVsbHB0ciB9OworICAgIFdlYlNvY2tldFNlcnZlckNsaWVudCogbV9jbGll bnQgeyBudWxscHRyIH07CisgICAgYm9vbCBtX3NodXRkb3duQWZ0ZXJTZW5kIHsgZmFsc2UgfTsK IH07CiAKIH0K