158606 2016-06-09 20:55:40 -0700 ErrorEvent / ProgressEvent should be exposed to workers 2016-06-10 09:18:18 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez beidson cdumez commit-queue darin esprehn+autocc kangil.han kondapallykalyan sam oldest_to_newest 1201139 0 cdumez 2016-06-09 20:55:40 -0700 ErrorEvent should be exposed to workers: https://html.spec.whatwg.org/multipage/webappapis.html#errorevent Test: http://w3c-test.org/workers/semantics/interface-objects/001.worker 1201154 1 280992 cdumez 2016-06-09 22:14:26 -0700 Created attachment 280992 Patch 1201193 2 280992 achristensen 2016-06-10 00:15:55 -0700 Comment on attachment 280992 Patch Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, and can't that only be used from the main thread? 1201235 3 cdumez 2016-06-10 07:23:54 -0700 (In reply to comment #2) > Comment on attachment 280992 [details] > Patch > > Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, > and can't that only be used from the main thread? Using AtomicString in other threads is fine. What you cannot do is pass them to other threads. AtomicStrings are per thread AFAIK. 1201246 4 beidson 2016-06-10 09:04:31 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 280992 [details] > > Patch > > > > Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, > > and can't that only be used from the main thread? > > Using AtomicString in other threads is fine. What you cannot do is pass them > to other threads. AtomicStrings are per thread AFAIK. This is correct - Each thread has its own AtomicString table, and its safe to use them within a given thread. 1201247 5 280992 cdumez 2016-06-10 09:18:14 -0700 Comment on attachment 280992 Patch Clearing flags on attachment: 280992 Committed r201926: <http://trac.webkit.org/changeset/201926> 1201248 6 cdumez 2016-06-10 09:18:18 -0700 All reviewed patches have been landed. Closing bug. 280992 2016-06-09 22:14:26 -0700 2016-06-10 09:18:14 -0700 Patch bug-158606-20160609221555.patch text/plain 5485 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxOTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQ2ODVkNDgwNmViMGI5 NWI2NTlhMDAxNzNiYjg2OTVkNmQ1ODA5YS4uOWQ2NjNlY2JiNTIyZThlMzhjOWNlZmE1NTgyOWFi MDA2YjVhZDJmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTA2LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRXJyb3JFdmVudCAvIFByb2dy ZXNzRXZlbnQgc2hvdWxkIGJlIGV4cG9zZWQgdG8gd29ya2VycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NjA2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXJyb3JFdmVudCAvIFByb2dyZXNzRXZlbnQg c2hvdWxkIGJlIGV4cG9zZWQgdG8gd29ya2VyczoKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3Bl Yy53aGF0d2cub3JnL211bHRpcGFnZS93ZWJhcHBhcGlzLmh0bWwjZXJyb3JldmVudAorICAgICAg ICAtIGh0dHBzOi8veGhyLnNwZWMud2hhdHdnLm9yZy8jaW50ZXJmYWNlLXByb2dyZXNzZXZlbnQK KworICAgICAgICBGaXJlZm94IGFuZCBDaHJvbWUgYm90aCBhbHJlYWR5IGV4cG9zZSB0aG9zZS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4aXN0aW5nIHRlc3QuCisKKyAg ICAgICAgKiBkb20vRXJyb3JFdmVudC5pZGw6CisgICAgICAgICogZG9tL1Byb2dyZXNzRXZlbnQu aWRsOgorCisyMDE2LTA2LTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAg ICAgICAgQWRkcmVzcyBEYXJpbidzIHJldmlldyBjb21tZW50IG9uIHIyMDE4OTguCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1NzYKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0Vycm9yRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUv ZG9tL0Vycm9yRXZlbnQuaWRsCmluZGV4IDU5NDFiZmVjNjJjNGNhMDViNDJiN2FmNGMyYWNhZWQ2 MTdmMGY5MzEuLjk0ZDBkMjhiYzcxNmZmYTAzNTMzZjJjZjNjNWEwYWM5ZTNiYTU5NDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FcnJvckV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRXJyb3JFdmVudC5pZGwKQEAgLTI5LDcgKzI5LDggQEAKICAqLwogCiBbCi0gICAg Q29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudAorICAgIENvbnN0cnVjdG9yVGVtcGxhdGU9RXZlbnQs CisgICAgRXhwb3NlZD0oV2luZG93LFdvcmtlciksCiBdIGludGVyZmFjZSBFcnJvckV2ZW50IDog RXZlbnQgewogICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rvcl0gcmVhZG9ubHkgYXR0 cmlidXRlIERPTVN0cmluZyBtZXNzYWdlOwogICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1 Y3Rvcl0gcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBmaWxlbmFtZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Qcm9ncmVzc0V2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Qcm9ncmVzc0V2ZW50LmlkbAppbmRleCBlM2ExMjBmZWQ4NzdhZGM0ODY3MTYzMTBiNWVkNmJk ODYxNzM0ZjEwLi4xYTNiM2E1YWI5ODk3MjA5N2UxM2NhNWQzNTA0NWUwN2YwZGFlMjlkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUHJvZ3Jlc3NFdmVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL1Byb2dyZXNzRXZlbnQuaWRsCkBAIC0yNSw2ICsyNSw3IEBACiAKIFsKICAg ICBDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50LAorICAgIEV4cG9zZWQ9KFdpbmRvdyxXb3JrZXIp LAogXSBpbnRlcmZhY2UgUHJvZ3Jlc3NFdmVudCA6IEV2ZW50IHsKICAgICBbSW5pdGlhbGl6ZWRC eUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIGxlbmd0aENvbXB1 dGFibGU7CiAgICAgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSByZWFkb25seSBhdHRy aWJ1dGUgdW5zaWduZWQgbG9uZyBsb25nIGxvYWRlZDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYzRlMTU2NzhhMDllZmEw Y2JiNTY4ZDIzYjcwNDNlZDUyNDQ2MzU5Li44ZmU4NTQ3MWQxNmQwZjBmNGM0MjEzZTcyZDllNTEy ZWI5NGM3YjM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDYtMDkgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBFcnJvckV2ZW50IC8gUHJvZ3Jlc3NFdmVu dCBzaG91bGQgYmUgZXhwb3NlZCB0byB3b3JrZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg2MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIHRlc3QuCisKKyAgICAgICAgKiBqcy9k b20vZ2xvYmFsLWNvbnN0cnVjdG9ycy1hdHRyaWJ1dGVzLWRlZGljYXRlZC13b3JrZXItZXhwZWN0 ZWQudHh0OgorCiAyMDE2LTA2LTA5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIHRlc3Rpbmcgc3VwcG9ydCBmb3IgM3ggZGV2aWNlIHNjYWxlIGZhY3Rvci4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9nbG9iYWwtY29uc3RydWN0b3JzLWF0dHJp YnV0ZXMtZGVkaWNhdGVkLXdvcmtlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9qcy9kb20v Z2xvYmFsLWNvbnN0cnVjdG9ycy1hdHRyaWJ1dGVzLWRlZGljYXRlZC13b3JrZXItZXhwZWN0ZWQu dHh0CmluZGV4IDcxMjQ2NGU4NDlkMzZkYTAyOWM2MjdhNTc1NmFhMGU2MjRiZWQxZTEuLmJhMDA5 OWY2NjU2MzE3ZTRkMTc3NzRmMGEyMDA3ODdhOWUyMmRlMDggMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2pzL2RvbS9nbG9iYWwtY29uc3RydWN0b3JzLWF0dHJpYnV0ZXMtZGVkaWNhdGVkLXdvcmtl ci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvanMvZG9tL2dsb2JhbC1jb25zdHJ1Y3Rv cnMtYXR0cmlidXRlcy1kZWRpY2F0ZWQtd29ya2VyLWV4cGVjdGVkLnR4dApAQCAtNTQsNiArNTQs MTEgQEAgUEFTUyBbV29ya2VyXSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGdsb2Jh bCwgJ0Vycm9yJykuaGFzT3duUHJvcGVydHkoJ2cKIFBBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93 blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdFcnJvcicpLmhhc093blByb3BlcnR5KCdzZXQn KSBpcyBmYWxzZQogUEFTUyBbV29ya2VyXSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9y KGdsb2JhbCwgJ0Vycm9yJykuZW51bWVyYWJsZSBpcyBmYWxzZQogUEFTUyBbV29ya2VyXSBPYmpl Y3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGdsb2JhbCwgJ0Vycm9yJykuY29uZmlndXJhYmxl IGlzIHRydWUKK1BBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihn bG9iYWwsICdFcnJvckV2ZW50JykudmFsdWUgaXMgRXJyb3JFdmVudAorUEFTUyBbV29ya2VyXSBP YmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGdsb2JhbCwgJ0Vycm9yRXZlbnQnKS5oYXNP d25Qcm9wZXJ0eSgnZ2V0JykgaXMgZmFsc2UKK1BBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blBy b3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdFcnJvckV2ZW50JykuaGFzT3duUHJvcGVydHkoJ3Nl dCcpIGlzIGZhbHNlCitQQVNTIFtXb3JrZXJdIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0 b3IoZ2xvYmFsLCAnRXJyb3JFdmVudCcpLmVudW1lcmFibGUgaXMgZmFsc2UKK1BBU1MgW1dvcmtl cl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdFcnJvckV2ZW50Jyku Y29uZmlndXJhYmxlIGlzIHRydWUKIFBBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5 RGVzY3JpcHRvcihnbG9iYWwsICdFdmFsRXJyb3InKS52YWx1ZSBpcyBFdmFsRXJyb3IKIFBBU1Mg W1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdFdmFsRXJy b3InKS5oYXNPd25Qcm9wZXJ0eSgnZ2V0JykgaXMgZmFsc2UKIFBBU1MgW1dvcmtlcl0gT2JqZWN0 LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdFdmFsRXJyb3InKS5oYXNPd25Qcm9w ZXJ0eSgnc2V0JykgaXMgZmFsc2UKQEAgLTE0OSw2ICsxNTQsMTEgQEAgUEFTUyBbV29ya2VyXSBP YmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGdsb2JhbCwgJ09iamVjdCcpLmhhc093blBy b3BlcnR5KCcKIFBBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihn bG9iYWwsICdPYmplY3QnKS5oYXNPd25Qcm9wZXJ0eSgnc2V0JykgaXMgZmFsc2UKIFBBU1MgW1dv cmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdPYmplY3QnKS5l bnVtZXJhYmxlIGlzIGZhbHNlCiBQQVNTIFtXb3JrZXJdIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURl c2NyaXB0b3IoZ2xvYmFsLCAnT2JqZWN0JykuY29uZmlndXJhYmxlIGlzIHRydWUKK1BBU1MgW1dv cmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdQcm9ncmVzc0V2 ZW50JykudmFsdWUgaXMgUHJvZ3Jlc3NFdmVudAorUEFTUyBbV29ya2VyXSBPYmplY3QuZ2V0T3du UHJvcGVydHlEZXNjcmlwdG9yKGdsb2JhbCwgJ1Byb2dyZXNzRXZlbnQnKS5oYXNPd25Qcm9wZXJ0 eSgnZ2V0JykgaXMgZmFsc2UKK1BBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5RGVz Y3JpcHRvcihnbG9iYWwsICdQcm9ncmVzc0V2ZW50JykuaGFzT3duUHJvcGVydHkoJ3NldCcpIGlz IGZhbHNlCitQQVNTIFtXb3JrZXJdIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoZ2xv YmFsLCAnUHJvZ3Jlc3NFdmVudCcpLmVudW1lcmFibGUgaXMgZmFsc2UKK1BBU1MgW1dvcmtlcl0g T2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdQcm9ncmVzc0V2ZW50Jyku Y29uZmlndXJhYmxlIGlzIHRydWUKIFBBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93blByb3BlcnR5 RGVzY3JpcHRvcihnbG9iYWwsICdQcm9taXNlJykudmFsdWUgaXMgUHJvbWlzZQogUEFTUyBbV29y a2VyXSBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGdsb2JhbCwgJ1Byb21pc2UnKS5o YXNPd25Qcm9wZXJ0eSgnZ2V0JykgaXMgZmFsc2UKIFBBU1MgW1dvcmtlcl0gT2JqZWN0LmdldE93 blByb3BlcnR5RGVzY3JpcHRvcihnbG9iYWwsICdQcm9taXNlJykuaGFzT3duUHJvcGVydHkoJ3Nl dCcpIGlzIGZhbHNlCg==