158598 2016-06-09 19:36:05 -0700 Web Inspector: Cleanup InspectorIndexedDBAgent a bit 2016-06-10 13:58:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1201096 0 joepeck 2016-06-09 19:36:05 -0700 Cleanup InspectorIndexedDBAgent a bit 1201097 1 280976 joepeck 2016-06-09 19:37:04 -0700 Created attachment 280976 [PATCH] Proposed Fix 1201121 2 280976 darin 2016-06-09 20:20:41 -0700 Comment on attachment 280976 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=280976&action=review > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:163 > + Ref<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this); I suggest using auto rather than repeating the type name twice here. Or just doing this inside the addEventListener call. I think there should be a lot more use of auto elsewhere in this file. 1201368 3 280976 commit-queue 2016-06-10 13:58:06 -0700 Comment on attachment 280976 [PATCH] Proposed Fix Clearing flags on attachment: 280976 Committed r201939: <http://trac.webkit.org/changeset/201939> 1201369 4 commit-queue 2016-06-10 13:58:10 -0700 All reviewed patches have been landed. Closing bug. 280976 2016-06-09 19:37:04 -0700 2016-06-10 13:58:06 -0700 [PATCH] Proposed Fix cleanup-1.patch text/plain 7588 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OWNkZGU1Li45MDJjNzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTYtMDYtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhbnVwIEluc3BlY3RvckluZGV4ZWREQkFnZW50IGEg Yml0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1 OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHA6CisKKzIwMTYtMDYtMDkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OOiBX ZWIgSW5zcGVjdG9yOiBJbmRleGVkREIgZG9lcyBub3Qgc2hvdyBPYmplY3RTdG9yZSBkYXRhCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTg1OTIKICAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NzMwNjk2PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHAKaW5kZXggZWZkYTYyYi4uZjcy NTAwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4 ZWREQkFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5k ZXhlZERCQWdlbnQuY3BwCkBAIC05NCwxNiArOTQsMTYgQEAgY2xhc3MgRXhlY3V0YWJsZVdpdGhE YXRhYmFzZSA6IHB1YmxpYyBSZWZDb3VudGVkPEV4ZWN1dGFibGVXaXRoRGF0YWJhc2U+IHsKIHB1 YmxpYzoKICAgICBFeGVjdXRhYmxlV2l0aERhdGFiYXNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQq IGNvbnRleHQpCiAgICAgICAgIDogbV9jb250ZXh0KGNvbnRleHQpIHsgfQotICAgIHZpcnR1YWwg fkV4ZWN1dGFibGVXaXRoRGF0YWJhc2UoKSB7IH07CisgICAgdmlydHVhbCB+RXhlY3V0YWJsZVdp dGhEYXRhYmFzZSgpIHsgfQogICAgIHZvaWQgc3RhcnQoSURCRmFjdG9yeSosIFNlY3VyaXR5T3Jp Z2luKiwgY29uc3QgU3RyaW5nJiBkYXRhYmFzZU5hbWUpOwogICAgIHZpcnR1YWwgdm9pZCBleGVj dXRlKElEQkRhdGFiYXNlJikgPSAwOwogICAgIHZpcnR1YWwgUmVxdWVzdENhbGxiYWNrJiByZXF1 ZXN0Q2FsbGJhY2soKSA9IDA7Ci0gICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCgp IHsgcmV0dXJuIG1fY29udGV4dDsgfTsKKyAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250 ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9jb250ZXh0OyB9CiBwcml2YXRlOgogICAgIFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqIG1fY29udGV4dDsKIH07CiAKLWNsYXNzIE9wZW5EYXRhYmFzZUNhbGxi YWNrIDogcHVibGljIEV2ZW50TGlzdGVuZXIgeworY2xhc3MgT3BlbkRhdGFiYXNlQ2FsbGJhY2sg ZmluYWwgOiBwdWJsaWMgRXZlbnRMaXN0ZW5lciB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxP cGVuRGF0YWJhc2VDYWxsYmFjaz4gY3JlYXRlKEV4ZWN1dGFibGVXaXRoRGF0YWJhc2UqIGV4ZWN1 dGFibGVXaXRoRGF0YWJhc2UpCiAgICAgewpAQCAtMTQ4LDE5ICsxNDgsMTkgQEAgcHJpdmF0ZToK IAogdm9pZCBFeGVjdXRhYmxlV2l0aERhdGFiYXNlOjpzdGFydChJREJGYWN0b3J5KiBpZGJGYWN0 b3J5LCBTZWN1cml0eU9yaWdpbiosIGNvbnN0IFN0cmluZyYgZGF0YWJhc2VOYW1lKQogewotICAg IFJlZjxPcGVuRGF0YWJhc2VDYWxsYmFjaz4gY2FsbGJhY2sgPSBPcGVuRGF0YWJhc2VDYWxsYmFj azo6Y3JlYXRlKHRoaXMpOwotICAgIEV4Y2VwdGlvbkNvZGVXaXRoTWVzc2FnZSBlYzsKLQogICAg IGlmICghY29udGV4dCgpKSB7CiAgICAgICAgIHJlcXVlc3RDYWxsYmFjaygpLnNlbmRGYWlsdXJl KCJDb3VsZCBub3Qgb3BlbiBkYXRhYmFzZS4iKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAor ICAgIEV4Y2VwdGlvbkNvZGVXaXRoTWVzc2FnZSBlYzsKICAgICBSZWZQdHI8SURCT3BlbkRCUmVx dWVzdD4gaWRiT3BlbkRCUmVxdWVzdCA9IGlkYkZhY3RvcnktPm9wZW4oKmNvbnRleHQoKSwgZGF0 YWJhc2VOYW1lLCBOdWxsb3B0LCBlYyk7CiAgICAgaWYgKGVjLmNvZGUpIHsKICAgICAgICAgcmVx dWVzdENhbGxiYWNrKCkuc2VuZEZhaWx1cmUoIkNvdWxkIG5vdCBvcGVuIGRhdGFiYXNlLiIpOwog ICAgICAgICByZXR1cm47CiAgICAgfQorCisgICAgUmVmPE9wZW5EYXRhYmFzZUNhbGxiYWNrPiBj YWxsYmFjayA9IE9wZW5EYXRhYmFzZUNhbGxiYWNrOjpjcmVhdGUodGhpcyk7CiAgICAgaWRiT3Bl bkRCUmVxdWVzdC0+YWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuc3VjY2Vzc0V2ZW50LCBX VEZNb3ZlKGNhbGxiYWNrKSwgZmFsc2UpOwogfQogCkBAIC0xNzQsMTMgKzE3NCwxNCBAQCBzdGF0 aWMgUmVmUHRyPEtleVBhdGg+IGtleVBhdGhGcm9tSURCS2V5UGF0aChjb25zdCBJREJLZXlQYXRo JiBpZGJLZXlQYXRoKQogICAgICAgICAgICAgLnNldFR5cGUoS2V5UGF0aDo6VHlwZTo6TnVsbCkK ICAgICAgICAgICAgIC5yZWxlYXNlKCk7CiAgICAgICAgIGJyZWFrOworCiAgICAgY2FzZSBJREJL ZXlQYXRoOjpUeXBlOjpTdHJpbmc6CiAgICAgICAgIGtleVBhdGggPSBLZXlQYXRoOjpjcmVhdGUo KQogICAgICAgICAgICAgLnNldFR5cGUoS2V5UGF0aDo6VHlwZTo6U3RyaW5nKQogICAgICAgICAg ICAgLnJlbGVhc2UoKTsKICAgICAgICAga2V5UGF0aC0+c2V0U3RyaW5nKGlkYktleVBhdGguc3Ry aW5nKCkpOwotCiAgICAgICAgIGJyZWFrOworCiAgICAgY2FzZSBJREJLZXlQYXRoOjpUeXBlOjpB cnJheTogewogICAgICAgICBhdXRvIGFycmF5ID0gSW5zcGVjdG9yOjpQcm90b2NvbDo6QXJyYXk8 U3RyaW5nPjo6Y3JlYXRlKCk7CiAgICAgICAgIGZvciAoYXV0byYgc3RyaW5nIDogaWRiS2V5UGF0 aC5hcnJheSgpKQpAQCAtMTkxLDYgKzE5Miw3IEBAIHN0YXRpYyBSZWZQdHI8S2V5UGF0aD4ga2V5 UGF0aEZyb21JREJLZXlQYXRoKGNvbnN0IElEQktleVBhdGgmIGlkYktleVBhdGgpCiAgICAgICAg IGtleVBhdGgtPnNldEFycmF5KFdURk1vdmUoYXJyYXkpKTsKICAgICAgICAgYnJlYWs7CiAgICAg fQorCiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQpA QCAtMjI1LDcgKzIyNyw3IEBAIHN0YXRpYyBSZWZQdHI8SURCSW5kZXg+IGluZGV4Rm9yT2JqZWN0 U3RvcmUoSURCT2JqZWN0U3RvcmUqIGlkYk9iamVjdFN0b3JlLCBjb25zCiAgICAgcmV0dXJuIGlk YkluZGV4OwogfQogCi1jbGFzcyBEYXRhYmFzZUxvYWRlciA6IHB1YmxpYyBFeGVjdXRhYmxlV2l0 aERhdGFiYXNlIHsKK2NsYXNzIERhdGFiYXNlTG9hZGVyIGZpbmFsIDogcHVibGljIEV4ZWN1dGFi bGVXaXRoRGF0YWJhc2UgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8RGF0YWJhc2VMb2FkZXI+ IGNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBSZWY8UmVxdWVzdERhdGFi YXNlQ2FsbGJhY2s+JiYgcmVxdWVzdENhbGxiYWNrKQogICAgIHsKQEAgLTI2NSw3ICsyNjcsNiBA QCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgLnNldEF1dG9JbmNyZW1lbnQob2JqZWN0U3RvcmVJ bmZvLT5hdXRvSW5jcmVtZW50KCkpCiAgICAgICAgICAgICAgICAgLnNldEluZGV4ZXMoV1RGTW92 ZShpbmRleGVzKSkKICAgICAgICAgICAgICAgICAucmVsZWFzZSgpOwotICAgICAgICAKICAgICAg ICAgICAgIG9iamVjdFN0b3Jlcy0+YWRkSXRlbShXVEZNb3ZlKG9iamVjdFN0b3JlKSk7CiAgICAg ICAgIH0KICAgICAKQEAgLTI3NCw3ICsyNzUsNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICAuc2V0 VmVyc2lvbihkYXRhYmFzZUluZm8udmVyc2lvbigpKQogICAgICAgICAgICAgLnNldE9iamVjdFN0 b3JlcyhXVEZNb3ZlKG9iamVjdFN0b3JlcykpCiAgICAgICAgICAgICAucmVsZWFzZSgpOwotICAg ICAgICAKICAgICAgICAgbV9yZXF1ZXN0Q2FsbGJhY2stPnNlbmRTdWNjZXNzKFdURk1vdmUocmVz dWx0KSk7CiAgICAgfQogCkBAIC0yODgsOCArMjg4LDYgQEAgcHJpdmF0ZToKIAogc3RhdGljIFJl ZlB0cjxJREJLZXk+IGlkYktleUZyb21JbnNwZWN0b3JPYmplY3QoSW5zcGVjdG9yT2JqZWN0KiBr ZXkpCiB7Ci0gICAgUmVmUHRyPElEQktleT4gaWRiS2V5OwotCiAgICAgU3RyaW5nIHR5cGU7CiAg ICAgaWYgKCFrZXktPmdldFN0cmluZygidHlwZSIsIHR5cGUpKQogICAgICAgICByZXR1cm4gbnVs bHB0cjsKQEAgLTI5OSw2ICsyOTcsNyBAQCBzdGF0aWMgUmVmUHRyPElEQktleT4gaWRiS2V5RnJv bUluc3BlY3Rvck9iamVjdChJbnNwZWN0b3JPYmplY3QqIGtleSkKICAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiBkYXRlVHlwZShBU0NJSUxpdGVyYWwoImRhdGUiKSk7CiAg ICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmluZz4gYXJyYXlUeXBlKEFTQ0lJTGl0 ZXJhbCgiYXJyYXkiKSk7CiAKKyAgICBSZWZQdHI8SURCS2V5PiBpZGJLZXk7CiAgICAgaWYgKHR5 cGUgPT0gbnVtYmVyVHlwZSkgewogICAgICAgICBkb3VibGUgbnVtYmVyOwogICAgICAgICBpZiAo IWtleS0+Z2V0RG91YmxlKCJudW1iZXIiLCBudW1iZXIpKQpAQCAtMzM2LDI1ICszMzUsMjUgQEAg c3RhdGljIFJlZlB0cjxJREJLZXk+IGlkYktleUZyb21JbnNwZWN0b3JPYmplY3QoSW5zcGVjdG9y T2JqZWN0KiBrZXkpCiBzdGF0aWMgUmVmUHRyPElEQktleVJhbmdlPiBpZGJLZXlSYW5nZUZyb21L ZXlSYW5nZShjb25zdCBJbnNwZWN0b3JPYmplY3QqIGtleVJhbmdlKQogewogICAgIFJlZlB0cjxJ bnNwZWN0b3JPYmplY3Q+IGxvd2VyOwotICAgIGlmICgha2V5UmFuZ2UtPmdldE9iamVjdCgibG93 ZXIiLCBsb3dlcikpCisgICAgaWYgKCFrZXlSYW5nZS0+Z2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgi bG93ZXIiKSwgbG93ZXIpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICBSZWZQdHI8SURC S2V5PiBpZGJMb3dlciA9IGlkYktleUZyb21JbnNwZWN0b3JPYmplY3QobG93ZXIuZ2V0KCkpOwog ICAgIGlmICghaWRiTG93ZXIpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgUmVmUHRy PEluc3BlY3Rvck9iamVjdD4gdXBwZXI7Ci0gICAgaWYgKCFrZXlSYW5nZS0+Z2V0T2JqZWN0KCJ1 cHBlciIsIHVwcGVyKSkKKyAgICBpZiAoIWtleVJhbmdlLT5nZXRPYmplY3QoQVNDSUlMaXRlcmFs KCJ1cHBlciIpLCB1cHBlcikpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIFJlZlB0cjxJ REJLZXk+IGlkYlVwcGVyID0gaWRiS2V5RnJvbUluc3BlY3Rvck9iamVjdCh1cHBlci5nZXQoKSk7 CiAgICAgaWYgKCFpZGJVcHBlcikKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBib29s IGxvd2VyT3BlbjsKLSAgICBpZiAoIWtleVJhbmdlLT5nZXRCb29sZWFuKCJsb3dlck9wZW4iLCBs b3dlck9wZW4pKQorICAgIGlmICgha2V5UmFuZ2UtPmdldEJvb2xlYW4oQVNDSUlMaXRlcmFsKCJs b3dlck9wZW4iKSwgbG93ZXJPcGVuKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICBi b29sIHVwcGVyT3BlbjsKLSAgICBpZiAoIWtleVJhbmdlLT5nZXRCb29sZWFuKCJ1cHBlck9wZW4i LCB1cHBlck9wZW4pKQorICAgIGlmICgha2V5UmFuZ2UtPmdldEJvb2xlYW4oQVNDSUlMaXRlcmFs KCJ1cHBlck9wZW4iKSwgdXBwZXJPcGVuKSkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAg ICByZXR1cm4gSURCS2V5UmFuZ2U6OmNyZWF0ZShXVEZNb3ZlKGlkYkxvd2VyKSwgV1RGTW92ZShp ZGJVcHBlciksIGxvd2VyT3BlbiwgdXBwZXJPcGVuKTsKQEAgLTQzMiw3ICs0MzEsNiBAQCBwdWJs aWM6CiAgICAgICAgICAgICAuc2V0VmFsdWUobV9pbmplY3RlZFNjcmlwdC53cmFwT2JqZWN0KGN1 cnNvci52YWx1ZSgpLCBTdHJpbmcoKSwgdHJ1ZSkpCiAgICAgICAgICAgICAucmVsZWFzZSgpOwog ICAgICAgICBtX3Jlc3VsdC0+YWRkSXRlbShXVEZNb3ZlKGRhdGFFbnRyeSkpOwotCiAgICAgfQog CiAgICAgdm9pZCBlbmQoYm9vbCBoYXNNb3JlKQpAQCAtNDQ3LDE2ICs0NDUsMTYgQEAgcHJpdmF0 ZToKICAgICAgICAgOiBFdmVudExpc3RlbmVyKEV2ZW50TGlzdGVuZXI6OkNQUEV2ZW50TGlzdGVu ZXJUeXBlKQogICAgICAgICAsIG1faW5qZWN0ZWRTY3JpcHQoaW5qZWN0ZWRTY3JpcHQpCiAgICAg ICAgICwgbV9yZXF1ZXN0Q2FsbGJhY2soV1RGTW92ZShyZXF1ZXN0Q2FsbGJhY2spKQotICAgICAg ICAsIG1fc2tpcENvdW50KHNraXBDb3VudCkKLSAgICAgICAgLCBtX3BhZ2VTaXplKHBhZ2VTaXpl KQogICAgICAgICAsIG1fcmVzdWx0KEFycmF5PERhdGFFbnRyeT46OmNyZWF0ZSgpKQorICAgICAg ICAsIG1fc2tpcENvdW50KHNraXBDb3VudCkKKyAgICAgICAgLCBtX3BhZ2VTaXplKHBhZ2VTaXpl KQogICAgIHsKICAgICB9CiAgICAgSW5qZWN0ZWRTY3JpcHQgbV9pbmplY3RlZFNjcmlwdDsKICAg ICBSZWY8UmVxdWVzdERhdGFDYWxsYmFjaz4gbV9yZXF1ZXN0Q2FsbGJhY2s7Ci0gICAgaW50IG1f c2tpcENvdW50OwotICAgIHVuc2lnbmVkIG1fcGFnZVNpemU7CiAgICAgUmVmPEFycmF5PERhdGFF bnRyeT4+IG1fcmVzdWx0OworICAgIGludCBtX3NraXBDb3VudDsKKyAgICB1bnNpZ25lZCBtX3Bh Z2VTaXplOwogfTsKIAogY2xhc3MgRGF0YUxvYWRlciA6IHB1YmxpYyBFeGVjdXRhYmxlV2l0aERh dGFiYXNlIHsKQEAgLTQ3Miw2ICs0NzAsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBpZiAo IXJlcXVlc3RDYWxsYmFjaygpLmlzQWN0aXZlKCkpCiAgICAgICAgICAgICByZXR1cm47CisKICAg ICAgICAgUmVmUHRyPElEQlRyYW5zYWN0aW9uPiBpZGJUcmFuc2FjdGlvbiA9IHRyYW5zYWN0aW9u Rm9yRGF0YWJhc2UoY29udGV4dCgpLCAmZGF0YWJhc2UsIG1fb2JqZWN0U3RvcmVOYW1lKTsKICAg ICAgICAgaWYgKCFpZGJUcmFuc2FjdGlvbikgewogICAgICAgICAgICAgbV9yZXF1ZXN0Q2FsbGJh Y2stPnNlbmRGYWlsdXJlKCJDb3VsZCBub3QgZ2V0IHRyYW5zYWN0aW9uIik7CkBAIC03MTAsNiAr NzA5LDcgQEAgcHVibGljOgogICAgICAgICAgICAgbV9yZXF1ZXN0Q2FsbGJhY2stPnNlbmRGYWls dXJlKCJDb3VsZCBub3QgZ2V0IHRyYW5zYWN0aW9uIik7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KKwogICAgICAgICBSZWZQdHI8SURCT2JqZWN0U3RvcmU+IGlkYk9iamVjdFN0b3Jl ID0gb2JqZWN0U3RvcmVGb3JUcmFuc2FjdGlvbihpZGJUcmFuc2FjdGlvbi5nZXQoKSwgbV9vYmpl Y3RTdG9yZU5hbWUpOwogICAgICAgICBpZiAoIWlkYk9iamVjdFN0b3JlKSB7CiAgICAgICAgICAg ICBtX3JlcXVlc3RDYWxsYmFjay0+c2VuZEZhaWx1cmUoIkNvdWxkIG5vdCBnZXQgb2JqZWN0IHN0 b3JlIik7Cg==