158592 2016-06-09 16:16:06 -0700 REGRESSION: Web Inspector: IndexedDB does not show ObjectStore data 2016-06-09 16:46:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg beidson commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1201037 0 joepeck 2016-06-09 16:16:06 -0700 Summary: IndexedDB does not show ObjectStore data Steps to Reproduce: 1. Inspect <https://matthew-andrews.github.io/offline-todo/> 2. Add Todo Items 3. Show Storage Tab 4. Show "todo" Object Store => Empty 5. Add more data 6. Refresh Object Store => Uncaught exceptions Notes: - Seems to be a regression with ModernIDB. 1201038 1 webkit-bug-importer 2016-06-09 16:18:39 -0700 <rdar://problem/26730696> 1201043 2 280965 joepeck 2016-06-09 16:21:27 -0700 Created attachment 280965 [PATCH] Proposed Fix 1201053 3 280965 commit-queue 2016-06-09 16:46:38 -0700 Comment on attachment 280965 [PATCH] Proposed Fix Clearing flags on attachment: 280965 Committed r201893: <http://trac.webkit.org/changeset/201893> 1201054 4 commit-queue 2016-06-09 16:46:42 -0700 All reviewed patches have been landed. Closing bug. 280965 2016-06-09 16:21:27 -0700 2016-06-09 16:46:38 -0700 [PATCH] Proposed Fix fix-indexeddb-1.patch text/plain 5822 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYWUwNDY1Li40OWNkZGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMDYtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OOiBXZWIgSW5zcGVjdG9yOiBJbmRleGVkREIgZG9lcyBub3Qgc2hv dyBPYmplY3RTdG9yZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTg1OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI2NzMwNjk2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFMb2Fk ZXI6OmV4ZWN1dGUpOgorICAgICAgICBFbnN1cmUgdGhlIElEQlRyYW5zYWN0aW9uIGlzIGFjdGl2 ZSB3aGVuIGF0dGVtcHRpbmcgdG8gb3BlbiBhIGN1cnNvci4KKworICAgICAgICAoV2ViQ29yZTo6 T3BlbkN1cnNvckNhbGxiYWNrOjpoYW5kbGVFdmVudCk6CisgICAgICAgIEVuZCwgd2hlbiB0aGUg Y3Vyc29yIHJlc3VsdCBpcyBlbXB0eSwgbGlrZSB3ZSBkbyBmb3Igc2NyaXB0IHJlc3VsdHMuCisK IDIwMTYtMDYtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBX b3JrZXJHbG9iYWxTY29wZSBhdHRyaWJ1dGVzIC8gb3BlcmF0aW9ucyBzaG91bGQgYmUgb24gdGhl IHByb3RvdHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckluZGV4ZWREQkFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJ bmRleGVkREJBZ2VudC5jcHAKaW5kZXggMzMwMzBiMi4uZWZkYTYyYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwCkBAIC0z OTQsNyArMzk0LDcgQEAgcHVibGljOgogICAgICAgICB9CiAgICAgICAgIGF1dG8qIGN1cnNvclJl c3VsdCA9IHJlcXVlc3QuY3Vyc29yUmVzdWx0KCk7CiAgICAgICAgIGlmICghY3Vyc29yUmVzdWx0 KSB7Ci0gICAgICAgICAgICBtX3JlcXVlc3RDYWxsYmFjay0+c2VuZEZhaWx1cmUoIlVuZXhwZWN0 ZWQgcmVzdWx0IHR5cGUuIik7CisgICAgICAgICAgICBlbmQoZmFsc2UpOwogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKQEAgLTQ4Myw4ICs0ODMsNyBAQCBwdWJsaWM6CiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBSZWY8T3BlbkN1cnNvckNhbGxiYWNr PiBvcGVuQ3Vyc29yQ2FsbGJhY2sgPSBPcGVuQ3Vyc29yQ2FsbGJhY2s6OmNyZWF0ZShtX2luamVj dGVkU2NyaXB0LCBtX3JlcXVlc3RDYWxsYmFjay5jb3B5UmVmKCksIDAsIG1fcGFnZVNpemUpOwot CisgICAgICAgIFRyYW5zYWN0aW9uQWN0aXZhdG9yIGFjdGl2YXRvcihpZGJUcmFuc2FjdGlvbi5n ZXQoKSk7CiAgICAgICAgIEV4Y2VwdGlvbkNvZGVXaXRoTWVzc2FnZSBlYzsKICAgICAgICAgUmVm UHRyPElEQlJlcXVlc3Q+IGlkYlJlcXVlc3Q7CiAgICAgICAgIGlmICghbV9pbmRleE5hbWUuaXNF bXB0eSgpKSB7CkBAIC01MDMsNiArNTAyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB9CiAKKyAgICAgICAgUmVmPE9wZW5DdXJzb3JDYWxsYmFjaz4gb3BlbkN1cnNv ckNhbGxiYWNrID0gT3BlbkN1cnNvckNhbGxiYWNrOjpjcmVhdGUobV9pbmplY3RlZFNjcmlwdCwg bV9yZXF1ZXN0Q2FsbGJhY2suY29weVJlZigpLCAwLCBtX3BhZ2VTaXplKTsKICAgICAgICAgaWRi UmVxdWVzdC0+YWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuc3VjY2Vzc0V2ZW50LCBXVEZN b3ZlKG9wZW5DdXJzb3JDYWxsYmFjayksIGZhbHNlKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hh bmdlTG9nCmluZGV4IDYzYTI2ZTkuLjgwNjEzZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIzIEBACisyMDE2LTA2LTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3BlY3RvcjogSW5kZXhlZERC IGRvZXMgbm90IHNob3cgT2JqZWN0U3RvcmUgZGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NTkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NjczMDY5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRGF0YUdyaWQucHJvdG90eXBlLl9ub3RlUm93UmVtb3ZlZCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZS5fZGV0YWNoKToKKyAgICAgICAgV2hlbiByb3dz IGFyZSByZW1vdmVkIGluIHRoZSBub24tVmlydHVhbCBEYXRhR3JpZHMsIHdlIHNob3VsZAorICAg ICAgICBhY3R1YWxseSByZW1vdmUgdGhlIHJvdy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvSW5kZXhlZERhdGFiYXNlT2JqZWN0U3RvcmVDb250ZW50Vmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5JbmRleGVkRGF0YWJhc2VPYmplY3RTdG9yZUNvbnRlbnRWaWV3KToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5JbmRleGVkRGF0YWJhc2VPYmplY3RTdG9yZUNvbnRlbnRWaWV3 LnByb3RvdHlwZS5fZmV0Y2hNb3JlRGF0YS5wcm9jZXNzRW50cmllcyk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuSW5kZXhlZERhdGFiYXNlT2JqZWN0U3RvcmVDb250ZW50Vmlldy5wcm90b3R5cGUu X2ZldGNoTW9yZURhdGEpOgorICAgICAgICBEb24ndCB1c2UgdGhlIGRlbGV0ZSBvcGVyYXRvci4g VXNlIGEgYm9vbGVhbi4KKwogMjAxNi0wNi0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IFdlYiBJbnNwZWN0b3I6IFNob3VsZCBi ZSBhYmxlIHRvIGV2YWx1YXRlICJ7YToxLCBiOjJ9IiBpbiB0aGUgY29uc29sZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpp bmRleCAwMWVmNmM0Li5mNjMzMmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpAQCAtMTAwNCw2ICsxMDA0LDE5IEBA IFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVj dG9yLlZpZXcKICAgICAgICAgdGhpcy5uZWVkc0xheW91dCgpOwogICAgIH0KIAorICAgIF9ub3Rl Um93UmVtb3ZlZChkYXRhR3JpZE5vZGUpCisgICAgeworICAgICAgICBpZiAodGhpcy5faW5saW5l IHx8IHRoaXMuX3ZhcmlhYmxlSGVpZ2h0Um93cykgeworICAgICAgICAgICAgLy8gSW5saW5lIERh dGFHcmlkcyByb3dzIGFyZSBub3QgdXBkYXRlZCBpbiBsYXlvdXQsIHNvCisgICAgICAgICAgICAv LyB3ZSBuZWVkIHRvIHJlbW92ZSByb3dzIGltbWVkaWF0ZWx5LgorICAgICAgICAgICAgaWYgKGRh dGFHcmlkTm9kZS5lbGVtZW50ICYmIGRhdGFHcmlkTm9kZS5lbGVtZW50LnBhcmVudE5vZGUpCisg ICAgICAgICAgICAgICAgZGF0YUdyaWROb2RlLmVsZW1lbnQucGFyZW50Tm9kZS5yZW1vdmVDaGls ZChkYXRhR3JpZE5vZGUuZWxlbWVudCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0K KworICAgICAgICB0aGlzLl9ub3RlUm93c0NoYW5nZWQoKTsKKyAgICB9CisKICAgICBfbm90ZVNj cm9sbFBvc2l0aW9uQ2hhbmdlZCgpCiAgICAgewogICAgICAgICB0aGlzLl9jYWNoZWRTY3JvbGxU b3AgPSBOYU47CkBAIC0yNTEzLDcgKzI1MjYsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2Rl ID0gY2xhc3MgRGF0YUdyaWROb2RlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAg ICB0aGlzLl9hdHRhY2hlZCA9IGZhbHNlOwogCiAgICAgICAgIHRoaXMuZGF0YUdyaWQuX3Jvd3Mu cmVtb3ZlKHRoaXMsIHRydWUpOwotICAgICAgICB0aGlzLmRhdGFHcmlkLl9ub3RlUm93c0NoYW5n ZWQoKTsKKyAgICAgICAgdGhpcy5kYXRhR3JpZC5fbm90ZVJvd1JlbW92ZWQodGhpcyk7CiAKICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLmNoaWxkcmVuLmxlbmd0aDsgKytpKQogICAg ICAgICAgICAgdGhpcy5jaGlsZHJlbltpXS5fZGV0YWNoKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9JbmRleGVkRGF0YWJhc2VPYmplY3RT dG9yZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvSW5kZXhlZERhdGFiYXNlT2JqZWN0U3RvcmVDb250ZW50Vmlldy5qcwppbmRleCAyODcy YWE0Li5jMzUxNTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9JbmRleGVkRGF0YWJhc2VPYmplY3RTdG9yZUNvbnRlbnRWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0luZGV4ZWREYXRhYmFz ZU9iamVjdFN0b3JlQ29udGVudFZpZXcuanMKQEAgLTc0LDYgKzc0LDcgQEAgV2ViSW5zcGVjdG9y LkluZGV4ZWREYXRhYmFzZU9iamVjdFN0b3JlQ29udGVudFZpZXcgPSBjbGFzcyBJbmRleGVkRGF0 YWJhc2VPYmplY3QKIAogICAgICAgICB0aGlzLl9lbnRyaWVzID0gW107CiAKKyAgICAgICAgdGhp cy5fZmV0Y2hpbmdNb3JlRGF0YSA9IGZhbHNlOwogICAgICAgICB0aGlzLl9mZXRjaE1vcmVEYXRh KCk7CiAKICAgICAgICAgdGhpcy5fcmVmcmVzaEJ1dHRvbk5hdmlnYXRpb25JdGVtID0gbmV3IFdl Ykluc3BlY3Rvci5CdXR0b25OYXZpZ2F0aW9uSXRlbSgiaW5kZXhlZC1kYXRhYmFzZS1vYmplY3Qt c3RvcmUtcmVmcmVzaCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVmcmVzaCIpLCAiSW1hZ2Vz L1JlbG9hZEZ1bGwuc3ZnIiwgMTMsIDEzKTsKQEAgLTE0Myw3ICsxNDQsNyBAQCBXZWJJbnNwZWN0 b3IuSW5kZXhlZERhdGFiYXNlT2JqZWN0U3RvcmVDb250ZW50VmlldyA9IGNsYXNzIEluZGV4ZWRE YXRhYmFzZU9iamVjdAogICAgICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFwcGVuZENoaWxk KGRhdGFHcmlkTm9kZSk7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGRlbGV0ZSB0aGlz Ll9mZXRjaGluZ01vcmVEYXRhOworICAgICAgICAgICAgdGhpcy5fZmV0Y2hpbmdNb3JlRGF0YSA9 IGZhbHNlOwogCiAgICAgICAgICAgICBpZiAobW9yZUF2YWlsYWJsZSAmJiB0aGlzLl9kYXRhR3Jp ZC5pc1Njcm9sbGVkVG9MYXN0Um93KCkpCiAgICAgICAgICAgICAgICAgdGhpcy5fZmV0Y2hNb3Jl RGF0YSgpOwo=